| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:70defd3a-7109-3d12-e3f9-2e3ad4caa042 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9C50:24CA2A:4D224EC:66CE663:6A65579F |
| html-safe-nonce | d11b171e1bfb4720ec3de601d49fde840e50f88ea04794d15ad1466c45103400 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzUwOjI0Q0EyQTo0RDIyNEVDOjY2Q0U2NjM6NkE2NTU3OUYiLCJ2aXNpdG9yX2lkIjoiNDYxMzM2NDkzNTgxMzMyMjY1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a6243372509e254cba74517a4e345730d8c4799e31bf434ae2fabb35d29797bd |
| hovercard-subject-tag | pull_request:467725012 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
| twitter:image | https://avatars.githubusercontent.com/u/301546?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/301546?s=400&v=4 |
| og:image:alt | which renders much faster!
Demo: https://codepen.io/antoinerg/full/wvGWgMY
TODO:
the plot step is now async. Fixed in e4b923b cc @alexcjohnson
download image in FF (Fixed in e4b923b)
test in a... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 309153364422b3c499922d1a2a6404910a58ed8e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5075%2Fcommits%2F18133c980934d6faf30eed84d4384e23126a011f |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5075%2Fcommits%2F18133c980934d6faf30eed84d4384e23126a011f |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
| Reload | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
| Reload | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
774
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
54
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fplotly%2Fplotly.js%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fplotly%2Fplotly.js%2Fissues%2Fnew%2Fchoose |
| antoinerg | https://github.com/antoinerg |
| master | https://github.com/plotly/plotly.js/tree/master |
| fast-image | https://github.com/plotly/plotly.js/tree/fast-image |
|
Conversation
99
| https://github.com/plotly/plotly.js/pull/5075 |
|
Commits
26
| https://github.com/plotly/plotly.js/pull/5075/commits |
|
Checks
0
| https://github.com/plotly/plotly.js/pull/5075/checks |
|
Files changed
| https://github.com/plotly/plotly.js/pull/5075/files |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
|
Introduces attribute source to image traces
| https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f#top |
|
Show all changes
26 commits
| https://github.com/plotly/plotly.js/pull/5075/files |
|
1c893e2
Introduces attribute "source" to image traces featuring fast rendering
antoinerg Jun 26, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/1c893e26cf471ab177b9521b174c47143af1d534 |
|
d45496d
Ignores image trace's source attribute that are not data URIs
antoinerg Aug 13, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
|
f03c7ae
Adds image_labuda_droplets_source to mock_test.js
antoinerg Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/f03c7aec5d8165ab7871173ab01793c06a70c013 |
|
2a687f2
Add "z" variable to hovertemplate in image defined by source attr
antoinerg Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/2a687f2e25f7cb4e2e60682f342150f94089e72f |
|
aaf7cbc
Append promise of image loading to the plot api so it can wait for it
antoinerg Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/aaf7cbc12ae272b6c70b02779b85f91588acbc9d |
|
e693446
In image traces, delete source attribute when it is invalid
antoinerg Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/e6934467faf4ca8a5e2a83ef4339ab9f8fd68dc7 |
|
130593e
Fixes image_test to reflect that invalid source are deleted
antoinerg Aug 17, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/130593e4d3ae412dbbd6dac9558556c33ebb2b6c |
|
09eb1d0
Improve code style in the plot routine of image traces
antoinerg Aug 17, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/09eb1d0c144692a2fe4590e524651bd7e8cb6215 |
|
9b8a843
Add a workaround to image's onload event not firing when image is cached
antoinerg Aug 17, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/9b8a843e9557b91192fd0406b4e87f27e6ef9705 |
|
2ba0998
Introduces Lib.isIOS() to detect Apple mobile devices
antoinerg Aug 17, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/2ba0998fa27feaab7af704c200145d0abf85fb70 |
|
a2ea331
Fall back to legacy rendering of image traces for iOS devices
antoinerg Aug 17, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/a2ea33147e8dfea7e87577377b1c3d9c60987e72 |
|
4f807c5
Add missing semicolon
antoinerg Aug 18, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/4f807c5a218e3023cc38ba16f50546716a9468ed |
|
7dd3b68
Fall back to legacy rendering of images traces for IE
antoinerg Aug 18, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/7dd3b6892f4e06a06b359bceb07b497c7cff0e19 |
f2caed8
Loads images into an instead of an for image traces
antoinerg Aug 18, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/f2caed81ee207c44c0e4189f9c4bb4c98819c689 |
|
d91e0c1
Reintroduce image traces with source attribute in the `test-image` suite
antoinerg Aug 18, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/d91e0c19e6205feaf99bb34b63e1389c0544f992 |
|
fe1d208
Improves code readability for image traces
antoinerg Aug 18, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/fe1d2083c4ae61d7c9ee85561fb4654f4cde4643 |
|
2960e55
Removes broken test following changes in how image traces check userA…
antoinerg Aug 18, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/2960e5564719cf3bb8becab6a8f77d22fe0a8430 |
|
3717cbe
Rename _isFrom(Z|Source) to _has(Z|Source)
antoinerg Aug 19, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/3717cbe7429e1266be24a19ce406f601f3718410 |
|
b586a86
Replace Labuda's photography of droplets by one from public domain
antoinerg Aug 19, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/b586a867175365143a8f959d21d899f1810030c0 |
|
d73f4c4
Add image_astronaut_source to mock_test.js
antoinerg Aug 19, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/d73f4c47975d3636916988d49ddfe598016abf2a |
|
18133c9
Update description of attribute `source` in images traces
antoinerg Aug 20, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
|
19ce21d
Introduce colormodel "rgba256" to image traces
antoinerg Aug 21, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/19ce21d21c9dd78504d6a16325cb5739d89bcbff |
|
74574b6
Update description of attribute colormodel in image traces
antoinerg Aug 31, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/74574b69d24fabb7d1e30ca629acd8525c0aeab8 |
|
8c736f7
Update description of attribute source in image traces
antoinerg Aug 31, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/8c736f76b89adad42b31d04d0198a323ee4dc612 |
|
3b75921
Prefer z data over source in image traces and improve code readability
antoinerg Aug 31, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/3b7592132e431fdba06287d6ea95bc065e47da9d |
|
66c58f6
:hocho: unreachable code in image trace defaults routine
antoinerg Aug 31, 2020
| https://github.com/plotly/plotly.js/pull/5075/commits/66c58f6c8aa38505c1904210e1dc4f24bab3155c |
|
Clear filters
| https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
|
Prev
| https://github.com/plotly/plotly.js/pull/5075/commits/d73f4c47975d3636916988d49ddfe598016abf2a |
|
Next
| https://github.com/plotly/plotly.js/pull/5075/commits/19ce21d21c9dd78504d6a16325cb5739d89bcbff |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
|
| https://github.com/antoinerg |
| antoinerg | https://github.com/plotly/plotly.js/commits?author=antoinerg |
| src/traces/image/attributes.js | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f#diff-d9924c2388b94eccb1e73875f6e4ffea295abbe5f3d96b356465072ff419cfff |
|
View file
| https://github.com/plotly/plotly.js/blob/18133c980934d6faf30eed84d4384e23126a011f/src/traces/image/attributes.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/5075/commits/{{ revealButtonHref }} |
|
| https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f#diff-d9924c2388b94eccb1e73875f6e4ffea295abbe5f3d96b356465072ff419cfff |
|
| https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f#diff-d9924c2388b94eccb1e73875f6e4ffea295abbe5f3d96b356465072ff419cfff |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |