| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a3ed07a2-1dc4-49d7-1b1a-2de9075177b0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DC90:187519:5C2048:78EFE8:6A5AE100 |
| html-safe-nonce | 70b1c76891f3fd76062417800b34e6f638fd1b4c10a62680a9d4423374fef83a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQzkwOjE4NzUxOTo1QzIwNDg6NzhFRkU4OjZBNUFFMTAwIiwidmlzaXRvcl9pZCI6IjU3ODY5ODM2ODE2NjA0Nzc2OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 936c95ef6ba1075d6e61c2ee656346ed20dc1b74e3b675aa03e015b46cdbb376 |
| hovercard-subject-tag | pull_request:467725012 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/5075/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/842cdcc9845c51d1baba625e67e31d628774d481c14685f0dd8aa900d24e3cc1/plotly/plotly.js/pull/5075 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/842cdcc9845c51d1baba625e67e31d628774d481c14685f0dd8aa900d24e3cc1/plotly/plotly.js/pull/5075 |
| og:image:alt | which renders much faster!
Demo: https://codepen.io/antoinerg/full/wvGWgMY
TODO:
the plot step is now async. Fixed in e4b923b cc @alexcjohnson
download image in FF (Fixed in e4b923b)
test in a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | antoinerg |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/5075#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5075 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5075 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/5075 |
| Reload | https://github.com/plotly/plotly.js/pull/5075 |
| Reload | https://github.com/plotly/plotly.js/pull/5075 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
773
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
57
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| antoinerg | https://github.com/antoinerg |
| master | https://github.com/plotly/plotly.js/tree/master |
| fast-image | https://github.com/plotly/plotly.js/tree/fast-image |
| Conversation | https://github.com/plotly/plotly.js/pull/5075 |
| Commits26 (26) | https://github.com/plotly/plotly.js/pull/5075/commits |
| Checks | https://github.com/plotly/plotly.js/pull/5075/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/5075/files |
| Introduces attribute source to image traces | https://github.com/plotly/plotly.js/pull/5075#top |
| antoinerg | https://github.com/antoinerg |
| master | https://github.com/plotly/plotly.js/tree/master |
| fast-image | https://github.com/plotly/plotly.js/tree/fast-image |
|
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Aug 14, 2020 | https://github.com/plotly/plotly.js/pull/5075#issue-678843933 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://codepen.io/antoinerg/full/wvGWgMY | https://codepen.io/antoinerg/full/wvGWgMY |
| e4b923b | https://github.com/plotly/plotly.js/commit/e4b923b9c043f71f98dde8de38bd830f96db34b5 |
| @alexcjohnson | https://github.com/alexcjohnson |
| e4b923b | https://github.com/plotly/plotly.js/commit/e4b923b9c043f71f98dde8de38bd830f96db34b5 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| antoinerg | https://github.com/antoinerg |
| August 13, 2020 17:08 | https://github.com/plotly/plotly.js/pull/5075#commits-pushed-1c893e2 |
|
| https://github.com/antoinerg |
| Introduces attribute "source" to image traces featuring fast rendering | https://github.com/plotly/plotly.js/pull/5075/commits/1c893e26cf471ab177b9521b174c47143af1d534 |
| 1c893e2 | https://github.com/plotly/plotly.js/pull/5075/commits/1c893e26cf471ab177b9521b174c47143af1d534 |
|
| https://github.com/antoinerg |
| Ignores image trace's source attribute that are not data URIs | https://github.com/plotly/plotly.js/pull/5075/commits/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
| d45496d | https://github.com/plotly/plotly.js/pull/5075/commits/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
|
Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-467263997 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
| src/traces/image/plot.js | https://github.com/plotly/plotly.js/pull/5075/files/d45496dd45c9bd6e47705664e3b3eaa9582d810c#diff-43dee5a972080512c74efa2a66301506587dcdec4f67fb71e35fe94b3b62b18e |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
|
Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-467264576 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
| test/image/compare_pixels_test.js | https://github.com/plotly/plotly.js/pull/5075/files/d45496dd45c9bd6e47705664e3b3eaa9582d810c#diff-8d21d9e1d87fb7fff767baf4d750e9c46efe23de2f341c15c2bb3867369e004e |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
|
Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-467264831 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
| test/jasmine/tests/image_test.js | https://github.com/plotly/plotly.js/pull/5075/files/d45496dd45c9bd6e47705664e3b3eaa9582d810c#diff-12b0fa60785ea835fae0a777115c25e7b75a735bc0abd676d3d3df54e8e7c857 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
|
Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-467265618 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
| src/traces/image/plot.js | https://github.com/plotly/plotly.js/pull/5075/files/d45496dd45c9bd6e47705664e3b3eaa9582d810c#diff-43dee5a972080512c74efa2a66301506587dcdec4f67fb71e35fe94b3b62b18e |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
| Aug 14, 2020 | https://github.com/plotly/plotly.js/pull/5075#event-3656314247 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
|
Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-467629527 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
| src/traces/image/defaults.js | https://github.com/plotly/plotly.js/pull/5075/files/d45496dd45c9bd6e47705664e3b3eaa9582d810c#diff-a3c9166dfdeb8b64ac5f48a2114f928372c1cfeec9c53b401e0fa9674ca37ccb |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Aug 14, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-674109818 |
| @antoinerg | https://github.com/antoinerg |
| plotly.js/test/jasmine/tests/mock_test.js | https://github.com/plotly/plotly.js/blob/d45496dd45c9bd6e47705664e3b3eaa9582d810c/test/jasmine/tests/mock_test.js#L637 |
| d45496d | https://github.com/plotly/plotly.js/commit/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
| plotly.js/test/jasmine/tests/mock_test.js | https://github.com/plotly/plotly.js/blob/d45496dd45c9bd6e47705664e3b3eaa9582d810c/test/jasmine/tests/mock_test.js#L1684 |
| d45496d | https://github.com/plotly/plotly.js/commit/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/emmanuelle |
| emmanuelle | https://github.com/emmanuelle |
| Aug 14, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-674110857 |
| @antoinerg | https://github.com/antoinerg |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Aug 14, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-674110903 |
| @antoinerg | https://github.com/antoinerg |
| plotly.js/test/jasmine/tests/mock_test.js | https://github.com/plotly/plotly.js/blob/d45496dd45c9bd6e47705664e3b3eaa9582d810c/test/jasmine/tests/mock_test.js#L637 |
| d45496d | https://github.com/plotly/plotly.js/commit/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
| plotly.js/test/jasmine/tests/mock_test.js | https://github.com/plotly/plotly.js/blob/d45496dd45c9bd6e47705664e3b3eaa9582d810c/test/jasmine/tests/mock_test.js#L1684 |
| d45496d | https://github.com/plotly/plotly.js/commit/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
| @archmoj | https://github.com/archmoj |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
|
Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-467639663 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/d45496dd45c9bd6e47705664e3b3eaa9582d810c |
| test/jasmine/tests/image_test.js | https://github.com/plotly/plotly.js/pull/5075/files/d45496dd45c9bd6e47705664e3b3eaa9582d810c#diff-12b0fa60785ea835fae0a777115c25e7b75a735bc0abd676d3d3df54e8e7c857 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Aug 14, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-674112261 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| @antoinerg | https://github.com/antoinerg |
| @emmanuelle | https://github.com/emmanuelle |
| https://github.com/plotly/plotly.js/pull/5075/files#r470673042 | https://github.com/plotly/plotly.js/pull/5075/files#r470673042 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Aug 14, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-674114343 |
| @archmoj | https://github.com/archmoj |
| #4762 | https://github.com/plotly/plotly.js/pull/4762 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
|
| https://github.com/antoinerg |
| Adds image_labuda_droplets_source to mock_test.js | https://github.com/plotly/plotly.js/pull/5075/commits/f03c7aec5d8165ab7871173ab01793c06a70c013 |
| f03c7ae | https://github.com/plotly/plotly.js/pull/5075/commits/f03c7aec5d8165ab7871173ab01793c06a70c013 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Aug 14, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-674145463 |
| @archmoj | https://github.com/archmoj |
| #4762 | https://github.com/plotly/plotly.js/pull/4762 |
| e5bc429 | https://github.com/plotly/plotly.js/commit/e5bc429997890c5d61a2575c2361d88fe9547058 |
| @archmoj | https://github.com/archmoj |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| antoinerg | https://github.com/antoinerg |
| August 14, 2020 13:12 | https://github.com/plotly/plotly.js/pull/5075#commits-pushed-2a687f2 |
|
| https://github.com/antoinerg |
| Add "z" variable to hovertemplate in image defined by source attr | https://github.com/plotly/plotly.js/pull/5075/commits/2a687f2e25f7cb4e2e60682f342150f94089e72f |
| 2a687f2 | https://github.com/plotly/plotly.js/pull/5075/commits/2a687f2e25f7cb4e2e60682f342150f94089e72f |
|
| https://github.com/antoinerg |
| Append promise of image loading to the plot api so it can wait for it | https://github.com/plotly/plotly.js/pull/5075/commits/aaf7cbc12ae272b6c70b02779b85f91588acbc9d |
| aaf7cbc | https://github.com/plotly/plotly.js/pull/5075/commits/aaf7cbc12ae272b6c70b02779b85f91588acbc9d |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-467895413 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/aaf7cbc12ae272b6c70b02779b85f91588acbc9d |
| src/traces/image/plot.js | https://github.com/plotly/plotly.js/pull/5075/files/aaf7cbc12ae272b6c70b02779b85f91588acbc9d#diff-43dee5a972080512c74efa2a66301506587dcdec4f67fb71e35fe94b3b62b18e |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
|
| https://github.com/antoinerg |
| In image traces, delete source attribute when it is invalid | https://github.com/plotly/plotly.js/pull/5075/commits/e6934467faf4ca8a5e2a83ef4339ab9f8fd68dc7 |
| e693446 | https://github.com/plotly/plotly.js/pull/5075/commits/e6934467faf4ca8a5e2a83ef4339ab9f8fd68dc7 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-467899368 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/aaf7cbc12ae272b6c70b02779b85f91588acbc9d |
| src/traces/image/plot.js | https://github.com/plotly/plotly.js/pull/5075/files/aaf7cbc12ae272b6c70b02779b85f91588acbc9d#diff-43dee5a972080512c74efa2a66301506587dcdec4f67fb71e35fe94b3b62b18e |
| archmoj | https://github.com/archmoj |
| Aug 14, 2020 | https://github.com/plotly/plotly.js/pull/5075#discussion_r470885188 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| antoinerg | https://github.com/antoinerg |
| Aug 17, 2020 | https://github.com/plotly/plotly.js/pull/5075#discussion_r471532780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| archmoj | https://github.com/archmoj |
| Aug 18, 2020 | https://github.com/plotly/plotly.js/pull/5075#discussion_r472470295 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| antoinerg | https://github.com/antoinerg |
| Aug 31, 2020 | https://github.com/plotly/plotly.js/pull/5075#discussion_r480252731 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @archmoj | https://github.com/archmoj |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| archmoj | https://github.com/archmoj |
| Aug 31, 2020 | https://github.com/plotly/plotly.js/pull/5075#discussion_r480255369 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-467899918 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/aaf7cbc12ae272b6c70b02779b85f91588acbc9d |
| src/traces/image/plot.js | https://github.com/plotly/plotly.js/pull/5075/files/aaf7cbc12ae272b6c70b02779b85f91588acbc9d#diff-43dee5a972080512c74efa2a66301506587dcdec4f67fb71e35fe94b3b62b18e |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-467901663 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/e6934467faf4ca8a5e2a83ef4339ab9f8fd68dc7 |
| src/traces/image/plot.js | https://github.com/plotly/plotly.js/pull/5075/files/e6934467faf4ca8a5e2a83ef4339ab9f8fd68dc7#diff-43dee5a972080512c74efa2a66301506587dcdec4f67fb71e35fe94b3b62b18e |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Aug 14, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-467903079 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/e6934467faf4ca8a5e2a83ef4339ab9f8fd68dc7 |
| src/traces/image/plot.js | https://github.com/plotly/plotly.js/pull/5075/files/e6934467faf4ca8a5e2a83ef4339ab9f8fd68dc7#diff-43dee5a972080512c74efa2a66301506587dcdec4f67fb71e35fe94b3b62b18e |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| antoinerg | https://github.com/antoinerg |
| August 17, 2020 11:01 | https://github.com/plotly/plotly.js/pull/5075#commits-pushed-130593e |
|
| https://github.com/antoinerg |
| Fixes image_test to reflect that invalid source are deleted | https://github.com/plotly/plotly.js/pull/5075/commits/130593e4d3ae412dbbd6dac9558556c33ebb2b6c |
| 130593e | https://github.com/plotly/plotly.js/pull/5075/commits/130593e4d3ae412dbbd6dac9558556c33ebb2b6c |
|
| https://github.com/antoinerg |
| Improve code style in the plot routine of image traces | https://github.com/plotly/plotly.js/pull/5075/commits/09eb1d0c144692a2fe4590e524651bd7e8cb6215 |
| 09eb1d0 | https://github.com/plotly/plotly.js/pull/5075/commits/09eb1d0c144692a2fe4590e524651bd7e8cb6215 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Aug 17, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-674967365 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://codepen.io/antoinerg/full/wvGWgMY | https://codepen.io/antoinerg/full/wvGWgMY |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Aug 17, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-675023601 |
| @nicolaskruchten | https://github.com/nicolaskruchten |
| @archmoj | https://github.com/archmoj |
| @alexcjohnson | https://github.com/alexcjohnson |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Aug 18, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-675669813 |
| f2caed8 | https://github.com/plotly/plotly.js/commit/f2caed81ee207c44c0e4189f9c4bb4c98819c689 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Aug 18, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-675671987 |
| @nicolaskruchten | https://github.com/nicolaskruchten |
| @archmoj | https://github.com/archmoj |
| @alexcjohnson | https://github.com/alexcjohnson |
| Stackoverflow thread | https://stackoverflow.com/questions/35036672/trap-the-image-loading-event-on-an-svg-element-in-ie11 |
| f2caed8 | https://github.com/plotly/plotly.js/commit/f2caed81ee207c44c0e4189f9c4bb4c98819c689 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| antoinerg | https://github.com/antoinerg |
| August 18, 2020 15:42 | https://github.com/plotly/plotly.js/pull/5075#commits-pushed-fe1d208 |
|
| https://github.com/antoinerg |
| Improves code readability for image traces | https://github.com/plotly/plotly.js/pull/5075/commits/fe1d2083c4ae61d7c9ee85561fb4654f4cde4643 |
|
| https://github.com/plotly/plotly.js/commit/fe1d2083c4ae61d7c9ee85561fb4654f4cde4643#comments |
| fe1d208 | https://github.com/plotly/plotly.js/pull/5075/commits/fe1d2083c4ae61d7c9ee85561fb4654f4cde4643 |
|
| https://github.com/antoinerg |
| Removes broken test following changes in how image traces check userA… | https://github.com/plotly/plotly.js/pull/5075/commits/2960e5564719cf3bb8becab6a8f77d22fe0a8430 |
| 2960e55 | https://github.com/plotly/plotly.js/pull/5075/commits/2960e5564719cf3bb8becab6a8f77d22fe0a8430 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Aug 18, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-675719467 |
| demo | https://codepen.io/MojtabaSamimi/pen/BaKLawq?editors=0010 |
| @nicolaskruchten | https://github.com/nicolaskruchten |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Aug 18, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-469841346 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/2960e5564719cf3bb8becab6a8f77d22fe0a8430 |
| src/traces/image/plot.js | https://github.com/plotly/plotly.js/pull/5075/files/2960e5564719cf3bb8becab6a8f77d22fe0a8430#diff-43dee5a972080512c74efa2a66301506587dcdec4f67fb71e35fe94b3b62b18e |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/nicolaskruchten |
| nicolaskruchten | https://github.com/nicolaskruchten |
| Aug 18, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-675754266 |
| @emmanuelle | https://github.com/emmanuelle |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| antoinerg | https://github.com/antoinerg |
| August 19, 2020 12:24 | https://github.com/plotly/plotly.js/pull/5075#commits-pushed-3717cbe |
|
| https://github.com/antoinerg |
| Rename _isFrom(Z|Source) to _has(Z|Source) | https://github.com/plotly/plotly.js/pull/5075/commits/3717cbe7429e1266be24a19ce406f601f3718410 |
| 3717cbe | https://github.com/plotly/plotly.js/pull/5075/commits/3717cbe7429e1266be24a19ce406f601f3718410 |
|
| https://github.com/antoinerg |
| Replace Labuda's photography of droplets by one from public domain | https://github.com/plotly/plotly.js/pull/5075/commits/b586a867175365143a8f959d21d899f1810030c0 |
| b586a86 | https://github.com/plotly/plotly.js/pull/5075/commits/b586a867175365143a8f959d21d899f1810030c0 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Aug 19, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-676629698 |
| @antoinerg | https://github.com/antoinerg |
| https://blogs.royalsociety.org/publishing/oh-boy-quantum-droplets-win-the-2019-royal-society-publishing-photography-competition/ | https://blogs.royalsociety.org/publishing/oh-boy-quantum-droplets-win-the-2019-royal-society-publishing-photography-competition/ |
| @emmanuelle | https://github.com/emmanuelle |
| @archmoj | https://github.com/archmoj |
| b586a86 | https://github.com/plotly/plotly.js/commit/b586a867175365143a8f959d21d899f1810030c0 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
|
| https://github.com/antoinerg |
| Add image_astronaut_source to mock_test.js | https://github.com/plotly/plotly.js/pull/5075/commits/d73f4c47975d3636916988d49ddfe598016abf2a |
| d73f4c4 | https://github.com/plotly/plotly.js/pull/5075/commits/d73f4c47975d3636916988d49ddfe598016abf2a |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| force-pushed | https://github.com/plotly/plotly.js/compare/2e90fae859635ff4ef80358a6629ad75fd4021f5..d73f4c47975d3636916988d49ddfe598016abf2a |
| 2e90fae | https://github.com/plotly/plotly.js/commit/2e90fae859635ff4ef80358a6629ad75fd4021f5 |
| d73f4c4 | https://github.com/plotly/plotly.js/commit/d73f4c47975d3636916988d49ddfe598016abf2a |
|
Compare
| https://github.com/plotly/plotly.js/compare/2e90fae859635ff4ef80358a6629ad75fd4021f5..d73f4c47975d3636916988d49ddfe598016abf2a |
| August 19, 2020 20:06 | https://github.com/plotly/plotly.js/pull/5075#event-3672419752 |
| antoinerg | https://github.com/antoinerg |
| August 20, 2020 11:38 | https://github.com/plotly/plotly.js/pull/5075#commits-pushed-18133c9 |
|
| https://github.com/antoinerg |
| Update description of attribute source in images traces | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
| 18133c9 | https://github.com/plotly/plotly.js/pull/5075/commits/18133c980934d6faf30eed84d4384e23126a011f |
|
| https://github.com/antoinerg |
| Introduce colormodel "rgba256" to image traces | https://github.com/plotly/plotly.js/pull/5075/commits/19ce21d21c9dd78504d6a16325cb5739d89bcbff |
| 19ce21d | https://github.com/plotly/plotly.js/pull/5075/commits/19ce21d21c9dd78504d6a16325cb5739d89bcbff |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Aug 21, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-472780995 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/19ce21d21c9dd78504d6a16325cb5739d89bcbff |
| src/traces/image/attributes.js | https://github.com/plotly/plotly.js/pull/5075/files/18133c980934d6faf30eed84d4384e23126a011f..19ce21d21c9dd78504d6a16325cb5739d89bcbff#diff-d9924c2388b94eccb1e73875f6e4ffea295abbe5f3d96b356465072ff419cfff |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Aug 21, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-472781401 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/19ce21d21c9dd78504d6a16325cb5739d89bcbff |
| src/traces/image/defaults.js | https://github.com/plotly/plotly.js/pull/5075/files/18133c980934d6faf30eed84d4384e23126a011f..19ce21d21c9dd78504d6a16325cb5739d89bcbff#diff-a3c9166dfdeb8b64ac5f48a2114f928372c1cfeec9c53b401e0fa9674ca37ccb |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Aug 21, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-472784960 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/19ce21d21c9dd78504d6a16325cb5739d89bcbff |
| src/traces/image/defaults.js | https://github.com/plotly/plotly.js/pull/5075/files/18133c980934d6faf30eed84d4384e23126a011f..19ce21d21c9dd78504d6a16325cb5739d89bcbff#diff-a3c9166dfdeb8b64ac5f48a2114f928372c1cfeec9c53b401e0fa9674ca37ccb |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Aug 21, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-472787060 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/19ce21d21c9dd78504d6a16325cb5739d89bcbff |
| src/traces/image/attributes.js | https://github.com/plotly/plotly.js/pull/5075/files/19ce21d21c9dd78504d6a16325cb5739d89bcbff#diff-d9924c2388b94eccb1e73875f6e4ffea295abbe5f3d96b356465072ff419cfff |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
Aug 21, 2020
| https://github.com/plotly/plotly.js/pull/5075#pullrequestreview-472790042 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/5075/files/19ce21d21c9dd78504d6a16325cb5739d89bcbff |
| test/jasmine/tests/image_test.js | https://github.com/plotly/plotly.js/pull/5075/files/19ce21d21c9dd78504d6a16325cb5739d89bcbff#diff-12b0fa60785ea835fae0a777115c25e7b75a735bc0abd676d3d3df54e8e7c857 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| antoinerg | https://github.com/antoinerg |
| August 31, 2020 12:13 | https://github.com/plotly/plotly.js/pull/5075#commits-pushed-74574b6 |
|
| https://github.com/antoinerg |
| Update description of attribute colormodel in image traces | https://github.com/plotly/plotly.js/pull/5075/commits/74574b69d24fabb7d1e30ca629acd8525c0aeab8 |
| 74574b6 | https://github.com/plotly/plotly.js/pull/5075/commits/74574b69d24fabb7d1e30ca629acd8525c0aeab8 |
|
| https://github.com/antoinerg |
| Update description of attribute source in image traces | https://github.com/plotly/plotly.js/pull/5075/commits/8c736f76b89adad42b31d04d0198a323ee4dc612 |
| 8c736f7 | https://github.com/plotly/plotly.js/pull/5075/commits/8c736f76b89adad42b31d04d0198a323ee4dc612 |
|
| https://github.com/antoinerg |
| Prefer z data over source in image traces and improve code readability | https://github.com/plotly/plotly.js/pull/5075/commits/3b7592132e431fdba06287d6ea95bc065e47da9d |
| 3b75921 | https://github.com/plotly/plotly.js/pull/5075/commits/3b7592132e431fdba06287d6ea95bc065e47da9d |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Aug 31, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-683907760 |
| 3b75921 | https://github.com/plotly/plotly.js/commit/3b7592132e431fdba06287d6ea95bc065e47da9d |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
|
| https://github.com/antoinerg |
| 🔪 unreachable code in image trace defaults routine | https://github.com/plotly/plotly.js/pull/5075/commits/66c58f6c8aa38505c1904210e1dc4f24bab3155c |
| 66c58f6 | https://github.com/plotly/plotly.js/pull/5075/commits/66c58f6c8aa38505c1904210e1dc4f24bab3155c |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Aug 31, 2020 | https://github.com/plotly/plotly.js/pull/5075#issuecomment-683918682 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| f15af7f | https://github.com/plotly/plotly.js/commit/f15af7f7103d8a521b91f090bd870ed3d3d568cb |
| Aug 31, 2020 | https://github.com/plotly/plotly.js/pull/5075#event-3710960703 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| August 31, 2020 17:49 | https://github.com/plotly/plotly.js/pull/5075#event-3710960935 |
|
install image-size in dependencies
#5119
| https://github.com/plotly/plotly.js/pull/5119 |
|
Optimized rendering for image traces
#4842
| https://github.com/plotly/plotly.js/issues/4842 |
|
source attribute for image traces
#4841
| https://github.com/plotly/plotly.js/issues/4841 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F5075 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/5075/files/2960e5564719cf3bb8becab6a8f77d22fe0a8430 |
|
| https://github.com/emmanuelle |
|
emmanuelle
| https://github.com/emmanuelle |
|
| https://github.com/plotly/plotly.js/pull/5075/files/2a687f2e25f7cb4e2e60682f342150f94089e72f |
|
| https://github.com/archmoj |
|
archmoj
| https://github.com/archmoj |
|
| https://github.com/plotly/plotly.js/pull/5075/files/8c736f76b89adad42b31d04d0198a323ee4dc612 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
| Please reload this page | https://github.com/plotly/plotly.js/pull/5075 |
|
| https://github.com/antoinerg |
|
| https://github.com/archmoj |
|
| https://github.com/emmanuelle |
|
| https://github.com/nicolaskruchten |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |