| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:21e45a68-335e-189f-9d61-379e5e2f1c1c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AA42:CD430:259F6AA:364E07F:6A57AD0A |
| html-safe-nonce | ae4a8984b4de2edbaa0149fc36466de23a898f55f4a62bfdc32c41a782c712b1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTQyOkNENDMwOjI1OUY2QUE6MzY0RTA3Rjo2QTU3QUQwQSIsInZpc2l0b3JfaWQiOiIxNDI2NDE1MTk2OTE1MDg0NTU0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | e8d5408831fd5086c5ffb1eb60d4ca3419aa5136c00f125e5445ca64390e10ce |
| hovercard-subject-tag | pull_request:67063518 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/plotly/plotly.js/pull/446/files |
| twitter:image | https://avatars.githubusercontent.com/u/837910?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/837910?s=400&v=4 |
| og:image:alt | ref original pull timelyportfolio#1 for very long discussion and commits
Addresses
#83
#89
#264
#345
plotly/plotly.R#311
Summary of Changes
attach promise-based toImage directly to Plotly
at... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 017a07c29bdd8a37b5907fc9a689338deb7103b5af7f56714193b2700229b3df |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 4cd16a676f89d1cedb932671a5c2d20b8e60f86a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/446/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F446%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F446%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/446/files |
| Reload | https://github.com/plotly/plotly.js/pull/446/files |
| Reload | https://github.com/plotly/plotly.js/pull/446/files |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
772
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
58
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fplotly%2Fplotly.js%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fplotly%2Fplotly.js%2Fissues%2Fnew%2Fchoose |
| etpinard | https://github.com/etpinard |
| plotly:master | https://github.com/plotly/plotly.js/tree/master |
| timelyportfolio:feature/snapshot-pull | https://github.com/timelyportfolio/plotly.js/tree/feature/snapshot-pull |
|
Conversation
91
| https://github.com/plotly/plotly.js/pull/446 |
|
Commits
7
| https://github.com/plotly/plotly.js/pull/446/commits |
|
Checks
0
| https://github.com/plotly/plotly.js/pull/446/checks |
|
Files changed
| https://github.com/plotly/plotly.js/pull/446/files |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
|
add new promise-based toImage and downloadImage to Plotly
| https://github.com/plotly/plotly.js/pull/446/files#top |
|
Show all changes
7 commits
| https://github.com/plotly/plotly.js/pull/446/files |
|
642ddba
add new promise-based toImage and downloadImage to Plotly
timelyportfolio May 11, 2016
| https://github.com/plotly/plotly.js/pull/446/commits/642ddbaee517bed535e69208cc8097233f5a6e82 |
|
41c3126
make IE download use `format:svg` and lint
timelyportfolio May 11, 2016
| https://github.com/plotly/plotly.js/pull/446/commits/41c31262ad90f4a107e4ea34a900913e33ae6233 |
|
3fca377
painfully work through more IE bugs with snapshot
timelyportfolio May 11, 2016
| https://github.com/plotly/plotly.js/pull/446/commits/3fca3778b41bbde537ef3cb2241419454ecd60ea |
|
649e067
reject with error in `svgtoimg` in IE if not `format:'svg'`
timelyportfolio May 12, 2016
| https://github.com/plotly/plotly.js/pull/446/commits/649e067a5f04cd09cd1764eec12292466886d798 |
|
0f5022e
fix promise check in toimage_test
timelyportfolio May 14, 2016
| https://github.com/plotly/plotly.js/pull/446/commits/0f5022e34e8e024b9f3eeb2b70e5e15ab0839808 |
|
5f8877f
change safari download to `application/octet-stream'
timelyportfolio May 16, 2016
| https://github.com/plotly/plotly.js/pull/446/commits/5f8877feed276531a664d1f41dcc1ca2022ca411 |
|
05a2448
remove unnecessary comment
timelyportfolio May 16, 2016
| https://github.com/plotly/plotly.js/pull/446/commits/05a24486f3576fc2662fb9d81c5d3e7a1144b824 |
|
Clear filters
| https://github.com/plotly/plotly.js/pull/446/files |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
|
.eslintrc
| https://github.com/plotly/plotly.js/pull/446/files#diff-e7e195d3d8fa5b82fa51ed952f3a179d429cbc46c0432ce1f7b357c54c162822 |
|
buttons.js
| https://github.com/plotly/plotly.js/pull/446/files#diff-d6275f435baf3d8a4c31e3a2d5636fea0cec83a8b600e5f14610e98a0a0b6549 |
|
core.js
| https://github.com/plotly/plotly.js/pull/446/files#diff-8ab41fe13597e1554b5d6b4c227b5f123ff2d6726a7f3688a8b8d1224fe1d4f3 |
|
to_image.js
| https://github.com/plotly/plotly.js/pull/446/files#diff-6aa51b427928317ed30c4f63936705428df517f7cb91121222aeac348d8d0a57 |
|
download.js
| https://github.com/plotly/plotly.js/pull/446/files#diff-e53ea7539ea0112a94124521600eb2bdaf3e0d279be5af204a1a541a16cf7b4d |
|
filesaver.js
| https://github.com/plotly/plotly.js/pull/446/files#diff-68ffdc7191421036023bfc35b469990da21da4dfc0c5f3e552c54ab5a248aec0 |
|
index.js
| https://github.com/plotly/plotly.js/pull/446/files#diff-8c216bb7d06d18ee6c3ecde9b51c4955f35f832e8337d7d8ed814fcbc050ba35 |
|
svgtoimg.js
| https://github.com/plotly/plotly.js/pull/446/files#diff-b6ec3ccf1f493cc2a63095b81c3c2d56a92bdbb0d4797c4e043a3c7ec40cfdcc |
|
toimage.js
| https://github.com/plotly/plotly.js/pull/446/files#diff-9f918ee61854f912a860473e91023cf3b11a1cf09a0adce3bac868950a898470 |
|
download_test.js
| https://github.com/plotly/plotly.js/pull/446/files#diff-ff32f2f0869c6558b44fe949b4a4c67180381178e55f0f0a94415a4ad17c3b1b |
|
toimage_test.js
| https://github.com/plotly/plotly.js/pull/446/files#diff-cb24dd981cf41998c93295c76af5b1e41c93bdd2e4da6ac96021b2dc3772279a |
| .eslintrc | https://github.com/plotly/plotly.js/pull/446/files#diff-e7e195d3d8fa5b82fa51ed952f3a179d429cbc46c0432ce1f7b357c54c162822 |
|
View file
| https://github.com/timelyportfolio/plotly.js/blob/05a24486f3576fc2662fb9d81c5d3e7a1144b824/.eslintrc |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/446/{{ revealButtonHref }} |
|
| https://github.com/plotly/plotly.js/pull/446/files#diff-e7e195d3d8fa5b82fa51ed952f3a179d429cbc46c0432ce1f7b357c54c162822 |
|
| https://github.com/plotly/plotly.js/pull/446/files#diff-e7e195d3d8fa5b82fa51ed952f3a179d429cbc46c0432ce1f7b357c54c162822 |
| src/components/modebar/buttons.js | https://github.com/plotly/plotly.js/pull/446/files#diff-d6275f435baf3d8a4c31e3a2d5636fea0cec83a8b600e5f14610e98a0a0b6549 |
|
View file
| https://github.com/timelyportfolio/plotly.js/blob/05a24486f3576fc2662fb9d81c5d3e7a1144b824/src/components/modebar/buttons.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/446/{{ revealButtonHref }} |
|
| https://github.com/plotly/plotly.js/pull/446/files#diff-d6275f435baf3d8a4c31e3a2d5636fea0cec83a8b600e5f14610e98a0a0b6549 |
|
| https://github.com/plotly/plotly.js/pull/446/files#diff-d6275f435baf3d8a4c31e3a2d5636fea0cec83a8b600e5f14610e98a0a0b6549 |
|
| https://github.com/plotly/plotly.js/pull/446/files#diff-d6275f435baf3d8a4c31e3a2d5636fea0cec83a8b600e5f14610e98a0a0b6549 |
| etpinard | https://github.com/etpinard |
| Apr 27, 2016 | https://github.com/plotly/plotly.js/pull/446/files#r61342806 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @timelyportfolio | https://github.com/timelyportfolio |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
| etpinard | https://github.com/etpinard |
| Apr 27, 2016 | https://github.com/plotly/plotly.js/pull/446/files#r61342944 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/plotly/plotly.js/pull/446/files#diff-40d98cbce238527d9bffcf2ecd4efa9bR33 | https://github.com/plotly/plotly.js/pull/446/files#diff-40d98cbce238527d9bffcf2ecd4efa9bR33 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
|
| https://github.com/plotly/plotly.js/pull/446/files#diff-d6275f435baf3d8a4c31e3a2d5636fea0cec83a8b600e5f14610e98a0a0b6549 |
| src/core.js | https://github.com/plotly/plotly.js/pull/446/files#diff-8ab41fe13597e1554b5d6b4c227b5f123ff2d6726a7f3688a8b8d1224fe1d4f3 |
|
View file
| https://github.com/timelyportfolio/plotly.js/blob/05a24486f3576fc2662fb9d81c5d3e7a1144b824/src/core.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/446/{{ revealButtonHref }} |
|
| https://github.com/plotly/plotly.js/pull/446/files#diff-8ab41fe13597e1554b5d6b4c227b5f123ff2d6726a7f3688a8b8d1224fe1d4f3 |
|
| https://github.com/plotly/plotly.js/pull/446/files#diff-8ab41fe13597e1554b5d6b4c227b5f123ff2d6726a7f3688a8b8d1224fe1d4f3 |
| src/plot_api/to_image.js | https://github.com/plotly/plotly.js/pull/446/files#diff-6aa51b427928317ed30c4f63936705428df517f7cb91121222aeac348d8d0a57 |
|
View file
| https://github.com/timelyportfolio/plotly.js/blob/05a24486f3576fc2662fb9d81c5d3e7a1144b824/src/plot_api/to_image.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/446/{{ revealButtonHref }} |
| mdtusz | https://github.com/mdtusz |
| May 12, 2016 | https://github.com/plotly/plotly.js/pull/446/files#r63041057 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
| timelyportfolio | https://github.com/timelyportfolio |
| May 12, 2016 | https://github.com/plotly/plotly.js/pull/446/files#r63042674 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
| src/snapshot/download.js | https://github.com/plotly/plotly.js/pull/446/files#diff-e53ea7539ea0112a94124521600eb2bdaf3e0d279be5af204a1a541a16cf7b4d |
|
View file
| https://github.com/timelyportfolio/plotly.js/blob/05a24486f3576fc2662fb9d81c5d3e7a1144b824/src/snapshot/download.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/446/{{ revealButtonHref }} |
| src/snapshot/filesaver.js | https://github.com/plotly/plotly.js/pull/446/files#diff-68ffdc7191421036023bfc35b469990da21da4dfc0c5f3e552c54ab5a248aec0 |
|
View file
| https://github.com/timelyportfolio/plotly.js/blob/05a24486f3576fc2662fb9d81c5d3e7a1144b824/src/snapshot/filesaver.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/446/{{ revealButtonHref }} |
| mdtusz | https://github.com/mdtusz |
| May 12, 2016 | https://github.com/plotly/plotly.js/pull/446/files#r63043176 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
| timelyportfolio | https://github.com/timelyportfolio |
| May 12, 2016 | https://github.com/plotly/plotly.js/pull/446/files#r63043856 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
| src/snapshot/index.js | https://github.com/plotly/plotly.js/pull/446/files#diff-8c216bb7d06d18ee6c3ecde9b51c4955f35f832e8337d7d8ed814fcbc050ba35 |
|
View file
| https://github.com/timelyportfolio/plotly.js/blob/05a24486f3576fc2662fb9d81c5d3e7a1144b824/src/snapshot/index.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/446/{{ revealButtonHref }} |
|
| https://github.com/plotly/plotly.js/pull/446/files#diff-8c216bb7d06d18ee6c3ecde9b51c4955f35f832e8337d7d8ed814fcbc050ba35 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/446/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |