| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8b3a724e-441f-f68b-5eae-ad2e73d8c1a1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9F4E:3CC14A:3A4812B:52F1DEB:6A56AFBE |
| html-safe-nonce | c9ecae8f8d53a25855c9988e609c5a42e6a6c01c3a0fcbfaf5857dfb52f22af1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RjRFOjNDQzE0QTozQTQ4MTJCOjUyRjFERUI6NkE1NkFGQkUiLCJ2aXNpdG9yX2lkIjoiMTM1OTY4NzgyNDc5NTE1MjMxOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a8dec88a3b8d3c6f818b627dd7f3c3b62446c2176b9fa2a910c14363396f0329 |
| hovercard-subject-tag | pull_request:334472580 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/4322/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/140fee444589e6dc26923da8af4f0203cd54a630ddf96a31f69821d261f363be/plotly/plotly.js/pull/4322 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/140fee444589e6dc26923da8af4f0203cd54a630ddf96a31f69821d261f363be/plotly/plotly.js/pull/4322 |
| og:image:alt | Node v12 is now LTS, so let's start using it.
Note the node-v12 docker containers provided by CircleCI ship with Chrome v78. This makes some of our jasmine tests fail.
The failing tests are:
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | etpinard |
| hostname | github.com |
| expected-hostname | github.com |
| None | df99b7164e1d961b639cf5d3cbd6b5ba673edc67bd7e47cdc4746b96099e11ae |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c29ba03b1896083dbe1084f6cd1c5367d8a0d67c |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/4322#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F4322 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F4322 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/4322 |
| Reload | https://github.com/plotly/plotly.js/pull/4322 |
| Reload | https://github.com/plotly/plotly.js/pull/4322 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/4322 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/4322 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
771
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
56
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| use-node12 | https://github.com/plotly/plotly.js/tree/use-node12 |
| Conversation | https://github.com/plotly/plotly.js/pull/4322 |
| Commits10 (10) | https://github.com/plotly/plotly.js/pull/4322/commits |
| Checks | https://github.com/plotly/plotly.js/pull/4322/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/4322/files |
| Use Node v12.13.0 (LTS) for development | https://github.com/plotly/plotly.js/pull/4322#top |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| use-node12 | https://github.com/plotly/plotly.js/tree/use-node12 |
|
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Oct 30, 2019 | https://github.com/plotly/plotly.js/pull/4322#issue-514929660 |
| Node v12 | https://nodejs.org/en/blog/release/v12.13.0/ |
| plotly.js/test/jasmine/tests/hover_label_test.js | https://github.com/plotly/plotly.js/blob/742b83da9f851860d3f217c7fb56b763912b541b/test/jasmine/tests/hover_label_test.js#L2527-L2551 |
| 742b83d | https://github.com/plotly/plotly.js/commit/742b83da9f851860d3f217c7fb56b763912b541b |
| plotly.js/test/jasmine/tests/colorbar_test.js | https://github.com/plotly/plotly.js/blob/742b83da9f851860d3f217c7fb56b763912b541b/test/jasmine/tests/colorbar_test.js#L400-L460 |
| 742b83d | https://github.com/plotly/plotly.js/commit/742b83da9f851860d3f217c7fb56b763912b541b |
| plotly.js/test/jasmine/tests/splom_test.js | https://github.com/plotly/plotly.js/blob/742b83da9f851860d3f217c7fb56b763912b541b/test/jasmine/tests/splom_test.js#L946-L998 |
| 742b83d | https://github.com/plotly/plotly.js/commit/742b83da9f851860d3f217c7fb56b763912b541b |
| #2939 | https://github.com/plotly/plotly.js/pull/2939 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/4322 |
| etpinard | https://github.com/etpinard |
| October 30, 2019 14:38 | https://github.com/plotly/plotly.js/pull/4322#commits-pushed-b18bf72 |
|
| https://github.com/etpinard |
| use node 12.13.0 (LTS) on CircleCI | https://github.com/plotly/plotly.js/pull/4322/commits/b18bf7295ad69f67d40d98a0dca83ad750ace39f |
| b18bf72 | https://github.com/plotly/plotly.js/pull/4322/commits/b18bf7295ad69f67d40d98a0dca83ad750ace39f |
|
| https://github.com/etpinard |
| use node "12" on AppVeyor | https://github.com/plotly/plotly.js/pull/4322/commits/dff2d0b00b8d796a0c37b768b2baecf72bbea0f4 |
| dff2d0b | https://github.com/plotly/plotly.js/pull/4322/commits/dff2d0b00b8d796a0c37b768b2baecf72bbea0f4 |
|
| https://github.com/etpinard |
| update Contributing to mention node v12 | https://github.com/plotly/plotly.js/pull/4322/commits/39c194425ace6bf0555744d7ec6043731a08237a |
| 39c1944 | https://github.com/plotly/plotly.js/pull/4322/commits/39c194425ace6bf0555744d7ec6043731a08237a |
|
| https://github.com/etpinard |
| set --node 12.13 and --npm 6.12 in check-node-version call | https://github.com/plotly/plotly.js/pull/4322/commits/a5eba617a552082a09048399a8a738d09003a6b3 |
| a5eba61 | https://github.com/plotly/plotly.js/pull/4322/commits/a5eba617a552082a09048399a8a738d09003a6b3 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
type: maintenance
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22type%3A%20maintenance%22 |
| Oct 30, 2019 | https://github.com/plotly/plotly.js/pull/4322#event-2757375432 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 30, 2019
| https://github.com/plotly/plotly.js/pull/4322#pullrequestreview-309468901 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/4322/files/a5eba617a552082a09048399a8a738d09003a6b3 |
| package.json | https://github.com/plotly/plotly.js/pull/4322/files/a5eba617a552082a09048399a8a738d09003a6b3#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 |
| etpinard | https://github.com/etpinard |
| Oct 30, 2019 | https://github.com/plotly/plotly.js/pull/4322#discussion_r340818601 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @archmoj | https://github.com/archmoj |
| Please reload this page | https://github.com/plotly/plotly.js/pull/4322 |
| etpinard | https://github.com/etpinard |
| Nov 20, 2019 | https://github.com/plotly/plotly.js/pull/4322#discussion_r348787061 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 7759c76 | https://github.com/plotly/plotly.js/commit/7759c7602be9d0247176d817bddf6ac0f6b5e630 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/4322 |
| etpinard | https://github.com/etpinard |
| November 20, 2019 15:00 | https://github.com/plotly/plotly.js/pull/4322#commits-pushed-7759c76 |
|
| https://github.com/etpinard |
| bump npm version check to 6.13 | https://github.com/plotly/plotly.js/pull/4322/commits/7759c7602be9d0247176d817bddf6ac0f6b5e630 |
| 7759c76 | https://github.com/plotly/plotly.js/pull/4322/commits/7759c7602be9d0247176d817bddf6ac0f6b5e630 |
|
| https://github.com/etpinard |
| Merge branch 'master' into use-node12 | https://github.com/plotly/plotly.js/pull/4322/commits/205f4f8e1fada89c12775e472095fc7dfe01af48 |
| 205f4f8 | https://github.com/plotly/plotly.js/pull/4322/commits/205f4f8e1fada89c12775e472095fc7dfe01af48 |
|
| https://github.com/etpinard |
| adapt "replot canvas" test for Chrome 78 | https://github.com/plotly/plotly.js/pull/4322/commits/97fe7600c9a110c5c38a7aa49c7d8612e3dda977 |
| 97fe760 | https://github.com/plotly/plotly.js/pull/4322/commits/97fe7600c9a110c5c38a7aa49c7d8612e3dda977 |
|
| https://github.com/etpinard |
| add | https://github.com/plotly/plotly.js/pull/4322/commits/cb5be64e4ab290ce92272783676e152722c95f56 |
| @flaky | https://github.com/flaky |
| to editable:true colorbar tests | https://github.com/plotly/plotly.js/pull/4322/commits/cb5be64e4ab290ce92272783676e152722c95f56 |
| cb5be64 | https://github.com/plotly/plotly.js/pull/4322/commits/cb5be64e4ab290ce92272783676e152722c95f56 |
|
| https://github.com/etpinard |
| round bbox widths values to workaround Chrome78 rounding errors | https://github.com/plotly/plotly.js/pull/4322/commits/9ec38b1548c76ae2c513b8fc814142ebf806d67d |
| 9ec38b1 | https://github.com/plotly/plotly.js/pull/4322/commits/9ec38b1548c76ae2c513b8fc814142ebf806d67d |
|
| https://github.com/etpinard |
| tweak hover label px position in scatterternay fill test | https://github.com/plotly/plotly.js/pull/4322/commits/00b7d309e26322320a13782095d06ec5d4801dd9 |
| 00b7d30 | https://github.com/plotly/plotly.js/pull/4322/commits/00b7d309e26322320a13782095d06ec5d4801dd9 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Nov 20, 2019 | https://github.com/plotly/plotly.js/pull/4322#issuecomment-556517981 |
| @archmoj | https://github.com/archmoj |
| Please reload this page | https://github.com/plotly/plotly.js/pull/4322 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
|
status: in progress
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22 |
| Nov 20, 2019 | https://github.com/plotly/plotly.js/pull/4322#event-2817106392 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Nov 21, 2019 | https://github.com/plotly/plotly.js/pull/4322#issuecomment-556863067 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/4322 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| 9ee4aa7 | https://github.com/plotly/plotly.js/commit/9ee4aa7e6f6be886e76201b8e7752d690f0daf35 |
| Nov 21, 2019 | https://github.com/plotly/plotly.js/pull/4322#event-2819903218 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| November 21, 2019 14:41 | https://github.com/plotly/plotly.js/pull/4322#event-2819903467 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F4322 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/4322 |
|
| https://github.com/etpinard |
|
| https://github.com/archmoj |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |