René's URL Explorer Experiment


Title: More auto-margin fixes (some of them temporary) by etpinard · Pull Request #4216 · plotly/plotly.js · GitHub

Open Graph Title: More auto-margin fixes (some of them temporary) by etpinard · Pull Request #4216 · plotly/plotly.js

X Title: More auto-margin fixes (some of them temporary) by etpinard · Pull Request #4216 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - More auto-margin fixes (some of them temporary) by etpinard · Pull Request #4216 · plotly/plotly.js

Open Graph Description: This PR closes #4028 - which presents two ways of getting infinite redraw loops with axis.automargin turned on. Example 1: before: https://codepen.io/alanjmac/pen/oraKpR (try reducing the window wi...

X Description: This PR closes #4028 - which presents two ways of getting infinite redraw loops with axis.automargin turned on. Example 1: before: https://codepen.io/alanjmac/pen/oraKpR (try reducing the window wi...

Opengraph URL: https://github.com/plotly/plotly.js/pull/4216

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7db2f030-fc55-bdea-3087-71f2b9ee313d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC59A:11EACE:1FC76D7:2A66F10:6B017B45
html-safe-noncec4d571c601947b6567d65b12487d7ec0ee907755b8dc41e8bb3b9e98d475db7e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTlBOjExRUFDRToxRkM3NkQ3OjJBNjZGMTA6NkIwMTdCNDUiLCJ2aXNpdG9yX2lkIjoiNzA4OTM3NDcxNjgwODQ5Mzg5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac65b3b02efd3fb705979c6e191666732b5b871071694b8e24792f511ab578f3ac
hovercard-subject-tagpull_request:320990823
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/4216/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8b1c2f40b6ede7272a33be40aadc7757587abe5487e36bd912cd8fa9fd97814b/plotly/plotly.js/pull/4216
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8b1c2f40b6ede7272a33be40aadc7757587abe5487e36bd912cd8fa9fd97814b/plotly/plotly.js/pull/4216
og:image:altThis PR closes #4028 - which presents two ways of getting infinite redraw loops with axis.automargin turned on. Example 1: before: https://codepen.io/alanjmac/pen/oraKpR (try reducing the window wi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameetpinard
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/4216#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F4216
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F4216
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/4216
Reloadhttps://github.com/plotly/plotly.js/pull/4216
Reloadhttps://github.com/plotly/plotly.js/pull/4216
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
automargin-max-number-of-redrawshttps://github.com/plotly/plotly.js/tree/automargin-max-number-of-redraws
Conversationhttps://github.com/plotly/plotly.js/pull/4216
Commits5 (5)https://github.com/plotly/plotly.js/pull/4216/commits
Checkshttps://github.com/plotly/plotly.js/pull/4216/checks
Files changedhttps://github.com/plotly/plotly.js/pull/4216/files
More auto-margin fixes (some of them temporary)https://github.com/plotly/plotly.js/pull/4216#top
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
automargin-max-number-of-redrawshttps://github.com/plotly/plotly.js/tree/automargin-max-number-of-redraws
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 24, 2019https://github.com/plotly/plotly.js/pull/4216#issue-497957987
#4028https://github.com/plotly/plotly.js/issues/4028
https://codepen.io/alanjmac/pen/oraKpRhttps://codepen.io/alanjmac/pen/oraKpR
https://codepen.io/etpinard/pen/OJLqVZKhttps://codepen.io/etpinard/pen/OJLqVZK
https://codepen.io/wbrgss/pen/LYPryKOhttps://codepen.io/wbrgss/pen/LYPryKO
https://codepen.io/etpinard/pen/xxKBGzWhttps://codepen.io/etpinard/pen/xxKBGzW
@wbrgsshttps://github.com/wbrgss
f506306https://github.com/plotly/plotly.js/commit/f506306b439db46e2f9de421aaddfb0d225ed988
7a8eedfhttps://github.com/plotly/plotly.js/commit/7a8eedf44b72456e8341802cc4efb7a19d6349fa
#2704 (comment)https://github.com/plotly/plotly.js/issues/2704#issuecomment-524474154
631014ahttps://github.com/plotly/plotly.js/commit/631014a1688c4a495125c9774d8e8b438d995555
Automargin pipeline #2704 (comment)https://github.com/plotly/plotly.js/issues/2704#issuecomment-534302295
58fd632https://github.com/plotly/plotly.js/commit/58fd6327481a261fc2392725051bc9f81e8219b0
f506306https://github.com/plotly/plotly.js/commit/f506306b439db46e2f9de421aaddfb0d225ed988
@archmojhttps://github.com/archmoj
Please reload this pagehttps://github.com/plotly/plotly.js/pull/4216
etpinardhttps://github.com/etpinard
September 24, 2019 17:40https://github.com/plotly/plotly.js/pull/4216#commits-pushed-f506306
https://github.com/etpinard
use (xl,xr,yt,yb) instead of (x,y) as push margin coordinateshttps://github.com/plotly/plotly.js/pull/4216/commits/f506306b439db46e2f9de421aaddfb0d225ed988
f506306https://github.com/plotly/plotly.js/pull/4216/commits/f506306b439db46e2f9de421aaddfb0d225ed988
https://github.com/etpinard
do not try to re-fix axis label overlaps when current autoangle:=90https://github.com/plotly/plotly.js/pull/4216/commits/7a8eedf44b72456e8341802cc4efb7a19d6349fa
7a8eedfhttps://github.com/plotly/plotly.js/pull/4216/commits/7a8eedf44b72456e8341802cc4efb7a19d6349fa
https://github.com/etpinard
Add (large) upper bound on the number of redraw callshttps://github.com/plotly/plotly.js/pull/4216/commits/631014a1688c4a495125c9774d8e8b438d995555
631014ahttps://github.com/plotly/plotly.js/pull/4216/commits/631014a1688c4a495125c9774d8e8b438d995555
https://github.com/etpinard
add mock 🔒 case that currently result in infinite loophttps://github.com/plotly/plotly.js/pull/4216/commits/58fd6327481a261fc2392725051bc9f81e8219b0
58fd632https://github.com/plotly/plotly.js/pull/4216/commits/58fd6327481a261fc2392725051bc9f81e8219b0
https://github.com/etpinard
etpinardhttps://github.com/etpinard
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
Sep 24, 2019https://github.com/plotly/plotly.js/pull/4216#event-2659754706
https://github.com/etpinard
etpinardhttps://github.com/etpinard
v1.50.0https://github.com/plotly/plotly.js/milestone/46
Sep 24, 2019https://github.com/plotly/plotly.js/pull/4216#event-2659754710
https://github.com/archmoj
archmojhttps://github.com/archmoj
Sep 25, 2019 https://github.com/plotly/plotly.js/pull/4216#pullrequestreview-292773132
View reviewed changes https://github.com/plotly/plotly.js/pull/4216/files/58fd6327481a261fc2392725051bc9f81e8219b0
archmojhttps://github.com/archmoj
https://github.com/plotly/plotly.js/pull/4216#pullrequestreview-292773132
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/4216
src/plots/cartesian/axes.jshttps://github.com/plotly/plotly.js/pull/4216/files/58fd6327481a261fc2392725051bc9f81e8219b0#diff-5f001ae7bd55867b9cfbe23508ea18384159d46c141298fa7d177cfd76194695
Please reload this pagehttps://github.com/plotly/plotly.js/pull/4216
https://github.com/etpinard
add extra ax.automargin condition for fixLabelOverlaps bypasshttps://github.com/plotly/plotly.js/pull/4216/commits/9a665dbd1245ba9a0461696b44366cb004a7b7ea
9a665dbhttps://github.com/plotly/plotly.js/pull/4216/commits/9a665dbd1245ba9a0461696b44366cb004a7b7ea
https://github.com/archmoj
archmojhttps://github.com/archmoj
Sep 25, 2019https://github.com/plotly/plotly.js/pull/4216#issuecomment-535047574
@etpinardhttps://github.com/etpinard
Please reload this pagehttps://github.com/plotly/plotly.js/pull/4216
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 25, 2019https://github.com/plotly/plotly.js/pull/4216#issuecomment-535054011
@archmojhttps://github.com/archmoj
Please reload this pagehttps://github.com/plotly/plotly.js/pull/4216
https://github.com/etpinard
etpinardhttps://github.com/etpinard
1dee68bhttps://github.com/plotly/plotly.js/commit/1dee68b7fdd768c5dbc4b3644d4bcbd15f8e591a
Sep 25, 2019https://github.com/plotly/plotly.js/pull/4216#event-2661946996
https://github.com/etpinard
etpinardhttps://github.com/etpinard
September 25, 2019 14:37https://github.com/plotly/plotly.js/pull/4216#event-2661947265
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 25, 2019 https://github.com/plotly/plotly.js/pull/4216#ref-issue-329951423
Automargin pipeline #2704 https://github.com/plotly/plotly.js/issues/2704
https://github.com/fabiangehring
fabiangehringhttps://github.com/fabiangehring
Oct 4, 2019https://github.com/plotly/plotly.js/pull/4216#issuecomment-538375435
Please reload this pagehttps://github.com/plotly/plotly.js/pull/4216
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Oct 4, 2019https://github.com/plotly/plotly.js/pull/4216#issuecomment-538388047
Please reload this pagehttps://github.com/plotly/plotly.js/pull/4216
https://github.com/bjornol
bjornolhttps://github.com/bjornol
Oct 18, 2019 https://github.com/plotly/plotly.js/pull/4216#ref-issue-509088528
Upgrade plotly.js to 1.5.n <--> xaxis : automargin causes infinite loop plotly/plotly.R#1642 https://github.com/plotly/plotly.R/issues/1642
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Oct 25, 2019 https://github.com/plotly/plotly.js/pull/4216#ref-issue-498916700
tight margins: rightmost label cutoff #4225 https://github.com/plotly/plotly.js/issues/4225
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Feb 4, 2020 https://github.com/plotly/plotly.js/pull/4216#ref-pullrequest-559463188
[Snyk] Upgrade plotly.js from 1.45.3 to 1.52.0 beauremus/ftp-viewer#1 https://github.com/beauremus/ftp-viewer/pull/1
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Feb 11, 2020 https://github.com/plotly/plotly.js/pull/4216#ref-issue-563494283
getting warning about too many auto-margin redraws #4572 https://github.com/plotly/plotly.js/issues/4572
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Feb 22, 2020 https://github.com/plotly/plotly.js/pull/4216#ref-pullrequest-569396455
[Snyk] Upgrade plotly.js from 1.35.2 to 1.52.1 raindigi/eShopOnContainersAI#1 https://github.com/raindigi/eShopOnContainersAI/pull/1
https://github.com/snyk-bot
snyk-bothttps://github.com/snyk-bot
Apr 17, 2020 https://github.com/plotly/plotly.js/pull/4216#ref-pullrequest-601631224
[Snyk] Upgrade plotly.js from 1.41.3 to 1.52.3 dunzoit/redash#4 https://github.com/dunzoit/redash/pull/4
petiihttps://github.com/petii
Apr 27, 2022 https://github.com/plotly/plotly.js/pull/4216#ref-commit-8b20212
https://github.com/petii
Cherry pick commits from "More auto-margin fixes (some of them tempor…https://github.com/tulip/plotly.js/commit/8b2021260a73c6410bffdfd159924f7c9c178032
8b20212https://github.com/tulip/plotly.js/commit/8b2021260a73c6410bffdfd159924f7c9c178032
plotly#4216https://github.com/plotly/plotly.js/pull/4216
7a8eedfhttps://github.com/tulip/plotly.js/commit/7a8eedf44b72456e8341802cc4efb7a19d6349fa
631014ahttps://github.com/tulip/plotly.js/commit/631014a1688c4a495125c9774d8e8b438d995555
petiihttps://github.com/petii
Apr 28, 2022 https://github.com/plotly/plotly.js/pull/4216#ref-commit-07f44f1
https://github.com/petii
Cherry pick commits from "More auto-margin fixes (some of them tempor…https://github.com/tulip/plotly.js/commit/07f44f14c15b734a8f127aac5d71f378a965af88
07f44f1https://github.com/tulip/plotly.js/commit/07f44f14c15b734a8f127aac5d71f378a965af88
plotly#4216https://github.com/plotly/plotly.js/pull/4216
7a8eedfhttps://github.com/tulip/plotly.js/commit/7a8eedf44b72456e8341802cc4efb7a19d6349fa
631014ahttps://github.com/tulip/plotly.js/commit/631014a1688c4a495125c9774d8e8b438d995555
petiihttps://github.com/petii
Apr 28, 2022 https://github.com/plotly/plotly.js/pull/4216#ref-commit-c4660aa
https://github.com/petii
Cherry pick commits from "More auto-margin fixes (some of them tempor…https://github.com/tulip/plotly.js/commit/c4660aa51d58c6428595e0c973af8a117d112e4b
c4660aahttps://github.com/tulip/plotly.js/commit/c4660aa51d58c6428595e0c973af8a117d112e4b
plotly#4216https://github.com/plotly/plotly.js/pull/4216
1fc0223https://github.com/tulip/plotly.js/commit/1fc0223d5251a4294979aa9c8e18145fef32d41a
7a8eedfhttps://github.com/tulip/plotly.js/commit/7a8eedf44b72456e8341802cc4efb7a19d6349fa
83f1a36https://github.com/tulip/plotly.js/commit/83f1a36546784a14b3ae651ca766d7b8b806fa01
631014ahttps://github.com/tulip/plotly.js/commit/631014a1688c4a495125c9774d8e8b438d995555
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Dec 15, 2023 https://github.com/plotly/plotly.js/pull/4216#ref-pullrequest-2006417762
Add autotickangles property #6790 https://github.com/plotly/plotly.js/pull/6790
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F4216
https://github.com/archmoj
archmoj https://github.com/archmoj
https://github.com/plotly/plotly.js/pull/4216/files/58fd6327481a261fc2392725051bc9f81e8219b0
Please reload this pagehttps://github.com/plotly/plotly.js/pull/4216
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
v1.50.0 https://github.com/plotly/plotly.js/milestone/46
Automargin call stack size exceeded exception when resizing window https://github.com/plotly/plotly.js/issues/4028
Please reload this pagehttps://github.com/plotly/plotly.js/pull/4216
https://github.com/etpinard
https://github.com/archmoj
https://github.com/fabiangehring
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.