react-profiling 0
react-import-map react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controller voltron_pull_requests_fragments
route-action pull_request_layout
fetch-nonce v2:658b11c3-b57c-44e9-11c3-52e49d9edc88
current-catalog-service-hash ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id 865A:148EE1:1CD609:248F6A:6B01F259
html-safe-nonce fdb0b0970c8a4ade6f2284bc2c921165a0e42cc3c765b87fce6139eb8c5f2f4e
visitor-payload eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjVBOjE0OEVFMToxQ0Q2MDk6MjQ4RjZBOjZCMDFGMjU5IiwidmlzaXRvcl9pZCI6Ijg1MjU0MTA1NTI3ODMxNzIxODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac d40b2a8f4f7b59cf3d68a7d269adb3c0ff052e3fe82d082a6dacf90dc3b3658a
hovercard-subject-tag pull_request:66022686
github-keyboard-shortcuts repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verification Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-url https://collector.github.com/github/collect
analytics-location ///voltron/pull_requests_fragments/pull_request_layout
fb:app_id 1401488693436528
apple-itunes-app app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/415/pull_request_layout
twitter:image https://opengraph.githubassets.com/489d0016140cd830f6140a6517ec2cc552b1d163a767caf2eec5771237903640/plotly/plotly.js/pull/415
twitter:card summary_large_image
og:image https://opengraph.githubassets.com/489d0016140cd830f6140a6517ec2cc552b1d163a767caf2eec5771237903640/plotly/plotly.js/pull/415
og:image:alt @jackparmer @etpinard
After this PR is merged, we should be able to use exported SVG from most plots in vector applications like Illustrator without nesting issues.
In Brief
Swap subplot and annot...
og:image:width 1200
og:image:height 600
og:site_name GitHub
og:type object
og:author:username mdtusz
hostname github.com
expected-hostname github.com
None 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-control no-cache
go-import github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id 5997976
octolytics-dimension-user_login plotly
octolytics-dimension-repository_id 45646037
octolytics-dimension-repository_nwo plotly/plotly.js
octolytics-dimension-repository_public true
octolytics-dimension-repository_is_fork false
octolytics-dimension-repository_network_root_id 45646037
octolytics-dimension-repository_network_root_nwo plotly/plotly.js
turbo-body-classes logged-out env-production page-responsive
disable-turbo false
browser-stats-url https://api.github.com/_private/browser/stats
browser-errors-url https://api.github.com/_private/browser/errors
release 423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-target full
theme-color #1e2327
color-scheme light dark
react-app-name pull-requests
Skip to content https://github.com/plotly/plotly.js/pull/415#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F415
GitHubRepository hosting, code review, and collaboration https://github.com/platform
CopilotAI coding agent for tasks, projects, and automated work https://github.com/features/copilot
ActionsCI/CD and automation https://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcement https://github.com/features/code-quality
CodespacesCloud development environments https://github.com/features/codespaces
Code SecurityVulnerability detection and remediation https://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak prevention https://github.com/security/advanced-security/secret-protection
All Features https://github.com/features
Documentation https://docs.github.com/en
Training https://learn.github.com/skills
Certifications https://learn.github.com/credentials
Build with Copilot https://github.com/features/ai
Customize Copilot https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrations https://github.com/marketplace
Trending repos https://github.com/trending
GitHub Sponsors https://github.com/open-source/sponsors
Developer articles https://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. https://github.blog/changelog/
Enterprises https://github.com/enterprise
Team https://github.com/team
Startups https://github.com/enterprise/startups
Nonprofits https://github.com/solutions/industry/nonprofits
Healthcare https://github.com/solutions/industry/healthcare
Financial services https://github.com/solutions/industry/financial-services
Manufacturing https://github.com/solutions/industry/manufacturing
Government https://github.com/solutions/industry/government
See all industries https://github.com/solutions/industry
Why GitHub https://github.com/why-github
Customer Stories https://github.com/customer-stories
Business insights https://github.com/solutions/executive-insights
Trust Center https://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code security https://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI features https://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 support https://github.com/enterprise/premium-support
Documentation https://docs.github.com/en
Resource center https://github.com/resources
Blog https://github.blog/
Events & webinars https://github.com/resources/events
Community Forum https://github.com/orgs/community/discussions
Customer Stories https://github.com/customer-stories
Integrations https://github.com/marketplace
Customer support https://help.github.com/
Training https://learn.github.com/skills
GitHub Status https://www.githubstatus.com/
About https://github.com/about
Partners https://github.com/partners
Changelog https://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. https://githubuniverse.com/
Pricing https://github.com/pricing
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F415
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reload https://github.com/plotly/plotly.js/pull/415
Reload https://github.com/plotly/plotly.js/pull/415
Reload https://github.com/plotly/plotly.js/pull/415
plotly https://github.com/plotly
plotly.js https://github.com/plotly/plotly.js
Code https://github.com/plotly/plotly.js
Issues726 (726) https://github.com/plotly/plotly.js/issues
Pull requests84 (84) https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
mdtusz https://github.com/mdtusz
master https://github.com/plotly/plotly.js/tree/master
svg-removal https://github.com/plotly/plotly.js/tree/svg-removal
Conversation https://github.com/plotly/plotly.js/pull/415
Commits7 (7) https://github.com/plotly/plotly.js/pull/415/commits
Checks https://github.com/plotly/plotly.js/pull/415/checks
Files changed https://github.com/plotly/plotly.js/pull/415/files
Nested removal https://github.com/plotly/plotly.js/pull/415#top
mdtusz https://github.com/mdtusz
master https://github.com/plotly/plotly.js/tree/master
svg-removal https://github.com/plotly/plotly.js/tree/svg-removal
https://github.com/mdtusz
mdtusz https://github.com/mdtusz
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#issue-147481985
@jackparmer https://github.com/jackparmer
@etpinard https://github.com/etpinard
https://reviewable.io/reviews/plotly/plotly.js/415
Please reload this page https://github.com/plotly/plotly.js/pull/415
mdtusz https://github.com/mdtusz
April 8, 2016 16:39 https://github.com/plotly/plotly.js/pull/415#commits-pushed-f213006
https://github.com/mdtusz
Switch subplot svg -> g https://github.com/plotly/plotly.js/pull/415/commits/f21300635a4c0542487fd6bde7c8c9781647724f
f213006 https://github.com/plotly/plotly.js/pull/415/commits/f21300635a4c0542487fd6bde7c8c9781647724f
https://github.com/mdtusz
Switch annotation svg -> g https://github.com/plotly/plotly.js/pull/415/commits/ab0b6bfff56e64c25eaa01d997a9c8786f15856a
ab0b6bf https://github.com/plotly/plotly.js/pull/415/commits/ab0b6bfff56e64c25eaa01d997a9c8786f15856a
https://github.com/mdtusz
Add test for nested svg tags https://github.com/plotly/plotly.js/pull/415/commits/d0d55771d6ad7d826f53641b1386c7ae073dc09b
d0d5577 https://github.com/plotly/plotly.js/pull/415/commits/d0d55771d6ad7d826f53641b1386c7ae073dc09b
https://github.com/mdtusz
Move layoutStyles call in Plotly.plot https://github.com/plotly/plotly.js/pull/415/commits/4d48fb1238fb7f50046849762eef85091739ee3f
4d48fb1 https://github.com/plotly/plotly.js/pull/415/commits/4d48fb1238fb7f50046849762eef85091739ee3f
Update image baselines for nested svg removal https://github.com/plotly/plotly.js/pull/415/commits/75897f337763a3a3b464d2a3ae3056c07e2a8aa0
75897f3 https://github.com/plotly/plotly.js/pull/415/commits/75897f337763a3a3b464d2a3ae3056c07e2a8aa0
https://github.com/mdtusz
mdtusz https://github.com/mdtusz
type: maintenance
https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22type%3A%20maintenance%22
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#event-622746647
https://github.com/etpinard
etpinard https://github.com/etpinard
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#issuecomment-208456021
@mdtusz https://github.com/mdtusz
tosvg.js https://github.com/plotly/plotly.js/blob/f692714952568346b6a92e0ff59dc8458cdfe5ac/src/snapshot/tosvg.js#L66-L86
Please reload this page https://github.com/plotly/plotly.js/pull/415
https://github.com/etpinard
etpinard https://github.com/etpinard
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#issuecomment-208456228
@timelyportfolio https://github.com/timelyportfolio
#322 https://github.com/plotly/plotly.js/issues/322
Please reload this page https://github.com/plotly/plotly.js/pull/415
etpinard https://github.com/etpinard
Apr 11, 2016
https://github.com/plotly/plotly.js/pull/415#discussion-diff-59243663
View reviewed changes
https://github.com/plotly/plotly.js/pull/415/files/75897f337763a3a3b464d2a3ae3056c07e2a8aa0#diff-e5f0f014dc7242edbb0589169bea157ca06470c4fdfcf0188be18677306b7cc4
src/components/annotations/index.js https://github.com/plotly/plotly.js/pull/415/files#diff-e5f0f014dc7242edbb0589169bea157ca06470c4fdfcf0188be18677306b7cc4
etpinard https://github.com/etpinard
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#discussion_r59243663
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/plotly/plotly.js/pull/415
mdtusz https://github.com/mdtusz
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#discussion_r59246381
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/plotly/plotly.js/pull/415
mdtusz https://github.com/mdtusz
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#discussion_r59246580
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/plotly/plotly.js/pull/415
etpinard https://github.com/etpinard
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#discussion_r59247910
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/plotly/plotly.js/pull/415
https://github.com/etpinard
etpinard https://github.com/etpinard
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#issuecomment-208461644
@alexcjohnson https://github.com/alexcjohnson
Please reload this page https://github.com/plotly/plotly.js/pull/415
etpinard https://github.com/etpinard
Apr 11, 2016
https://github.com/plotly/plotly.js/pull/415#discussion-diff-59248214
View reviewed changes
https://github.com/plotly/plotly.js/pull/415/files/75897f337763a3a3b464d2a3ae3056c07e2a8aa0#diff-c0e0068a64a327363b9a8eda6b113e993ef5d9a49b9617b80d3c113f2ea5284a
test/jasmine/tests/snapshot_test.js https://github.com/plotly/plotly.js/pull/415/files#diff-c0e0068a64a327363b9a8eda6b113e993ef5d9a49b9617b80d3c113f2ea5284a
etpinard https://github.com/etpinard
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#discussion_r59248214
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/plotly/plotly.js/pull/415
mdtusz https://github.com/mdtusz
April 11, 2016 14:39 https://github.com/plotly/plotly.js/pull/415#commits-pushed-787c903
https://github.com/mdtusz
Make nested-svg test more strict https://github.com/plotly/plotly.js/pull/415/commits/787c903843e8dd4a0fc4e35ddc5c705be3d65a85
787c903 https://github.com/plotly/plotly.js/pull/415/commits/787c903843e8dd4a0fc4e35ddc5c705be3d65a85
https://github.com/mdtusz
Remove unnecessary transform https://github.com/plotly/plotly.js/pull/415/commits/21f5cc96aa822176af9bd81ebe27e14cbf4614bf
21f5cc9 https://github.com/plotly/plotly.js/pull/415/commits/21f5cc96aa822176af9bd81ebe27e14cbf4614bf
etpinard https://github.com/etpinard
Apr 11, 2016
https://github.com/plotly/plotly.js/pull/415#discussion-diff-59260966
View reviewed changes
https://github.com/plotly/plotly.js/pull/415/files/75897f337763a3a3b464d2a3ae3056c07e2a8aa0..787c903843e8dd4a0fc4e35ddc5c705be3d65a85#diff-c0e0068a64a327363b9a8eda6b113e993ef5d9a49b9617b80d3c113f2ea5284a
test/jasmine/tests/snapshot_test.js https://github.com/plotly/plotly.js/pull/415/files#diff-c0e0068a64a327363b9a8eda6b113e993ef5d9a49b9617b80d3c113f2ea5284a
etpinard https://github.com/etpinard
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#discussion_r59260966
Learn more https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this page https://github.com/plotly/plotly.js/pull/415
https://github.com/timelyportfolio
timelyportfolio https://github.com/timelyportfolio
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#issuecomment-208511617
@etpinard https://github.com/etpinard
https://cloud.githubusercontent.com/assets/837910/14439382/87c44d7a-fff0-11e5-8276-541ea8559afd.png
https://cloud.githubusercontent.com/assets/837910/14439422/b18eec5a-fff0-11e5-8af7-b6aad997927d.png
@cpsievert https://github.com/cpsievert
Please reload this page https://github.com/plotly/plotly.js/pull/415
https://github.com/etpinard
etpinard https://github.com/etpinard
Apr 11, 2016 https://github.com/plotly/plotly.js/pull/415#issuecomment-208514828
@timelyportfolio https://github.com/timelyportfolio
Please reload this page https://github.com/plotly/plotly.js/pull/415
https://github.com/cpsievert
cpsievert https://github.com/cpsievert
Apr 12, 2016 https://github.com/plotly/plotly.js/pull/415#issuecomment-208643221
@timelyportfolio https://github.com/timelyportfolio
Please reload this page https://github.com/plotly/plotly.js/pull/415
https://github.com/etpinard
etpinard https://github.com/etpinard
Apr 12, 2016 https://github.com/plotly/plotly.js/pull/415#issuecomment-209029898
Please reload this page https://github.com/plotly/plotly.js/pull/415
https://github.com/mdtusz
mdtusz https://github.com/mdtusz
21f5cc9 https://github.com/plotly/plotly.js/commit/21f5cc96aa822176af9bd81ebe27e14cbf4614bf
Apr 13, 2016 https://github.com/plotly/plotly.js/pull/415#event-625837745
https://github.com/mdtusz
mdtusz https://github.com/mdtusz
April 13, 2016 14:13 https://github.com/plotly/plotly.js/pull/415#event-625837887
https://github.com/mdtusz
mdtusz https://github.com/mdtusz
April 13, 2016 15:16 https://github.com/plotly/plotly.js/pull/415#event-625946287
mdtusz https://github.com/mdtusz
Apr 13, 2016
https://github.com/plotly/plotly.js/pull/415#ref-commit-8138572
https://github.com/mdtusz
Merge pull request https://github.com/plotly/plotly.js/commit/8138572b741535b41af06deae3ae3b59f082bced
#415 https://github.com/plotly/plotly.js/pull/415
from plotly/svg-removal [Miklós Tusz] https://github.com/plotly/plotly.js/commit/8138572b741535b41af06deae3ae3b59f082bced
8138572 https://github.com/plotly/plotly.js/commit/8138572b741535b41af06deae3ae3b59f082bced
https://github.com/etpinard
etpinard https://github.com/etpinard
Apr 18, 2016
https://github.com/plotly/plotly.js/pull/415#ref-issue-139630304
Download PNG not working in RStudio
#322
https://github.com/plotly/plotly.js/issues/322
https://github.com/mdtusz
mdtusz https://github.com/mdtusz
Apr 18, 2016
https://github.com/plotly/plotly.js/pull/415#ref-pullrequest-149273442
Fixup SVG Removal Panning
#442
https://github.com/plotly/plotly.js/pull/442
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for free https://github.com/join?source=comment-repo
Sign in to comment https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F415
Please reload this page https://github.com/plotly/plotly.js/pull/415
Please reload this page https://github.com/plotly/plotly.js/pull/415
https://github.com/mdtusz
https://github.com/etpinard
https://github.com/timelyportfolio
https://github.com/cpsievert
https://github.com
Terms https://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacy https://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Security https://github.com/security
Status https://www.githubstatus.com/
Community https://github.community/
Docs https://docs.github.com/
Contact https://support.github.com?tags=dotcom-footer