| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6d8b117c-7262-0a3a-39b7-1d2d05858e26 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B606:B1B84:2C798B6:389A08A:6B01ED70 |
| html-safe-nonce | e45d5dd6ffcabf30bb039b6e677a30da99977a3cce10337cc772ce112eafce2f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjA2OkIxQjg0OjJDNzk4QjY6Mzg5QTA4QTo2QjAxRUQ3MCIsInZpc2l0b3JfaWQiOiIxMTIxMzE5ODc1NzcyNTQyMzIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 6b00f2450ef070fbde926c7c5cc8a150bed8465e70aed44ddcf4e47a15d28a1e |
| hovercard-subject-tag | pull_request:65344440 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/395/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a1d27e3822b0730f281289844f068bc598f180de66f2729b835fc23f06db313f/plotly/plotly.js/pull/395 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a1d27e3822b0730f281289844f068bc598f180de66f2729b835fc23f06db313f/plotly/plotly.js/pull/395 |
| og:image:alt | This PR fixes #359 by moving the select and zoombox elements from the subplot svg to the shapelayer.
@etpinard @mdtusz do you have suggestions for any tests I could add? |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | n-riesco |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/plotly/plotly.js/pull/395#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F395 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F395 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/395 |
| Reload | https://github.com/plotly/plotly.js/pull/395 |
| Reload | https://github.com/plotly/plotly.js/pull/395 |
| plotly | https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Code | https://github.com/plotly/plotly.js |
| Issues726 (726) | https://github.com/plotly/plotly.js/issues |
| Pull requests84 (84) | https://github.com/plotly/plotly.js/pulls |
| Actions | https://github.com/plotly/plotly.js/actions |
| Security and quality | https://github.com/plotly/plotly.js/security |
| Insights | https://github.com/plotly/plotly.js/insights |
| https://github.com/plotly/plotly.js |
| n-riesco | https://github.com/n-riesco |
| plotly:master | https://github.com/plotly/plotly.js/tree/master |
| n-riesco:issue-359-zoomlayer | https://github.com/n-riesco/plotly.js/tree/issue-359-zoomlayer |
| Conversation | https://github.com/plotly/plotly.js/pull/395 |
| Commits7 (7) | https://github.com/plotly/plotly.js/pull/395/commits |
| Checks | https://github.com/plotly/plotly.js/pull/395/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/395/files |
| Fix zoom overlay positioning (Fixes #359) | https://github.com/plotly/plotly.js/pull/395#top |
| n-riesco | https://github.com/n-riesco |
| plotly:master | https://github.com/plotly/plotly.js/tree/master |
| n-riesco:issue-359-zoomlayer | https://github.com/n-riesco/plotly.js/tree/issue-359-zoomlayer |
|
| https://github.com/n-riesco |
| n-riesco | https://github.com/n-riesco |
| Apr 5, 2016 | https://github.com/plotly/plotly.js/pull/395#issue-146058072 |
| #359 | https://github.com/plotly/plotly.js/issues/359 |
| @etpinard | https://github.com/etpinard |
| @mdtusz | https://github.com/mdtusz |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
| n-riesco | https://github.com/n-riesco |
| April 5, 2016 08:46 | https://github.com/plotly/plotly.js/pull/395#commits-pushed-df69584 |
|
| https://github.com/n-riesco |
| Split method shapes.draw into smaller functions | https://github.com/plotly/plotly.js/pull/395/commits/df69584e893307e8e3ad351c3627fa2637357835 |
| df69584 | https://github.com/plotly/plotly.js/pull/395/commits/df69584e893307e8e3ad351c3627fa2637357835 |
|
| https://github.com/n-riesco |
| Remove unnecessary step from shapes.drawAll() | https://github.com/plotly/plotly.js/pull/395/commits/e342a9e525ef00bec5e18e64ed832764a629b128 |
| e342a9e | https://github.com/plotly/plotly.js/pull/395/commits/e342a9e525ef00bec5e18e64ed832764a629b128 |
|
| https://github.com/n-riesco |
| Move select and zoombox elements into shapelayer | https://github.com/plotly/plotly.js/pull/395/commits/bfc8e0ab3eb9a0523b799c211fe711ce3adb309f |
| bfc8e0a | https://github.com/plotly/plotly.js/pull/395/commits/bfc8e0ab3eb9a0523b799c211fe711ce3adb309f |
| plotly#359 | https://github.com/plotly/plotly.js/issues/359 |
| https://github.com/mdtusz |
| mdtusz | https://github.com/mdtusz |
| Apr 5, 2016 | https://github.com/plotly/plotly.js/pull/395#event-615567755 |
| mdtusz | https://github.com/mdtusz |
|
Apr 5, 2016
| https://github.com/plotly/plotly.js/pull/395#discussion-diff-58585550 |
| View reviewed changes
| https://github.com/plotly/plotly.js/pull/395/files/bfc8e0ab3eb9a0523b799c211fe711ce3adb309f#diff-74c84233009f2acc55821a211d2e91009a129bab7b5fa19c0572e32856860d37 |
| src/components/shapes/index.js | https://github.com/plotly/plotly.js/pull/395/files#diff-74c84233009f2acc55821a211d2e91009a129bab7b5fa19c0572e32856860d37 |
| mdtusz | https://github.com/mdtusz |
| Apr 5, 2016 | https://github.com/plotly/plotly.js/pull/395#discussion_r58585550 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
| https://github.com/mdtusz |
| mdtusz | https://github.com/mdtusz |
| Apr 5, 2016 | https://github.com/plotly/plotly.js/pull/395#issuecomment-205926001 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
| n-riesco | https://github.com/n-riesco |
| April 5, 2016 19:36 | https://github.com/plotly/plotly.js/pull/395#commits-pushed-1d23673 |
|
| https://github.com/n-riesco |
| Shapes: Remove unnecessary call to String() | https://github.com/plotly/plotly.js/pull/395/commits/1d23673b4ea537d7343bb75d3c7d4938995a657b |
| 1d23673 | https://github.com/plotly/plotly.js/pull/395/commits/1d23673b4ea537d7343bb75d3c7d4938995a657b |
|
| https://github.com/n-riesco |
| graph_interact: Definitions before declarations | https://github.com/plotly/plotly.js/pull/395/commits/e3bfea7a200a38723d402dfbb23b1bfa0018d8b7 |
| e3bfea7 | https://github.com/plotly/plotly.js/pull/395/commits/e3bfea7a200a38723d402dfbb23b1bfa0018d8b7 |
| https://github.com/n-riesco |
| n-riesco | https://github.com/n-riesco |
| Apr 5, 2016 | https://github.com/plotly/plotly.js/pull/395#issuecomment-205947016 |
| @mdtusz | https://github.com/mdtusz |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
| n-riesco | https://github.com/n-riesco |
| April 5, 2016 20:58 | https://github.com/plotly/plotly.js/pull/395#commits-pushed-9b8d3c5 |
|
| https://github.com/n-riesco |
| Add more tests to select_test.js | https://github.com/plotly/plotly.js/pull/395/commits/9b8d3c501a3c4c6149200b8d8057237b05704c0a |
| 9b8d3c5 | https://github.com/plotly/plotly.js/pull/395/commits/9b8d3c501a3c4c6149200b8d8057237b05704c0a |
|
| https://github.com/n-riesco |
| Add zoom tests | https://github.com/plotly/plotly.js/pull/395/commits/4fbf087c7428a7ffc7a689d588530c63532af8ea |
| 4fbf087 | https://github.com/plotly/plotly.js/pull/395/commits/4fbf087c7428a7ffc7a689d588530c63532af8ea |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Apr 6, 2016 | https://github.com/plotly/plotly.js/pull/395#issuecomment-206438737 |
| @mdtusz | https://github.com/mdtusz |
| #359 | https://github.com/plotly/plotly.js/issues/359 |
| @n-riesco | https://github.com/n-riesco |
| @alexcjohnson | https://github.com/alexcjohnson |
| df69584 | https://github.com/plotly/plotly.js/commit/df69584e893307e8e3ad351c3627fa2637357835 |
| e342a9e | https://github.com/plotly/plotly.js/commit/e342a9e525ef00bec5e18e64ed832764a629b128 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
| https://github.com/n-riesco |
| n-riesco | https://github.com/n-riesco |
| Apr 6, 2016 | https://github.com/plotly/plotly.js/pull/395#issuecomment-206444902 |
| @etpinard | https://github.com/etpinard |
| #378 | https://github.com/plotly/plotly.js/pull/378 |
| e342a9e | https://github.com/plotly/plotly.js/commit/e342a9e525ef00bec5e18e64ed832764a629b128 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 6, 2016 | https://github.com/plotly/plotly.js/pull/395#issuecomment-206453109 |
| @n-riesco | https://github.com/n-riesco |
| infolayer | https://github.com/plotly/plotly.js/blob/master/src/plot_api/plot_api.js#L2634 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
| https://github.com/n-riesco |
| n-riesco | https://github.com/n-riesco |
| Apr 6, 2016 | https://github.com/plotly/plotly.js/pull/395#issuecomment-206459011 |
| @alexcjohnson | https://github.com/alexcjohnson |
| @mdtusz | https://github.com/mdtusz |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Apr 18, 2016 | https://github.com/plotly/plotly.js/pull/395#issuecomment-211563961 |
| @n-riesco | https://github.com/n-riesco |
| #439 | https://github.com/plotly/plotly.js/pull/439 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
| https://github.com/n-riesco |
| n-riesco | https://github.com/n-riesco |
| Apr 18, 2016 | https://github.com/plotly/plotly.js/pull/395#issuecomment-211571889 |
| @etpinard | https://github.com/etpinard |
| #439 | https://github.com/plotly/plotly.js/pull/439 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
bug
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug |
|
status: on hold
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20on%20hold%22 |
| Apr 18, 2016 | https://github.com/plotly/plotly.js/pull/395#event-631988584 |
| https://github.com/n-riesco |
| n-riesco | https://github.com/n-riesco |
|
Apr 19, 2016
| https://github.com/plotly/plotly.js/pull/395#ref-pullrequest-149582590 |
|
Fix issue 359 (zoom overlay drawn beneath shapes)
#448
| https://github.com/plotly/plotly.js/pull/448 |
| https://github.com/n-riesco |
| n-riesco | https://github.com/n-riesco |
| Apr 19, 2016 | https://github.com/plotly/plotly.js/pull/395#issuecomment-212127011 |
| #448 | https://github.com/plotly/plotly.js/pull/448 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
| https://github.com/n-riesco |
| n-riesco | https://github.com/n-riesco |
| Apr 19, 2016 | https://github.com/plotly/plotly.js/pull/395#event-633595638 |
| https://github.com/n-riesco |
| n-riesco | https://github.com/n-riesco |
| April 26, 2016 18:28 | https://github.com/plotly/plotly.js/pull/395#event-641900148 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F395 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
|
bug
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug |
|
Zoom overlay drawn beneath shapes.
| https://github.com/plotly/plotly.js/issues/359 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/395 |
|
| https://github.com/n-riesco |
|
| https://github.com/mdtusz |
|
| https://github.com/etpinard |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |