René's URL Explorer Experiment


Title: Fix zoom overlay positioning (Fixes #359) by n-riesco · Pull Request #395 · plotly/plotly.js · GitHub

Open Graph Title: Fix zoom overlay positioning (Fixes #359) by n-riesco · Pull Request #395 · plotly/plotly.js

X Title: Fix zoom overlay positioning (Fixes #359) by n-riesco · Pull Request #395 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Fix zoom overlay positioning (Fixes #359) by n-riesco · Pull Request #395 · plotly/plotly.js

Open Graph Description: This PR fixes #359 by moving the select and zoombox elements from the subplot svg to the shapelayer. @etpinard @mdtusz do you have suggestions for any tests I could add?

X Description: This PR fixes #359 by moving the select and zoombox elements from the subplot svg to the shapelayer. @etpinard @mdtusz do you have suggestions for any tests I could add?

Opengraph URL: https://github.com/plotly/plotly.js/pull/395

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6d8b117c-7262-0a3a-39b7-1d2d05858e26
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB606:B1B84:2C798B6:389A08A:6B01ED70
html-safe-noncee45d5dd6ffcabf30bb039b6e677a30da99977a3cce10337cc772ce112eafce2f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjA2OkIxQjg0OjJDNzk4QjY6Mzg5QTA4QTo2QjAxRUQ3MCIsInZpc2l0b3JfaWQiOiIxMTIxMzE5ODc1NzcyNTQyMzIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6b00f2450ef070fbde926c7c5cc8a150bed8465e70aed44ddcf4e47a15d28a1e
hovercard-subject-tagpull_request:65344440
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/395/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a1d27e3822b0730f281289844f068bc598f180de66f2729b835fc23f06db313f/plotly/plotly.js/pull/395
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a1d27e3822b0730f281289844f068bc598f180de66f2729b835fc23f06db313f/plotly/plotly.js/pull/395
og:image:altThis PR fixes #359 by moving the select and zoombox elements from the subplot svg to the shapelayer. @etpinard @mdtusz do you have suggestions for any tests I could add?
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamen-riesco
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/395#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F395
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F395
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/395
Reloadhttps://github.com/plotly/plotly.js/pull/395
Reloadhttps://github.com/plotly/plotly.js/pull/395
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
n-riescohttps://github.com/n-riesco
plotly:masterhttps://github.com/plotly/plotly.js/tree/master
n-riesco:issue-359-zoomlayerhttps://github.com/n-riesco/plotly.js/tree/issue-359-zoomlayer
Conversationhttps://github.com/plotly/plotly.js/pull/395
Commits7 (7)https://github.com/plotly/plotly.js/pull/395/commits
Checkshttps://github.com/plotly/plotly.js/pull/395/checks
Files changedhttps://github.com/plotly/plotly.js/pull/395/files
Fix zoom overlay positioning (Fixes #359)https://github.com/plotly/plotly.js/pull/395#top
n-riescohttps://github.com/n-riesco
plotly:masterhttps://github.com/plotly/plotly.js/tree/master
n-riesco:issue-359-zoomlayerhttps://github.com/n-riesco/plotly.js/tree/issue-359-zoomlayer
https://github.com/n-riesco
n-riescohttps://github.com/n-riesco
Apr 5, 2016https://github.com/plotly/plotly.js/pull/395#issue-146058072
#359https://github.com/plotly/plotly.js/issues/359
@etpinardhttps://github.com/etpinard
@mdtuszhttps://github.com/mdtusz
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
n-riescohttps://github.com/n-riesco
April 5, 2016 08:46https://github.com/plotly/plotly.js/pull/395#commits-pushed-df69584
https://github.com/n-riesco
Split method shapes.draw into smaller functionshttps://github.com/plotly/plotly.js/pull/395/commits/df69584e893307e8e3ad351c3627fa2637357835
df69584https://github.com/plotly/plotly.js/pull/395/commits/df69584e893307e8e3ad351c3627fa2637357835
https://github.com/n-riesco
Remove unnecessary step from shapes.drawAll()https://github.com/plotly/plotly.js/pull/395/commits/e342a9e525ef00bec5e18e64ed832764a629b128
e342a9ehttps://github.com/plotly/plotly.js/pull/395/commits/e342a9e525ef00bec5e18e64ed832764a629b128
https://github.com/n-riesco
Move select and zoombox elements into shapelayerhttps://github.com/plotly/plotly.js/pull/395/commits/bfc8e0ab3eb9a0523b799c211fe711ce3adb309f
bfc8e0ahttps://github.com/plotly/plotly.js/pull/395/commits/bfc8e0ab3eb9a0523b799c211fe711ce3adb309f
plotly#359https://github.com/plotly/plotly.js/issues/359
https://github.com/mdtusz
mdtuszhttps://github.com/mdtusz
Apr 5, 2016https://github.com/plotly/plotly.js/pull/395#event-615567755
mdtuszhttps://github.com/mdtusz
Apr 5, 2016 https://github.com/plotly/plotly.js/pull/395#discussion-diff-58585550
View reviewed changes https://github.com/plotly/plotly.js/pull/395/files/bfc8e0ab3eb9a0523b799c211fe711ce3adb309f#diff-74c84233009f2acc55821a211d2e91009a129bab7b5fa19c0572e32856860d37
src/components/shapes/index.jshttps://github.com/plotly/plotly.js/pull/395/files#diff-74c84233009f2acc55821a211d2e91009a129bab7b5fa19c0572e32856860d37
mdtuszhttps://github.com/mdtusz
Apr 5, 2016https://github.com/plotly/plotly.js/pull/395#discussion_r58585550
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
https://github.com/mdtusz
mdtuszhttps://github.com/mdtusz
Apr 5, 2016https://github.com/plotly/plotly.js/pull/395#issuecomment-205926001
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
n-riescohttps://github.com/n-riesco
April 5, 2016 19:36https://github.com/plotly/plotly.js/pull/395#commits-pushed-1d23673
https://github.com/n-riesco
Shapes: Remove unnecessary call to String()https://github.com/plotly/plotly.js/pull/395/commits/1d23673b4ea537d7343bb75d3c7d4938995a657b
1d23673https://github.com/plotly/plotly.js/pull/395/commits/1d23673b4ea537d7343bb75d3c7d4938995a657b
https://github.com/n-riesco
graph_interact: Definitions before declarationshttps://github.com/plotly/plotly.js/pull/395/commits/e3bfea7a200a38723d402dfbb23b1bfa0018d8b7
e3bfea7https://github.com/plotly/plotly.js/pull/395/commits/e3bfea7a200a38723d402dfbb23b1bfa0018d8b7
https://github.com/n-riesco
n-riescohttps://github.com/n-riesco
Apr 5, 2016https://github.com/plotly/plotly.js/pull/395#issuecomment-205947016
@mdtuszhttps://github.com/mdtusz
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
n-riescohttps://github.com/n-riesco
April 5, 2016 20:58https://github.com/plotly/plotly.js/pull/395#commits-pushed-9b8d3c5
https://github.com/n-riesco
Add more tests to select_test.jshttps://github.com/plotly/plotly.js/pull/395/commits/9b8d3c501a3c4c6149200b8d8057237b05704c0a
9b8d3c5https://github.com/plotly/plotly.js/pull/395/commits/9b8d3c501a3c4c6149200b8d8057237b05704c0a
https://github.com/n-riesco
Add zoom testshttps://github.com/plotly/plotly.js/pull/395/commits/4fbf087c7428a7ffc7a689d588530c63532af8ea
4fbf087https://github.com/plotly/plotly.js/pull/395/commits/4fbf087c7428a7ffc7a689d588530c63532af8ea
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 6, 2016https://github.com/plotly/plotly.js/pull/395#issuecomment-206438737
@mdtuszhttps://github.com/mdtusz
#359https://github.com/plotly/plotly.js/issues/359
@n-riescohttps://github.com/n-riesco
@alexcjohnsonhttps://github.com/alexcjohnson
df69584https://github.com/plotly/plotly.js/commit/df69584e893307e8e3ad351c3627fa2637357835
e342a9ehttps://github.com/plotly/plotly.js/commit/e342a9e525ef00bec5e18e64ed832764a629b128
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
https://github.com/n-riesco
n-riescohttps://github.com/n-riesco
Apr 6, 2016https://github.com/plotly/plotly.js/pull/395#issuecomment-206444902
@etpinardhttps://github.com/etpinard
#378https://github.com/plotly/plotly.js/pull/378
e342a9ehttps://github.com/plotly/plotly.js/commit/e342a9e525ef00bec5e18e64ed832764a629b128
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Apr 6, 2016https://github.com/plotly/plotly.js/pull/395#issuecomment-206453109
@n-riescohttps://github.com/n-riesco
infolayerhttps://github.com/plotly/plotly.js/blob/master/src/plot_api/plot_api.js#L2634
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
https://github.com/n-riesco
n-riescohttps://github.com/n-riesco
Apr 6, 2016https://github.com/plotly/plotly.js/pull/395#issuecomment-206459011
@alexcjohnsonhttps://github.com/alexcjohnson
@mdtuszhttps://github.com/mdtusz
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 18, 2016https://github.com/plotly/plotly.js/pull/395#issuecomment-211563961
@n-riescohttps://github.com/n-riesco
#439https://github.com/plotly/plotly.js/pull/439
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
https://github.com/n-riesco
n-riescohttps://github.com/n-riesco
Apr 18, 2016https://github.com/plotly/plotly.js/pull/395#issuecomment-211571889
@etpinardhttps://github.com/etpinard
#439https://github.com/plotly/plotly.js/pull/439
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
https://github.com/etpinard
etpinardhttps://github.com/etpinard
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
status: on hold https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20on%20hold%22
Apr 18, 2016https://github.com/plotly/plotly.js/pull/395#event-631988584
https://github.com/n-riesco
n-riescohttps://github.com/n-riesco
Apr 19, 2016 https://github.com/plotly/plotly.js/pull/395#ref-pullrequest-149582590
Fix issue 359 (zoom overlay drawn beneath shapes) #448 https://github.com/plotly/plotly.js/pull/448
https://github.com/n-riesco
n-riescohttps://github.com/n-riesco
Apr 19, 2016https://github.com/plotly/plotly.js/pull/395#issuecomment-212127011
#448https://github.com/plotly/plotly.js/pull/448
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
https://github.com/n-riesco
n-riescohttps://github.com/n-riesco
Apr 19, 2016https://github.com/plotly/plotly.js/pull/395#event-633595638
https://github.com/n-riesco
n-riescohttps://github.com/n-riesco
April 26, 2016 18:28https://github.com/plotly/plotly.js/pull/395#event-641900148
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F395
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
Zoom overlay drawn beneath shapes. https://github.com/plotly/plotly.js/issues/359
Please reload this pagehttps://github.com/plotly/plotly.js/pull/395
https://github.com/n-riesco
https://github.com/mdtusz
https://github.com/etpinard
https://github.com/alexcjohnson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.