René's URL Explorer Experiment


Title: Funnel traces by archmoj · Pull Request #3817 · plotly/plotly.js · GitHub

Open Graph Title: Funnel traces by archmoj · Pull Request #3817 · plotly/plotly.js

X Title: Funnel traces by archmoj · Pull Request #3817 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Funnel traces by archmoj · Pull Request #3817 · plotly/plotly.js

Open Graph Description: This PR added 'bar-like' funnel traces on Cartesian coordinates towards addressing #3504. Also added new bar and waterfall attribute insidetextanchor ⚓ new bar and waterfall attribute text...

X Description: This PR added 'bar-like' funnel traces on Cartesian coordinates towards addressing #3504. Also added new bar and waterfall attribute insidetextanchor ⚓ new bar and waterfall attrib...

Opengraph URL: https://github.com/plotly/plotly.js/pull/3817

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:113e925b-772f-d803-e477-5eab0caef965
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD084:5D487:927AA0:C2FF66:6B01B80A
html-safe-nonce775d6d0ed301f3234d4afdc80f312a2e61196d964d77a75bffae3f60951ee69b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMDg0OjVENDg3OjkyN0FBMDpDMkZGNjY6NkIwMUI4MEEiLCJ2aXNpdG9yX2lkIjoiNDc3NTM1ODg4NzM0MTcwMTEzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac34c7528e1cf082d46716efc2e523cf64ce3a9e9c280c78cddda2cfdedd7644c1
hovercard-subject-tagpull_request:274488311
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/3817/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4f2f0c44401a136fec63633d7d3d46a66db8b13b2fb0a17da3e7d55ce16f61b3/plotly/plotly.js/pull/3817
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4f2f0c44401a136fec63633d7d3d46a66db8b13b2fb0a17da3e7d55ce16f61b3/plotly/plotly.js/pull/3817
og:image:altThis PR added 'bar-like' funnel traces on Cartesian coordinates towards addressing #3504. Also added new bar and waterfall attribute insidetextanchor ⚓ new bar and waterfall attribute text...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamearchmoj
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/3817#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3817
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3817
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/3817
Reloadhttps://github.com/plotly/plotly.js/pull/3817
Reloadhttps://github.com/plotly/plotly.js/pull/3817
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
archmojhttps://github.com/archmoj
fix3777-textinfo-waterfall-finhttps://github.com/plotly/plotly.js/tree/fix3777-textinfo-waterfall-fin
funnel-traceshttps://github.com/plotly/plotly.js/tree/funnel-traces
Conversationhttps://github.com/plotly/plotly.js/pull/3817
Commits51 (51)https://github.com/plotly/plotly.js/pull/3817/commits
Checkshttps://github.com/plotly/plotly.js/pull/3817/checks
Files changedhttps://github.com/plotly/plotly.js/pull/3817/files
Funnel traceshttps://github.com/plotly/plotly.js/pull/3817#top
archmojhttps://github.com/archmoj
fix3777-textinfo-waterfall-finhttps://github.com/plotly/plotly.js/tree/fix3777-textinfo-waterfall-fin
funnel-traceshttps://github.com/plotly/plotly.js/tree/funnel-traces
https://github.com/archmoj
archmojhttps://github.com/archmoj
Apr 29, 2019https://github.com/plotly/plotly.js/pull/3817#issue-438462659
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
#3504https://github.com/plotly/plotly.js/issues/3504
Implementation of textinfo for waterfall traces #3790https://github.com/plotly/plotly.js/pull/3790
Basic codepenhttps://codepen.io/MojtabaSamimi/pen/BEEYvd?editors=0010
React codepenhttps://codepen.io/MojtabaSamimi/pen/arOYEy?editors=0010
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
archmojhttps://github.com/archmoj
April 29, 2019 13:14https://github.com/plotly/plotly.js/pull/3817#commits-pushed-3832e01
https://github.com/archmoj
add funnel - changes to libhttps://github.com/plotly/plotly.js/pull/3817/commits/3832e017bea5c7cc241a718655e4702b427f2fa1
3832e01https://github.com/plotly/plotly.js/pull/3817/commits/3832e017bea5c7cc241a718655e4702b427f2fa1
https://github.com/archmoj
add funnel - changes to src plot plot_api and legend stylehttps://github.com/plotly/plotly.js/pull/3817/commits/dd5ff488330d0f45b7ac8455e80875e917a3d594
dd5ff48https://github.com/plotly/plotly.js/pull/3817/commits/dd5ff488330d0f45b7ac8455e80875e917a3d594
https://github.com/archmoj
add funnel - chanegs to barhttps://github.com/plotly/plotly.js/pull/3817/commits/8846193abbfa9461526d756813500af1b0c15797
8846193https://github.com/plotly/plotly.js/pull/3817/commits/8846193abbfa9461526d756813500af1b0c15797
https://github.com/archmoj
add funnel - new trace fileshttps://github.com/plotly/plotly.js/pull/3817/commits/cad13aa2b6a5bd2dc6eeb2fd74512f62948c4ff1
cad13aahttps://github.com/plotly/plotly.js/pull/3817/commits/cad13aa2b6a5bd2dc6eeb2fd74512f62948c4ff1
https://github.com/archmoj
add funnel test - mocks and baselineshttps://github.com/plotly/plotly.js/pull/3817/commits/87b1c4403d472ab7fe624b1e0c75a24f8f9aecf8
87b1c44https://github.com/plotly/plotly.js/pull/3817/commits/87b1c4403d472ab7fe624b1e0c75a24f8f9aecf8
https://github.com/archmoj
add funnel jasmine testhttps://github.com/plotly/plotly.js/pull/3817/commits/424d6f51561b6102ae5c4ddb17063280f398b944
424d6f5https://github.com/plotly/plotly.js/pull/3817/commits/424d6f51561b6102ae5c4ddb17063280f398b944
https://github.com/archmoj
revisions after etpinard commentshttps://github.com/plotly/plotly.js/pull/3817/commits/aec946e8570c042d632352fc58eaf99276797bd5
aec946ehttps://github.com/plotly/plotly.js/pull/3817/commits/aec946e8570c042d632352fc58eaf99276797bd5
https://github.com/archmoj
archmojhttps://github.com/archmoj
feature https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
Apr 29, 2019https://github.com/plotly/plotly.js/pull/3817#event-2307629501
https://github.com/etpinard
etpinardhttps://github.com/etpinard
v1.48.0https://github.com/plotly/plotly.js/milestone/44
Apr 29, 2019https://github.com/plotly/plotly.js/pull/3817#event-2307635373
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231879137
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/components/drawing/index.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-e8c93e83ebf0c3a486f3187d44d91b1709f51bccaba559fcadab2a3e3f9f56c6
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231883241
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/traces/bar/attributes.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-e0368430352e33aca0bc8c6b9bf9ef5e8f98227e86138b388259b6429ea810be
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231885271
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/traces/funnel/attributes.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-d5f4bff59ff05d9c8c552b463c9ed8f26516caa4e0e38390c2f4c9133917d837
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231885967
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/traces/funnel/calc.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-e74104b9c5aed1c89e5cbc04c7f5d45ddb20be317bd48bb0aa56f4e1771ae871
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231888221
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/traces/funnel/cross_trace_calc.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-4aeb9fb71eb2469c9da81229baf3c520f7ff715599d09e887963a31af0a9ae21
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231890730
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/traces/funnel/defaults.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-3823e1cdb7c2129c3d91da04efa07a43a48a829c235de2d84fc873c90e71e608
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231893766
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/traces/funnel/attributes.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-d5f4bff59ff05d9c8c552b463c9ed8f26516caa4e0e38390c2f4c9133917d837
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231896999
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
test/image/mocks/blank-bar-outsidetext_horizontal.jsonhttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-880015b4c7fed8fb91b47819a37c40d5fa9cab01ee5ad3adb38945f208afd818
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231899691
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/traces/funnel/defaults.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-3823e1cdb7c2129c3d91da04efa07a43a48a829c235de2d84fc873c90e71e608
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231900525
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/traces/funnel/plot.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-b8f221187051576dfd53ba9ea078f44e403242a66267175ca563f75aa19a42fe
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231902613
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/traces/funnel/style.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-7b87a1001f5b5a700022afb94ceb5e82caa2def6ce156465260fc62a9d29c12e
etpinardhttps://github.com/etpinard
Apr 29, 2019https://github.com/plotly/plotly.js/pull/3817#discussion_r279539500
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
plotly.js/src/traces/bar/attributes.jshttps://github.com/plotly/plotly.js/blob/adf9bee14a8badcb5b2f49065fd594623421c82e/src/traces/bar/attributes.js#L199-L216
adf9beehttps://github.com/plotly/plotly.js/commit/adf9bee14a8badcb5b2f49065fd594623421c82e
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231903098
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
test/image/mocks/funnel_11.jsonhttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-15d8b4d609b881b3b62de6e45499b48ad0a8fc4539285c81f21a4bbfa4397460
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231904524
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
test/image/mocks/funnel_and_bar.jsonhttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-2a6aaba620dd3b78873eb19e74c125f75badd4732544201b7114ca9bca60e2e8
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231910430
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/plots/cartesian/layout_defaults.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-91cf4d62b1e2b6b1ba56098e7cfdc6a3ec8cf275c6fd2b6f4b9a6f5bfca058d8
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231911132
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/traces/bar/plot.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-e5a908bc8cc6eacabde0c549eb2b81bf2d4c256eb19b160e572e65c581fbd80b
etpinardhttps://github.com/etpinard
Apr 29, 2019https://github.com/plotly/plotly.js/pull/3817#discussion_r279546181
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
archmojhttps://github.com/archmoj
Apr 30, 2019https://github.com/plotly/plotly.js/pull/3817#discussion_r279599970
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
8d02bcfhttps://github.com/plotly/plotly.js/commit/8d02bcff0f997dd901a89d9b08af1199ef705cbb
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
etpinardhttps://github.com/etpinard
Apr 30, 2019https://github.com/plotly/plotly.js/pull/3817#discussion_r279782341
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231912044
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
src/traces/bar/plot.jshttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-e5a908bc8cc6eacabde0c549eb2b81bf2d4c256eb19b160e572e65c581fbd80b
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231916533
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
test/image/mocks/funnel_axis.jsonhttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-82b919491f3da5f4a06190d13a0b7fc824f24ed3c0ce4a2bd854fa6e11c2a413
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231917217
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
test/image/mocks/funnel_axis.jsonhttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-82b919491f3da5f4a06190d13a0b7fc824f24ed3c0ce4a2bd854fa6e11c2a413
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 29, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-231918883
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5
test/image/mocks/funnel_axis_with_other_traces.jsonhttps://github.com/plotly/plotly.js/pull/3817/files/aec946e8570c042d632352fc58eaf99276797bd5#diff-f18fa79ade95ed32d819d485e82d0ff99c9774e1d933c43fbb9210e202568292
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/archmoj
split handleTickLabelDefaults and split the process into two passes t…https://github.com/plotly/plotly.js/pull/3817/commits/e968da68abbc70c67a0b08f646d266a2e1754dd2
e968da6https://github.com/plotly/plotly.js/pull/3817/commits/e968da68abbc70c67a0b08f646d266a2e1754dd2
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 3, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-233473089
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/c29b58d25b1d61749ddeded441420979f8ad8d13
src/traces/funnel/defaults.jshttps://github.com/plotly/plotly.js/pull/3817/files/0c169b5ca180b6b84121f1963620ee081edc2929..c29b58d25b1d61749ddeded441420979f8ad8d13#diff-3823e1cdb7c2129c3d91da04efa07a43a48a829c235de2d84fc873c90e71e608
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 3, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-233479610
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/e968da68abbc70c67a0b08f646d266a2e1754dd2
src/traces/funnel/attributes.jshttps://github.com/plotly/plotly.js/pull/3817/files/e968da68abbc70c67a0b08f646d266a2e1754dd2#diff-d5f4bff59ff05d9c8c552b463c9ed8f26516caa4e0e38390c2f4c9133917d837
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 3, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-233480915
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/e968da68abbc70c67a0b08f646d266a2e1754dd2
src/traces/funnel/defaults.jshttps://github.com/plotly/plotly.js/pull/3817/files/e968da68abbc70c67a0b08f646d266a2e1754dd2#diff-3823e1cdb7c2129c3d91da04efa07a43a48a829c235de2d84fc873c90e71e608
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
archmojhttps://github.com/archmoj
May 3, 2019 22:07https://github.com/plotly/plotly.js/pull/3817#commits-pushed-380db2e
https://github.com/archmoj
implement textangle for bars funnels and waterfalls - add testshttps://github.com/plotly/plotly.js/pull/3817/commits/380db2ecaa750ae317c06e2aaf1d31aac3139bdf
380db2ehttps://github.com/plotly/plotly.js/pull/3817/commits/380db2ecaa750ae317c06e2aaf1d31aac3139bdf
https://github.com/archmoj
fix alignmentgroup attributes of funnel and waterfallhttps://github.com/plotly/plotly.js/pull/3817/commits/61b6068cda0761ed877846a00cb110da4b0f98f3
61b6068https://github.com/plotly/plotly.js/pull/3817/commits/61b6068cda0761ed877846a00cb110da4b0f98f3
https://github.com/archmoj
refactor bar inside text if statementhttps://github.com/plotly/plotly.js/pull/3817/commits/0236783b6cf407a493a4cd02074d6dbcd8e64915
0236783https://github.com/plotly/plotly.js/pull/3817/commits/0236783b6cf407a493a4cd02074d6dbcd8e64915
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 6, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-234010906
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/380db2ecaa750ae317c06e2aaf1d31aac3139bdf
test/image/mocks/funnel_axis.jsonhttps://github.com/plotly/plotly.js/pull/3817/files/e968da68abbc70c67a0b08f646d266a2e1754dd2..380db2ecaa750ae317c06e2aaf1d31aac3139bdf#diff-82b919491f3da5f4a06190d13a0b7fc824f24ed3c0ce4a2bd854fa6e11c2a413
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
archmojhttps://github.com/archmoj
May 6, 2019 10:44https://github.com/plotly/plotly.js/pull/3817#commits-pushed-4d403fd
https://github.com/archmoj
revert cartesian layout_default filehttps://github.com/plotly/plotly.js/pull/3817/commits/4d403fde9c42e0be2481fd52cca7421a3917d3d1
4d403fdhttps://github.com/plotly/plotly.js/pull/3817/commits/4d403fde9c42e0be2481fd52cca7421a3917d3d1
https://github.com/archmoj
minimal change to add logic to hide funnelshttps://github.com/plotly/plotly.js/pull/3817/commits/a650170bfcee35743e0b3eb5aa42e2e12b8518d6
a650170https://github.com/plotly/plotly.js/pull/3817/commits/a650170bfcee35743e0b3eb5aa42e2e12b8518d6
https://github.com/archmoj
drop texangle and position defaults from funnel mockshttps://github.com/plotly/plotly.js/pull/3817/commits/a7446899f8c48924509c843a42c9554412a4aa9c
a744689https://github.com/plotly/plotly.js/pull/3817/commits/a7446899f8c48924509c843a42c9554412a4aa9c
https://github.com/archmoj
fixup textangle algo - added test for outside texthttps://github.com/plotly/plotly.js/pull/3817/commits/30b172a613626b491b8b814b4a392d45f8b4c681
30b172ahttps://github.com/plotly/plotly.js/pull/3817/commits/30b172a613626b491b8b814b4a392d45f8b4c681
https://github.com/archmoj
fix outside long text position with textangle - add testhttps://github.com/plotly/plotly.js/pull/3817/commits/446baccaed5712736a21fea85f33078347db0ef5
446bacchttps://github.com/plotly/plotly.js/pull/3817/commits/446baccaed5712736a21fea85f33078347db0ef5
https://github.com/archmoj
default funnels to horizontalhttps://github.com/plotly/plotly.js/pull/3817/commits/b93e3a5a83b6561ac6258a59f274b5fc87630c3e
b93e3a5https://github.com/plotly/plotly.js/pull/3817/commits/b93e3a5a83b6561ac6258a59f274b5fc87630c3e
https://github.com/archmoj
handle multicategory labels in funnel and waterfall textinfohttps://github.com/plotly/plotly.js/pull/3817/commits/02a176a8cee2cdb872fa30529f3cb53cde689fd2
02a176ahttps://github.com/plotly/plotly.js/pull/3817/commits/02a176a8cee2cdb872fa30529f3cb53cde689fd2
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 7, 2019https://github.com/plotly/plotly.js/pull/3817#issuecomment-490085713
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
@archmojhttps://github.com/archmoj
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
archmojhttps://github.com/archmoj
May 7, 2019 12:25https://github.com/plotly/plotly.js/pull/3817#commits-pushed-d0e8fe5
https://github.com/archmoj
add logic to reverse y axis by default if only funnelshttps://github.com/plotly/plotly.js/pull/3817/commits/d0e8fe569eaea6b7be4926e7e2c0741242362727
d0e8fe5https://github.com/plotly/plotly.js/pull/3817/commits/d0e8fe569eaea6b7be4926e7e2c0741242362727
https://github.com/archmoj
remove yaxis autorange reversed from funnel mockshttps://github.com/plotly/plotly.js/pull/3817/commits/0eb3917637704ebbff3e4c8e2ffc5521be305fee
0eb3917https://github.com/plotly/plotly.js/pull/3817/commits/0eb3917637704ebbff3e4c8e2ffc5521be305fee
https://github.com/archmoj
improve funnel orientation description and do base waterfall and funn…https://github.com/plotly/plotly.js/pull/3817/commits/fd1f6ca218c70dee563c3ab424067548ccedaf29
fd1f6cahttps://github.com/plotly/plotly.js/pull/3817/commits/fd1f6ca218c70dee563c3ab424067548ccedaf29
https://github.com/archmoj
revisit transform inside bar to reduce diff after textangle - revert …https://github.com/plotly/plotly.js/pull/3817/commits/6d50386f775a993990eb772495b034e03a36ebc0
6d50386https://github.com/plotly/plotly.js/pull/3817/commits/6d50386f775a993990eb772495b034e03a36ebc0
https://github.com/archmoj
archmojhttps://github.com/archmoj
May 7, 2019https://github.com/plotly/plotly.js/pull/3817#issuecomment-490208273
@archmojhttps://github.com/archmoj
@etpinardhttps://github.com/etpinard
6d50386https://github.com/plotly/plotly.js/commit/6d50386f775a993990eb772495b034e03a36ebc0
d0e8fe5https://github.com/plotly/plotly.js/commit/d0e8fe569eaea6b7be4926e7e2c0741242362727
fd1f6cahttps://github.com/plotly/plotly.js/commit/fd1f6ca218c70dee563c3ab424067548ccedaf29
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/archmoj
archmojhttps://github.com/archmoj
May 7, 2019https://github.com/plotly/plotly.js/pull/3817#issuecomment-490210429
@nicolaskruchtenhttps://github.com/nicolaskruchten
@alexcjohnsonhttps://github.com/alexcjohnson
@etpinardhttps://github.com/etpinard
plotly.js/src/traces/bar/plot.jshttps://github.com/plotly/plotly.js/blob/6d50386f775a993990eb772495b034e03a36ebc0/src/traces/bar/plot.js#L536-L580
6d50386https://github.com/plotly/plotly.js/commit/6d50386f775a993990eb772495b034e03a36ebc0
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 7, 2019 https://github.com/plotly/plotly.js/pull/3817#pullrequestreview-234702991
View reviewed changes https://github.com/plotly/plotly.js/pull/3817/files/d0e8fe569eaea6b7be4926e7e2c0741242362727
src/plots/cartesian/layout_defaults.jshttps://github.com/plotly/plotly.js/pull/3817/files/02a176a8cee2cdb872fa30529f3cb53cde689fd2..d0e8fe569eaea6b7be4926e7e2c0741242362727#diff-91cf4d62b1e2b6b1ba56098e7cfdc6a3ec8cf275c6fd2b6f4b9a6f5bfca058d8
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 7, 2019https://github.com/plotly/plotly.js/pull/3817#issuecomment-490217026
Implementation of textinfo for waterfall traces #3790https://github.com/plotly/plotly.js/pull/3790
@archmojhttps://github.com/archmoj
#3790https://github.com/plotly/plotly.js/pull/3790
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 7, 2019https://github.com/plotly/plotly.js/pull/3817#issuecomment-490218090
Rotated & shifted hover labels on bars #3838https://github.com/plotly/plotly.js/issues/3838
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 7, 2019https://github.com/plotly/plotly.js/pull/3817#issuecomment-490219491
@nicolaskruchtenhttps://github.com/nicolaskruchten
@alexcjohnsonhttps://github.com/alexcjohnson
@etpinardhttps://github.com/etpinard
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/archmoj
archmojhttps://github.com/archmoj
May 7, 2019https://github.com/plotly/plotly.js/pull/3817#issuecomment-490221175
@etpinardhttps://github.com/etpinard
#3790https://github.com/plotly/plotly.js/pull/3790
#3817 (comment)https://github.com/plotly/plotly.js/pull/3817#issuecomment-490210429
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/archmoj
archmojhttps://github.com/archmoj
79d6ef1https://github.com/plotly/plotly.js/commit/79d6ef1e9c165e486e4a4bda8e79d19e842cbc54
May 7, 2019https://github.com/plotly/plotly.js/pull/3817#event-2325269530
https://github.com/archmoj
archmojhttps://github.com/archmoj
May 7, 2019 19:23https://github.com/plotly/plotly.js/pull/3817#event-2325272120
https://github.com/archmoj
archmojhttps://github.com/archmoj
May 8, 2019 https://github.com/plotly/plotly.js/pull/3817#ref-pullrequest-432639176
Set enabled:false when filter target array is empty #3766 https://github.com/plotly/plotly.js/pull/3766
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3817
https://github.com/alexcjohnson
alexcjohnson https://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/3817/files/6a3a13c6f20348a5637eaa87a81d07eb28125145
https://github.com/nicolaskruchten
nicolaskruchten https://github.com/nicolaskruchten
https://github.com/plotly/plotly.js/pull/3817/files/4c741c7f477d53033ec320cbbb52c9c8c1d33f1d
https://github.com/etpinard
etpinard https://github.com/etpinard
https://github.com/plotly/plotly.js/pull/3817/files/6d50386f775a993990eb772495b034e03a36ebc0
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
feature https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature
v1.48.0 https://github.com/plotly/plotly.js/milestone/44
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3817
https://github.com/archmoj
https://github.com/nicolaskruchten
https://github.com/etpinard
https://github.com/alexcjohnson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.