| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:454ece1c-7a36-4895-5cb9-9e6ca92d273b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB3C:2A5566:58F7A3:747DE7:6B019D55 |
| html-safe-nonce | 8565c744de3815a1a61b9a785c91cc6b8ae6fe3bfb54fe4a8f77e0a6c1abc397 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjNDOjJBNTU2Njo1OEY3QTM6NzQ3REU3OjZCMDE5RDU1IiwidmlzaXRvcl9pZCI6IjczNzM4MDgwMDU4NDA2NDM0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6f22afab9b88c48f9cf584041b11cd2f017c8abf6408fdc06f72ad1e80ec9cc9 |
| hovercard-subject-tag | pull_request:260304941 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/3628/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2e5697392cc89484ccbc7ccf9cded6597ebde6e33ad57b1c58f97252ab4fc018/plotly/plotly.js/pull/3628 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2e5697392cc89484ccbc7ccf9cded6597ebde6e33ad57b1c58f97252ab4fc018/plotly/plotly.js/pull/3628 |
| og:image:alt | Fixes the handling of horizontal grouped legend items see #1913. Maintains the vertical grouping and includes gaps between traces (see below screenshot)
@antoinerg @etpinard
(edit: updated to show... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | nathanjenx |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/plotly/plotly.js/pull/3628#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3628 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3628 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/3628 |
| Reload | https://github.com/plotly/plotly.js/pull/3628 |
| Reload | https://github.com/plotly/plotly.js/pull/3628 |
| plotly | https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Code | https://github.com/plotly/plotly.js |
| Issues726 (726) | https://github.com/plotly/plotly.js/issues |
| Pull requests84 (84) | https://github.com/plotly/plotly.js/pulls |
| Actions | https://github.com/plotly/plotly.js/actions |
| Security and quality | https://github.com/plotly/plotly.js/security |
| Insights | https://github.com/plotly/plotly.js/insights |
| https://github.com/plotly/plotly.js |
| antoinerg | https://github.com/antoinerg |
| plotly:master | https://github.com/plotly/plotly.js/tree/master |
| nathanjenx:fix1913-horizontal-legened-groups | https://github.com/nathanjenx/plotly.js/tree/fix1913-horizontal-legened-groups |
| Conversation | https://github.com/plotly/plotly.js/pull/3628 |
| Commits14 (14) | https://github.com/plotly/plotly.js/pull/3628/commits |
| Checks | https://github.com/plotly/plotly.js/pull/3628/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/3628/files |
| Fix #1913 by pushing overflowed legend items to a new line | https://github.com/plotly/plotly.js/pull/3628#top |
| antoinerg | https://github.com/antoinerg |
| plotly:master | https://github.com/plotly/plotly.js/tree/master |
| nathanjenx:fix1913-horizontal-legened-groups | https://github.com/nathanjenx/plotly.js/tree/fix1913-horizontal-legened-groups |
|
| https://github.com/nathanjenx |
| nathanjenx | https://github.com/nathanjenx |
| Mar 12, 2019 | https://github.com/plotly/plotly.js/pull/3628#issue-419913002 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| #1913 | https://github.com/plotly/plotly.js/issues/1913 |
| https://user-images.githubusercontent.com/17784905/54224362-48298b00-44f1-11e9-95b9-d2be9e576faf.png |
| @antoinerg | https://github.com/antoinerg |
| @etpinard | https://github.com/etpinard |
| here | https://user-images.githubusercontent.com/17784905/54193763-a4b98580-44b2-11e9-928d-df12b110357c.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| nathanjenx | https://github.com/nathanjenx |
| March 12, 2019 10:30 | https://github.com/plotly/plotly.js/pull/3628#commits-pushed-b89f1ee |
|
| https://github.com/nathanjenx |
| Fix | https://github.com/plotly/plotly.js/pull/3628/commits/b89f1eeef88fca6ec30483dcfdcae1b7812c4f8c |
| plotly#1913 | https://github.com/plotly/plotly.js/issues/1913 |
| by adding pushing overflowed legend items to a new li… | https://github.com/plotly/plotly.js/pull/3628/commits/b89f1eeef88fca6ec30483dcfdcae1b7812c4f8c |
| b89f1ee | https://github.com/plotly/plotly.js/pull/3628/commits/b89f1eeef88fca6ec30483dcfdcae1b7812c4f8c |
|
| https://github.com/nathanjenx |
| Add test image for legendgroup horizontal wrapping | https://github.com/plotly/plotly.js/pull/3628/commits/d152792df82fa6f1bd8e091a697da86e05dba241 |
| d152792 | https://github.com/plotly/plotly.js/pull/3628/commits/d152792df82fa6f1bd8e091a697da86e05dba241 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
|
Mar 12, 2019
| https://github.com/plotly/plotly.js/pull/3628#ref-pullrequest-417976333 |
|
Fix handling of horizontal legendgroup
#3609
| https://github.com/plotly/plotly.js/pull/3609 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Mar 12, 2019 | https://github.com/plotly/plotly.js/pull/3628#issuecomment-472059298 |
| @nathanjenx | https://github.com/nathanjenx |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Mar 12, 2019 | https://github.com/plotly/plotly.js/pull/3628#issuecomment-472087590 |
| @nathanjenx | https://github.com/nathanjenx |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| nathanjenx | https://github.com/nathanjenx |
| March 12, 2019 17:57 | https://github.com/plotly/plotly.js/pull/3628#commits-pushed-b9542c4 |
|
| https://github.com/nathanjenx |
| Remove traceGroupGap from widths | https://github.com/plotly/plotly.js/pull/3628/commits/b9542c44673ec5eeba3524c3dd3ff68e279733ae |
| b9542c4 | https://github.com/plotly/plotly.js/pull/3628/commits/b9542c44673ec5eeba3524c3dd3ff68e279733ae |
|
| https://github.com/nathanjenx |
| Generate test images for legend group wrapping | https://github.com/plotly/plotly.js/pull/3628/commits/f279235ed99f3b3fda9805cdfd9b44378003eceb |
| f279235 | https://github.com/plotly/plotly.js/pull/3628/commits/f279235ed99f3b3fda9805cdfd9b44378003eceb |
| https://github.com/nathanjenx |
| nathanjenx | https://github.com/nathanjenx |
| Mar 12, 2019 | https://github.com/plotly/plotly.js/pull/3628#issuecomment-472115256 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| @antoinerg | https://github.com/antoinerg |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
|
Mar 12, 2019
| https://github.com/plotly/plotly.js/pull/3628#pullrequestreview-213571955 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3628/files/f279235ed99f3b3fda9805cdfd9b44378003eceb |
| src/components/legend/draw.js | https://github.com/plotly/plotly.js/pull/3628/files/f279235ed99f3b3fda9805cdfd9b44378003eceb#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Mar 12, 2019 | https://github.com/plotly/plotly.js/pull/3628#issuecomment-472135605 |
| @nathanjenx | https://github.com/nathanjenx |
| b9542c4 | https://github.com/plotly/plotly.js/commit/b9542c44673ec5eeba3524c3dd3ff68e279733ae |
| L672 of draw.js | https://github.com/nathanjenx/plotly.js/blob/f279235ed99f3b3fda9805cdfd9b44378003eceb/src/components/legend/draw.js#L672 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
|
| https://github.com/nathanjenx |
| Enforce minimum of 5px gap between traces when legend horizontal | https://github.com/plotly/plotly.js/pull/3628/commits/51178ec2187db86eb17234eb171142f4a7e30af5 |
| 51178ec | https://github.com/plotly/plotly.js/pull/3628/commits/51178ec2187db86eb17234eb171142f4a7e30af5 |
| https://github.com/nathanjenx |
| nathanjenx | https://github.com/nathanjenx |
| Mar 12, 2019 | https://github.com/plotly/plotly.js/pull/3628#issuecomment-472140419 |
| @nathanjenx | https://github.com/nathanjenx |
| b9542c4 | https://github.com/plotly/plotly.js/commit/b9542c44673ec5eeba3524c3dd3ff68e279733ae |
| L672 of draw.js | https://github.com/nathanjenx/plotly.js/blob/f279235ed99f3b3fda9805cdfd9b44378003eceb/src/components/legend/draw.js#L672 |
| 51178ec | https://github.com/plotly/plotly.js/commit/51178ec2187db86eb17234eb171142f4a7e30af5 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
|
Mar 12, 2019
| https://github.com/plotly/plotly.js/pull/3628#pullrequestreview-213595730 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3628/files/51178ec2187db86eb17234eb171142f4a7e30af5 |
| src/components/legend/draw.js | https://github.com/plotly/plotly.js/pull/3628/files/f279235ed99f3b3fda9805cdfd9b44378003eceb..51178ec2187db86eb17234eb171142f4a7e30af5#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
|
Mar 12, 2019
| https://github.com/plotly/plotly.js/pull/3628#pullrequestreview-213596125 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3628/files/51178ec2187db86eb17234eb171142f4a7e30af5 |
| src/components/legend/draw.js | https://github.com/plotly/plotly.js/pull/3628/files/51178ec2187db86eb17234eb171142f4a7e30af5#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Mar 12, 2019 | https://github.com/plotly/plotly.js/pull/3628#issuecomment-472143975 |
| this baseline | https://github.com/plotly/plotly.js/pull/3628/files?short_path=3367b6a#diff-3367b6ae7c2fe5d6fbdfd3a6630f48a1 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
|
| https://github.com/nathanjenx |
| Fix traceGroup vriable and baseline images | https://github.com/plotly/plotly.js/pull/3628/commits/76df791da4fddc9c78977e3f5b86c82a43c8d349 |
| 76df791 | https://github.com/plotly/plotly.js/pull/3628/commits/76df791da4fddc9c78977e3f5b86c82a43c8d349 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Mar 12, 2019 | https://github.com/plotly/plotly.js/pull/3628#issuecomment-472155261 |
| @nathanjenx | https://github.com/nathanjenx |
| https://user-images.githubusercontent.com/301546/54231097-37bbe500-44de-11e9-91a5-e94fccff0fcf.png |
| https://user-images.githubusercontent.com/301546/54231130-473b2e00-44de-11e9-8fd5-c2cad32858da.png |
| @nathanjenx | https://github.com/nathanjenx |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| nathanjenx | https://github.com/nathanjenx |
| March 13, 2019 09:37 | https://github.com/plotly/plotly.js/pull/3628#commits-pushed-737150b |
|
| https://github.com/nathanjenx |
| Ensure width of legend is checked before adding a new width | https://github.com/plotly/plotly.js/pull/3628/commits/737150b1ed2cfb479e791b1b0f43151ab304bcda |
| 737150b | https://github.com/plotly/plotly.js/pull/3628/commits/737150b1ed2cfb479e791b1b0f43151ab304bcda |
|
| https://github.com/nathanjenx |
| Remove extra height from horizontal grouped legends | https://github.com/plotly/plotly.js/pull/3628/commits/3edc9eb9a9ef1498d930875e241b1723c693b3c6 |
| 3edc9eb | https://github.com/plotly/plotly.js/pull/3628/commits/3edc9eb9a9ef1498d930875e241b1723c693b3c6 |
|
| https://github.com/nathanjenx |
| Only add traceGap on new rows | https://github.com/plotly/plotly.js/pull/3628/commits/68848e497d7e12d9347e748c33cecce0ca13c71d |
| 68848e4 | https://github.com/plotly/plotly.js/pull/3628/commits/68848e497d7e12d9347e748c33cecce0ca13c71d |
|
| https://github.com/nathanjenx |
| Include intial 10px padding on legend | https://github.com/plotly/plotly.js/pull/3628/commits/f6d430ba3794e0fac9453c054c3f84567ddebd55 |
| f6d430b | https://github.com/plotly/plotly.js/pull/3628/commits/f6d430ba3794e0fac9453c054c3f84567ddebd55 |
|
| https://github.com/nathanjenx |
| Add opts.tracegroupgap to height not traceGap | https://github.com/plotly/plotly.js/pull/3628/commits/9dfdedd864f71c06e94f552766531899be367bb3 |
| 9dfdedd | https://github.com/plotly/plotly.js/pull/3628/commits/9dfdedd864f71c06e94f552766531899be367bb3 |
| https://github.com/nathanjenx |
| nathanjenx | https://github.com/nathanjenx |
| Mar 13, 2019 | https://github.com/plotly/plotly.js/pull/3628#issuecomment-472363399 |
| @antoinerg | https://github.com/antoinerg |
| @antoinerg | https://github.com/antoinerg |
| @archmoj | https://github.com/archmoj |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Mar 13, 2019 | https://github.com/plotly/plotly.js/pull/3628#issuecomment-472522813 |
| @nathanjenx | https://github.com/nathanjenx |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Mar 18, 2019
| https://github.com/plotly/plotly.js/pull/3628#pullrequestreview-215678130 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3628/files/9dfdedd864f71c06e94f552766531899be367bb3 |
| test/image/mocks/legendgroup_horizontal_wrapping.json | https://github.com/plotly/plotly.js/pull/3628/files/9dfdedd864f71c06e94f552766531899be367bb3#diff-7176b0e54aad5c10505882279f60bc9a2e1c6f27f86a0fa06599f5ea4400dc57 |
| etpinard | https://github.com/etpinard |
| Mar 18, 2019 | https://github.com/plotly/plotly.js/pull/3628#discussion_r266502969 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://user-images.githubusercontent.com/6675409/54542461-32ddb200-4972-11e9-9ea6-fd529f83db44.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
bug
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
| Mar 18, 2019 | https://github.com/plotly/plotly.js/pull/3628#event-2210923729 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Mar 18, 2019
| https://github.com/plotly/plotly.js/pull/3628#pullrequestreview-215716928 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3628/files/9dfdedd864f71c06e94f552766531899be367bb3 |
| src/components/legend/draw.js | https://github.com/plotly/plotly.js/pull/3628/files/9dfdedd864f71c06e94f552766531899be367bb3#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| nathanjenx | https://github.com/nathanjenx |
| March 18, 2019 17:37 | https://github.com/plotly/plotly.js/pull/3628#commits-pushed-0806a9a |
|
| https://github.com/nathanjenx |
| Ensure opt.tracegroupgap is added to legend rather than traceGap, ref… | https://github.com/plotly/plotly.js/pull/3628/commits/0806a9ab0f6e2d6f185cb22fdcf93dce95680426 |
| 0806a9a | https://github.com/plotly/plotly.js/pull/3628/commits/0806a9ab0f6e2d6f185cb22fdcf93dce95680426 |
|
| https://github.com/antoinerg |
| test that changing legend.tracegroupgap updates the margin size | https://github.com/plotly/plotly.js/pull/3628/commits/131145d58da38ab4ec3087fb23907d4fb571d357 |
| 131145d | https://github.com/plotly/plotly.js/pull/3628/commits/131145d58da38ab4ec3087fb23907d4fb571d357 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Mar 20, 2019
| https://github.com/plotly/plotly.js/pull/3628#pullrequestreview-216944088 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3628/files/131145d58da38ab4ec3087fb23907d4fb571d357 |
| src/components/legend/draw.js | https://github.com/plotly/plotly.js/pull/3628/files/131145d58da38ab4ec3087fb23907d4fb571d357#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578 |
| etpinard | https://github.com/etpinard |
| Mar 20, 2019 | https://github.com/plotly/plotly.js/pull/3628#discussion_r267516120 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Lib.aggNums | https://github.com/plotly/plotly.js/blob/12ce7253e5a3995824ec514a42be01aadbfdb6ea/src/lib/stats.js#L28-L44 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| antoinerg | https://github.com/antoinerg |
| Mar 20, 2019 | https://github.com/plotly/plotly.js/pull/3628#discussion_r267527436 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| a5fa247 | https://github.com/plotly/plotly.js/commit/a5fa247e5b06bbb1a53dd2c60876f8130a5915fd |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| etpinard | https://github.com/etpinard |
| Mar 20, 2019 | https://github.com/plotly/plotly.js/pull/3628#discussion_r267535086 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Lib.mean | https://github.com/plotly/plotly.js/blob/12ce7253e5a3995824ec514a42be01aadbfdb6ea/src/lib/stats.js#L54-L57 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Mar 20, 2019 | https://github.com/plotly/plotly.js/pull/3628#issuecomment-475000554 |
| @antoinerg | https://github.com/antoinerg |
| @nathanjenx | https://github.com/nathanjenx |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
|
| https://github.com/antoinerg |
| legend: minor style improvements to the code | https://github.com/plotly/plotly.js/pull/3628/commits/a5fa247e5b06bbb1a53dd2c60876f8130a5915fd |
| a5fa247 | https://github.com/plotly/plotly.js/pull/3628/commits/a5fa247e5b06bbb1a53dd2c60876f8130a5915fd |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| a24fea7 | https://github.com/plotly/plotly.js/commit/a24fea7ce623a81579a3b334f2bea8c1e4a3d347 |
| Mar 20, 2019 | https://github.com/plotly/plotly.js/pull/3628#event-2218165901 |
| https://github.com/nathanjenx |
| nathanjenx | https://github.com/nathanjenx |
| Mar 24, 2019 | https://github.com/plotly/plotly.js/pull/3628#issuecomment-476002599 |
| @etpinard | https://github.com/etpinard |
| @antoinerg | https://github.com/antoinerg |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3628 |
|
| https://github.com/antoinerg |
|
antoinerg
| https://github.com/antoinerg |
|
| https://github.com/plotly/plotly.js/pull/3628/files/a5fa247e5b06bbb1a53dd2c60876f8130a5915fd |
|
| https://github.com/etpinard |
|
etpinard
| https://github.com/etpinard |
|
| https://github.com/plotly/plotly.js/pull/3628/files/a5fa247e5b06bbb1a53dd2c60876f8130a5915fd |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
|
bug
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3628 |
|
| https://github.com/nathanjenx |
|
| https://github.com/antoinerg |
|
| https://github.com/archmoj |
|
| https://github.com/etpinard |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |