René's URL Explorer Experiment


Title: Fix #1913 by pushing overflowed legend items to a new line by nathanjenx · Pull Request #3628 · plotly/plotly.js · GitHub

Open Graph Title: Fix #1913 by pushing overflowed legend items to a new line by nathanjenx · Pull Request #3628 · plotly/plotly.js

X Title: Fix #1913 by pushing overflowed legend items to a new line by nathanjenx · Pull Request #3628 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Fix #1913 by pushing overflowed legend items to a new line by nathanjenx · Pull Request #3628 · plotly/plotly.js

Open Graph Description: Fixes the handling of horizontal grouped legend items see #1913. Maintains the vertical grouping and includes gaps between traces (see below screenshot) @antoinerg @etpinard (edit: updated to show...

X Description: Fixes the handling of horizontal grouped legend items see #1913. Maintains the vertical grouping and includes gaps between traces (see below screenshot) @antoinerg @etpinard (edit: updated to show...

Opengraph URL: https://github.com/plotly/plotly.js/pull/3628

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:454ece1c-7a36-4895-5cb9-9e6ca92d273b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB3C:2A5566:58F7A3:747DE7:6B019D55
html-safe-nonce8565c744de3815a1a61b9a785c91cc6b8ae6fe3bfb54fe4a8f77e0a6c1abc397
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjNDOjJBNTU2Njo1OEY3QTM6NzQ3REU3OjZCMDE5RDU1IiwidmlzaXRvcl9pZCI6IjczNzM4MDgwMDU4NDA2NDM0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6f22afab9b88c48f9cf584041b11cd2f017c8abf6408fdc06f72ad1e80ec9cc9
hovercard-subject-tagpull_request:260304941
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/3628/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2e5697392cc89484ccbc7ccf9cded6597ebde6e33ad57b1c58f97252ab4fc018/plotly/plotly.js/pull/3628
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2e5697392cc89484ccbc7ccf9cded6597ebde6e33ad57b1c58f97252ab4fc018/plotly/plotly.js/pull/3628
og:image:altFixes the handling of horizontal grouped legend items see #1913. Maintains the vertical grouping and includes gaps between traces (see below screenshot) @antoinerg @etpinard (edit: updated to show...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamenathanjenx
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/3628#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3628
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3628
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/3628
Reloadhttps://github.com/plotly/plotly.js/pull/3628
Reloadhttps://github.com/plotly/plotly.js/pull/3628
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
antoinerghttps://github.com/antoinerg
plotly:masterhttps://github.com/plotly/plotly.js/tree/master
nathanjenx:fix1913-horizontal-legened-groupshttps://github.com/nathanjenx/plotly.js/tree/fix1913-horizontal-legened-groups
Conversationhttps://github.com/plotly/plotly.js/pull/3628
Commits14 (14)https://github.com/plotly/plotly.js/pull/3628/commits
Checkshttps://github.com/plotly/plotly.js/pull/3628/checks
Files changedhttps://github.com/plotly/plotly.js/pull/3628/files
Fix #1913 by pushing overflowed legend items to a new linehttps://github.com/plotly/plotly.js/pull/3628#top
antoinerghttps://github.com/antoinerg
plotly:masterhttps://github.com/plotly/plotly.js/tree/master
nathanjenx:fix1913-horizontal-legened-groupshttps://github.com/nathanjenx/plotly.js/tree/fix1913-horizontal-legened-groups
https://github.com/nathanjenx
nathanjenxhttps://github.com/nathanjenx
Mar 12, 2019https://github.com/plotly/plotly.js/pull/3628#issue-419913002
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
#1913https://github.com/plotly/plotly.js/issues/1913
https://user-images.githubusercontent.com/17784905/54224362-48298b00-44f1-11e9-95b9-d2be9e576faf.png
@antoinerghttps://github.com/antoinerg
@etpinardhttps://github.com/etpinard
herehttps://user-images.githubusercontent.com/17784905/54193763-a4b98580-44b2-11e9-928d-df12b110357c.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
nathanjenxhttps://github.com/nathanjenx
March 12, 2019 10:30https://github.com/plotly/plotly.js/pull/3628#commits-pushed-b89f1ee
https://github.com/nathanjenx
Fixhttps://github.com/plotly/plotly.js/pull/3628/commits/b89f1eeef88fca6ec30483dcfdcae1b7812c4f8c
plotly#1913https://github.com/plotly/plotly.js/issues/1913
by adding pushing overflowed legend items to a new li…https://github.com/plotly/plotly.js/pull/3628/commits/b89f1eeef88fca6ec30483dcfdcae1b7812c4f8c
b89f1eehttps://github.com/plotly/plotly.js/pull/3628/commits/b89f1eeef88fca6ec30483dcfdcae1b7812c4f8c
https://github.com/nathanjenx
Add test image for legendgroup horizontal wrappinghttps://github.com/plotly/plotly.js/pull/3628/commits/d152792df82fa6f1bd8e091a697da86e05dba241
d152792https://github.com/plotly/plotly.js/pull/3628/commits/d152792df82fa6f1bd8e091a697da86e05dba241
https://github.com/antoinerg
antoinerghttps://github.com/antoinerg
Mar 12, 2019 https://github.com/plotly/plotly.js/pull/3628#ref-pullrequest-417976333
Fix handling of horizontal legendgroup #3609 https://github.com/plotly/plotly.js/pull/3609
https://github.com/antoinerg
antoinerghttps://github.com/antoinerg
Mar 12, 2019https://github.com/plotly/plotly.js/pull/3628#issuecomment-472059298
@nathanjenxhttps://github.com/nathanjenx
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/antoinerg
antoinerghttps://github.com/antoinerg
Mar 12, 2019https://github.com/plotly/plotly.js/pull/3628#issuecomment-472087590
@nathanjenxhttps://github.com/nathanjenx
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
nathanjenxhttps://github.com/nathanjenx
March 12, 2019 17:57https://github.com/plotly/plotly.js/pull/3628#commits-pushed-b9542c4
https://github.com/nathanjenx
Remove traceGroupGap from widthshttps://github.com/plotly/plotly.js/pull/3628/commits/b9542c44673ec5eeba3524c3dd3ff68e279733ae
b9542c4https://github.com/plotly/plotly.js/pull/3628/commits/b9542c44673ec5eeba3524c3dd3ff68e279733ae
https://github.com/nathanjenx
Generate test images for legend group wrappinghttps://github.com/plotly/plotly.js/pull/3628/commits/f279235ed99f3b3fda9805cdfd9b44378003eceb
f279235https://github.com/plotly/plotly.js/pull/3628/commits/f279235ed99f3b3fda9805cdfd9b44378003eceb
https://github.com/nathanjenx
nathanjenxhttps://github.com/nathanjenx
Mar 12, 2019https://github.com/plotly/plotly.js/pull/3628#issuecomment-472115256
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
@antoinerghttps://github.com/antoinerg
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/antoinerg
antoinerghttps://github.com/antoinerg
Mar 12, 2019 https://github.com/plotly/plotly.js/pull/3628#pullrequestreview-213571955
View reviewed changes https://github.com/plotly/plotly.js/pull/3628/files/f279235ed99f3b3fda9805cdfd9b44378003eceb
src/components/legend/draw.jshttps://github.com/plotly/plotly.js/pull/3628/files/f279235ed99f3b3fda9805cdfd9b44378003eceb#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/antoinerg
antoinerghttps://github.com/antoinerg
Mar 12, 2019https://github.com/plotly/plotly.js/pull/3628#issuecomment-472135605
@nathanjenxhttps://github.com/nathanjenx
b9542c4https://github.com/plotly/plotly.js/commit/b9542c44673ec5eeba3524c3dd3ff68e279733ae
L672 of draw.jshttps://github.com/nathanjenx/plotly.js/blob/f279235ed99f3b3fda9805cdfd9b44378003eceb/src/components/legend/draw.js#L672
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/nathanjenx
Enforce minimum of 5px gap between traces when legend horizontalhttps://github.com/plotly/plotly.js/pull/3628/commits/51178ec2187db86eb17234eb171142f4a7e30af5
51178echttps://github.com/plotly/plotly.js/pull/3628/commits/51178ec2187db86eb17234eb171142f4a7e30af5
https://github.com/nathanjenx
nathanjenxhttps://github.com/nathanjenx
Mar 12, 2019https://github.com/plotly/plotly.js/pull/3628#issuecomment-472140419
@nathanjenxhttps://github.com/nathanjenx
b9542c4https://github.com/plotly/plotly.js/commit/b9542c44673ec5eeba3524c3dd3ff68e279733ae
L672 of draw.jshttps://github.com/nathanjenx/plotly.js/blob/f279235ed99f3b3fda9805cdfd9b44378003eceb/src/components/legend/draw.js#L672
51178echttps://github.com/plotly/plotly.js/commit/51178ec2187db86eb17234eb171142f4a7e30af5
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/antoinerg
antoinerghttps://github.com/antoinerg
Mar 12, 2019 https://github.com/plotly/plotly.js/pull/3628#pullrequestreview-213595730
View reviewed changes https://github.com/plotly/plotly.js/pull/3628/files/51178ec2187db86eb17234eb171142f4a7e30af5
src/components/legend/draw.jshttps://github.com/plotly/plotly.js/pull/3628/files/f279235ed99f3b3fda9805cdfd9b44378003eceb..51178ec2187db86eb17234eb171142f4a7e30af5#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/antoinerg
antoinerghttps://github.com/antoinerg
Mar 12, 2019 https://github.com/plotly/plotly.js/pull/3628#pullrequestreview-213596125
View reviewed changes https://github.com/plotly/plotly.js/pull/3628/files/51178ec2187db86eb17234eb171142f4a7e30af5
src/components/legend/draw.jshttps://github.com/plotly/plotly.js/pull/3628/files/51178ec2187db86eb17234eb171142f4a7e30af5#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/archmoj
archmojhttps://github.com/archmoj
Mar 12, 2019https://github.com/plotly/plotly.js/pull/3628#issuecomment-472143975
this baselinehttps://github.com/plotly/plotly.js/pull/3628/files?short_path=3367b6a#diff-3367b6ae7c2fe5d6fbdfd3a6630f48a1
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/nathanjenx
Fix traceGroup vriable and baseline imageshttps://github.com/plotly/plotly.js/pull/3628/commits/76df791da4fddc9c78977e3f5b86c82a43c8d349
76df791https://github.com/plotly/plotly.js/pull/3628/commits/76df791da4fddc9c78977e3f5b86c82a43c8d349
https://github.com/antoinerg
antoinerghttps://github.com/antoinerg
Mar 12, 2019https://github.com/plotly/plotly.js/pull/3628#issuecomment-472155261
@nathanjenxhttps://github.com/nathanjenx
https://user-images.githubusercontent.com/301546/54231097-37bbe500-44de-11e9-91a5-e94fccff0fcf.png
https://user-images.githubusercontent.com/301546/54231130-473b2e00-44de-11e9-8fd5-c2cad32858da.png
@nathanjenxhttps://github.com/nathanjenx
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
nathanjenxhttps://github.com/nathanjenx
March 13, 2019 09:37https://github.com/plotly/plotly.js/pull/3628#commits-pushed-737150b
https://github.com/nathanjenx
Ensure width of legend is checked before adding a new widthhttps://github.com/plotly/plotly.js/pull/3628/commits/737150b1ed2cfb479e791b1b0f43151ab304bcda
737150bhttps://github.com/plotly/plotly.js/pull/3628/commits/737150b1ed2cfb479e791b1b0f43151ab304bcda
https://github.com/nathanjenx
Remove extra height from horizontal grouped legendshttps://github.com/plotly/plotly.js/pull/3628/commits/3edc9eb9a9ef1498d930875e241b1723c693b3c6
3edc9ebhttps://github.com/plotly/plotly.js/pull/3628/commits/3edc9eb9a9ef1498d930875e241b1723c693b3c6
https://github.com/nathanjenx
Only add traceGap on new rowshttps://github.com/plotly/plotly.js/pull/3628/commits/68848e497d7e12d9347e748c33cecce0ca13c71d
68848e4https://github.com/plotly/plotly.js/pull/3628/commits/68848e497d7e12d9347e748c33cecce0ca13c71d
https://github.com/nathanjenx
Include intial 10px padding on legendhttps://github.com/plotly/plotly.js/pull/3628/commits/f6d430ba3794e0fac9453c054c3f84567ddebd55
f6d430bhttps://github.com/plotly/plotly.js/pull/3628/commits/f6d430ba3794e0fac9453c054c3f84567ddebd55
https://github.com/nathanjenx
Add opts.tracegroupgap to height not traceGaphttps://github.com/plotly/plotly.js/pull/3628/commits/9dfdedd864f71c06e94f552766531899be367bb3
9dfdeddhttps://github.com/plotly/plotly.js/pull/3628/commits/9dfdedd864f71c06e94f552766531899be367bb3
https://github.com/nathanjenx
nathanjenxhttps://github.com/nathanjenx
Mar 13, 2019https://github.com/plotly/plotly.js/pull/3628#issuecomment-472363399
@antoinerghttps://github.com/antoinerg
@antoinerghttps://github.com/antoinerg
@archmojhttps://github.com/archmoj
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/antoinerg
antoinerghttps://github.com/antoinerg
Mar 13, 2019https://github.com/plotly/plotly.js/pull/3628#issuecomment-472522813
@nathanjenxhttps://github.com/nathanjenx
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Mar 18, 2019 https://github.com/plotly/plotly.js/pull/3628#pullrequestreview-215678130
View reviewed changes https://github.com/plotly/plotly.js/pull/3628/files/9dfdedd864f71c06e94f552766531899be367bb3
test/image/mocks/legendgroup_horizontal_wrapping.jsonhttps://github.com/plotly/plotly.js/pull/3628/files/9dfdedd864f71c06e94f552766531899be367bb3#diff-7176b0e54aad5c10505882279f60bc9a2e1c6f27f86a0fa06599f5ea4400dc57
etpinardhttps://github.com/etpinard
Mar 18, 2019https://github.com/plotly/plotly.js/pull/3628#discussion_r266502969
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://user-images.githubusercontent.com/6675409/54542461-32ddb200-4972-11e9-9ea6-fd529f83db44.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/etpinard
etpinardhttps://github.com/etpinard
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
Mar 18, 2019https://github.com/plotly/plotly.js/pull/3628#event-2210923729
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Mar 18, 2019 https://github.com/plotly/plotly.js/pull/3628#pullrequestreview-215716928
View reviewed changes https://github.com/plotly/plotly.js/pull/3628/files/9dfdedd864f71c06e94f552766531899be367bb3
src/components/legend/draw.jshttps://github.com/plotly/plotly.js/pull/3628/files/9dfdedd864f71c06e94f552766531899be367bb3#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
nathanjenxhttps://github.com/nathanjenx
March 18, 2019 17:37https://github.com/plotly/plotly.js/pull/3628#commits-pushed-0806a9a
https://github.com/nathanjenx
Ensure opt.tracegroupgap is added to legend rather than traceGap, ref…https://github.com/plotly/plotly.js/pull/3628/commits/0806a9ab0f6e2d6f185cb22fdcf93dce95680426
0806a9ahttps://github.com/plotly/plotly.js/pull/3628/commits/0806a9ab0f6e2d6f185cb22fdcf93dce95680426
https://github.com/antoinerg
test that changing legend.tracegroupgap updates the margin sizehttps://github.com/plotly/plotly.js/pull/3628/commits/131145d58da38ab4ec3087fb23907d4fb571d357
131145dhttps://github.com/plotly/plotly.js/pull/3628/commits/131145d58da38ab4ec3087fb23907d4fb571d357
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Mar 20, 2019 https://github.com/plotly/plotly.js/pull/3628#pullrequestreview-216944088
View reviewed changes https://github.com/plotly/plotly.js/pull/3628/files/131145d58da38ab4ec3087fb23907d4fb571d357
src/components/legend/draw.jshttps://github.com/plotly/plotly.js/pull/3628/files/131145d58da38ab4ec3087fb23907d4fb571d357#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578
etpinardhttps://github.com/etpinard
Mar 20, 2019https://github.com/plotly/plotly.js/pull/3628#discussion_r267516120
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Lib.aggNumshttps://github.com/plotly/plotly.js/blob/12ce7253e5a3995824ec514a42be01aadbfdb6ea/src/lib/stats.js#L28-L44
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
antoinerghttps://github.com/antoinerg
Mar 20, 2019https://github.com/plotly/plotly.js/pull/3628#discussion_r267527436
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
a5fa247https://github.com/plotly/plotly.js/commit/a5fa247e5b06bbb1a53dd2c60876f8130a5915fd
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
etpinardhttps://github.com/etpinard
Mar 20, 2019https://github.com/plotly/plotly.js/pull/3628#discussion_r267535086
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Lib.meanhttps://github.com/plotly/plotly.js/blob/12ce7253e5a3995824ec514a42be01aadbfdb6ea/src/lib/stats.js#L54-L57
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Mar 20, 2019https://github.com/plotly/plotly.js/pull/3628#issuecomment-475000554
@antoinerghttps://github.com/antoinerg
@nathanjenxhttps://github.com/nathanjenx
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/antoinerg
legend: minor style improvements to the codehttps://github.com/plotly/plotly.js/pull/3628/commits/a5fa247e5b06bbb1a53dd2c60876f8130a5915fd
a5fa247https://github.com/plotly/plotly.js/pull/3628/commits/a5fa247e5b06bbb1a53dd2c60876f8130a5915fd
https://github.com/antoinerg
antoinerghttps://github.com/antoinerg
a24fea7https://github.com/plotly/plotly.js/commit/a24fea7ce623a81579a3b334f2bea8c1e4a3d347
Mar 20, 2019https://github.com/plotly/plotly.js/pull/3628#event-2218165901
https://github.com/nathanjenx
nathanjenxhttps://github.com/nathanjenx
Mar 24, 2019https://github.com/plotly/plotly.js/pull/3628#issuecomment-476002599
@etpinardhttps://github.com/etpinard
@antoinerghttps://github.com/antoinerg
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3628
https://github.com/antoinerg
antoinerg https://github.com/antoinerg
https://github.com/plotly/plotly.js/pull/3628/files/a5fa247e5b06bbb1a53dd2c60876f8130a5915fd
https://github.com/etpinard
etpinard https://github.com/etpinard
https://github.com/plotly/plotly.js/pull/3628/files/a5fa247e5b06bbb1a53dd2c60876f8130a5915fd
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3628
https://github.com/nathanjenx
https://github.com/antoinerg
https://github.com/archmoj
https://github.com/etpinard
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.