René's URL Explorer Experiment


Title: Automargin edge cases by etpinard · Pull Request #3605 · plotly/plotly.js · GitHub

Open Graph Title: Automargin edge cases by etpinard · Pull Request #3605 · plotly/plotly.js

X Title: Automargin edge cases by etpinard · Pull Request #3605 · plotly/plotly.js

Description: fixes #3579 and #3600 Updated codepens: https://codepen.io/etpinard/pen/aMmwRZ https://codepen.io/etpinard/pen/bZwRmQ cc @plotly/plotly_js

Open Graph Description: fixes #3579 and #3600 Updated codepens: https://codepen.io/etpinard/pen/aMmwRZ https://codepen.io/etpinard/pen/bZwRmQ cc @plotly/plotly_js

X Description: fixes #3579 and #3600 Updated codepens: https://codepen.io/etpinard/pen/aMmwRZ https://codepen.io/etpinard/pen/bZwRmQ cc @plotly/plotly_js

Opengraph URL: https://github.com/plotly/plotly.js/pull/3605

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cab4dd67-86e3-b33d-6345-482b9595e474
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id89CA:280A2E:54542E:6E9147:6B017988
html-safe-noncebf9cbf08c34f97e3e698da9033ae5eebca1bb6cc0f8036c8577676a82877a7b2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUNBOjI4MEEyRTo1NDU0MkU6NkU5MTQ3OjZCMDE3OTg4IiwidmlzaXRvcl9pZCI6IjYxNDc1NzA0MjI2NzEwNDcwNDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacada1bc6a8a8b5ffe7421087635e1a3ea9da13f31c8125767f2e68f04397e7f85
hovercard-subject-tagpull_request:258116221
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/plotly/plotly.js/pull/3605/files
twitter:imagehttps://avatars.githubusercontent.com/u/6675409?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/6675409?s=400&v=4
og:image:altfixes #3579 and #3600 Updated codepens: https://codepen.io/etpinard/pen/aMmwRZ https://codepen.io/etpinard/pen/bZwRmQ cc @plotly/plotly_js
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/3605/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3605%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3605%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/3605/files
Reloadhttps://github.com/plotly/plotly.js/pull/3605/files
Reloadhttps://github.com/plotly/plotly.js/pull/3605/files
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fplotly%2Fplotly.js%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fplotly%2Fplotly.js%2Fissues%2Fnew%2Fchoose
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
automargin-edge-caseshttps://github.com/plotly/plotly.js/tree/automargin-edge-cases
Conversation 11 https://github.com/plotly/plotly.js/pull/3605
Commits 6 https://github.com/plotly/plotly.js/pull/3605/commits
Checks 0 https://github.com/plotly/plotly.js/pull/3605/checks
Files changed https://github.com/plotly/plotly.js/pull/3605/files
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3605/files
Automargin edge cases https://github.com/plotly/plotly.js/pull/3605/files#top
Show all changes 6 commits https://github.com/plotly/plotly.js/pull/3605/files
6c7db5e fix #3579 - consider tick labels to go past plot area etpinard Mar 4, 2019 https://github.com/plotly/plotly.js/pull/3605/commits/6c7db5e2092efec967aca83f9aef1645aceb763f
1f6e711 improve axis automargin tests etpinard Mar 4, 2019 https://github.com/plotly/plotly.js/pull/3605/commits/1f6e7119c7b4efa04e5b1a243fc919eacfe9f1e2
8a1b5e7 throw axis scaling error when ax._length is negative etpinard Mar 4, 2019 https://github.com/plotly/plotly.js/pull/3605/commits/8a1b5e76b0b57ed777b8c4e6ef131c0d93fb0690
87b10a7 fix #3600 - skip automargin pushes that lead to negative plot area etpinard Mar 4, 2019 https://github.com/plotly/plotly.js/pull/3605/commits/87b10a78ac7a8153314d76c6a1ce0aba04f2fb4b
d5bacfe :camel: case etpinard Mar 5, 2019 https://github.com/plotly/plotly.js/pull/3605/commits/d5bacfefbc0d75cfaf81a70a568bc27e08ed2c30
18f827d mojtaba-proof test msgs etpinard Mar 5, 2019 https://github.com/plotly/plotly.js/pull/3605/commits/18f827d738fb7ac48bee45f4b7f8f164ccec28a4
Clear filters https://github.com/plotly/plotly.js/pull/3605/files
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3605/files
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3605/files
axes.js https://github.com/plotly/plotly.js/pull/3605/files#diff-5f001ae7bd55867b9cfbe23508ea18384159d46c141298fa7d177cfd76194695
set_convert.js https://github.com/plotly/plotly.js/pull/3605/files#diff-10cca8c9eea1420164e53bbf7ed6b1bef79c17ad4116f5ecc079ed72f725da64
plots.js https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
automargin-push-x-extra.png https://github.com/plotly/plotly.js/pull/3605/files#diff-cf8cf75c9c50d0ecd623619f9bc084c4beb01f266466be9c0edb25962c3b8c4f
automargin-push-y-extra.png https://github.com/plotly/plotly.js/pull/3605/files#diff-75ba1bbe2aefb95e942cc9267ca95a98022dede4c99fac3bb461f1af81524342
automargin-push-x-extra.json https://github.com/plotly/plotly.js/pull/3605/files#diff-41af0f14d010786585268eb8d6c135c24e2b4fa77752f50a93f405beabb67758
automargin-push-y-extra.json https://github.com/plotly/plotly.js/pull/3605/files#diff-62d613e68d1b79aefb5aa1bb89aa9eda5069f597ff2040add79a7897fb4e979d
axes_test.js https://github.com/plotly/plotly.js/pull/3605/files#diff-49b76cce481e5bce7093546f0260b025811410d6826842eee83019fc4b04e9bd
src/plots/cartesian/axes.jshttps://github.com/plotly/plotly.js/pull/3605/files#diff-5f001ae7bd55867b9cfbe23508ea18384159d46c141298fa7d177cfd76194695
View file https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/src/plots/cartesian/axes.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/3605/{{ revealButtonHref }}
https://github.com/plotly/plotly.js/pull/3605/files#diff-5f001ae7bd55867b9cfbe23508ea18384159d46c141298fa7d177cfd76194695
https://github.com/plotly/plotly.js/pull/3605/files#diff-5f001ae7bd55867b9cfbe23508ea18384159d46c141298fa7d177cfd76194695
src/plots/cartesian/set_convert.jshttps://github.com/plotly/plotly.js/pull/3605/files#diff-10cca8c9eea1420164e53bbf7ed6b1bef79c17ad4116f5ecc079ed72f725da64
View file https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/src/plots/cartesian/set_convert.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/3605/{{ revealButtonHref }}
https://github.com/plotly/plotly.js/pull/3605/files#diff-10cca8c9eea1420164e53bbf7ed6b1bef79c17ad4116f5ecc079ed72f725da64
https://github.com/plotly/plotly.js/pull/3605/files#diff-10cca8c9eea1420164e53bbf7ed6b1bef79c17ad4116f5ecc079ed72f725da64
src/plots/plots.jshttps://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
View file https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/src/plots/plots.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/3605/{{ revealButtonHref }}
https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
test/image/baselines/automargin-push-x-extra.pnghttps://github.com/plotly/plotly.js/pull/3605/files#diff-cf8cf75c9c50d0ecd623619f9bc084c4beb01f266466be9c0edb25962c3b8c4f
View file https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/test/image/baselines/automargin-push-x-extra.png
Open in desktop https://desktop.github.com
Reload?https://github.com/plotly/plotly.js/pull/3605/files
test/image/baselines/automargin-push-y-extra.pnghttps://github.com/plotly/plotly.js/pull/3605/files#diff-75ba1bbe2aefb95e942cc9267ca95a98022dede4c99fac3bb461f1af81524342
View file https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/test/image/baselines/automargin-push-y-extra.png
Open in desktop https://desktop.github.com
Reload?https://github.com/plotly/plotly.js/pull/3605/files
test/image/mocks/automargin-push-x-extra.jsonhttps://github.com/plotly/plotly.js/pull/3605/files#diff-41af0f14d010786585268eb8d6c135c24e2b4fa77752f50a93f405beabb67758
View file https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/test/image/mocks/automargin-push-x-extra.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/3605/{{ revealButtonHref }}
test/image/mocks/automargin-push-y-extra.jsonhttps://github.com/plotly/plotly.js/pull/3605/files#diff-62d613e68d1b79aefb5aa1bb89aa9eda5069f597ff2040add79a7897fb4e979d
View file https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/test/image/mocks/automargin-push-y-extra.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/3605/{{ revealButtonHref }}
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3605/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.