| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:cab4dd67-86e3-b33d-6345-482b9595e474 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 89CA:280A2E:54542E:6E9147:6B017988 |
| html-safe-nonce | bf9cbf08c34f97e3e698da9033ae5eebca1bb6cc0f8036c8577676a82877a7b2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OUNBOjI4MEEyRTo1NDU0MkU6NkU5MTQ3OjZCMDE3OTg4IiwidmlzaXRvcl9pZCI6IjYxNDc1NzA0MjI2NzEwNDcwNDgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ada1bc6a8a8b5ffe7421087635e1a3ea9da13f31c8125767f2e68f04397e7f85 |
| hovercard-subject-tag | pull_request:258116221 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/plotly/plotly.js/pull/3605/files |
| twitter:image | https://avatars.githubusercontent.com/u/6675409?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/6675409?s=400&v=4 |
| og:image:alt | fixes #3579 and #3600
Updated codepens:
https://codepen.io/etpinard/pen/aMmwRZ
https://codepen.io/etpinard/pen/bZwRmQ
cc @plotly/plotly_js |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/3605/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3605%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3605%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/3605/files |
| Reload | https://github.com/plotly/plotly.js/pull/3605/files |
| Reload | https://github.com/plotly/plotly.js/pull/3605/files |
| plotly | https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Code | https://github.com/plotly/plotly.js |
| Issues726 (726) | https://github.com/plotly/plotly.js/issues |
| Pull requests84 (84) | https://github.com/plotly/plotly.js/pulls |
| Actions | https://github.com/plotly/plotly.js/actions |
| Security and quality | https://github.com/plotly/plotly.js/security |
| Insights | https://github.com/plotly/plotly.js/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fplotly%2Fplotly.js%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fplotly%2Fplotly.js%2Fissues%2Fnew%2Fchoose |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| automargin-edge-cases | https://github.com/plotly/plotly.js/tree/automargin-edge-cases |
|
Conversation
11
| https://github.com/plotly/plotly.js/pull/3605 |
|
Commits
6
| https://github.com/plotly/plotly.js/pull/3605/commits |
|
Checks
0
| https://github.com/plotly/plotly.js/pull/3605/checks |
|
Files changed
| https://github.com/plotly/plotly.js/pull/3605/files |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3605/files |
|
Automargin edge cases
| https://github.com/plotly/plotly.js/pull/3605/files#top |
|
Show all changes
6 commits
| https://github.com/plotly/plotly.js/pull/3605/files |
|
6c7db5e
fix #3579 - consider tick labels to go past plot area
etpinard Mar 4, 2019
| https://github.com/plotly/plotly.js/pull/3605/commits/6c7db5e2092efec967aca83f9aef1645aceb763f |
|
1f6e711
improve axis automargin tests
etpinard Mar 4, 2019
| https://github.com/plotly/plotly.js/pull/3605/commits/1f6e7119c7b4efa04e5b1a243fc919eacfe9f1e2 |
|
8a1b5e7
throw axis scaling error when ax._length is negative
etpinard Mar 4, 2019
| https://github.com/plotly/plotly.js/pull/3605/commits/8a1b5e76b0b57ed777b8c4e6ef131c0d93fb0690 |
|
87b10a7
fix #3600 - skip automargin pushes that lead to negative plot area
etpinard Mar 4, 2019
| https://github.com/plotly/plotly.js/pull/3605/commits/87b10a78ac7a8153314d76c6a1ce0aba04f2fb4b |
|
d5bacfe
:camel: case
etpinard Mar 5, 2019
| https://github.com/plotly/plotly.js/pull/3605/commits/d5bacfefbc0d75cfaf81a70a568bc27e08ed2c30 |
|
18f827d
mojtaba-proof test msgs
etpinard Mar 5, 2019
| https://github.com/plotly/plotly.js/pull/3605/commits/18f827d738fb7ac48bee45f4b7f8f164ccec28a4 |
|
Clear filters
| https://github.com/plotly/plotly.js/pull/3605/files |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3605/files |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3605/files |
|
axes.js
| https://github.com/plotly/plotly.js/pull/3605/files#diff-5f001ae7bd55867b9cfbe23508ea18384159d46c141298fa7d177cfd76194695 |
|
set_convert.js
| https://github.com/plotly/plotly.js/pull/3605/files#diff-10cca8c9eea1420164e53bbf7ed6b1bef79c17ad4116f5ecc079ed72f725da64 |
|
plots.js
| https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970 |
|
automargin-push-x-extra.png
| https://github.com/plotly/plotly.js/pull/3605/files#diff-cf8cf75c9c50d0ecd623619f9bc084c4beb01f266466be9c0edb25962c3b8c4f |
|
automargin-push-y-extra.png
| https://github.com/plotly/plotly.js/pull/3605/files#diff-75ba1bbe2aefb95e942cc9267ca95a98022dede4c99fac3bb461f1af81524342 |
|
automargin-push-x-extra.json
| https://github.com/plotly/plotly.js/pull/3605/files#diff-41af0f14d010786585268eb8d6c135c24e2b4fa77752f50a93f405beabb67758 |
|
automargin-push-y-extra.json
| https://github.com/plotly/plotly.js/pull/3605/files#diff-62d613e68d1b79aefb5aa1bb89aa9eda5069f597ff2040add79a7897fb4e979d |
|
axes_test.js
| https://github.com/plotly/plotly.js/pull/3605/files#diff-49b76cce481e5bce7093546f0260b025811410d6826842eee83019fc4b04e9bd |
| src/plots/cartesian/axes.js | https://github.com/plotly/plotly.js/pull/3605/files#diff-5f001ae7bd55867b9cfbe23508ea18384159d46c141298fa7d177cfd76194695 |
|
View file
| https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/src/plots/cartesian/axes.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/3605/{{ revealButtonHref }} |
|
| https://github.com/plotly/plotly.js/pull/3605/files#diff-5f001ae7bd55867b9cfbe23508ea18384159d46c141298fa7d177cfd76194695 |
|
| https://github.com/plotly/plotly.js/pull/3605/files#diff-5f001ae7bd55867b9cfbe23508ea18384159d46c141298fa7d177cfd76194695 |
| src/plots/cartesian/set_convert.js | https://github.com/plotly/plotly.js/pull/3605/files#diff-10cca8c9eea1420164e53bbf7ed6b1bef79c17ad4116f5ecc079ed72f725da64 |
|
View file
| https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/src/plots/cartesian/set_convert.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/3605/{{ revealButtonHref }} |
|
| https://github.com/plotly/plotly.js/pull/3605/files#diff-10cca8c9eea1420164e53bbf7ed6b1bef79c17ad4116f5ecc079ed72f725da64 |
|
| https://github.com/plotly/plotly.js/pull/3605/files#diff-10cca8c9eea1420164e53bbf7ed6b1bef79c17ad4116f5ecc079ed72f725da64 |
| src/plots/plots.js | https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970 |
|
View file
| https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/src/plots/plots.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/3605/{{ revealButtonHref }} |
|
| https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970 |
|
| https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970 |
|
| https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970 |
|
| https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970 |
|
| https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970 |
|
| https://github.com/plotly/plotly.js/pull/3605/files#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970 |
| test/image/baselines/automargin-push-x-extra.png | https://github.com/plotly/plotly.js/pull/3605/files#diff-cf8cf75c9c50d0ecd623619f9bc084c4beb01f266466be9c0edb25962c3b8c4f |
|
View file
| https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/test/image/baselines/automargin-push-x-extra.png |
|
Open in desktop
| https://desktop.github.com |
| Reload? | https://github.com/plotly/plotly.js/pull/3605/files |
| test/image/baselines/automargin-push-y-extra.png | https://github.com/plotly/plotly.js/pull/3605/files#diff-75ba1bbe2aefb95e942cc9267ca95a98022dede4c99fac3bb461f1af81524342 |
|
View file
| https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/test/image/baselines/automargin-push-y-extra.png |
|
Open in desktop
| https://desktop.github.com |
| Reload? | https://github.com/plotly/plotly.js/pull/3605/files |
| test/image/mocks/automargin-push-x-extra.json | https://github.com/plotly/plotly.js/pull/3605/files#diff-41af0f14d010786585268eb8d6c135c24e2b4fa77752f50a93f405beabb67758 |
|
View file
| https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/test/image/mocks/automargin-push-x-extra.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/3605/{{ revealButtonHref }} |
| test/image/mocks/automargin-push-y-extra.json | https://github.com/plotly/plotly.js/pull/3605/files#diff-62d613e68d1b79aefb5aa1bb89aa9eda5069f597ff2040add79a7897fb4e979d |
|
View file
| https://github.com/plotly/plotly.js/blob/18f827d738fb7ac48bee45f4b7f8f164ccec28a4/test/image/mocks/automargin-push-y-extra.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/3605/{{ revealButtonHref }} |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3605/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |