| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:c4d7110b-7f30-0b4b-1d91-c08a71e59fde |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AD1E:27E2F7:5F9F7E:7F821E:6A52FDE9 |
| html-safe-nonce | 107488f629f56c1394e200ddad33888e6d04fad1c214b9a2d183577c15fc25f8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDFFOjI3RTJGNzo1RjlGN0U6N0Y4MjFFOjZBNTJGREU5IiwidmlzaXRvcl9pZCI6IjQ2MTQ0NDczODI0MDkzNzQ0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c631966de68cf0de93e68fed16e6795491d7141334bfadf3169d1d13a7305571 |
| hovercard-subject-tag | pull_request:64074000 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/356/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5215449c1d8eed500be0f26f515bb9d25fa89c84c3813d2eacc9360106df65ca/plotly/plotly.js/pull/356 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5215449c1d8eed500be0f26f515bb9d25fa89c84c3813d2eacc9360106df65ca/plotly/plotly.js/pull/356 |
| og:image:alt | This is my first attempt at addressing #348 and plotly/plotly.R#525. In summary, I
moved some code out of the if(firstRender==true block as suggested in @etpinard issue comment
fixed clipPath ent... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | timelyportfolio |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/356#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F356 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F356 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/356 |
| Reload | https://github.com/plotly/plotly.js/pull/356 |
| Reload | https://github.com/plotly/plotly.js/pull/356 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
773
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
60
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| timelyportfolio | https://github.com/timelyportfolio |
| plotly:master | https://github.com/plotly/plotly.js/tree/master |
| timelyportfolio:fix/legend-resize | https://github.com/timelyportfolio/plotly.js/tree/fix/legend-resize |
| Conversation | https://github.com/plotly/plotly.js/pull/356 |
| Commits4 (4) | https://github.com/plotly/plotly.js/pull/356/commits |
| Checks | https://github.com/plotly/plotly.js/pull/356/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/356/files |
| Fix/legend resize | https://github.com/plotly/plotly.js/pull/356#top |
| timelyportfolio | https://github.com/timelyportfolio |
| plotly:master | https://github.com/plotly/plotly.js/tree/master |
| timelyportfolio:fix/legend-resize | https://github.com/timelyportfolio/plotly.js/tree/fix/legend-resize |
|
| https://github.com/timelyportfolio |
| timelyportfolio | https://github.com/timelyportfolio |
| Mar 24, 2016 | https://github.com/plotly/plotly.js/pull/356#issue-143317505 |
| #348 | https://github.com/plotly/plotly.js/issues/348 |
| plotly/plotly.R#525 | https://github.com/plotly/plotly.R/issues/525 |
| @etpinard issue comment | https://github.com/plotly/plotly.js/issues/348#issuecomment-200411524 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| etpinard | https://github.com/etpinard |
| March 23, 2016 15:02 | https://github.com/plotly/plotly.js/pull/356#commits-pushed-52f1a3c |
|
| https://github.com/etpinard |
|
| https://github.com/timelyportfolio |
| incremental progress toward working scrolling legend after resize | https://github.com/plotly/plotly.js/pull/356/commits/52f1a3c686daea20e3ebd798a84416201d7808b2 |
| 52f1a3c | https://github.com/plotly/plotly.js/pull/356/commits/52f1a3c686daea20e3ebd798a84416201d7808b2 |
|
| https://github.com/timelyportfolio |
| change legend scrollbar drag to d3 drag behavior | https://github.com/plotly/plotly.js/pull/356/commits/197f7fa1cf4bb903fade6e44a2c9322546ee9eff |
| 197f7fa | https://github.com/plotly/plotly.js/pull/356/commits/197f7fa1cf4bb903fade6e44a2c9322546ee9eff |
| https://github.com/timelyportfolio |
| timelyportfolio | https://github.com/timelyportfolio |
| Mar 24, 2016 | https://github.com/plotly/plotly.js/pull/356#issuecomment-200953513 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
|
| https://github.com/timelyportfolio |
| lint | https://github.com/plotly/plotly.js/pull/356/commits/94bd5fffce7b0b4055ea7f7604a5569cf794e1ee |
| 94bd5ff | https://github.com/plotly/plotly.js/pull/356/commits/94bd5fffce7b0b4055ea7f7604a5569cf794e1ee |
| https://github.com/timelyportfolio |
| timelyportfolio | https://github.com/timelyportfolio |
| force-pushed | https://github.com/plotly/plotly.js/compare/fd2351cbfdc4ccdb79211776791595b44b66f46d..94bd5fffce7b0b4055ea7f7604a5569cf794e1ee |
| fd2351c | https://github.com/plotly/plotly.js/commit/fd2351cbfdc4ccdb79211776791595b44b66f46d |
| 94bd5ff | https://github.com/plotly/plotly.js/commit/94bd5fffce7b0b4055ea7f7604a5569cf794e1ee |
|
Compare
| https://github.com/plotly/plotly.js/compare/fd2351cbfdc4ccdb79211776791595b44b66f46d..94bd5fffce7b0b4055ea7f7604a5569cf794e1ee |
| March 24, 2016 18:31 | https://github.com/plotly/plotly.js/pull/356#event-602158869 |
| mdtusz | https://github.com/mdtusz |
|
Mar 24, 2016
| https://github.com/plotly/plotly.js/pull/356#discussion-diff-57395611 |
| View reviewed changes
| https://github.com/plotly/plotly.js/pull/356/files/94bd5fffce7b0b4055ea7f7604a5569cf794e1ee#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578 |
| src/components/legend/draw.js | https://github.com/plotly/plotly.js/pull/356/files#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578 |
| mdtusz | https://github.com/mdtusz |
| Mar 24, 2016 | https://github.com/plotly/plotly.js/pull/356#discussion_r57395611 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| timelyportfolio | https://github.com/timelyportfolio |
| Mar 24, 2016 | https://github.com/plotly/plotly.js/pull/356#discussion_r57396058 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| https://github.com/mdtusz |
| mdtusz | https://github.com/mdtusz |
| Mar 24, 2016 | https://github.com/plotly/plotly.js/pull/356#issuecomment-201045176 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Mar 25, 2016 | https://github.com/plotly/plotly.js/pull/356#issuecomment-201337454 |
| d3-selection | https://github.com/d3/d3-selection#handling-events |
| @timelyportfolio | https://github.com/timelyportfolio |
| case | https://github.com/plotly/plotly.js/blob/bbb8205903cdd34ae019d5cd6a2c197e9a2550e7/test/jasmine/tests/legend_scroll_test.js#L80 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Mar 28, 2016 | https://github.com/plotly/plotly.js/pull/356#issuecomment-202576909 |
| @timelyportfolio | https://github.com/timelyportfolio |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| https://github.com/timelyportfolio |
| timelyportfolio | https://github.com/timelyportfolio |
| Mar 29, 2016 | https://github.com/plotly/plotly.js/pull/356#issuecomment-202868225 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Mar 29, 2016 | https://github.com/plotly/plotly.js/pull/356#issuecomment-202889052 |
| @timelyportfolio | https://github.com/timelyportfolio |
| example | http://community.plot.ly/t/default-showlegend-changed-with-update/708/2 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| https://github.com/timelyportfolio |
| timelyportfolio | https://github.com/timelyportfolio |
| Mar 29, 2016 | https://github.com/plotly/plotly.js/pull/356#issuecomment-202908582 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| https://github.com/timelyportfolio |
| timelyportfolio | https://github.com/timelyportfolio |
| force-pushed | https://github.com/plotly/plotly.js/compare/c012d741b761a419bdfe446e6f70b8c5fe766b25..43d430c7c1889fa3ef5d0b7722d88698752359a0 |
| c012d74 | https://github.com/plotly/plotly.js/commit/c012d741b761a419bdfe446e6f70b8c5fe766b25 |
| 43d430c | https://github.com/plotly/plotly.js/commit/43d430c7c1889fa3ef5d0b7722d88698752359a0 |
|
Compare
| https://github.com/plotly/plotly.js/compare/c012d741b761a419bdfe446e6f70b8c5fe766b25..43d430c7c1889fa3ef5d0b7722d88698752359a0 |
| March 29, 2016 21:22 | https://github.com/plotly/plotly.js/pull/356#event-607357074 |
| mdtusz | https://github.com/mdtusz |
|
Mar 29, 2016
| https://github.com/plotly/plotly.js/pull/356#discussion-diff-57804561 |
| View reviewed changes
| https://github.com/plotly/plotly.js/pull/356/files/94bd5fffce7b0b4055ea7f7604a5569cf794e1ee..43d430c7c1889fa3ef5d0b7722d88698752359a0#diff-1c9011cecef7c5fa1a9ae135b7282735601013c5e703ee0da2f47853c0f462ba |
| test/jasmine/tests/legend_scroll_test.js | https://github.com/plotly/plotly.js/pull/356/files#diff-1c9011cecef7c5fa1a9ae135b7282735601013c5e703ee0da2f47853c0f462ba |
| mdtusz | https://github.com/mdtusz |
| Mar 29, 2016 | https://github.com/plotly/plotly.js/pull/356#discussion_r57804561 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| timelyportfolio | https://github.com/timelyportfolio |
| Mar 29, 2016 | https://github.com/plotly/plotly.js/pull/356#discussion_r57805289 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| https://github.com/timelyportfolio |
| timelyportfolio | https://github.com/timelyportfolio |
| force-pushed | https://github.com/plotly/plotly.js/compare/a565dc691c946403425da92f68c702f0c6a2586b..3e6b949354b2f9e6f906d9879f716699d9d27221 |
| a565dc6 | https://github.com/plotly/plotly.js/commit/a565dc691c946403425da92f68c702f0c6a2586b |
| 3e6b949 | https://github.com/plotly/plotly.js/commit/3e6b949354b2f9e6f906d9879f716699d9d27221 |
|
Compare
| https://github.com/plotly/plotly.js/compare/a565dc691c946403425da92f68c702f0c6a2586b..3e6b949354b2f9e6f906d9879f716699d9d27221 |
| March 30, 2016 03:00 | https://github.com/plotly/plotly.js/pull/356#event-607640758 |
|
| https://github.com/timelyportfolio |
| add tests for legend resize and this forum [post]( | https://github.com/plotly/plotly.js/pull/356/commits/3e6b949354b2f9e6f906d9879f716699d9d27221 |
| http://community.pl… | http://community.plot.ly/t/default-showlegend-changed-with-update/708 |
| 3e6b949 | https://github.com/plotly/plotly.js/pull/356/commits/3e6b949354b2f9e6f906d9879f716699d9d27221 |
| …ot.ly/t/default-showlegend-changed-with-update/708 | http://community.plot.ly/t/default-showlegend-changed-with-update/708 |
| https://github.com/timelyportfolio |
| timelyportfolio | https://github.com/timelyportfolio |
| Mar 30, 2016 | https://github.com/plotly/plotly.js/pull/356#issuecomment-203227143 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Mar 30, 2016
| https://github.com/plotly/plotly.js/pull/356#ref-pullrequest-144596594 |
|
Legend fixups [fixes #348]
#365
| https://github.com/plotly/plotly.js/pull/365 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Mar 30, 2016 | https://github.com/plotly/plotly.js/pull/356#issuecomment-203438699 |
| @timelyportfolio | https://github.com/timelyportfolio |
| #365 | https://github.com/plotly/plotly.js/pull/365 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Mar 30, 2016 | https://github.com/plotly/plotly.js/pull/356#event-608277669 |
| https://github.com/timelyportfolio |
| timelyportfolio | https://github.com/timelyportfolio |
| Mar 30, 2016 | https://github.com/plotly/plotly.js/pull/356#issuecomment-203449128 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F356 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/356 |
|
| https://github.com/timelyportfolio |
|
| https://github.com/mdtusz |
|
| https://github.com/etpinard |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |