| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:925fdba6-a07c-73d7-25f0-32c4e9a38eee |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BF00:363D8E:2D8AF2D:39C2ACB:6B01A13F |
| html-safe-nonce | e4bbcaf9faefe698e341ce9933c49c23d509264c05c93495b75782b050936a6d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRjAwOjM2M0Q4RToyRDhBRjJEOjM5QzJBQ0I6NkIwMUExM0YiLCJ2aXNpdG9yX2lkIjoiNzc2MDA1OTg3NDY5NTgxNTQ4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b4847982dc610f54b27324b42e1361b7cc910f770cfa9ad75b7e0425f9ab38ca |
| hovercard-subject-tag | pull_request:251758109 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/3531/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/afeb4610290fe3abee60ca65136f60121dbb844ab92f850d5223957423f40d1e/plotly/plotly.js/pull/3531 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/afeb4610290fe3abee60ca65136f60121dbb844ab92f850d5223957423f40d1e/plotly/plotly.js/pull/3531 |
| og:image:alt | Fixes #3037.
A prototype for waterfall new trace type mainly based on bar.
TODO:
add a selection test
Why aren't arrayOk offset and width working?
add total color container an keep marker s... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | archmoj |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/plotly/plotly.js/pull/3531#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3531 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3531 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/3531 |
| Reload | https://github.com/plotly/plotly.js/pull/3531 |
| Reload | https://github.com/plotly/plotly.js/pull/3531 |
| plotly | https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Code | https://github.com/plotly/plotly.js |
| Issues726 (726) | https://github.com/plotly/plotly.js/issues |
| Pull requests84 (84) | https://github.com/plotly/plotly.js/pulls |
| Actions | https://github.com/plotly/plotly.js/actions |
| Security and quality | https://github.com/plotly/plotly.js/security |
| Insights | https://github.com/plotly/plotly.js/insights |
| https://github.com/plotly/plotly.js |
| archmoj | https://github.com/archmoj |
| master | https://github.com/plotly/plotly.js/tree/master |
| waterfall-new-trace | https://github.com/plotly/plotly.js/tree/waterfall-new-trace |
| Conversation | https://github.com/plotly/plotly.js/pull/3531 |
| Commits78 (78) | https://github.com/plotly/plotly.js/pull/3531/commits |
| Checks | https://github.com/plotly/plotly.js/pull/3531/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/3531/files |
| Waterfall charts | https://github.com/plotly/plotly.js/pull/3531#top |
| archmoj | https://github.com/archmoj |
| master | https://github.com/plotly/plotly.js/tree/master |
| waterfall-new-trace | https://github.com/plotly/plotly.js/tree/waterfall-new-trace |
|
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Feb 10, 2019 | https://github.com/plotly/plotly.js/pull/3531#issue-408566708 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| #3037 | https://github.com/plotly/plotly.js/issues/3037 |
| codepen | https://codepen.io/MojtabaSamimi/pen/BbmVVd?editors=0010 |
| https://user-images.githubusercontent.com/33888540/54249913-390a0380-4518-11e9-95a0-5b288c71faae.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
|
| https://github.com/archmoj |
| started waterfall | https://github.com/plotly/plotly.js/pull/3531/commits/8f8956432ed18368fb6d3f70107b94bbfb39a528 |
| 8f89564 | https://github.com/plotly/plotly.js/pull/3531/commits/8f8956432ed18368fb6d3f70107b94bbfb39a528 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
|
status: in progress
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22 |
| Feb 10, 2019 | https://github.com/plotly/plotly.js/pull/3531#event-2129355851 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Feb 10, 2019
| https://github.com/plotly/plotly.js/pull/3531#pullrequestreview-201917345 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528 |
| src/traces/bar/calc.js | https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528#diff-062540bc1aa3e35833bcb304349c4ed9464ae1828c07e2850015ce3745610158 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Feb 10, 2019
| https://github.com/plotly/plotly.js/pull/3531#pullrequestreview-201917412 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528 |
| src/traces/bar/cross_trace_calc.js | https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528#diff-c208c1bdc6f02ecae06b5caa367e5c4c8df7d14a6f3ccdcf50e358b920f966c1 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Feb 10, 2019
| https://github.com/plotly/plotly.js/pull/3531#pullrequestreview-201917656 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528 |
| src/traces/bar/calc.js | https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528#diff-062540bc1aa3e35833bcb304349c4ed9464ae1828c07e2850015ce3745610158 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Feb 10, 2019
| https://github.com/plotly/plotly.js/pull/3531#pullrequestreview-201917715 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528 |
| src/traces/waterfall/attributes.js | https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528#diff-1a4d1a1f8eacd6c83cb7ffecb68777041c3d5c9ee138ef617bb8c72d43e8cd93 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Feb 10, 2019
| https://github.com/plotly/plotly.js/pull/3531#pullrequestreview-201917796 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528 |
| src/traces/waterfall/index.js | https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528#diff-f71da6eda0c882fa0c86814f75d8b70b53a64e920fd6e7333ad4201fa5bc007c |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Feb 10, 2019
| https://github.com/plotly/plotly.js/pull/3531#pullrequestreview-201918007 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528 |
| src/traces/waterfall/attributes.js | https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528#diff-1a4d1a1f8eacd6c83cb7ffecb68777041c3d5c9ee138ef617bb8c72d43e8cd93 |
| etpinard | https://github.com/etpinard |
| Feb 10, 2019 | https://github.com/plotly/plotly.js/pull/3531#discussion_r255352097 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| plotly.js/src/traces/ohlc/attributes.js | https://github.com/plotly/plotly.js/blob/02e51d8f5ba5601f53ee3dc839ba05fb12c7f8a2/src/traces/ohlc/attributes.js#L89-L91 |
| 02e51d8 | https://github.com/plotly/plotly.js/commit/02e51d8f5ba5601f53ee3dc839ba05fb12c7f8a2 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Feb 10, 2019
| https://github.com/plotly/plotly.js/pull/3531#pullrequestreview-201918101 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528 |
| src/traces/waterfall/attributes.js | https://github.com/plotly/plotly.js/pull/3531/files/8f8956432ed18368fb6d3f70107b94bbfb39a528#diff-1a4d1a1f8eacd6c83cb7ffecb68777041c3d5c9ee138ef617bb8c72d43e8cd93 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Feb 10, 2019 | https://github.com/plotly/plotly.js/pull/3531#issuecomment-462165705 |
| @archmoj | https://github.com/archmoj |
| #3531 (comment) | https://github.com/plotly/plotly.js/pull/3531#discussion_r255351883 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Feb 11, 2019 | https://github.com/plotly/plotly.js/pull/3531#issuecomment-462199103 |
| @archmoj | https://github.com/archmoj |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| archmoj | https://github.com/archmoj |
| February 11, 2019 11:14 | https://github.com/plotly/plotly.js/pull/3531#commits-pushed-5678653 |
|
| https://github.com/archmoj |
| rm traceIs waterfall as it described as bar | https://github.com/plotly/plotly.js/pull/3531/commits/56786530ff31d865aefd30ad4ebab4cff7487f94 |
| 5678653 | https://github.com/plotly/plotly.js/pull/3531/commits/56786530ff31d865aefd30ad4ebab4cff7487f94 |
|
| https://github.com/archmoj |
| isFall > isSum as we may use rise and fall for positive and negative … | https://github.com/plotly/plotly.js/pull/3531/commits/cfe8eb287bcf7106a876e5ec2ee65e4fdf24515c |
| cfe8eb2 | https://github.com/plotly/plotly.js/pull/3531/commits/cfe8eb287bcf7106a876e5ec2ee65e4fdf24515c |
|
| https://github.com/archmoj |
| separated calc for waterfall - pass 1 | https://github.com/plotly/plotly.js/pull/3531/commits/dbc98b505f776a663366d8084de1421c684c2ffa |
| dbc98b5 | https://github.com/plotly/plotly.js/pull/3531/commits/dbc98b505f776a663366d8084de1421c684c2ffa |
|
| https://github.com/archmoj |
| removed barnorm stack and base | https://github.com/plotly/plotly.js/pull/3531/commits/acc36402705fc431189e32baf389df80ae679582 |
| acc3640 | https://github.com/plotly/plotly.js/pull/3531/commits/acc36402705fc431189e32baf389df80ae679582 |
|
| https://github.com/archmoj |
| removed more useless mocks | https://github.com/plotly/plotly.js/pull/3531/commits/9537ee8410aca13db1068cccc91a55bddb71f7da |
| 9537ee8 | https://github.com/plotly/plotly.js/pull/3531/commits/9537ee8410aca13db1068cccc91a55bddb71f7da |
|
| https://github.com/archmoj |
| easier to use api | https://github.com/plotly/plotly.js/pull/3531/commits/6be0a4a385d6b5778df05c25ddd819241fd4b690 |
| 6be0a4a | https://github.com/plotly/plotly.js/pull/3531/commits/6be0a4a385d6b5778df05c25ddd819241fd4b690 |
|
| https://github.com/archmoj |
| new baselines | https://github.com/plotly/plotly.js/pull/3531/commits/d6a69f28a9fdae76df079df57833aec91a79263e |
| d6a69f2 | https://github.com/plotly/plotly.js/pull/3531/commits/d6a69f28a9fdae76df079df57833aec91a79263e |
|
| https://github.com/archmoj |
| handle undefined cases in extract instructions | https://github.com/plotly/plotly.js/pull/3531/commits/34b6a0a7c210400fb2f696eff9959b8392c2b1af |
| 34b6a0a | https://github.com/plotly/plotly.js/pull/3531/commits/34b6a0a7c210400fb2f696eff9959b8392c2b1af |
|
| https://github.com/archmoj |
| new baselines | https://github.com/plotly/plotly.js/pull/3531/commits/aa585717f37060f79eebf9543301ad18a75490a4 |
| aa58571 | https://github.com/plotly/plotly.js/pull/3531/commits/aa585717f37060f79eebf9543301ad18a75490a4 |
|
| https://github.com/archmoj |
| auto compute color array based on vals when array left empty | https://github.com/plotly/plotly.js/pull/3531/commits/6a4666aa154c93e2e450752c81013a4c83768333 |
| 6a4666a | https://github.com/plotly/plotly.js/pull/3531/commits/6a4666aa154c93e2e450752c81013a4c83768333 |
|
| https://github.com/archmoj |
| new baselines | https://github.com/plotly/plotly.js/pull/3531/commits/3fb35974210a4f4682c44fa0a5b6d5b13d35bd7c |
| 3fb3597 | https://github.com/plotly/plotly.js/pull/3531/commits/3fb35974210a4f4682c44fa0a5b6d5b13d35bd7c |
|
| https://github.com/archmoj |
| defualt to remove instructions from ax text | https://github.com/plotly/plotly.js/pull/3531/commits/dc1b4204a75081b7ab1b5c9ee188a33c58ad29f8 |
| dc1b420 | https://github.com/plotly/plotly.js/pull/3531/commits/dc1b4204a75081b7ab1b5c9ee188a33c58ad29f8 |
|
| https://github.com/archmoj |
| only accept valid tokens | https://github.com/plotly/plotly.js/pull/3531/commits/f8507ce69372e6565114b81c3eb62e08c8a1d0b9 |
| f8507ce | https://github.com/plotly/plotly.js/pull/3531/commits/f8507ce69372e6565114b81c3eb62e08c8a1d0b9 |
|
| https://github.com/archmoj |
| new baselines | https://github.com/plotly/plotly.js/pull/3531/commits/a875ac7396daf575d618b45c462c7876314f8180 |
| a875ac7 | https://github.com/plotly/plotly.js/pull/3531/commits/a875ac7396daf575d618b45c462c7876314f8180 |
|
| https://github.com/archmoj |
| only run waterfalls on CI for now | https://github.com/plotly/plotly.js/pull/3531/commits/69956a019e02e7fff0516e3fb684daf3c5e3197f |
| 69956a0 | https://github.com/plotly/plotly.js/pull/3531/commits/69956a019e02e7fff0516e3fb684daf3c5e3197f |
|
| https://github.com/archmoj |
| use operators instead of instr and token | https://github.com/plotly/plotly.js/pull/3531/commits/82dfd189834928337f09a8a38abfd7d223469106 |
| 82dfd18 | https://github.com/plotly/plotly.js/pull/3531/commits/82dfd189834928337f09a8a38abfd7d223469106 |
|
| https://github.com/archmoj |
| handle initial values | https://github.com/plotly/plotly.js/pull/3531/commits/87ad17c1f7373bcc9509082a9b3bc5ede0f53b20 |
| 87ad17c | https://github.com/plotly/plotly.js/pull/3531/commits/87ad17c1f7373bcc9509082a9b3bc5ede0f53b20 |
|
| https://github.com/archmoj |
| correct baselines cases without an initial value | https://github.com/plotly/plotly.js/pull/3531/commits/b0fdceda91abdbf2ccfccde1b4106db208931ea5 |
| b0fdced | https://github.com/plotly/plotly.js/pull/3531/commits/b0fdceda91abdbf2ccfccde1b4106db208931ea5 |
| archmoj | https://github.com/archmoj |
| March 27, 2019 12:22 | https://github.com/plotly/plotly.js/pull/3531#commits-pushed-2a25753 |
|
| https://github.com/archmoj |
| dont coerce connector if visible false | https://github.com/plotly/plotly.js/pull/3531/commits/2a25753c9cfae9d3ea7291c27912ae22635b2683 |
| 2a25753 | https://github.com/plotly/plotly.js/pull/3531/commits/2a25753c9cfae9d3ea7291c27912ae22635b2683 |
|
| https://github.com/archmoj |
| turn connector.(color|dash|width) into -> connector.line.(color|dash|… | https://github.com/plotly/plotly.js/pull/3531/commits/1825027b9ef5e08a302949c9ac0f852512e51630 |
| 1825027 | https://github.com/plotly/plotly.js/pull/3531/commits/1825027b9ef5e08a302949c9ac0f852512e51630 |
|
| https://github.com/archmoj |
| make restyle connector visible (true|false) work | https://github.com/plotly/plotly.js/pull/3531/commits/4a044e42ac7fea7f8efea4da7e90b4b4183b0fb7 |
| 4a044e4 | https://github.com/plotly/plotly.js/pull/3531/commits/4a044e42ac7fea7f8efea4da7e90b4b4183b0fb7 |
|
| https://github.com/archmoj |
| fixup restyle connector visible remove nodes | https://github.com/plotly/plotly.js/pull/3531/commits/c53bcce408bcda2b47960d15557c28aa03ca81ab |
| c53bcce | https://github.com/plotly/plotly.js/pull/3531/commits/c53bcce408bcda2b47960d15557c28aa03ca81ab |
|
| https://github.com/archmoj |
| added connector restyle visible true false | https://github.com/plotly/plotly.js/pull/3531/commits/3b984ff752b08add66f5d0a914efbb92735de21b |
| 3b984ff | https://github.com/plotly/plotly.js/pull/3531/commits/3b984ff752b08add66f5d0a914efbb92735de21b |
|
| https://github.com/archmoj |
| no need to loop over all the traces when waterfallmode is not group | https://github.com/plotly/plotly.js/pull/3531/commits/6b3eeab43c5d7ea382bd47306fd355367df14a9b |
| 6b3eeab | https://github.com/plotly/plotly.js/pull/3531/commits/6b3eeab43c5d7ea382bd47306fd355367df14a9b |
|
| https://github.com/etpinard |
| make waterfall NOT a 'bar' category | https://github.com/plotly/plotly.js/pull/3531/commits/ce0a56aa96c437bd1164a920e637a71cf4e19699 |
| ce0a56a | https://github.com/plotly/plotly.js/pull/3531/commits/ce0a56aa96c437bd1164a920e637a71cf4e19699 |
|
| https://github.com/etpinard |
| revamp waterfall marker style logic | https://github.com/plotly/plotly.js/pull/3531/commits/412bf9d3ee04c8674a16ea4d9b722d8d324df953 |
| 412bf9d | https://github.com/plotly/plotly.js/pull/3531/commits/412bf9d3ee04c8674a16ea4d9b722d8d324df953 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Mar 27, 2019 | https://github.com/plotly/plotly.js/pull/3531#issuecomment-477379792 |
| master...waterfall_tests-tmp | https://github.com/plotly/plotly.js/compare/master...waterfall_tests-tmp |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| Mar 28, 2019 | https://github.com/plotly/plotly.js/pull/3531#issuecomment-477407967 |
| master...waterfall_tests-tmp | https://github.com/plotly/plotly.js/compare/master...waterfall_tests-tmp |
| @etpinard | https://github.com/etpinard |
| waterfall_tests-tmp...waterfall_more-tests | https://github.com/plotly/plotly.js/compare/waterfall_tests-tmp...waterfall_more-tests |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| etpinard | https://github.com/etpinard |
| March 28, 2019 10:07 | https://github.com/plotly/plotly.js/pull/3531#commits-pushed-a55777f |
|
| https://github.com/etpinard |
|
| https://github.com/archmoj |
| 🔪 [un]selected style container for waterfall (for now) | https://github.com/plotly/plotly.js/pull/3531/commits/a55777faf9acd6731e8c059a752b4966498bbb33 |
| a55777f | https://github.com/plotly/plotly.js/pull/3531/commits/a55777faf9acd6731e8c059a752b4966498bbb33 |
|
| https://github.com/etpinard |
|
| https://github.com/archmoj |
| do not show hover label when size===0 | https://github.com/plotly/plotly.js/pull/3531/commits/dee39dc5e02afc7c8c94560d47cd4688b557194f |
| dee39dc | https://github.com/plotly/plotly.js/pull/3531/commits/dee39dc5e02afc7c8c94560d47cd4688b557194f |
|
| https://github.com/etpinard |
|
| https://github.com/archmoj |
| adapt waterfall legend to new *marker* styles ... | https://github.com/plotly/plotly.js/pull/3531/commits/a138ebde72d83f6affdb417c51fba415fca2848f |
| a138ebd | https://github.com/plotly/plotly.js/pull/3531/commits/a138ebde72d83f6affdb417c51fba415fca2848f |
|
| https://github.com/etpinard |
|
| https://github.com/archmoj |
| fixup (from 🔪 'bar' category commit) | https://github.com/plotly/plotly.js/pull/3531/commits/7019a1235e03259726f88d1cef84f4bc1bfb10a8 |
| 7019a12 | https://github.com/plotly/plotly.js/pull/3531/commits/7019a1235e03259726f88d1cef84f4bc1bfb10a8 |
|
| https://github.com/etpinard |
|
| https://github.com/archmoj |
| fixup waterfall mocks and baselines | https://github.com/plotly/plotly.js/pull/3531/commits/8bbc86341e4171ef5d5f04778d4978fd9629374e |
| 8bbc863 | https://github.com/plotly/plotly.js/pull/3531/commits/8bbc86341e4171ef5d5f04778d4978fd9629374e |
|
| https://github.com/etpinard |
|
| https://github.com/archmoj |
| fixup mock list | https://github.com/plotly/plotly.js/pull/3531/commits/b6fdaed9ea16f737dee10d2613b746dbabe0a90a |
| b6fdaed | https://github.com/plotly/plotly.js/pull/3531/commits/b6fdaed9ea16f737dee10d2613b746dbabe0a90a |
|
| https://github.com/archmoj |
| adapt failing waterfall jasmine tests | https://github.com/plotly/plotly.js/pull/3531/commits/cb8f1ecda3d3e8cab9c6a1bd8a37501cafd672db |
| cb8f1ec | https://github.com/plotly/plotly.js/pull/3531/commits/cb8f1ecda3d3e8cab9c6a1bd8a37501cafd672db |
|
| https://github.com/etpinard |
|
| https://github.com/archmoj |
| fixup waterfall bar path query | https://github.com/plotly/plotly.js/pull/3531/commits/1447b401900974b19f308db26eeca1a7d447f7ca |
| 1447b40 | https://github.com/plotly/plotly.js/pull/3531/commits/1447b401900974b19f308db26eeca1a7d447f7ca |
|
| https://github.com/archmoj |
| add a flaky flag for one test | https://github.com/plotly/plotly.js/pull/3531/commits/4eb5dafc041e51aa251e99da9abae41884e31f05 |
| 4eb5daf | https://github.com/plotly/plotly.js/pull/3531/commits/4eb5dafc041e51aa251e99da9abae41884e31f05 |
|
| https://github.com/archmoj |
| waterfall marker description - set default to between mode - added sp… | https://github.com/plotly/plotly.js/pull/3531/commits/f3a071e48251fe9bb66895760c0d3d5f9d1795a1 |
| f3a071e | https://github.com/plotly/plotly.js/pull/3531/commits/f3a071e48251fe9bb66895760c0d3d5f9d1795a1 |
|
| https://github.com/archmoj |
| fix waterfall connectors - not to draw lines between null amounts - u… | https://github.com/plotly/plotly.js/pull/3531/commits/1721ab7895542f75ee11910c11cabe48f88324e2 |
| 1721ab7 | https://github.com/plotly/plotly.js/pull/3531/commits/1721ab7895542f75ee11910c11cabe48f88324e2 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
|
status: in progress
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22 |
| Mar 28, 2019 | https://github.com/plotly/plotly.js/pull/3531#event-2237205569 |
| archmoj | https://github.com/archmoj |
| March 28, 2019 14:49 | https://github.com/plotly/plotly.js/pull/3531#commits-pushed-7655664 |
|
| https://github.com/archmoj |
| Merge remote-tracking branch 'origin/master' into waterfall-new-trace | https://github.com/plotly/plotly.js/pull/3531/commits/765566414e3b6aefdf66fc71a52835a343101b21 |
| 7655664 | https://github.com/plotly/plotly.js/pull/3531/commits/765566414e3b6aefdf66fc71a52835a343101b21 |
|
| https://github.com/archmoj |
| set a noCI flag for the select test | https://github.com/plotly/plotly.js/pull/3531/commits/1d275f5bee088c8865b82947374b18c008659e2d |
| 1d275f5 | https://github.com/plotly/plotly.js/pull/3531/commits/1d275f5bee088c8865b82947374b18c008659e2d |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Mar 28, 2019 | https://github.com/plotly/plotly.js/pull/3531#issuecomment-477747969 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| 978303e | https://github.com/plotly/plotly.js/commit/978303e86ee470c7fdfb02d70b09517936d4eb73 |
| Mar 28, 2019 | https://github.com/plotly/plotly.js/pull/3531#event-2237438914 |
| https://github.com/archmoj |
| archmoj | https://github.com/archmoj |
| March 28, 2019 20:01 | https://github.com/plotly/plotly.js/pull/3531#event-2237448306 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Apr 1, 2019
| https://github.com/plotly/plotly.js/pull/3531#ref-pullrequest-427792751 |
|
Add waterfall trace to finance bundle
#3708
| https://github.com/plotly/plotly.js/pull/3708 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Jun 27, 2022
| https://github.com/plotly/plotly.js/pull/3531#ref-issue-543459754 |
|
add stacked waterfall charts
#4450
| https://github.com/plotly/plotly.js/issues/4450 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3531 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/3531/files/346c63723452e14368e349f796a0d886cbbd9e8e |
|
| https://github.com/etpinard |
|
etpinard
| https://github.com/etpinard |
|
| https://github.com/plotly/plotly.js/pull/3531/files/2a25753c9cfae9d3ea7291c27912ae22635b2683 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
|
v1.46.0
| https://github.com/plotly/plotly.js/milestone/42 |
|
Waterfall trace type
| https://github.com/plotly/plotly.js/issues/3037 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3531 |
|
| https://github.com/archmoj |
|
| https://github.com/etpinard |
|
| https://github.com/nicolaskruchten |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |