René's URL Explorer Experiment


Title: Fix scatter fill regression by etpinard · Pull Request #3168 · plotly/plotly.js · GitHub

Open Graph Title: Fix scatter fill regression by etpinard · Pull Request #3168 · plotly/plotly.js

X Title: Fix scatter fill regression by etpinard · Pull Request #3168 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Fix scatter fill regression by etpinard · Pull Request #3168 · plotly/plotly.js

Open Graph Description: This PR fixes an unreleased regression originating from #3087. I'd like to get this in before the 1.42.0 release. Scatter fills on master currently do not restyle correctly and lead to these lo...

X Description: This PR fixes an unreleased regression originating from #3087. I'd like to get this in before the 1.42.0 release. Scatter fills on master currently do not restyle correctly and lead to thes...

Opengraph URL: https://github.com/plotly/plotly.js/pull/3168

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:71ba7f87-a43a-4b98-6ea0-830c6d3a59cb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB292:29DE49:D90935:1206512:6A528CCA
html-safe-nonce516b7a90ff19e225013cd6006dd3286140a4d06e35fa54f35cb5b3abfe14970b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjkyOjI5REU0OTpEOTA5MzU6MTIwNjUxMjo2QTUyOENDQSIsInZpc2l0b3JfaWQiOiI4OTkwNjYwMTAxOTcyMDY5NTc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd311120c7099aa2f740792c3af591e7acf9127f3770fe6244dd256847b404f8c
hovercard-subject-tagpull_request:226159582
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/3168/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/cad430b8281297d8ee3a40ba93a60cb7ebb2130fe58f265258d45bff76aa3bf2/plotly/plotly.js/pull/3168
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/cad430b8281297d8ee3a40ba93a60cb7ebb2130fe58f265258d45bff76aa3bf2/plotly/plotly.js/pull/3168
og:image:altThis PR fixes an unreleased regression originating from #3087. I'd like to get this in before the 1.42.0 release. Scatter fills on master currently do not restyle correctly and lead to these lo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameetpinard
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/3168#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3168
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3168
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/3168
Reloadhttps://github.com/plotly/plotly.js/pull/3168
Reloadhttps://github.com/plotly/plotly.js/pull/3168
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3168
plotly https://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3168
Notifications https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Fork 2k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Star 18.2k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Code https://github.com/plotly/plotly.js
Issues 773 https://github.com/plotly/plotly.js/issues
Pull requests 60 https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality 0 https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
Code https://github.com/plotly/plotly.js
Issues https://github.com/plotly/plotly.js/issues
Pull requests https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
fix-scatter-fill-regressionhttps://github.com/plotly/plotly.js/tree/fix-scatter-fill-regression
Conversationhttps://github.com/plotly/plotly.js/pull/3168
Commits2 (2)https://github.com/plotly/plotly.js/pull/3168/commits
Checkshttps://github.com/plotly/plotly.js/pull/3168/checks
Files changedhttps://github.com/plotly/plotly.js/pull/3168/files
Fix scatter fill regressionhttps://github.com/plotly/plotly.js/pull/3168#top
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
fix-scatter-fill-regressionhttps://github.com/plotly/plotly.js/tree/fix-scatter-fill-regression
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Oct 26, 2018https://github.com/plotly/plotly.js/pull/3168#issue-374462110
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3168
#3087https://github.com/plotly/plotly.js/pull/3087
https://user-images.githubusercontent.com/6675409/47579989-99a6f400-d91b-11e8-827d-a2c9b2d65e7c.png
plotly.js/src/components/drawing/index.jshttps://github.com/plotly/plotly.js/blob/0a310c99455bf7389f4bb891392c806b59d93d47/src/components/drawing/index.js#L201-L207
0a310c9https://github.com/plotly/plotly.js/commit/0a310c99455bf7389f4bb891392c806b59d93d47
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3168
etpinardhttps://github.com/etpinard
October 26, 2018 12:05https://github.com/plotly/plotly.js/pull/3168#commits-pushed-95ecdce
https://github.com/etpinard
fix scatter fill restyle regressionhttps://github.com/plotly/plotly.js/pull/3168/commits/95ecdce379ad46db9a5b96580739497633366979
95ecdcehttps://github.com/plotly/plotly.js/pull/3168/commits/95ecdce379ad46db9a5b96580739497633366979
https://github.com/etpinard
rm try-catch (useless?) in Drawing.fillGroupStylehttps://github.com/plotly/plotly.js/pull/3168/commits/1f3c10c735927d57b78151be8c4d43bdf35e53d7
1f3c10chttps://github.com/plotly/plotly.js/pull/3168/commits/1f3c10c735927d57b78151be8c4d43bdf35e53d7
https://github.com/etpinard
etpinardhttps://github.com/etpinard
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
Oct 26, 2018https://github.com/plotly/plotly.js/pull/3168#event-1929311323
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Oct 26, 2018https://github.com/plotly/plotly.js/pull/3168#issuecomment-433485034
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3168
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Oct 26, 2018https://github.com/plotly/plotly.js/pull/3168#issuecomment-433505665
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3168
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Oct 26, 2018https://github.com/plotly/plotly.js/pull/3168#issuecomment-433506111
1f3c10chttps://github.com/plotly/plotly.js/commit/1f3c10c735927d57b78151be8c4d43bdf35e53d7
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3168
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Oct 26, 2018https://github.com/plotly/plotly.js/pull/3168#issuecomment-433509738
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3168
https://github.com/etpinard
etpinardhttps://github.com/etpinard
15afd7bhttps://github.com/plotly/plotly.js/commit/15afd7b144d0ae9eb0ca8650af12cc225cfd8188
Oct 26, 2018https://github.com/plotly/plotly.js/pull/3168#event-1929593373
https://github.com/etpinard
etpinardhttps://github.com/etpinard
October 26, 2018 18:56https://github.com/plotly/plotly.js/pull/3168#event-1929593489
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Oct 30, 2018 https://github.com/plotly/plotly.js/pull/3168#ref-pullrequest-375635285
Fix modebar