| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:9d7194d2-05b1-e9a6-385a-368f03e4659d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B9DA:3D97C8:2E2CBA3:3D7BB13:6B01D67A |
| html-safe-nonce | 4c08dba03f269c533532cd3cfd8d6bc326a92a81541257fbb33e8a63ce511c60 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOURBOjNEOTdDODoyRTJDQkEzOjNEN0JCMTM6NkIwMUQ2N0EiLCJ2aXNpdG9yX2lkIjoiNzU4NTc1NDk5NjQyNDE2OTA4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 7e0819ffc007b75154763a34bdd4bdcf3447e4f429ac872e539ecb86462abe77 |
| hovercard-subject-tag | pull_request:225539791 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/3150/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/b9147187fb3a598ca5b9f1ddafcc01ec99cfb89cd0dcdda3241c8df25972bd42/plotly/plotly.js/pull/3150 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b9147187fb3a598ca5b9f1ddafcc01ec99cfb89cd0dcdda3241c8df25972bd42/plotly/plotly.js/pull/3150 |
| og:image:alt | Addressing comments of @etpinard on PR #3096.
Replace .map call by Lib.repeat
Enable trace-level hover(info|label)
I also DRYed up some tests! |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | antoinerg |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/plotly/plotly.js/pull/3150#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3150 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3150 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/3150 |
| Reload | https://github.com/plotly/plotly.js/pull/3150 |
| Reload | https://github.com/plotly/plotly.js/pull/3150 |
| plotly | https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Code | https://github.com/plotly/plotly.js |
| Issues726 (726) | https://github.com/plotly/plotly.js/issues |
| Pull requests84 (84) | https://github.com/plotly/plotly.js/pulls |
| Actions | https://github.com/plotly/plotly.js/actions |
| Security and quality | https://github.com/plotly/plotly.js/security |
| Insights | https://github.com/plotly/plotly.js/insights |
| https://github.com/plotly/plotly.js |
| antoinerg | https://github.com/antoinerg |
| master | https://github.com/plotly/plotly.js/tree/master |
| sankey-trace-hover | https://github.com/plotly/plotly.js/tree/sankey-trace-hover |
| Conversation | https://github.com/plotly/plotly.js/pull/3150 |
| Commits3 (3) | https://github.com/plotly/plotly.js/pull/3150/commits |
| Checks | https://github.com/plotly/plotly.js/pull/3150/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/3150/files |
| sankey hover improvements | https://github.com/plotly/plotly.js/pull/3150#top |
| antoinerg | https://github.com/antoinerg |
| master | https://github.com/plotly/plotly.js/tree/master |
| sankey-trace-hover | https://github.com/plotly/plotly.js/tree/sankey-trace-hover |
|
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Oct 24, 2018 | https://github.com/plotly/plotly.js/pull/3150#issue-373663455 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| @etpinard | https://github.com/etpinard |
| #3096 | https://github.com/plotly/plotly.js/pull/3096 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| antoinerg | https://github.com/antoinerg |
| October 24, 2018 16:17 | https://github.com/plotly/plotly.js/pull/3150#commits-pushed-27f379f |
|
| https://github.com/antoinerg |
| sankey: introduce trace-level hover(info|lable) and improve tests | https://github.com/plotly/plotly.js/pull/3150/commits/27f379f8db2fb30187aa388aafb85410af9e5aab |
| 27f379f | https://github.com/plotly/plotly.js/pull/3150/commits/27f379f8db2fb30187aa388aafb85410af9e5aab |
|
| https://github.com/antoinerg |
| replace .map call by Lib.repeat | https://github.com/plotly/plotly.js/pull/3150/commits/4453455358ebb86eba2d7559418a18e25094de98 |
| 4453455 | https://github.com/plotly/plotly.js/pull/3150/commits/4453455358ebb86eba2d7559418a18e25094de98 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
|
regression
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Aregression |
| Oct 24, 2018 | https://github.com/plotly/plotly.js/pull/3150#event-1924890085 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 25, 2018
| https://github.com/plotly/plotly.js/pull/3150#pullrequestreview-168170973 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3150/files/4453455358ebb86eba2d7559418a18e25094de98 |
| src/traces/sankey/defaults.js | https://github.com/plotly/plotly.js/pull/3150/files/4453455358ebb86eba2d7559418a18e25094de98#diff-988216ef2468e127d0e779ed92ceb753c4fadbf6b9e5486731a4e77d2cc2e8fa |
| etpinard | https://github.com/etpinard |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#discussion_r228002423 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| src/traces/sankey/defaults.js | https://github.com/plotly/plotly.js/pull/3150/files/4453455358ebb86eba2d7559418a18e25094de98#diff-988216ef2468e127d0e779ed92ceb753c4fadbf6b9e5486731a4e77d2cc2e8fa |
| etpinard | https://github.com/etpinard |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#discussion_r228002626 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| src/traces/sankey/attributes.js | https://github.com/plotly/plotly.js/pull/3150/files/4453455358ebb86eba2d7559418a18e25094de98#diff-59fcb82301bd4fec4fe37e3d5705904fda29c07021f0d0082d55a9291be7c9c5 |
| etpinard | https://github.com/etpinard |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#discussion_r228004477 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| plotly.js/src/plots/attributes.js | https://github.com/plotly/plotly.js/blob/36d9fb4ad341510823e6e25cb9202867ac94a94a/src/plots/attributes.js#L117-L130 |
| 36d9fb4 | https://github.com/plotly/plotly.js/commit/36d9fb4ad341510823e6e25cb9202867ac94a94a |
| @alexcjohnson | https://github.com/alexcjohnson |
| #3096 (comment) | https://github.com/plotly/plotly.js/pull/3096#discussion_r227626370 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| antoinerg | https://github.com/antoinerg |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#discussion_r228015534 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| alexcjohnson | https://github.com/alexcjohnson |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#discussion_r228015842 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #3058 (comment) | https://github.com/plotly/plotly.js/issues/3058#issuecomment-429069306 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| etpinard | https://github.com/etpinard |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#discussion_r228016486 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| antoinerg | https://github.com/antoinerg |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#discussion_r228019062 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| alexcjohnson | https://github.com/alexcjohnson |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#discussion_r228019494 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| alexcjohnson | https://github.com/alexcjohnson |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#discussion_r228019568 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #3058 | https://github.com/plotly/plotly.js/issues/3058 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| etpinard | https://github.com/etpinard |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#discussion_r228172990 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| antoinerg | https://github.com/antoinerg |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#discussion_r228216452 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @alexcjohnson | https://github.com/alexcjohnson |
| #3058 | https://github.com/plotly/plotly.js/issues/3058 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
|
| https://github.com/antoinerg |
| remove hoverinfo flags that aren't implemented | https://github.com/plotly/plotly.js/pull/3150/commits/6ab718d19178e400d848dd27fddfd4a4b451a04b |
| 6ab718d | https://github.com/plotly/plotly.js/pull/3150/commits/6ab718d19178e400d848dd27fddfd4a4b451a04b |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 25, 2018
| https://github.com/plotly/plotly.js/pull/3150#pullrequestreview-168381005 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/3150/files/6ab718d19178e400d848dd27fddfd4a4b451a04b |
| src/traces/sankey/attributes.js | https://github.com/plotly/plotly.js/pull/3150/files/6ab718d19178e400d848dd27fddfd4a4b451a04b#diff-59fcb82301bd4fec4fe37e3d5705904fda29c07021f0d0082d55a9291be7c9c5 |
| etpinard | https://github.com/etpinard |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#discussion_r228172667 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| plotly.js/src/plots/attributes.js | https://github.com/plotly/plotly.js/blob/d5ebb50a727821f6705d72182d7822d0097e8a41/src/plots/attributes.js#L121 |
| d5ebb50 | https://github.com/plotly/plotly.js/commit/d5ebb50a727821f6705d72182d7822d0097e8a41 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#issuecomment-433054084 |
| @antoinerg | https://github.com/antoinerg |
| #3058 | https://github.com/plotly/plotly.js/issues/3058 |
| #3150 (comment) | https://github.com/plotly/plotly.js/pull/3150#discussion_r228172990 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| c3a0118 | https://github.com/plotly/plotly.js/commit/c3a0118498dbaf2617d042cbca4d0ddf0295eb95 |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3150#event-1926439943 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| October 25, 2018 14:40 | https://github.com/plotly/plotly.js/pull/3150#event-1926440214 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
|
Nov 22, 2018
| https://github.com/plotly/plotly.js/pull/3150#ref-issue-227757731 |
|
Sankey hover text & styling
#1663
| https://github.com/plotly/plotly.js/issues/1663 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3150 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/3150/files/6ab718d19178e400d848dd27fddfd4a4b451a04b |
|
| https://github.com/etpinard |
|
etpinard
| https://github.com/etpinard |
|
| https://github.com/plotly/plotly.js/pull/3150/files/6ab718d19178e400d848dd27fddfd4a4b451a04b |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
|
regression
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Aregression |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3150 |
|
| https://github.com/antoinerg |
|
| https://github.com/etpinard |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |