René's URL Explorer Experiment


Title: 2951 contrasting pie and bar inside text by rmoestl · Pull Request #3130 · plotly/plotly.js · GitHub

Open Graph Title: 2951 contrasting pie and bar inside text by rmoestl · Pull Request #3130 · plotly/plotly.js

X Title: 2951 contrasting pie and bar inside text by rmoestl · Pull Request #3130 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - 2951 contrasting pie and bar inside text by rmoestl · Pull Request #3130 · plotly/plotly.js

Open Graph Description: Improves a few things around text font styling for pie and bar. Specified and discussed in #2951. Rough overview: If no custom font color is specified in trace, an inside text label will render wi...

X Description: Improves a few things around text font styling for pie and bar. Specified and discussed in #2951. Rough overview: If no custom font color is specified in trace, an inside text label will render wi...

Opengraph URL: https://github.com/plotly/plotly.js/pull/3130

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ca47173a-24e4-2ea2-15c5-b432830a07b2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC1A:95647:2CC06:39BCD:6B01AF08
html-safe-nonce9b68d5846f502927539a18e5342b100cc26b8040535edace1c05c3a878db4ad2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzFBOjk1NjQ3OjJDQzA2OjM5QkNEOjZCMDFBRjA4IiwidmlzaXRvcl9pZCI6IjExNzIyNjUwNDY5NjU4NTgwNTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac11773b308a4d91a89fb554be1a01f514b4ab9308e908170d838cf8bb5fb4185e
hovercard-subject-tagpull_request:224385850
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/3130/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/19a8cbf662459419fec71ac34a24a74b05301f5b396af272f94d7531bab7cfa2/plotly/plotly.js/pull/3130
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/19a8cbf662459419fec71ac34a24a74b05301f5b396af272f94d7531bab7cfa2/plotly/plotly.js/pull/3130
og:image:altImproves a few things around text font styling for pie and bar. Specified and discussed in #2951. Rough overview: If no custom font color is specified in trace, an inside text label will render wi...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamermoestl
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/3130#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3130
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3130
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/3130
Reloadhttps://github.com/plotly/plotly.js/pull/3130
Reloadhttps://github.com/plotly/plotly.js/pull/3130
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
rmoestlhttps://github.com/rmoestl
masterhttps://github.com/plotly/plotly.js/tree/master
2951-contrasting-pie-and-bar-inside-texthttps://github.com/plotly/plotly.js/tree/2951-contrasting-pie-and-bar-inside-text
Conversationhttps://github.com/plotly/plotly.js/pull/3130
Commits17 (17)https://github.com/plotly/plotly.js/pull/3130/commits
Checkshttps://github.com/plotly/plotly.js/pull/3130/checks
Files changedhttps://github.com/plotly/plotly.js/pull/3130/files
2951 contrasting pie and bar inside texthttps://github.com/plotly/plotly.js/pull/3130#top
rmoestlhttps://github.com/rmoestl
masterhttps://github.com/plotly/plotly.js/tree/master
2951-contrasting-pie-and-bar-inside-texthttps://github.com/plotly/plotly.js/tree/2951-contrasting-pie-and-bar-inside-text
https://github.com/rmoestl
rmoestlhttps://github.com/rmoestl
Oct 19, 2018https://github.com/plotly/plotly.js/pull/3130#issue-372084388
#2951https://github.com/plotly/plotly.js/issues/2951
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3130
rmoestlhttps://github.com/rmoestl
October 19, 2018 13:44https://github.com/plotly/plotly.js/pull/3130#commits-pushed-58be4f4
https://github.com/rmoestl
Correct typo in a pie attribute descriptionhttps://github.com/plotly/plotly.js/pull/3130/commits/58be4f43e9a838c784534d2c53c687185cc552ed
58be4f4https://github.com/plotly/plotly.js/pull/3130/commits/58be4f43e9a838c784534d2c53c687185cc552ed
https://github.com/rmoestl
Fix minor typos in pie_test.jshttps://github.com/plotly/plotly.js/pull/3130/commits/cabd0be8692eb0a0e6bb25517f50cb21f4995d8f
cabd0behttps://github.com/plotly/plotly.js/pull/3130/commits/cabd0be8692eb0a0e6bb25517f50cb21f4995d8f
https://github.com/rmoestl
Use contrasting inside text color for pie by default [2951]https://github.com/plotly/plotly.js/pull/3130/commits/487f73eae43d952eaab1b1408a188f18d48a7b92
487f73ehttps://github.com/plotly/plotly.js/pull/3130/commits/487f73eae43d952eaab1b1408a188f18d48a7b92
https://github.com/rmoestl
Use contrasting inside text color for bar by default [2951]https://github.com/plotly/plotly.js/pull/3130/commits/6c8f2afba0f73224a5d4f63524ed9c2fae8325d7
6c8f2afhttps://github.com/plotly/plotly.js/pull/3130/commits/6c8f2afba0f73224a5d4f63524ed9c2fae8325d7
https://github.com/rmoestl
Update pie baselines b/c inside text defaults to contrasting now [2951]https://github.com/plotly/plotly.js/pull/3130/commits/4b02d3692ecf39f52c00b9663b11310fcc556336
4b02d36https://github.com/plotly/plotly.js/pull/3130/commits/4b02d3692ecf39f52c00b9663b11310fcc556336
https://github.com/rmoestl
Update bar baselines b/c inside text defaults to contrasting now [2951]https://github.com/plotly/plotly.js/pull/3130/commits/66e26db69499270032449a2abb8d3b5b1f1cb09c
66e26dbhttps://github.com/plotly/plotly.js/pull/3130/commits/66e26db69499270032449a2abb8d3b5b1f1cb09c
https://github.com/rmoestl
Make pie font properties arrayOk [2951]https://github.com/plotly/plotly.js/pull/3130/commits/66fc66530b660e757025b662b1b2e0b5fa65dc46
66fc665https://github.com/plotly/plotly.js/pull/3130/commits/66fc66530b660e757025b662b1b2e0b5fa65dc46
https://github.com/rmoestl
Fix style of bar 'outside' labels being pushed 'inside' [2951]https://github.com/plotly/plotly.js/pull/3130/commits/df0d6c396abf7caaaf775f0d1a7b85d7037d22e3
df0d6c3https://github.com/plotly/plotly.js/pull/3130/commits/df0d6c396abf7caaaf775f0d1a7b85d7037d22e3
https://github.com/rmoestl
Fix baseline image differences resulting from parallel work [2951]https://github.com/plotly/plotly.js/pull/3130/commits/d2dbd28b8663e7ad489bb0d04219ae6e339c48de
d2dbd28https://github.com/plotly/plotly.js/pull/3130/commits/d2dbd28b8663e7ad489bb0d04219ae6e339c48de
https://github.com/rmoestl
Retain bar text styles throughout selection as well [2951]https://github.com/plotly/plotly.js/pull/3130/commits/e26bc504bee649a155eac4ce9d09310fed2a1caa
e26bc50https://github.com/plotly/plotly.js/pull/3130/commits/e26bc504bee649a155eac4ce9d09310fed2a1caa
https://github.com/rmoestl
Test that bar opacity is considered for contrasting text color [2951]https://github.com/plotly/plotly.js/pull/3130/commits/172e3e9f9e28491f4950853e542be29fe97382fa
172e3e9https://github.com/plotly/plotly.js/pull/3130/commits/172e3e9f9e28491f4950853e542be29fe97382fa
https://github.com/rmoestl
Move rgb conversion into assert methods for bar and pie tests [2951]https://github.com/plotly/plotly.js/pull/3130/commits/2b3a78b250791807565937551651de350370e876
2b3a78bhttps://github.com/plotly/plotly.js/pull/3130/commits/2b3a78b250791807565937551651de350370e876
https://github.com/rmoestl
Improve comment in bar/defaults.js [2951]https://github.com/plotly/plotly.js/pull/3130/commits/3bc3aa29aaf2c82f255315f4d90db15a6a417e6e
3bc3aa2https://github.com/plotly/plotly.js/pull/3130/commits/3bc3aa29aaf2c82f255315f4d90db15a6a417e6e
https://github.com/rmoestl
Improve some variable names in pie/plot.js [2951]https://github.com/plotly/plotly.js/pull/3130/commits/61b9d5016d4d587768dadf49c1a8ab76514b2159
61b9d50https://github.com/plotly/plotly.js/pull/3130/commits/61b9d5016d4d587768dadf49c1a8ab76514b2159
https://github.com/antoinerg
antoinerghttps://github.com/antoinerg
Oct 19, 2018https://github.com/plotly/plotly.js/pull/3130#issuecomment-431472232
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3130
https://github.com/rmoestl
rmoestlhttps://github.com/rmoestl
Oct 19, 2018https://github.com/plotly/plotly.js/pull/3130#issuecomment-431474113
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3130
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Oct 22, 2018https://github.com/plotly/plotly.js/pull/3130#issuecomment-431908326
bar_attrs_relativehttps://github.com/plotly/plotly.js/pull/3130/files?short_path=f2db335#diff-055dc9f6b5ae185a53b5bf0a29766fbc
https://user-images.githubusercontent.com/2678795/47308146-c77bf800-d5fe-11e8-9eaf-b7b611c0d2fa.png
https://user-images.githubusercontent.com/2678795/47308165-d2368d00-d5fe-11e8-8738-7d93e698f912.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3130
rmoestlhttps://github.com/rmoestl
October 23, 2018 09:23https://github.com/plotly/plotly.js/pull/3130#commits-pushed-a27d278
https://github.com/rmoestl
Fix contrasting text color for bars without explicit marker color [2951]https://github.com/plotly/plotly.js/pull/3130/commits/a27d278caf5513336c12e12e8dc2e5ac8bc7dc3c
a27d278https://github.com/plotly/plotly.js/pull/3130/commits/a27d278caf5513336c12e12e8dc2e5ac8bc7dc3c
https://github.com/rmoestl
Test contrasting inside text colors for standard pie colors [2951]https://github.com/plotly/plotly.js/pull/3130/commits/3ccc68b6e2d1724b3908fa8a4a8e6271a33b915a
3ccc68bhttps://github.com/plotly/plotly.js/pull/3130/commits/3ccc68b6e2d1724b3908fa8a4a8e6271a33b915a
https://github.com/rmoestl
Update baseline for mathjax.json [2951]https://github.com/plotly/plotly.js/pull/3130/commits/69b35b50d33b83cd76c87495b6eb8d9b88faa4e9
69b35b5https://github.com/plotly/plotly.js/pull/3130/commits/69b35b50d33b83cd76c87495b6eb8d9b88faa4e9
https://github.com/rmoestl
rmoestlhttps://github.com/rmoestl
Oct 23, 2018https://github.com/plotly/plotly.js/pull/3130#issuecomment-432143760
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3130
https://github.com/etpinard
etpinardhttps://github.com/etpinard
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
feature https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
Oct 23, 2018https://github.com/plotly/plotly.js/pull/3130#event-1921418156
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Oct 24, 2018https://github.com/plotly/plotly.js/pull/3130#issuecomment-432494775
@rmoestlhttps://github.com/rmoestl
@etpinardhttps://github.com/etpinard
@nicolaskruchtenhttps://github.com/nicolaskruchten
@VeraZabhttps://github.com/VeraZab
undefinedhttps://github.com/plotly/plotly.js/pull/3130/files?short_path=5a6cbbd#diff-53de192dfcd2487ecdc3dec4d837ede6R165
#3109 (comment)https://github.com/plotly/plotly.js/pull/3109#discussion_r227543929
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3130
https://github.com/nicolaskruchten
nicolaskruchtenhttps://github.com/nicolaskruchten
Oct 24, 2018https://github.com/plotly/plotly.js/pull/3130#issuecomment-432666817
https://user-images.githubusercontent.com/203523/47435584-ea2f1d80-d772-11e8-8e29-312737ec8320.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3130
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Oct 24, 2018https://github.com/plotly/plotly.js/pull/3130#issuecomment-432669799
concerns about how stuff like this will interact with templateshttps://github.com/plotly/plotly.js/pull/3109#discussion_r227543929
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3130
https://github.com/rmoestl
rmoestlhttps://github.com/rmoestl
d5ebb50https://github.com/plotly/plotly.js/commit/d5ebb50a727821f6705d72182d7822d0097e8a41
Oct 25, 2018https://github.com/plotly/plotly.js/pull/3130#event-1925236641
https://github.com/rmoestl
rmoestlhttps://github.com/rmoestl
October 25, 2018 05:33https://github.com/plotly/plotly.js/pull/3130#event-1925236710
https://github.com/etpinard
etpinardhttps://github.com/etpinard
v1.42.0https://github.com/plotly/plotly.js/milestone/38
Oct 25, 2018https://github.com/plotly/plotly.js/pull/3130#event-1926240132
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Oct 26, 2018 https://github.com/plotly/plotly.js/pull/3130#ref-issue-343662971
Fields missing in fullData #2834 https://github.com/plotly/plotly.js/issues/2834
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3130
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3130
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
feature https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature
v1.42.0 https://github.com/plotly/plotly.js/milestone/38
Please reload this pagehttps://github.com/plotly/plotly.js/pull/3130
https://github.com/rmoestl
https://github.com/antoinerg
https://github.com/alexcjohnson
https://github.com/nicolaskruchten
https://github.com/etpinard
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.