| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:ca47173a-24e4-2ea2-15c5-b432830a07b2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AC1A:95647:2CC06:39BCD:6B01AF08 |
| html-safe-nonce | 9b68d5846f502927539a18e5342b100cc26b8040535edace1c05c3a878db4ad2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzFBOjk1NjQ3OjJDQzA2OjM5QkNEOjZCMDFBRjA4IiwidmlzaXRvcl9pZCI6IjExNzIyNjUwNDY5NjU4NTgwNTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 11773b308a4d91a89fb554be1a01f514b4ab9308e908170d838cf8bb5fb4185e |
| hovercard-subject-tag | pull_request:224385850 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/3130/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/19a8cbf662459419fec71ac34a24a74b05301f5b396af272f94d7531bab7cfa2/plotly/plotly.js/pull/3130 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/19a8cbf662459419fec71ac34a24a74b05301f5b396af272f94d7531bab7cfa2/plotly/plotly.js/pull/3130 |
| og:image:alt | Improves a few things around text font styling for pie and bar. Specified and discussed in #2951.
Rough overview:
If no custom font color is specified in trace, an inside text label will render wi... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rmoestl |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/plotly/plotly.js/pull/3130#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3130 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3130 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/3130 |
| Reload | https://github.com/plotly/plotly.js/pull/3130 |
| Reload | https://github.com/plotly/plotly.js/pull/3130 |
| plotly | https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Code | https://github.com/plotly/plotly.js |
| Issues726 (726) | https://github.com/plotly/plotly.js/issues |
| Pull requests84 (84) | https://github.com/plotly/plotly.js/pulls |
| Actions | https://github.com/plotly/plotly.js/actions |
| Security and quality | https://github.com/plotly/plotly.js/security |
| Insights | https://github.com/plotly/plotly.js/insights |
| https://github.com/plotly/plotly.js |
| rmoestl | https://github.com/rmoestl |
| master | https://github.com/plotly/plotly.js/tree/master |
| 2951-contrasting-pie-and-bar-inside-text | https://github.com/plotly/plotly.js/tree/2951-contrasting-pie-and-bar-inside-text |
| Conversation | https://github.com/plotly/plotly.js/pull/3130 |
| Commits17 (17) | https://github.com/plotly/plotly.js/pull/3130/commits |
| Checks | https://github.com/plotly/plotly.js/pull/3130/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/3130/files |
| 2951 contrasting pie and bar inside text | https://github.com/plotly/plotly.js/pull/3130#top |
| rmoestl | https://github.com/rmoestl |
| master | https://github.com/plotly/plotly.js/tree/master |
| 2951-contrasting-pie-and-bar-inside-text | https://github.com/plotly/plotly.js/tree/2951-contrasting-pie-and-bar-inside-text |
|
| https://github.com/rmoestl |
| rmoestl | https://github.com/rmoestl |
| Oct 19, 2018 | https://github.com/plotly/plotly.js/pull/3130#issue-372084388 |
| #2951 | https://github.com/plotly/plotly.js/issues/2951 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3130 |
| rmoestl | https://github.com/rmoestl |
| October 19, 2018 13:44 | https://github.com/plotly/plotly.js/pull/3130#commits-pushed-58be4f4 |
|
| https://github.com/rmoestl |
| Correct typo in a pie attribute description | https://github.com/plotly/plotly.js/pull/3130/commits/58be4f43e9a838c784534d2c53c687185cc552ed |
| 58be4f4 | https://github.com/plotly/plotly.js/pull/3130/commits/58be4f43e9a838c784534d2c53c687185cc552ed |
|
| https://github.com/rmoestl |
| Fix minor typos in pie_test.js | https://github.com/plotly/plotly.js/pull/3130/commits/cabd0be8692eb0a0e6bb25517f50cb21f4995d8f |
| cabd0be | https://github.com/plotly/plotly.js/pull/3130/commits/cabd0be8692eb0a0e6bb25517f50cb21f4995d8f |
|
| https://github.com/rmoestl |
| Use contrasting inside text color for pie by default [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/487f73eae43d952eaab1b1408a188f18d48a7b92 |
| 487f73e | https://github.com/plotly/plotly.js/pull/3130/commits/487f73eae43d952eaab1b1408a188f18d48a7b92 |
|
| https://github.com/rmoestl |
| Use contrasting inside text color for bar by default [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/6c8f2afba0f73224a5d4f63524ed9c2fae8325d7 |
| 6c8f2af | https://github.com/plotly/plotly.js/pull/3130/commits/6c8f2afba0f73224a5d4f63524ed9c2fae8325d7 |
|
| https://github.com/rmoestl |
| Update pie baselines b/c inside text defaults to contrasting now [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/4b02d3692ecf39f52c00b9663b11310fcc556336 |
| 4b02d36 | https://github.com/plotly/plotly.js/pull/3130/commits/4b02d3692ecf39f52c00b9663b11310fcc556336 |
|
| https://github.com/rmoestl |
| Update bar baselines b/c inside text defaults to contrasting now [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/66e26db69499270032449a2abb8d3b5b1f1cb09c |
| 66e26db | https://github.com/plotly/plotly.js/pull/3130/commits/66e26db69499270032449a2abb8d3b5b1f1cb09c |
|
| https://github.com/rmoestl |
| Make pie font properties arrayOk [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/66fc66530b660e757025b662b1b2e0b5fa65dc46 |
| 66fc665 | https://github.com/plotly/plotly.js/pull/3130/commits/66fc66530b660e757025b662b1b2e0b5fa65dc46 |
|
| https://github.com/rmoestl |
| Fix style of bar 'outside' labels being pushed 'inside' [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/df0d6c396abf7caaaf775f0d1a7b85d7037d22e3 |
| df0d6c3 | https://github.com/plotly/plotly.js/pull/3130/commits/df0d6c396abf7caaaf775f0d1a7b85d7037d22e3 |
|
| https://github.com/rmoestl |
| Fix baseline image differences resulting from parallel work [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/d2dbd28b8663e7ad489bb0d04219ae6e339c48de |
| d2dbd28 | https://github.com/plotly/plotly.js/pull/3130/commits/d2dbd28b8663e7ad489bb0d04219ae6e339c48de |
|
| https://github.com/rmoestl |
| Retain bar text styles throughout selection as well [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/e26bc504bee649a155eac4ce9d09310fed2a1caa |
| e26bc50 | https://github.com/plotly/plotly.js/pull/3130/commits/e26bc504bee649a155eac4ce9d09310fed2a1caa |
|
| https://github.com/rmoestl |
| Test that bar opacity is considered for contrasting text color [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/172e3e9f9e28491f4950853e542be29fe97382fa |
| 172e3e9 | https://github.com/plotly/plotly.js/pull/3130/commits/172e3e9f9e28491f4950853e542be29fe97382fa |
|
| https://github.com/rmoestl |
| Move rgb conversion into assert methods for bar and pie tests [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/2b3a78b250791807565937551651de350370e876 |
| 2b3a78b | https://github.com/plotly/plotly.js/pull/3130/commits/2b3a78b250791807565937551651de350370e876 |
|
| https://github.com/rmoestl |
| Improve comment in bar/defaults.js [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/3bc3aa29aaf2c82f255315f4d90db15a6a417e6e |
| 3bc3aa2 | https://github.com/plotly/plotly.js/pull/3130/commits/3bc3aa29aaf2c82f255315f4d90db15a6a417e6e |
|
| https://github.com/rmoestl |
| Improve some variable names in pie/plot.js [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/61b9d5016d4d587768dadf49c1a8ab76514b2159 |
| 61b9d50 | https://github.com/plotly/plotly.js/pull/3130/commits/61b9d5016d4d587768dadf49c1a8ab76514b2159 |
| https://github.com/antoinerg |
| antoinerg | https://github.com/antoinerg |
| Oct 19, 2018 | https://github.com/plotly/plotly.js/pull/3130#issuecomment-431472232 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3130 |
| https://github.com/rmoestl |
| rmoestl | https://github.com/rmoestl |
| Oct 19, 2018 | https://github.com/plotly/plotly.js/pull/3130#issuecomment-431474113 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3130 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Oct 22, 2018 | https://github.com/plotly/plotly.js/pull/3130#issuecomment-431908326 |
| bar_attrs_relative | https://github.com/plotly/plotly.js/pull/3130/files?short_path=f2db335#diff-055dc9f6b5ae185a53b5bf0a29766fbc |
| https://user-images.githubusercontent.com/2678795/47308146-c77bf800-d5fe-11e8-9eaf-b7b611c0d2fa.png |
| https://user-images.githubusercontent.com/2678795/47308165-d2368d00-d5fe-11e8-8738-7d93e698f912.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3130 |
| rmoestl | https://github.com/rmoestl |
| October 23, 2018 09:23 | https://github.com/plotly/plotly.js/pull/3130#commits-pushed-a27d278 |
|
| https://github.com/rmoestl |
| Fix contrasting text color for bars without explicit marker color [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/a27d278caf5513336c12e12e8dc2e5ac8bc7dc3c |
| a27d278 | https://github.com/plotly/plotly.js/pull/3130/commits/a27d278caf5513336c12e12e8dc2e5ac8bc7dc3c |
|
| https://github.com/rmoestl |
| Test contrasting inside text colors for standard pie colors [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/3ccc68b6e2d1724b3908fa8a4a8e6271a33b915a |
| 3ccc68b | https://github.com/plotly/plotly.js/pull/3130/commits/3ccc68b6e2d1724b3908fa8a4a8e6271a33b915a |
|
| https://github.com/rmoestl |
| Update baseline for mathjax.json [2951] | https://github.com/plotly/plotly.js/pull/3130/commits/69b35b50d33b83cd76c87495b6eb8d9b88faa4e9 |
| 69b35b5 | https://github.com/plotly/plotly.js/pull/3130/commits/69b35b50d33b83cd76c87495b6eb8d9b88faa4e9 |
| https://github.com/rmoestl |
| rmoestl | https://github.com/rmoestl |
| Oct 23, 2018 | https://github.com/plotly/plotly.js/pull/3130#issuecomment-432143760 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3130 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
bug
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
| Oct 23, 2018 | https://github.com/plotly/plotly.js/pull/3130#event-1921418156 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Oct 24, 2018 | https://github.com/plotly/plotly.js/pull/3130#issuecomment-432494775 |
| @rmoestl | https://github.com/rmoestl |
| @etpinard | https://github.com/etpinard |
| @nicolaskruchten | https://github.com/nicolaskruchten |
| @VeraZab | https://github.com/VeraZab |
| undefined | https://github.com/plotly/plotly.js/pull/3130/files?short_path=5a6cbbd#diff-53de192dfcd2487ecdc3dec4d837ede6R165 |
| #3109 (comment) | https://github.com/plotly/plotly.js/pull/3109#discussion_r227543929 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3130 |
| https://github.com/nicolaskruchten |
| nicolaskruchten | https://github.com/nicolaskruchten |
| Oct 24, 2018 | https://github.com/plotly/plotly.js/pull/3130#issuecomment-432666817 |
| https://user-images.githubusercontent.com/203523/47435584-ea2f1d80-d772-11e8-8e29-312737ec8320.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3130 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Oct 24, 2018 | https://github.com/plotly/plotly.js/pull/3130#issuecomment-432669799 |
| concerns about how stuff like this will interact with templates | https://github.com/plotly/plotly.js/pull/3109#discussion_r227543929 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3130 |
| https://github.com/rmoestl |
| rmoestl | https://github.com/rmoestl |
| d5ebb50 | https://github.com/plotly/plotly.js/commit/d5ebb50a727821f6705d72182d7822d0097e8a41 |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3130#event-1925236641 |
| https://github.com/rmoestl |
| rmoestl | https://github.com/rmoestl |
| October 25, 2018 05:33 | https://github.com/plotly/plotly.js/pull/3130#event-1925236710 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| v1.42.0 | https://github.com/plotly/plotly.js/milestone/38 |
| Oct 25, 2018 | https://github.com/plotly/plotly.js/pull/3130#event-1926240132 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 26, 2018
| https://github.com/plotly/plotly.js/pull/3130#ref-issue-343662971 |
|
Fields missing in fullData
#2834
| https://github.com/plotly/plotly.js/issues/2834 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F3130 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3130 |
|
bug
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
|
v1.42.0
| https://github.com/plotly/plotly.js/milestone/38 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/3130 |
|
| https://github.com/rmoestl |
|
| https://github.com/antoinerg |
|
| https://github.com/alexcjohnson |
|
| https://github.com/nicolaskruchten |
|
| https://github.com/etpinard |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |