René's URL Explorer Experiment


Title: fix layer ordering of scatter subtypes by alexcjohnson · Pull Request #2978 · plotly/plotly.js · GitHub

Open Graph Title: fix layer ordering of scatter subtypes by alexcjohnson · Pull Request #2978 · plotly/plotly.js

X Title: fix layer ordering of scatter subtypes by alexcjohnson · Pull Request #2978 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - fix layer ordering of scatter subtypes by alexcjohnson · Pull Request #2978 · plotly/plotly.js

Open Graph Description: Fixes #2972 - and some other related ordering bugs on mode changes. Basically just by using more standard d3 idioms 🙄 cc @etpinard

X Description: Fixes #2972 - and some other related ordering bugs on mode changes. Basically just by using more standard d3 idioms 🙄 cc @etpinard

Opengraph URL: https://github.com/plotly/plotly.js/pull/2978

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a72e106e-4d74-cbd1-8ba6-7224d6ec9bc5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC7F2:2C4BED:2EDE516:3B8C346:6B01C0D2
html-safe-noncec6c3032de59a89e084e2f10f12087367c5def05b3e04386b6b824eb6904cb098
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0YyOjJDNEJFRDoyRURFNTE2OjNCOEMzNDY6NkIwMUMwRDIiLCJ2aXNpdG9yX2lkIjoiMTE2MzIzNDQ0MzQxMTk0OTYyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace1fb78a41eeaba0f3744f3d3bd5c68b0fdd2232b56306962f5f1599d65eecf8f
hovercard-subject-tagpull_request:213772063
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/2978/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9c031d30442d922b6650985c7d7f020fb912e2b0f40ce3cf2cf68be75807995f/plotly/plotly.js/pull/2978
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9c031d30442d922b6650985c7d7f020fb912e2b0f40ce3cf2cf68be75807995f/plotly/plotly.js/pull/2978
og:image:altFixes #2972 - and some other related ordering bugs on mode changes. Basically just by using more standard d3 idioms 🙄 cc @etpinard
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealexcjohnson
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/2978#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2978
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2978
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/2978
Reloadhttps://github.com/plotly/plotly.js/pull/2978
Reloadhttps://github.com/plotly/plotly.js/pull/2978
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
alexcjohnsonhttps://github.com/alexcjohnson
masterhttps://github.com/plotly/plotly.js/tree/master
scatter-layer-orderhttps://github.com/plotly/plotly.js/tree/scatter-layer-order
Conversationhttps://github.com/plotly/plotly.js/pull/2978
Commits4 (4)https://github.com/plotly/plotly.js/pull/2978/commits
Checkshttps://github.com/plotly/plotly.js/pull/2978/checks
Files changedhttps://github.com/plotly/plotly.js/pull/2978/files
fix layer ordering of scatter subtypeshttps://github.com/plotly/plotly.js/pull/2978#top
alexcjohnsonhttps://github.com/alexcjohnson
masterhttps://github.com/plotly/plotly.js/tree/master
scatter-layer-orderhttps://github.com/plotly/plotly.js/tree/scatter-layer-order
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Sep 6, 2018https://github.com/plotly/plotly.js/pull/2978#issue-357856964
#2972https://github.com/plotly/plotly.js/issues/2972
@etpinardhttps://github.com/etpinard
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
https://github.com/alexcjohnson
fix layer ordering of scatter subtypeshttps://github.com/plotly/plotly.js/pull/2978/commits/aeef7f724ea727d6288f586fc3e3062286fe8a0c
aeef7f7https://github.com/plotly/plotly.js/pull/2978/commits/aeef7f724ea727d6288f586fc3e3062286fe8a0c
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
Sep 6, 2018https://github.com/plotly/plotly.js/pull/2978#event-1831633272
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Sep 6, 2018 https://github.com/plotly/plotly.js/pull/2978#pullrequestreview-153151667
View reviewed changes https://github.com/plotly/plotly.js/pull/2978/files/aeef7f724ea727d6288f586fc3e3062286fe8a0c
test/jasmine/tests/scatter_test.jshttps://github.com/plotly/plotly.js/pull/2978/files/aeef7f724ea727d6288f586fc3e3062286fe8a0c#diff-7f7fbde98ee7dc18f1c7b1ca7ac148deb643c5c588ebc2f6acbba93d429813c8
alexcjohnsonhttps://github.com/alexcjohnson
Sep 6, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r215802304
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
alexcjohnsonhttps://github.com/alexcjohnson
Sep 7, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r215970509
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
etpinardhttps://github.com/etpinard
Sep 7, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r215983996
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
alexcjohnsonhttps://github.com/alexcjohnson
Sep 11, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r216546111
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
6988818https://github.com/plotly/plotly.js/commit/69888187c9de68a3d8a6d75cd1bb84e6c0c66f1a
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Sep 6, 2018 https://github.com/plotly/plotly.js/pull/2978#pullrequestreview-153152638
View reviewed changes https://github.com/plotly/plotly.js/pull/2978/files/aeef7f724ea727d6288f586fc3e3062286fe8a0c
src/traces/scatter/style.jshttps://github.com/plotly/plotly.js/pull/2978/files/aeef7f724ea727d6288f586fc3e3062286fe8a0c#diff-dc1c14713038bb369d27e17840c5f6240144e26d566b915b360ac6aa6138e383
alexcjohnsonhttps://github.com/alexcjohnson
Sep 6, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r215803080
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@etpinardhttps://github.com/etpinard
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
alexcjohnsonhttps://github.com/alexcjohnson
Sep 6, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r215806135
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
alexcjohnsonhttps://github.com/alexcjohnson
Sep 7, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r215819086
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
7c54fc2https://github.com/plotly/plotly.js/commit/7c54fc2f0bd38ecac52c314b736e86ef035c3511
removes everything on updatehttps://github.com/plotly/plotly.js/blob/33e1acfdd5ffb8a87a637e0868827abad60dabbf/src/traces/scattergeo/plot.js#L37
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
etpinardhttps://github.com/etpinard
Sep 7, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r215981825
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
7c54fc2https://github.com/plotly/plotly.js/commit/7c54fc2f0bd38ecac52c314b736e86ef035c3511
https://github.com/plotly/plotly.js/blob/master/src/traces/scattergeo/style.jshttps://github.com/plotly/plotly.js/blob/master/src/traces/scattergeo/style.js
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
etpinardhttps://github.com/etpinard
Sep 7, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r215982585
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
etpinardhttps://github.com/etpinard
Sep 7, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r215992273
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@etpinardhttps://github.com/etpinard
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
https://github.com/alexcjohnson
put back text styling in scattergeohttps://github.com/plotly/plotly.js/pull/2978/commits/7c54fc2f0bd38ecac52c314b736e86ef035c3511
7c54fc2https://github.com/plotly/plotly.js/pull/2978/commits/7c54fc2f0bd38ecac52c314b736e86ef035c3511
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 7, 2018 https://github.com/plotly/plotly.js/pull/2978#pullrequestreview-153369562
View reviewed changes https://github.com/plotly/plotly.js/pull/2978/files/7c54fc2f0bd38ecac52c314b736e86ef035c3511
src/traces/scatter/plot.jshttps://github.com/plotly/plotly.js/pull/2978/files/7c54fc2f0bd38ecac52c314b736e86ef035c3511#diff-a3243ea6027b49a0f58a8322452fa3a9a492ab742663191ec03c77689386fe92
etpinardhttps://github.com/etpinard
Sep 7, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r215980485
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://user-images.githubusercontent.com/6675409/45224769-ce39f000-b288-11e8-9ce1-3648051f9444.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
alexcjohnsonhttps://github.com/alexcjohnson
Sep 10, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r216506217
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
etpinardhttps://github.com/etpinard
Sep 10, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r216507362
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 7, 2018https://github.com/plotly/plotly.js/pull/2978#issuecomment-419460182
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
https://plot.ly/javascript/animations/https://plot.ly/javascript/animations/
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 7, 2018 https://github.com/plotly/plotly.js/pull/2978#pullrequestreview-153378735
View reviewed changes https://github.com/plotly/plotly.js/pull/2978/files/7c54fc2f0bd38ecac52c314b736e86ef035c3511
src/traces/scatter/plot.jshttps://github.com/plotly/plotly.js/pull/2978/files/7c54fc2f0bd38ecac52c314b736e86ef035c3511#diff-a3243ea6027b49a0f58a8322452fa3a9a492ab742663191ec03c77689386fe92
etpinardhttps://github.com/etpinard
Sep 7, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r215987598
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 7, 2018 https://github.com/plotly/plotly.js/pull/2978#pullrequestreview-153380590
View reviewed changes https://github.com/plotly/plotly.js/pull/2978/files/7c54fc2f0bd38ecac52c314b736e86ef035c3511
src/traces/scatter/plot.jshttps://github.com/plotly/plotly.js/pull/2978/files/7c54fc2f0bd38ecac52c314b736e86ef035c3511#diff-a3243ea6027b49a0f58a8322452fa3a9a492ab742663191ec03c77689386fe92
etpinardhttps://github.com/etpinard
Sep 7, 2018https://github.com/plotly/plotly.js/pull/2978#discussion_r215989008
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
https://github.com/antoinerg
antoinerghttps://github.com/antoinerg
Sep 7, 2018https://github.com/plotly/plotly.js/pull/2978#issuecomment-419481069
https://plot.ly/javascript/animations/https://plot.ly/javascript/animations/
@alexcjohnsonhttps://github.com/alexcjohnson
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
alexcjohnsonhttps://github.com/alexcjohnson
September 7, 2018 14:01https://github.com/plotly/plotly.js/pull/2978#commits-pushed-509ed7e
https://github.com/alexcjohnson
Merge branch 'master' into scatter-layer-orderhttps://github.com/plotly/plotly.js/pull/2978/commits/509ed7eee0e32e4e5d7302d29d2d78a5de294849
509ed7ehttps://github.com/plotly/plotly.js/pull/2978/commits/509ed7eee0e32e4e5d7302d29d2d78a5de294849
https://github.com/alexcjohnson
better algorithm for covering all state transitionshttps://github.com/plotly/plotly.js/pull/2978/commits/69888187c9de68a3d8a6d75cd1bb84e6c0c66f1a
6988818https://github.com/plotly/plotly.js/pull/2978/commits/69888187c9de68a3d8a6d75cd1bb84e6c0c66f1a
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 11, 2018https://github.com/plotly/plotly.js/pull/2978#issuecomment-420282350
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
f034c62https://github.com/plotly/plotly.js/commit/f034c629caa07e2c2aa4106e1384dd1a7cd91868
Sep 11, 2018https://github.com/plotly/plotly.js/pull/2978#event-1838623426
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
September 11, 2018 14:03https://github.com/plotly/plotly.js/pull/2978#event-1838623558
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Sep 14, 2018 https://github.com/plotly/plotly.js/pull/2978#ref-issue-298017801
Strange behaviour when hiding a trace in a plot with many filling traces #2380 https://github.com/plotly/plotly.js/issues/2380
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2978
https://github.com/etpinard
etpinard https://github.com/etpinard
https://github.com/plotly/plotly.js/pull/2978/files/7c54fc2f0bd38ecac52c314b736e86ef035c3511
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2978
https://github.com/alexcjohnson
https://github.com/etpinard
https://github.com/antoinerg
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.