| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:d94346c5-04de-56f9-41d0-e8c263a0f90b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 82A6:2CEF6D:E78D87:15164F4:6A56074E |
| html-safe-nonce | f3b44df7f00dd090dc9b0708f4532cdf2dac847c8ac05d75f125b54eda3bef44 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkE2OjJDRUY2RDpFNzhEODc6MTUxNjRGNDo2QTU2MDc0RSIsInZpc2l0b3JfaWQiOiIzMTIxNTE0NDY2NTIyODI2NTc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9b6a6dd9aabeee9c951fb8aeca205d5694bd51d0ae4071a9afb858605e63f603 |
| hovercard-subject-tag | pull_request:207732047 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/2895/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3c2995c3c56edf2416f9a0f9fef867d0bd00e5a61ac9e75362d52b90d14f97fd/plotly/plotly.js/pull/2895 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3c2995c3c56edf2416f9a0f9fef867d0bd00e5a61ac9e75362d52b90d14f97fd/plotly/plotly.js/pull/2895 |
| og:image:alt | This is a preliminary PR for barpolar.
I dove back hard into the polar code in the past 10 days and I noticed a few hacks that were worth cleaning up before adding barpolar.
Commit 3d8eef2 is the b... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | etpinard |
| hostname | github.com |
| expected-hostname | github.com |
| None | f4368738fc918fecd9b3958f6b49218bbe60d4185f38e72e3954e11f1ad0213a |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 85a7179838b41e8b23f939d3b67b53f752ecfc54 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/2895#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2895 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2895 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/2895 |
| Reload | https://github.com/plotly/plotly.js/pull/2895 |
| Reload | https://github.com/plotly/plotly.js/pull/2895 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
771
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
56
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| polar-better-set-convert | https://github.com/plotly/plotly.js/tree/polar-better-set-convert |
| Conversation | https://github.com/plotly/plotly.js/pull/2895 |
| Commits18 (18) | https://github.com/plotly/plotly.js/pull/2895/commits |
| Checks | https://github.com/plotly/plotly.js/pull/2895/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/2895/files |
| Better polar setConvert + a few misc polar touch ups | https://github.com/plotly/plotly.js/pull/2895#top |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| polar-better-set-convert | https://github.com/plotly/plotly.js/tree/polar-better-set-convert |
|
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Aug 10, 2018 | https://github.com/plotly/plotly.js/pull/2895#issue-349669620 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| 3d8eef2 | https://github.com/plotly/plotly.js/commit/3d8eef2b7b7e258e094395e65186ddea725c6f0b |
| 91064ca | https://github.com/plotly/plotly.js/commit/91064cac5c3f7ed14741c96641f9a7436a19c33b |
| scatterpolargl in 'lines' mode smears on axis rotation #2888 | https://github.com/plotly/plotly.js/issues/2888 |
| Enable text for scattergl trace #2737 | https://github.com/plotly/plotly.js/pull/2737 |
| Implement hoveron: 'fills' for scattergl and scatterpolargl #2887 (comment) | https://github.com/plotly/plotly.js/issues/2887#issuecomment-411911140 |
| @alexcjohnson | https://github.com/alexcjohnson |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| etpinard | https://github.com/etpinard |
| August 9, 2018 13:26 | https://github.com/plotly/plotly.js/pull/2895#commits-pushed-e9c3ef8 |
|
| https://github.com/etpinard |
| 🔪 obsolete things in Bar.calc | https://github.com/plotly/plotly.js/pull/2895/commits/e9c3ef88ad93599e256b59569084b3c237aa14d4 |
| e9c3ef8 | https://github.com/plotly/plotly.js/pull/2895/commits/e9c3ef88ad93599e256b59569084b3c237aa14d4 |
|
| https://github.com/etpinard |
| require doTicksSingle and setConvertCartesian directly | https://github.com/plotly/plotly.js/pull/2895/commits/80717d5e4e5d4962e0ca18674c838698e3409ae9 |
| 80717d5 | https://github.com/plotly/plotly.js/pull/2895/commits/80717d5e4e5d4962e0ca18674c838698e3409ae9 |
|
| https://github.com/etpinard |
| improve polar setConvert | https://github.com/plotly/plotly.js/pull/2895/commits/3d8eef2b7b7e258e094395e65186ddea725c6f0b |
| 3d8eef2 | https://github.com/plotly/plotly.js/pull/2895/commits/3d8eef2b7b7e258e094395e65186ddea725c6f0b |
|
| https://github.com/etpinard |
| 🔪 now useless intoCenter line calcdata hack | https://github.com/plotly/plotly.js/pull/2895/commits/87a392065c613a6be6225331050888028adaac28 |
| 87a3920 | https://github.com/plotly/plotly.js/pull/2895/commits/87a392065c613a6be6225331050888028adaac28 |
|
| https://github.com/etpinard |
| add 📚 about axes in polar subplots | https://github.com/plotly/plotly.js/pull/2895/commits/91064cac5c3f7ed14741c96641f9a7436a19c33b |
| 91064ca | https://github.com/plotly/plotly.js/pull/2895/commits/91064cac5c3f7ed14741c96641f9a7436a19c33b |
|
| https://github.com/etpinard |
| sub angularAxis._id 'angular' -> 'angularaxis' | https://github.com/plotly/plotly.js/pull/2895/commits/3787bfac2f5f705ad12ca3db843031e0d4832e5a |
| 3787bfa | https://github.com/plotly/plotly.js/pull/2895/commits/3787bfac2f5f705ad12ca3db843031e0d4832e5a |
|
| https://github.com/etpinard |
| add r0/dr theta0/dtheta | https://github.com/plotly/plotly.js/pull/2895/commits/4f881faec1be586d4808564a08c4c6692d3f6b55 |
| 4f881fa | https://github.com/plotly/plotly.js/pull/2895/commits/4f881faec1be586d4808564a08c4c6692d3f6b55 |
|
| https://github.com/etpinard |
| fix | https://github.com/plotly/plotly.js/pull/2895/commits/449dc4307fec03db0b0073cc8e8dafb0b079e3af |
| #2888 | https://github.com/plotly/plotly.js/issues/2888 |
| - clear scene via gl ref in line2d object | https://github.com/plotly/plotly.js/pull/2895/commits/449dc4307fec03db0b0073cc8e8dafb0b079e3af |
| 449dc43 | https://github.com/plotly/plotly.js/pull/2895/commits/449dc4307fec03db0b0073cc8e8dafb0b079e3af |
|
| https://github.com/etpinard |
| 🔪 hoveron declaration in scattergl and scatterpolargl | https://github.com/plotly/plotly.js/pull/2895/commits/dae3ccd53549a971c2e5b6fa83e4b033f601a89a |
| dae3ccd | https://github.com/plotly/plotly.js/pull/2895/commits/dae3ccd53549a971c2e5b6fa83e4b033f601a89a |
| #2887 | https://github.com/plotly/plotly.js/issues/2887 |
|
| https://github.com/etpinard |
| add on-graph 'text' to scatterpolargl | https://github.com/plotly/plotly.js/pull/2895/commits/d3b36151d02219bf122fc7cd813b544ccdd6ac2a |
| d3b3615 | https://github.com/plotly/plotly.js/pull/2895/commits/d3b36151d02219bf122fc7cd813b544ccdd6ac2a |
| #2737 | https://github.com/plotly/plotly.js/pull/2737 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
bug
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
| Aug 10, 2018 | https://github.com/plotly/plotly.js/pull/2895#event-1783461031 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| v1.40.0 | https://github.com/plotly/plotly.js/milestone/36 |
| Aug 10, 2018 | https://github.com/plotly/plotly.js/pull/2895#event-1783461038 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Aug 13, 2018
| https://github.com/plotly/plotly.js/pull/2895#pullrequestreview-145701657 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2895/files/e9c3ef88ad93599e256b59569084b3c237aa14d4 |
| src/traces/bar/calc.js | https://github.com/plotly/plotly.js/pull/2895/files/e9c3ef88ad93599e256b59569084b3c237aa14d4#diff-062540bc1aa3e35833bcb304349c4ed9464ae1828c07e2850015ce3745610158 |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209648435 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
|
| https://github.com/etpinard |
| fix radial drag when scatterpolar & scatterpolargl are on same subplot | https://github.com/plotly/plotly.js/pull/2895/commits/ec57a4283b70925636d9c28dbe8cced9fc7e9723 |
| ec57a42 | https://github.com/plotly/plotly.js/pull/2895/commits/ec57a4283b70925636d9c28dbe8cced9fc7e9723 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Aug 13, 2018
| https://github.com/plotly/plotly.js/pull/2895#pullrequestreview-145724236 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2895/files/3d8eef2b7b7e258e094395e65186ddea725c6f0b |
| src/plots/polar/set_convert.js | https://github.com/plotly/plotly.js/pull/2895/files/80717d5e4e5d4962e0ca18674c838698e3409ae9..3d8eef2b7b7e258e094395e65186ddea725c6f0b#diff-7352c580eb6897d98f61be93522c8ee0f54ef5333d714ee9484ace9c9e1a6c47 |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209666950 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209667236 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| plotly.js/src/plots/cartesian/set_convert.js | https://github.com/plotly/plotly.js/blob/def6aa5a24527c68e90f50485255170609640e43/src/plots/cartesian/set_convert.js#L35-L50 |
| def6aa5 | https://github.com/plotly/plotly.js/commit/def6aa5a24527c68e90f50485255170609640e43 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| etpinard | https://github.com/etpinard |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209760501 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 4c11c84 | https://github.com/plotly/plotly.js/commit/4c11c84251cfe8aa532f42a26022803e867f4ed4 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209791471 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Aug 13, 2018
| https://github.com/plotly/plotly.js/pull/2895#pullrequestreview-145725325 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2895/files/3d8eef2b7b7e258e094395e65186ddea725c6f0b |
| src/plots/polar/set_convert.js | https://github.com/plotly/plotly.js/pull/2895/files/80717d5e4e5d4962e0ca18674c838698e3409ae9..3d8eef2b7b7e258e094395e65186ddea725c6f0b#diff-7352c580eb6897d98f61be93522c8ee0f54ef5333d714ee9484ace9c9e1a6c47 |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209667875 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| etpinard | https://github.com/etpinard |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209670292 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| f5bceda | https://github.com/plotly/plotly.js/commit/f5bceda77844160879033d283f2a4cf914924a7a |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
|
| https://github.com/etpinard |
| 🔪 unused keys from angular axis objects | https://github.com/plotly/plotly.js/pull/2895/commits/f5bceda77844160879033d283f2a4cf914924a7a |
| f5bceda | https://github.com/plotly/plotly.js/pull/2895/commits/f5bceda77844160879033d283f2a4cf914924a7a |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Aug 13, 2018
| https://github.com/plotly/plotly.js/pull/2895#pullrequestreview-145727600 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2895/files/91064cac5c3f7ed14741c96641f9a7436a19c33b |
| src/plots/polar/polar.js | https://github.com/plotly/plotly.js/pull/2895/files/87a392065c613a6be6225331050888028adaac28..91064cac5c3f7ed14741c96641f9a7436a19c33b#diff-9975b27f7fda754e176beeb3b3fa125b643379d0d85071a73b9f4b7bac9f9b6f |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209669776 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Aug 13, 2018
| https://github.com/plotly/plotly.js/pull/2895#pullrequestreview-145730985 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2895/files/3787bfac2f5f705ad12ca3db843031e0d4832e5a |
| src/plots/polar/polar.js | https://github.com/plotly/plotly.js/pull/2895/files/91064cac5c3f7ed14741c96641f9a7436a19c33b..3787bfac2f5f705ad12ca3db843031e0d4832e5a#diff-9975b27f7fda754e176beeb3b3fa125b643379d0d85071a73b9f4b7bac9f9b6f |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209672468 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| plotly.js/src/plots/polar/layout_defaults.js | https://github.com/plotly/plotly.js/blob/def6aa5a24527c68e90f50485255170609640e43/src/plots/polar/layout_defaults.js#L57 |
| def6aa5 | https://github.com/plotly/plotly.js/commit/def6aa5a24527c68e90f50485255170609640e43 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Aug 13, 2018
| https://github.com/plotly/plotly.js/pull/2895#pullrequestreview-145732266 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2895/files/3787bfac2f5f705ad12ca3db843031e0d4832e5a |
| src/plots/cartesian/axes.js | https://github.com/plotly/plotly.js/pull/2895/files/91064cac5c3f7ed14741c96641f9a7436a19c33b..3787bfac2f5f705ad12ca3db843031e0d4832e5a#diff-5f001ae7bd55867b9cfbe23508ea18384159d46c141298fa7d177cfd76194695 |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209673484 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| etpinard | https://github.com/etpinard |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209760294 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 0c517d1 | https://github.com/plotly/plotly.js/commit/0c517d197dce032bcd5835adf80952672c2341fe |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Aug 13, 2018
| https://github.com/plotly/plotly.js/pull/2895#pullrequestreview-145732568 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2895/files/3787bfac2f5f705ad12ca3db843031e0d4832e5a |
| src/plots/cartesian/axes.js | https://github.com/plotly/plotly.js/pull/2895/files/91064cac5c3f7ed14741c96641f9a7436a19c33b..3787bfac2f5f705ad12ca3db843031e0d4832e5a#diff-5f001ae7bd55867b9cfbe23508ea18384159d46c141298fa7d177cfd76194695 |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209673733 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| etpinard | https://github.com/etpinard |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209760387 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 0c517d1 | https://github.com/plotly/plotly.js/commit/0c517d197dce032bcd5835adf80952672c2341fe |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Aug 13, 2018
| https://github.com/plotly/plotly.js/pull/2895#pullrequestreview-145792643 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2895/files/4f881faec1be586d4808564a08c4c6692d3f6b55 |
| src/traces/scatterpolar/attributes.js | https://github.com/plotly/plotly.js/pull/2895/files/3787bfac2f5f705ad12ca3db843031e0d4832e5a..4f881faec1be586d4808564a08c4c6692d3f6b55#diff-c09d4a9f1975b63e18a83c399da2a795be6ce8ae5811f6371b44f575e62e3f7d |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209723280 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Aug 13, 2018
| https://github.com/plotly/plotly.js/pull/2895#pullrequestreview-145802074 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2895/files/449dc4307fec03db0b0073cc8e8dafb0b079e3af |
| src/traces/scattergl/index.js | https://github.com/plotly/plotly.js/pull/2895/files/4f881faec1be586d4808564a08c4c6692d3f6b55..449dc4307fec03db0b0073cc8e8dafb0b079e3af#diff-688adb1ec93d8ef915d23c66c29f83e7d9eb5be92123332179fdc5d1ef25769d |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209730944 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #2888 | https://github.com/plotly/plotly.js/issues/2888 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| etpinard | https://github.com/etpinard |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209732284 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #2797 | https://github.com/plotly/plotly.js/issues/2797 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| etpinard | https://github.com/etpinard |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209765078 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| c3044e0 | https://github.com/plotly/plotly.js/commit/c3044e094eacfc25fbd2f85648c66c4bf8693994 |
| @dy | https://github.com/dy |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 14, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209795453 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #2900 | https://github.com/plotly/plotly.js/issues/2900 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| etpinard | https://github.com/etpinard |
| Aug 14, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r210025612 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 75786e4 | https://github.com/plotly/plotly.js/commit/75786e40279e1cfbbc04333be7fb0d15d2f3be39 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Aug 13, 2018
| https://github.com/plotly/plotly.js/pull/2895#pullrequestreview-145807973 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2895/files/ec57a4283b70925636d9c28dbe8cced9fc7e9723 |
| src/plots/polar/polar.js | https://github.com/plotly/plotly.js/pull/2895/files/d3b36151d02219bf122fc7cd813b544ccdd6ac2a..ec57a4283b70925636d9c28dbe8cced9fc7e9723#diff-9975b27f7fda754e176beeb3b3fa125b643379d0d85071a73b9f4b7bac9f9b6f |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209735982 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| etpinard | https://github.com/etpinard |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209765242 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| b81885d | https://github.com/plotly/plotly.js/commit/b81885d7315b1d16e609e7d1ca7af3311ea3dbaa |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Aug 13, 2018
| https://github.com/plotly/plotly.js/pull/2895#pullrequestreview-145809759 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2895/files/ec57a4283b70925636d9c28dbe8cced9fc7e9723 |
| test/jasmine/tests/polar_test.js | https://github.com/plotly/plotly.js/pull/2895/files/d3b36151d02219bf122fc7cd813b544ccdd6ac2a..ec57a4283b70925636d9c28dbe8cced9fc7e9723#diff-17a4c82658143eaa6773062bd9a4f6cb785563c75d4208b1577d18eb9b84d7ea |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209737409 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| etpinard | https://github.com/etpinard |
| Aug 13, 2018 | https://github.com/plotly/plotly.js/pull/2895#discussion_r209760602 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| b4700ca | https://github.com/plotly/plotly.js/commit/b4700cabda7752b3d21f1277a37dd912664a2805 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| etpinard | https://github.com/etpinard |
| August 13, 2018 16:37 | https://github.com/plotly/plotly.js/pull/2895#commits-pushed-0c517d1 |
|
| https://github.com/etpinard |
| use isAngular helper in axes.js | https://github.com/plotly/plotly.js/pull/2895/commits/0c517d197dce032bcd5835adf80952672c2341fe |
| 0c517d1 | https://github.com/plotly/plotly.js/pull/2895/commits/0c517d197dce032bcd5835adf80952672c2341fe |
|
| https://github.com/etpinard |
| improve polar setConvert docstring | https://github.com/plotly/plotly.js/pull/2895/commits/4c11c84251cfe8aa532f42a26022803e867f4ed4 |
| 4c11c84 | https://github.com/plotly/plotly.js/pull/2895/commits/4c11c84251cfe8aa532f42a26022803e867f4ed4 |
|
| https://github.com/etpinard |
| use .filter instead of (confusing) .reduce | https://github.com/plotly/plotly.js/pull/2895/commits/b4700cabda7752b3d21f1277a37dd912664a2805 |
| b4700ca | https://github.com/plotly/plotly.js/pull/2895/commits/b4700cabda7752b3d21f1277a37dd912664a2805 |
| etpinard | https://github.com/etpinard |
| August 13, 2018 17:02 | https://github.com/plotly/plotly.js/pull/2895#commits-pushed-c3044e0 |
|
| https://github.com/etpinard |
| clean up cleanViewport logic | https://github.com/plotly/plotly.js/pull/2895/commits/c3044e094eacfc25fbd2f85648c66c4bf8693994 |
| c3044e0 | https://github.com/plotly/plotly.js/pull/2895/commits/c3044e094eacfc25fbd2f85648c66c4bf8693994 |
|
| https://github.com/etpinard |
| avoid trying to call scene.clear more than once per mousemove | https://github.com/plotly/plotly.js/pull/2895/commits/b81885d7315b1d16e609e7d1ca7af3311ea3dbaa |
| b81885d | https://github.com/plotly/plotly.js/pull/2895/commits/b81885d7315b1d16e609e7d1ca7af3311ea3dbaa |
|
| https://github.com/etpinard |
| add fill2d and error2d in clearViewport fallback list | https://github.com/plotly/plotly.js/pull/2895/commits/75786e40279e1cfbbc04333be7fb0d15d2f3be39 |
| 75786e4 | https://github.com/plotly/plotly.js/pull/2895/commits/75786e40279e1cfbbc04333be7fb0d15d2f3be39 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Aug 14, 2018 | https://github.com/plotly/plotly.js/pull/2895#issuecomment-413010138 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| 665a9c4 | https://github.com/plotly/plotly.js/commit/665a9c4e6412fd7e3d552a8213b1ee96e6695427 |
| Aug 15, 2018 | https://github.com/plotly/plotly.js/pull/2895#event-1790119409 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| August 15, 2018 14:18 | https://github.com/plotly/plotly.js/pull/2895#event-1790119580 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 6, 2018
| https://github.com/plotly/plotly.js/pull/2895#ref-issue-289068372 |
|
Polar 2.0 open items
#2255
| https://github.com/plotly/plotly.js/issues/2255 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2895 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/2895/files/b81885d7315b1d16e609e7d1ca7af3311ea3dbaa |
|
bug
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
|
v1.40.0
| https://github.com/plotly/plotly.js/milestone/36 |
|
scatterpolargl in 'lines' mode smears on axis rotation
| https://github.com/plotly/plotly.js/issues/2888 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2895 |
|
| https://github.com/etpinard |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |