René's URL Explorer Experiment


Title: Cone sizeref fixes by etpinard · Pull Request #2715 · plotly/plotly.js · GitHub

Open Graph Title: Cone sizeref fixes by etpinard · Pull Request #2715 · plotly/plotly.js

X Title: Cone sizeref fixes by etpinard · Pull Request #2715 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Cone sizeref fixes by etpinard · Pull Request #2715 · plotly/plotly.js

Open Graph Description: fixes #2700 and #2701 (with the help gl-vis/gl-cone3d#12). This PR also improves hover on cones by picking the entire cone as opposed to overlaying gl-scatter3d points and using those for picking. ...

X Description: fixes #2700 and #2701 (with the help gl-vis/gl-cone3d#12). This PR also improves hover on cones by picking the entire cone as opposed to overlaying gl-scatter3d points and using those for picking. ...

Opengraph URL: https://github.com/plotly/plotly.js/pull/2715

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:594647a4-55fe-da5e-d899-6388ecaf39c6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A8E:1148D3:FF6885:146FB26:6B011480
html-safe-noncecf70ace2a0444b8fdaed531ae372eb006def6b5ff3ad4a837792d35f7f39a23f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QThFOjExNDhEMzpGRjY4ODU6MTQ2RkIyNjo2QjAxMTQ4MCIsInZpc2l0b3JfaWQiOiI1MDg1ODM3NzA5NDgyNzI2NTI4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac859005522bfbc7188da0de1d90216b1061d7b60ec60eda9b040c937f79914f01
hovercard-subject-tagpull_request:193738480
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/2715/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0fff3098566ef91b9591ece8376616899c896200ec36757bb1b3b1342958ee9b/plotly/plotly.js/pull/2715
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0fff3098566ef91b9591ece8376616899c896200ec36757bb1b3b1342958ee9b/plotly/plotly.js/pull/2715
og:image:altfixes #2700 and #2701 (with the help gl-vis/gl-cone3d#12). This PR also improves hover on cones by picking the entire cone as opposed to overlaying gl-scatter3d points and using those for picking. ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameetpinard
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/2715#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2715
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2715
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/2715
Reloadhttps://github.com/plotly/plotly.js/pull/2715
Reloadhttps://github.com/plotly/plotly.js/pull/2715
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
cone-sizeref-fixeshttps://github.com/plotly/plotly.js/tree/cone-sizeref-fixes
Conversationhttps://github.com/plotly/plotly.js/pull/2715
Commits9 (9)https://github.com/plotly/plotly.js/pull/2715/commits
Checkshttps://github.com/plotly/plotly.js/pull/2715/checks
Files changedhttps://github.com/plotly/plotly.js/pull/2715/files
Cone sizeref fixeshttps://github.com/plotly/plotly.js/pull/2715#top
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
cone-sizeref-fixeshttps://github.com/plotly/plotly.js/tree/cone-sizeref-fixes
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 8, 2018https://github.com/plotly/plotly.js/pull/2715#issue-330822929
#2700https://github.com/plotly/plotly.js/issues/2700
#2701https://github.com/plotly/plotly.js/issues/2701
gl-vis/gl-cone3d#12https://github.com/gl-vis/gl-cone3d/pull/12
4836861https://github.com/plotly/plotly.js/commit/4836861130a1a2944d42ca2fc2025efa2027d68d
gl-vis/gl-cone3d@3b3ef9dhttps://github.com/gl-vis/gl-cone3d/commit/3b3ef9d465a8e30d14a9a4a1cc88d4deebec64a9
@alexcjohnsonhttps://github.com/alexcjohnson
gl-vis/gl-cone3d@3b3ef9dhttps://github.com/gl-vis/gl-cone3d/commit/3b3ef9d465a8e30d14a9a4a1cc88d4deebec64a9
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2715
etpinardhttps://github.com/etpinard
June 8, 2018 18:29https://github.com/plotly/plotly.js/pull/2715#commits-pushed-8619ce1
https://github.com/etpinard
use gl-cone3d picking instead of gl-scatter3d overlayhttps://github.com/plotly/plotly.js/pull/2715/commits/8619ce1bb4a531a5071f0934435df3d86a633359
8619ce1https://github.com/plotly/plotly.js/pull/2715/commits/8619ce1bb4a531a5071f0934435df3d86a633359
https://github.com/etpinard
[tmp] use gl-cone3d fromhttps://github.com/plotly/plotly.js/pull/2715/commits/625764236a4bd7b4e24d7674cf4ca6f25ec294a5
gl-vis/gl-cone3d#12https://github.com/gl-vis/gl-cone3d/pull/12
6257642https://github.com/plotly/plotly.js/pull/2715/commits/625764236a4bd7b4e24d7674cf4ca6f25ec294a5
https://github.com/etpinard
try fixing cone 'absolute' scalinghttps://github.com/plotly/plotly.js/pull/2715/commits/4836861130a1a2944d42ca2fc2025efa2027d68d
4836861https://github.com/plotly/plotly.js/pull/2715/commits/4836861130a1a2944d42ca2fc2025efa2027d68d
https://github.com/etpinard
new cone baselineshttps://github.com/plotly/plotly.js/pull/2715/commits/bb4bde7670ee42b92dca9f9837ad78f5a95299be
bb4bde7https://github.com/plotly/plotly.js/pull/2715/commits/bb4bde7670ee42b92dca9f9837ad78f5a95299be
https://github.com/etpinard
etpinardhttps://github.com/etpinard
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
status: in progress https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22
Jun 8, 2018https://github.com/plotly/plotly.js/pull/2715#event-1671929822
https://github.com/etpinard
fixup cone testshttps://github.com/plotly/plotly.js/pull/2715/commits/67f372d2e5af07b8d0c6173823ca56ebf14a9afe
67f372dhttps://github.com/plotly/plotly.js/pull/2715/commits/67f372d2e5af07b8d0c6173823ca56ebf14a9afe
https://github.com/etpinard
etpinardhttps://github.com/etpinard
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
status: in progress https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22
Jun 11, 2018https://github.com/plotly/plotly.js/pull/2715#event-1674218790
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 11, 2018 https://github.com/plotly/plotly.js/pull/2715#pullrequestreview-127628351
View reviewed changes https://github.com/plotly/plotly.js/pull/2715/files/4836861130a1a2944d42ca2fc2025efa2027d68d
src/traces/cone/convert.jshttps://github.com/plotly/plotly.js/pull/2715/files/625764236a4bd7b4e24d7674cf4ca6f25ec294a5..4836861130a1a2944d42ca2fc2025efa2027d68d#diff-8018032474d11964f67eb7ffb43cb8b21af7dfc9d81e78c4c1db807066d2efc2
etpinardhttps://github.com/etpinard
Jun 11, 2018https://github.com/plotly/plotly.js/pull/2715#discussion_r194453287
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2715
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#2646https://github.com/plotly/plotly.js/issues/2646
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2715
alexcjohnsonhttps://github.com/alexcjohnson
Jun 11, 2018https://github.com/plotly/plotly.js/pull/2715#discussion_r194459609
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2715
etpinardhttps://github.com/etpinard
Jun 11, 2018https://github.com/plotly/plotly.js/pull/2715#discussion_r194463374
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2715
etpinardhttps://github.com/etpinard
Jun 11, 2018https://github.com/plotly/plotly.js/pull/2715#discussion_r194487265
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2715
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jun 11, 2018 https://github.com/plotly/plotly.js/pull/2715#pullrequestreview-127633924
View reviewed changes https://github.com/plotly/plotly.js/pull/2715/files/67f372d2e5af07b8d0c6173823ca56ebf14a9afe
src/traces/cone/attributes.jshttps://github.com/plotly/plotly.js/pull/2715/files/67f372d2e5af07b8d0c6173823ca56ebf14a9afe#diff-46ab7eddb745d42ff612c0a0ccf1ae3195527803656eee6da31f859f96ba80b8
alexcjohnsonhttps://github.com/alexcjohnson
Jun 11, 2018https://github.com/plotly/plotly.js/pull/2715#discussion_r194457759
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2715
etpinardhttps://github.com/etpinard
Jun 11, 2018https://github.com/plotly/plotly.js/pull/2715#discussion_r194459357
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2715
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jun 11, 2018 https://github.com/plotly/plotly.js/pull/2715#pullrequestreview-127634451
View reviewed changes https://github.com/plotly/plotly.js/pull/2715/files/67f372d2e5af07b8d0c6173823ca56ebf14a9afe
src/traces/cone/attributes.jshttps://github.com/plotly/plotly.js/pull/2715/files/67f372d2e5af07b8d0c6173823ca56ebf14a9afe#diff-46ab7eddb745d42ff612c0a0ccf1ae3195527803656eee6da31f859f96ba80b8
alexcjohnsonhttps://github.com/alexcjohnson
Jun 11, 2018https://github.com/plotly/plotly.js/pull/2715#discussion_r194458142
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2715
etpinardhttps://github.com/etpinard
June 11, 2018 14:11https://github.com/plotly/plotly.js/pull/2715#commits-pushed-10475be
https://github.com/etpinard
fixups in sizeref descriptionhttps://github.com/plotly/plotly.js/pull/2715/commits/10475beb5ea2f182702e1ef39147d98ef03ea7e7
10475behttps://github.com/plotly/plotly.js/pull/2715/commits/10475beb5ea2f182702e1ef39147d98ef03ea7e7
https://github.com/etpinard
improve sizeref default for 0-norm coneshttps://github.com/plotly/plotly.js/pull/2715/commits/7236e2dbc662f124d31aef80f01f10ac72f73366
7236e2dhttps://github.com/plotly/plotly.js/pull/2715/commits/7236e2dbc662f124d31aef80f01f10ac72f73366
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 11, 2018 https://github.com/plotly/plotly.js/pull/2715#ref-pullrequest-330815763
A few cone improvements gl-vis/gl-cone3d#12 https://github.com/gl-vis/gl-cone3d/pull/12
etpinardhttps://github.com/etpinard
June 11, 2018 14:23https://github.com/plotly/plotly.js/pull/2715#commits-pushed-c8a40d5
https://github.com/etpinard
bump gl-cone3d to 1.1.0https://github.com/plotly/plotly.js/pull/2715/commits/c8a40d5091ef683d163cc741409967b2fd5a8274
c8a40d5https://github.com/plotly/plotly.js/pull/2715/commits/c8a40d5091ef683d163cc741409967b2fd5a8274
https://github.com/etpinard
more sizemode/sizeref fixupshttps://github.com/plotly/plotly.js/pull/2715/commits/a1ba95328e4e3f6d6f7a64d7c4bd95b3033f3c58
a1ba953https://github.com/plotly/plotly.js/pull/2715/commits/a1ba95328e4e3f6d6f7a64d7c4bd95b3033f3c58
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jun 11, 2018https://github.com/plotly/plotly.js/pull/2715#issuecomment-396343925
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2715
https://github.com/etpinard
etpinardhttps://github.com/etpinard
f4b836chttps://github.com/plotly/plotly.js/commit/f4b836c85cdc7a821bd5e81a34d8a88538d2765d
Jun 11, 2018https://github.com/plotly/plotly.js/pull/2715#event-1674629167
https://github.com/etpinard
etpinardhttps://github.com/etpinard
June 11, 2018 18:51https://github.com/plotly/plotly.js/pull/2715#event-1674629282
Merge v1.38.3 into master #2725 https://github.com/plotly/plotly.js/pull/2725
Cone traces with irregular grids do not scale cone correctly #2701 https://github.com/plotly/plotly.js/issues/2701
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2715
https://github.com/alexcjohnson
alexcjohnson https://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/2715/files/67f372d2e5af07b8d0c6173823ca56ebf14a9afe
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2715
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
This cone trace with sizemode: 'absolute' punches through scene wall https://github.com/plotly/plotly.js/issues/2700
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2715
https://github.com/etpinard
https://github.com/alexcjohnson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.