René's URL Explorer Experiment


Title: Automargin fixes by alexcjohnson · Pull Request #2681 · plotly/plotly.js · GitHub

Open Graph Title: Automargin fixes by alexcjohnson · Pull Request #2681 · plotly/plotly.js

X Title: Automargin fixes by alexcjohnson · Pull Request #2681 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Automargin fixes by alexcjohnson · Pull Request #2681 · plotly/plotly.js

Open Graph Description: Fixes #2651 - and a bunch of other things I encountered along the way: Stops writing trace.uid back to the user input data, instead reusing the values from oldFullData if the user didn't speci...

X Description: Fixes #2651 - and a bunch of other things I encountered along the way: Stops writing trace.uid back to the user input data, instead reusing the values from oldFullData if the user didn't s...

Opengraph URL: https://github.com/plotly/plotly.js/pull/2681

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:389fffe6-3e95-2a6e-9e9e-12008939f447
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC5D0:B53AF:1FE2045:2A667F8:6B017B48
html-safe-noncef45d07cdda93872f09107ef7ec5cba44c7ca3112fd89bd1c2c8cc82bd1cba640
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUQwOkI1M0FGOjFGRTIwNDU6MkE2NjdGODo2QjAxN0I0OCIsInZpc2l0b3JfaWQiOiI3NDY1MjE2NTg0NjQzMDgzMDgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac995841b6ec52f9c34aa9dea26f846a1b6df12ad9ab20a0d6055130f62d1f936a
hovercard-subject-tagpull_request:191531486
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/2681/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1e868951da361c3777f7f9d3280a4a1f52c48fe62a461f074625dc9f6092d5cc/plotly/plotly.js/pull/2681
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1e868951da361c3777f7f9d3280a4a1f52c48fe62a461f074625dc9f6092d5cc/plotly/plotly.js/pull/2681
og:image:altFixes #2651 - and a bunch of other things I encountered along the way: Stops writing trace.uid back to the user input data, instead reusing the values from oldFullData if the user didn't speci...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealexcjohnson
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/2681#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2681
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2681
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/2681
Reloadhttps://github.com/plotly/plotly.js/pull/2681
Reloadhttps://github.com/plotly/plotly.js/pull/2681
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
alexcjohnsonhttps://github.com/alexcjohnson
masterhttps://github.com/plotly/plotly.js/tree/master
react-automarginhttps://github.com/plotly/plotly.js/tree/react-automargin
Conversationhttps://github.com/plotly/plotly.js/pull/2681
Commits17 (17)https://github.com/plotly/plotly.js/pull/2681/commits
Checkshttps://github.com/plotly/plotly.js/pull/2681/checks
Files changedhttps://github.com/plotly/plotly.js/pull/2681/files
Automargin fixeshttps://github.com/plotly/plotly.js/pull/2681#top
alexcjohnsonhttps://github.com/alexcjohnson
masterhttps://github.com/plotly/plotly.js/tree/master
react-automarginhttps://github.com/plotly/plotly.js/tree/react-automargin
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#issue-327834803
#2651https://github.com/plotly/plotly.js/issues/2651
@etpinardhttps://github.com/etpinard
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
May 30, 2018 12:52https://github.com/plotly/plotly.js/pull/2681#commits-pushed-970db80
https://github.com/alexcjohnson
stop mutating user data to add uidshttps://github.com/plotly/plotly.js/pull/2681/commits/970db808dc1a6dab0817992d10d7d9e8fa9b8600
970db80https://github.com/plotly/plotly.js/pull/2681/commits/970db808dc1a6dab0817992d10d7d9e8fa9b8600
https://github.com/alexcjohnson
some test cleanuphttps://github.com/plotly/plotly.js/pull/2681/commits/26278de2dcc7771d8c76c45df8fa4e1623a06ea2
26278dehttps://github.com/plotly/plotly.js/pull/2681/commits/26278de2dcc7771d8c76c45df8fa4e1623a06ea2
https://github.com/alexcjohnson
first cut at updating automargin logichttps://github.com/plotly/plotly.js/pull/2681/commits/6dd68bd1e2ca367236ff02ade3e4983fbaa39a5d
6dd68bdhttps://github.com/plotly/plotly.js/pull/2681/commits/6dd68bd1e2ca367236ff02ade3e4983fbaa39a5d
https://github.com/alexcjohnson
refactor colorbars for simpler connection to trace attributeshttps://github.com/plotly/plotly.js/pull/2681/commits/fa8614750586a2901ccf65a520521bb570eb7026
fa86147https://github.com/plotly/plotly.js/pull/2681/commits/fa8614750586a2901ccf65a520521bb570eb7026
https://github.com/alexcjohnson
test legend, rangeselector, rangeslider automargin updateshttps://github.com/plotly/plotly.js/pull/2681/commits/95f9b33311017e6f6eb4ed4c7d875b13c9c8afd3
95f9b33https://github.com/plotly/plotly.js/pull/2681/commits/95f9b33311017e6f6eb4ed4c7d875b13c9c8afd3
https://github.com/alexcjohnson
provide uids to traces a little earlier - to fix carpet clip idshttps://github.com/plotly/plotly.js/pull/2681/commits/8f3da8225e2650a2622c6b677704c218ba11a0a0
8f3da82https://github.com/plotly/plotly.js/pull/2681/commits/8f3da8225e2650a2622c6b677704c218ba11a0a0
https://github.com/etpinard
etpinardhttps://github.com/etpinard
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#event-1654248119
https://github.com/etpinard
etpinardhttps://github.com/etpinard
v1.39.0https://github.com/plotly/plotly.js/milestone/35
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#event-1654248232
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 30, 2018 https://github.com/plotly/plotly.js/pull/2681#pullrequestreview-124536446
View reviewed changes https://github.com/plotly/plotly.js/pull/2681/files/6dd68bd1e2ca367236ff02ade3e4983fbaa39a5d
src/components/rangeslider/draw.jshttps://github.com/plotly/plotly.js/pull/2681/files/26278de2dcc7771d8c76c45df8fa4e1623a06ea2..6dd68bd1e2ca367236ff02ade3e4983fbaa39a5d#diff-8e04902c896e8bff31ff5d59a0ccf97b71779ecc5b2194cad2fcefe6488593fc
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191876433
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
src/plot_api/plot_api.jshttps://github.com/plotly/plotly.js/pull/2681/files/26278de2dcc7771d8c76c45df8fa4e1623a06ea2..6dd68bd1e2ca367236ff02ade3e4983fbaa39a5d#diff-4cc342865f02fea8acedf92e7c0855b4c805c9824b4b4aaf0f587dba2506c9e7
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191877868
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191915573
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
src/plot_api/subroutines.jshttps://github.com/plotly/plotly.js/pull/2681/files/26278de2dcc7771d8c76c45df8fa4e1623a06ea2..6dd68bd1e2ca367236ff02ade3e4983fbaa39a5d#diff-d670f85239a0f2240b21379a074593658aa18b142d90eeeab8a10699713eb148
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191878318
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
src/traces/cone/colorbar.jshttps://github.com/plotly/plotly.js/pull/2681/files/26278de2dcc7771d8c76c45df8fa4e1623a06ea2..6dd68bd1e2ca367236ff02ade3e4983fbaa39a5d#diff-9af3842eaa0e5707972f6e5a8a38a22bedc6739bc0d2bc11a8629bb046062a6b
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191879161
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191882085
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
fa86147https://github.com/plotly/plotly.js/commit/fa8614750586a2901ccf65a520521bb570eb7026
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191916587
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
May 31, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r192099843
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
src/components/updatemenus/draw.jshttps://github.com/plotly/plotly.js/pull/2681/files/26278de2dcc7771d8c76c45df8fa4e1623a06ea2..6dd68bd1e2ca367236ff02ade3e4983fbaa39a5d#diff-14e1814f826e54c32acaceda12ec44f769db57969b7b868e0a60575fb5c2add3
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191879632
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191909484
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r193400563
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
3deab4chttps://github.com/plotly/plotly.js/commit/3deab4c4aefeac557058800a46707d5669b0a334
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
test/jasmine/tests/legend_test.jshttps://github.com/plotly/plotly.js/pull/2681/files/fa8614750586a2901ccf65a520521bb570eb7026..95f9b33311017e6f6eb4ed4c7d875b13c9c8afd3#diff-4e42e0bae41327053517ccddcd92f047f6133498975413f8400318aef41604d6
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191889443
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191921353
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
src/components/colorbar/connect.jshttps://github.com/plotly/plotly.js/pull/2681/files/6dd68bd1e2ca367236ff02ade3e4983fbaa39a5d..fa8614750586a2901ccf65a520521bb570eb7026#diff-4349984b3f677b59dae142c8c61b7016c030cde97f1ec98bad0dc82f2c92ea38
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191891287
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/plotly/plotly.js/blob/fa8614750586a2901ccf65a520521bb570eb7026/src/traces/contour/colorbar.jshttps://github.com/plotly/plotly.js/blob/fa8614750586a2901ccf65a520521bb570eb7026/src/traces/contour/colorbar.js
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191891861
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191919926
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
colorbar.drawhttps://github.com/plotly/plotly.js/pull/2681/commits/fa8614750586a2901ccf65a520521bb570eb7026#diff-ad110e994c21bb045d288b9c96e4e6ccR452
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
May 31, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r192100780
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
src/plot_api/plot_api.jshttps://github.com/plotly/plotly.js/pull/2681/files/8f3da8225e2650a2622c6b677704c218ba11a0a0#diff-4cc342865f02fea8acedf92e7c0855b4c805c9824b4b4aaf0f587dba2506c9e7
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191892922
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
src/plot_api/plot_api.jshttps://github.com/plotly/plotly.js/pull/2681/files/8f3da8225e2650a2622c6b677704c218ba11a0a0#diff-4cc342865f02fea8acedf92e7c0855b4c805c9824b4b4aaf0f587dba2506c9e7
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191894083
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191894949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191911220
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191912682
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r193433643
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r193445011
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r193446391
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r193488182
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
230a782https://github.com/plotly/plotly.js/commit/230a782766ae9864eb5ac803c5fb069bedb9ab25
#2704https://github.com/plotly/plotly.js/issues/2704
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
src/plots/plots.jshttps://github.com/plotly/plotly.js/pull/2681/files/95f9b33311017e6f6eb4ed4c7d875b13c9c8afd3..8f3da8225e2650a2622c6b677704c218ba11a0a0#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191895944
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://user-images.githubusercontent.com/6675409/40743247-fa945b26-641e-11e8-8a2e-92b5fe585f53.png
https://user-images.githubusercontent.com/6675409/40743266-07c4e130-641f-11e8-987c-e7c28ef14adc.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191896286
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191925363
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r191935434
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 30, 2018https://github.com/plotly/plotly.js/pull/2681#issuecomment-393292890
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
@alexcjohnsonhttps://github.com/alexcjohnson
Automargin fixes #2681 (comment)https://github.com/plotly/plotly.js/pull/2681#discussion_r191894083
Automargin fixes #2681 (comment)https://github.com/plotly/plotly.js/pull/2681#discussion_r191877868
Automargin fixes #2681 (comment)https://github.com/plotly/plotly.js/pull/2681#discussion_r191879632
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
May 30, 2018 18:04https://github.com/plotly/plotly.js/pull/2681#commits-pushed-f9fbbc6
https://github.com/alexcjohnson
🔪 colorbar.vals - seems like that was all obsolete anywayhttps://github.com/plotly/plotly.js/pull/2681/commits/f9fbbc647cad99497514c8a575c111b7222f8d73
f9fbbc6https://github.com/plotly/plotly.js/pull/2681/commits/f9fbbc647cad99497514c8a575c111b7222f8d73
https://github.com/alexcjohnson
cleanup in sliders_testhttps://github.com/plotly/plotly.js/pull/2681/commits/222f39632a907c926b77d58a469de770ac7326e5
222f396https://github.com/plotly/plotly.js/pull/2681/commits/222f39632a907c926b77d58a469de770ac7326e5
https://github.com/alexcjohnson
simplify inner plot size tests with custom_assertionshttps://github.com/plotly/plotly.js/pull/2681/commits/bd07df76e0701070096ebabbfda3d564fb5e6e64
bd07df7https://github.com/plotly/plotly.js/pull/2681/commits/bd07df76e0701070096ebabbfda3d564fb5e6e64
https://github.com/alexcjohnson
fix and test slider x positioning when they push marginshttps://github.com/plotly/plotly.js/pull/2681/commits/84a569500646d26357b4692b2544fb01db3e70d6
84a5695https://github.com/plotly/plotly.js/pull/2681/commits/84a569500646d26357b4692b2544fb01db3e70d6
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 1, 2018 https://github.com/plotly/plotly.js/pull/2681#pullrequestreview-125177662
View reviewed changes https://github.com/plotly/plotly.js/pull/2681/files/bd07df76e0701070096ebabbfda3d564fb5e6e64
test/jasmine/assets/custom_assertions.jshttps://github.com/plotly/plotly.js/pull/2681/files/222f39632a907c926b77d58a469de770ac7326e5..bd07df76e0701070096ebabbfda3d564fb5e6e64#diff-01e3303bacaeef58ed3774be8555ae3fe535050b06ad279df52b23c095922740
etpinardhttps://github.com/etpinard
Jun 1, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r192403980
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
Jun 1, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r192406480
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
Jun 1, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r192407667
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r193399442
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
bb6c720https://github.com/plotly/plotly.js/commit/bb6c7201820468747976de41baa90f65a08eb4ee
5d31324https://github.com/plotly/plotly.js/commit/5d3132423a1a4a347528d80feb03ba6ad7bc356e
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jun 1, 2018 https://github.com/plotly/plotly.js/pull/2681#pullrequestreview-125184229
View reviewed changes https://github.com/plotly/plotly.js/pull/2681/files/84a569500646d26357b4692b2544fb01db3e70d6
src/plots/plots.jshttps://github.com/plotly/plotly.js/pull/2681/files/bd07df76e0701070096ebabbfda3d564fb5e6e64..84a569500646d26357b4692b2544fb01db3e70d6#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
alexcjohnsonhttps://github.com/alexcjohnson
Jun 1, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r192409090
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
Jun 1, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r192412710
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
June 1, 2018 16:03https://github.com/plotly/plotly.js/pull/2681#commits-pushed-3deab4c
https://github.com/alexcjohnson
move sliders to the updated automargin frameworkhttps://github.com/plotly/plotly.js/pull/2681/commits/3deab4c4aefeac557058800a46707d5669b0a334
3deab4chttps://github.com/plotly/plotly.js/pull/2681/commits/3deab4c4aefeac557058800a46707d5669b0a334
https://github.com/alexcjohnson
use bg rect instead of grids for assertPlotSizehttps://github.com/plotly/plotly.js/pull/2681/commits/bb6c7201820468747976de41baa90f65a08eb4ee
bb6c720https://github.com/plotly/plotly.js/pull/2681/commits/bb6c7201820468747976de41baa90f65a08eb4ee
https://github.com/alexcjohnson
base fractional colorbar size on post-expanded-margin plot sizehttps://github.com/plotly/plotly.js/pull/2681/commits/d02c76b3d1082996fa1c2543d7c8f08e08a256c0
d02c76bhttps://github.com/plotly/plotly.js/pull/2681/commits/d02c76b3d1082996fa1c2543d7c8f08e08a256c0
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jun 5, 2018 https://github.com/plotly/plotly.js/pull/2681#ref-pullrequest-329642208
Fix scatter3d scalar hovertext handling #2698 https://github.com/plotly/plotly.js/pull/2698
alexcjohnsonhttps://github.com/alexcjohnson
June 6, 2018 08:42https://github.com/plotly/plotly.js/pull/2681#commits-pushed-5d31324
https://github.com/alexcjohnson
comment and fix on assertPlotSize with margin.padhttps://github.com/plotly/plotly.js/pull/2681/commits/5d3132423a1a4a347528d80feb03ba6ad7bc356e
5d31324https://github.com/plotly/plotly.js/pull/2681/commits/5d3132423a1a4a347528d80feb03ba6ad7bc356e
https://github.com/alexcjohnson
reduce automargin padding for small explicit marginshttps://github.com/plotly/plotly.js/pull/2681/commits/16ea22a2b376c4ee258c31a82daeef7b48e12ccd
16ea22ahttps://github.com/plotly/plotly.js/pull/2681/commits/16ea22a2b376c4ee258c31a82daeef7b48e12ccd
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jun 6, 2018 https://github.com/plotly/plotly.js/pull/2681#pullrequestreview-126360599
View reviewed changes https://github.com/plotly/plotly.js/pull/2681/files/16ea22a2b376c4ee258c31a82daeef7b48e12ccd
src/plots/plots.jshttps://github.com/plotly/plotly.js/pull/2681/files/5d3132423a1a4a347528d80feb03ba6ad7bc356e..16ea22a2b376c4ee258c31a82daeef7b48e12ccd#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
alexcjohnsonhttps://github.com/alexcjohnson
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r193398523
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@etpinardhttps://github.com/etpinard
d02c76bhttps://github.com/plotly/plotly.js/commit/d02c76b3d1082996fa1c2543d7c8f08e08a256c0
#2681 (comment)https://github.com/plotly/plotly.js/pull/2681#discussion_r192409090
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
etpinardhttps://github.com/etpinard
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r193450420
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
https://github.com/alexcjohnson
axRange edits don't need drawMarginPushers after allhttps://github.com/plotly/plotly.js/pull/2681/commits/24aeb7c4761d345ea05a0bfa7053659f067717e5
https://github.com/plotly/plotly.js/commit/24aeb7c4761d345ea05a0bfa7053659f067717e5#comments
24aeb7chttps://github.com/plotly/plotly.js/pull/2681/commits/24aeb7c4761d345ea05a0bfa7053659f067717e5
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 6, 2018 https://github.com/plotly/plotly.js/pull/2681#pullrequestreview-126416938
View reviewed changes https://github.com/plotly/plotly.js/pull/2681/files/24aeb7c4761d345ea05a0bfa7053659f067717e5
src/components/sliders/draw.jshttps://github.com/plotly/plotly.js/pull/2681/files/24aeb7c4761d345ea05a0bfa7053659f067717e5#diff-97d6a8c76c33b6a617b7742909606862ce3730435dd4c9335c9b106326331ca0
etpinardhttps://github.com/etpinard
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r193443763
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/plotly/plotly.js/pull/2681/files#r191879632https://github.com/plotly/plotly.js/pull/2681/files#r191879632
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r193487881
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
230a782https://github.com/plotly/plotly.js/commit/230a782766ae9864eb5ac803c5fb069bedb9ab25
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 6, 2018 https://github.com/plotly/plotly.js/pull/2681#pullrequestreview-126422770
View reviewed changes https://github.com/plotly/plotly.js/pull/2681/files/24aeb7c4761d345ea05a0bfa7053659f067717e5
src/components/colorbar/draw.jshttps://github.com/plotly/plotly.js/pull/2681/files/24aeb7c4761d345ea05a0bfa7053659f067717e5#diff-d4553342c6e52682adb2af7a21b00a23de1609ff8167cad9e7d467fe67281265
etpinardhttps://github.com/etpinard
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r193448434
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
alexcjohnsonhttps://github.com/alexcjohnson
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#discussion_r193487813
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
230a782https://github.com/plotly/plotly.js/commit/230a782766ae9864eb5ac803c5fb069bedb9ab25
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jun 6, 2018 https://github.com/plotly/plotly.js/pull/2681#ref-issue-329951423
Automargin pipeline #2704 https://github.com/plotly/plotly.js/issues/2704
https://github.com/alexcjohnson
automargin comment updateshttps://github.com/plotly/plotly.js/pull/2681/commits/230a782766ae9864eb5ac803c5fb069bedb9ab25
230a782https://github.com/plotly/plotly.js/pull/2681/commits/230a782766ae9864eb5ac803c5fb069bedb9ab25
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#issuecomment-395148115
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
387db82https://github.com/plotly/plotly.js/commit/387db82562ce57d5e6478b2db73061f914c74c94
Jun 6, 2018https://github.com/plotly/plotly.js/pull/2681#event-1666700638
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
June 6, 2018 17:23https://github.com/plotly/plotly.js/pull/2681#event-1666700777
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jul 23, 2018 https://github.com/plotly/plotly.js/pull/2681#ref-issue-343793639
Plotly.deleteTraces leads to bad trace uid sequence #2836 https://github.com/plotly/plotly.js/issues/2836
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 4, 2018 https://github.com/plotly/plotly.js/pull/2681#ref-pullrequest-356205017
Parallel Categories (parcats) trace type for multi dimensional categorical data #2963 https://github.com/plotly/plotly.js/pull/2963
https://github.com/dmt0
dmt0https://github.com/dmt0
Oct 10, 2018 https://github.com/plotly/plotly.js/pull/2681#ref-issue-368828508
Trace uid not generated plotly/react-chart-editor#765 https://github.com/plotly/react-chart-editor/issues/765
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Nov 10, 2018 https://github.com/plotly/plotly.js/pull/2681#ref-pullrequest-379350857
Preserve ui state across Plotly.react redraws #3236 https://github.com/plotly/plotly.js/pull/3236
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2681
https://github.com/etpinard
etpinard https://github.com/etpinard
https://github.com/plotly/plotly.js/pull/2681/files/16ea22a2b376c4ee258c31a82daeef7b48e12ccd
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
v1.39.0 https://github.com/plotly/plotly.js/milestone/35
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2681
https://github.com/alexcjohnson
https://github.com/etpinard
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.