René's URL Explorer Experiment


Title: Finance refactor by alexcjohnson · Pull Request #2561 · plotly/plotly.js · GitHub

Open Graph Title: Finance refactor by alexcjohnson · Pull Request #2561 · plotly/plotly.js

X Title: Finance refactor by alexcjohnson · Pull Request #2561 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Finance refactor by alexcjohnson · Pull Request #2561 · plotly/plotly.js

Open Graph Description: Closes #2510 - Makes finance traces (OHLC, candlestick) into 🥇 first-class trace types. Along with this I added selection to both of these trace types. I did not however add custom selection styles...

X Description: Closes #2510 - Makes finance traces (OHLC, candlestick) into 🥇 first-class trace types. Along with this I added selection to both of these trace types. I did not however add custom selection styles...

Opengraph URL: https://github.com/plotly/plotly.js/pull/2561

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:76eab49c-3c71-b888-9601-584cf69f5bfe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC656:35E4DB:2602DC1:344646A:6A56CADB
html-safe-nonce01bd38d3beb1f54174b92bb78a23df858bda696a24ef2b580eff2c4c681ee081
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjU2OjM1RTREQjoyNjAyREMxOjM0NDY0NkE6NkE1NkNBREIiLCJ2aXNpdG9yX2lkIjoiOTAzOTc1MjkwMTAxNTU1NDc4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2d828abd5770ff952e5cef4b3e8ca176694094948913af188adc12100e9d5bd2
hovercard-subject-tagpull_request:181931318
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/2561/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e8526d076a1f6d0238622d8b2d5cb3b38bf5fa1ee971046d0b82cf5d929e3134/plotly/plotly.js/pull/2561
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e8526d076a1f6d0238622d8b2d5cb3b38bf5fa1ee971046d0b82cf5d929e3134/plotly/plotly.js/pull/2561
og:image:altCloses #2510 - Makes finance traces (OHLC, candlestick) into 🥇 first-class trace types. Along with this I added selection to both of these trace types. I did not however add custom selection styles...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealexcjohnson
hostnamegithub.com
expected-hostnamegithub.com
Nonedf99b7164e1d961b639cf5d3cbd6b5ba673edc67bd7e47cdc4746b96099e11ae
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3146ab55fc8763ab0e1d2a875e600b3a545bc751
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/2561#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2561
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2561
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/2561
Reloadhttps://github.com/plotly/plotly.js/pull/2561
Reloadhttps://github.com/plotly/plotly.js/pull/2561
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
plotly https://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
Notifications https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Fork 2k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Star 18.3k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Code https://github.com/plotly/plotly.js
Issues 772 https://github.com/plotly/plotly.js/issues
Pull requests 58 https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality 0 https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
Code https://github.com/plotly/plotly.js
Issues https://github.com/plotly/plotly.js/issues
Pull requests https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
alexcjohnsonhttps://github.com/alexcjohnson
masterhttps://github.com/plotly/plotly.js/tree/master
finance-refactorhttps://github.com/plotly/plotly.js/tree/finance-refactor
Conversationhttps://github.com/plotly/plotly.js/pull/2561
Commits25 (25)https://github.com/plotly/plotly.js/pull/2561/commits
Checkshttps://github.com/plotly/plotly.js/pull/2561/checks
Files changedhttps://github.com/plotly/plotly.js/pull/2561/files
Finance refactorhttps://github.com/plotly/plotly.js/pull/2561#top
alexcjohnsonhttps://github.com/alexcjohnson
masterhttps://github.com/plotly/plotly.js/tree/master
finance-refactorhttps://github.com/plotly/plotly.js/tree/finance-refactor
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#issue-314742416
#2510https://github.com/plotly/plotly.js/issues/2510
@etpinardhttps://github.com/etpinard
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
April 15, 2018 23:32https://github.com/plotly/plotly.js/pull/2561#commits-pushed-e979cf0
https://github.com/alexcjohnson
refactor candlestick into a first-class trace, also box/violin hover …https://github.com/plotly/plotly.js/pull/2561/commits/e979cf0dbf3493c8d693f0e3b0d44f9bff659cb4
e979cf0https://github.com/plotly/plotly.js/pull/2561/commits/e979cf0dbf3493c8d693f0e3b0d44f9bff659cb4
https://github.com/alexcjohnson
refactor OHLC into a first-class trace typehttps://github.com/plotly/plotly.js/pull/2561/commits/84c36a91091aa5524e6b2a9f0788766b622146de
84c36a9https://github.com/plotly/plotly.js/pull/2561/commits/84c36a91091aa5524e6b2a9f0788766b622146de
https://github.com/alexcjohnson
update non-finance tests for finance refactorhttps://github.com/plotly/plotly.js/pull/2561/commits/38705037992b0aaefb95d1b40ca67fa4860bab67
3870503https://github.com/plotly/plotly.js/pull/2561/commits/38705037992b0aaefb95d1b40ca67fa4860bab67
https://github.com/alexcjohnson
fix finance tests - with a couple of bugfixes toohttps://github.com/plotly/plotly.js/pull/2561/commits/4c46a73d0851ebbf262d462485670e51f46de114
4c46a73https://github.com/plotly/plotly.js/pull/2561/commits/4c46a73d0851ebbf262d462485670e51f46de114
https://github.com/alexcjohnson
fixhttps://github.com/plotly/plotly.js/pull/2561/commits/94c4560eb78e66f3c51912da547cfa27d66b7f5b
#2004https://github.com/plotly/plotly.js/issues/2004
94c4560https://github.com/plotly/plotly.js/pull/2561/commits/94c4560eb78e66f3c51912da547cfa27d66b7f5b
https://github.com/alexcjohnson
fix and test finance hover labels - including test forhttps://github.com/plotly/plotly.js/pull/2561/commits/3509b99223cf17d3770b5e56f8fbed0deae863cb
#1807https://github.com/plotly/plotly.js/issues/1807
3509b99https://github.com/plotly/plotly.js/pull/2561/commits/3509b99223cf17d3770b5e56f8fbed0deae863cb
https://github.com/alexcjohnson
test finance trace selecthttps://github.com/plotly/plotly.js/pull/2561/commits/2849ff9c920b69d66aa372ef3bbd075db9560a09
2849ff9https://github.com/plotly/plotly.js/pull/2561/commits/2849ff9c920b69d66aa372ef3bbd075db9560a09
https://github.com/alexcjohnson
🔪 hover test in finance_test - hover_label_test covers it betterhttps://github.com/plotly/plotly.js/pull/2561/commits/be2b523dc513bb2034e5242d419c12d834e5afd0
be2b523https://github.com/plotly/plotly.js/pull/2561/commits/be2b523dc513bb2034e5242d419c12d834e5afd0
https://github.com/alexcjohnson
fix prereqs for transform_multi_testhttps://github.com/plotly/plotly.js/pull/2561/commits/5b6a7d5066d1f856db68edad0e89640812ee3725
5b6a7d5https://github.com/plotly/plotly.js/pull/2561/commits/5b6a7d5066d1f856db68edad0e89640812ee3725
https://github.com/alexcjohnson
update finance bundle testshttps://github.com/plotly/plotly.js/pull/2561/commits/121d171f0e94d5d25201b06d8623ad173dfa4f9a
121d171https://github.com/plotly/plotly.js/pull/2561/commits/121d171f0e94d5d25201b06d8623ad173dfa4f9a
https://github.com/alexcjohnson
update finance mockshttps://github.com/plotly/plotly.js/pull/2561/commits/ad1d8f0e0654250763b99e01b9b70552134712a3
ad1d8f0https://github.com/plotly/plotly.js/pull/2561/commits/ad1d8f0e0654250763b99e01b9b70552134712a3
https://github.com/alexcjohnson
fix lf/uf vs min/max logic for box/violin/candlestickhttps://github.com/plotly/plotly.js/pull/2561/commits/2554482ebd84961ec5538cf163eff8dbd2e6a770
2554482https://github.com/plotly/plotly.js/pull/2561/commits/2554482ebd84961ec5538cf163eff8dbd2e6a770
https://github.com/alexcjohnson
fixhttps://github.com/plotly/plotly.js/pull/2561/commits/0d80a21458b31a2d8ec3c6a04428cc6fe8fdd949
#2510https://github.com/plotly/plotly.js/issues/2510
- or rather, revive the test that the refactor fixed thishttps://github.com/plotly/plotly.js/pull/2561/commits/0d80a21458b31a2d8ec3c6a04428cc6fe8fdd949
0d80a21https://github.com/plotly/plotly.js/pull/2561/commits/0d80a21458b31a2d8ec3c6a04428cc6fe8fdd949
https://github.com/alexcjohnson
tweak and test cleanData for finance traceshttps://github.com/plotly/plotly.js/pull/2561/commits/82677ac8745ca56da740302977533dffcd5521b6
82677achttps://github.com/plotly/plotly.js/pull/2561/commits/82677ac8745ca56da740302977533dffcd5521b6
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
feature https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#event-1576832962
https://github.com/etpinard
etpinardhttps://github.com/etpinard
v1.36.0https://github.com/plotly/plotly.js/milestone/32
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#event-1576956200
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 16, 2018 https://github.com/plotly/plotly.js/pull/2561#pullrequestreview-112544033
View reviewed changes https://github.com/plotly/plotly.js/pull/2561/files/82677ac8745ca56da740302977533dffcd5521b6
etpinardhttps://github.com/etpinard
https://github.com/plotly/plotly.js/pull/2561#pullrequestreview-112544033
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#1015https://github.com/plotly/plotly.js/issues/1015
#1217https://github.com/plotly/plotly.js/issues/1217
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
src/components/fx/hover.jshttps://github.com/plotly/plotly.js/pull/2561/files/82677ac8745ca56da740302977533dffcd5521b6#diff-754e3dde48df955de63f6c76eb1c43fed92a3931b9d7f51035a2d400029c8063
etpinardhttps://github.com/etpinard
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181848068
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181868919
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
etpinardhttps://github.com/etpinard
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181877249
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
src/components/rangeslider/draw.jshttps://github.com/plotly/plotly.js/pull/2561/files/82677ac8745ca56da740302977533dffcd5521b6#diff-8e04902c896e8bff31ff5d59a0ccf97b71779ecc5b2194cad2fcefe6488593fc
etpinardhttps://github.com/etpinard
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181851481
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
Apr 17, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r182088027
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
c77a8a3https://github.com/plotly/plotly.js/commit/c77a8a319ccfc6aeff044e48cee561e281dec21a
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
src/plot_api/plot_schema.jshttps://github.com/plotly/plotly.js/pull/2561/files/82677ac8745ca56da740302977533dffcd5521b6#diff-bad78aaf1b92069f85cf5f24a2720055802aeb95983235a15c2275b67e2a8817
etpinardhttps://github.com/etpinard
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181851930
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181871761
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
src/plots/cartesian/constants.jshttps://github.com/plotly/plotly.js/pull/2561/files/82677ac8745ca56da740302977533dffcd5521b6#diff-e895543188d8e53750b37a7b1c2f4653bfb6b4cfe070e07641bdfc6ba2ff5908
etpinardhttps://github.com/etpinard
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181852109
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181911423
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
0b7541ehttps://github.com/plotly/plotly.js/commit/0b7541e34d63ce74cddb5d243a652b2df0430b70
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
src/plots/cartesian/index.jshttps://github.com/plotly/plotly.js/pull/2561/files/82677ac8745ca56da740302977533dffcd5521b6#diff-8235b6d0b87fca3c0caaed994db8375802da313c433ec62a4d27e4a3fd8c5e8d
etpinardhttps://github.com/etpinard
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181852562
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
constants.traceLayerClasseshttps://github.com/plotly/plotly.js/blob/18e19a86a3e683c1d11f6f4a04eb7f89d1b6108f/src/plots/cartesian/constants.js#L64
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181902574
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
etpinardhttps://github.com/etpinard
Apr 17, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r182073576
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#2563https://github.com/plotly/plotly.js/issues/2563
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
src/traces/ohlc/hover.jshttps://github.com/plotly/plotly.js/pull/2561/files/82677ac8745ca56da740302977533dffcd5521b6#diff-d723a541b1386cda5b7c891f9de21f6afa665744114000fa11b15be4e15eaa52
etpinardhttps://github.com/etpinard
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181859015
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://user-images.githubusercontent.com/6675409/38830727-420a9206-418b-11e8-9fb7-4154936fefde.gif
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181915015
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
tinycolor.readability testhttps://github.com/plotly/plotly.js/blob/b938842854538d3b6b0bc3ff6eb2cb77964dc899/src/components/fx/hover.js#L1296
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
src/traces/ohlc/style.jshttps://github.com/plotly/plotly.js/pull/2561/files/82677ac8745ca56da740302977533dffcd5521b6#diff-7a862c20060db5e838c8c059555c7d187f8dd50712b77a5e79370e8aaffef8d3
etpinardhttps://github.com/etpinard
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181861023
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://user-images.githubusercontent.com/6675409/38830975-f5737d12-418b-11e8-98ab-9b83ceb1356c.png
https://user-images.githubusercontent.com/6675409/38831043-35d3d03c-418c-11e8-8e83-2e9f9255fab3.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181910861
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
f84dfaehttps://github.com/plotly/plotly.js/commit/f84dfae9d46b48fb84fd1be21c710a7dc2d346dd
0b7541ehttps://github.com/plotly/plotly.js/commit/0b7541e34d63ce74cddb5d243a652b2df0430b70
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
etpinardhttps://github.com/etpinard
Apr 17, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r182077712
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
f84dfaehttps://github.com/plotly/plotly.js/commit/f84dfae9d46b48fb84fd1be21c710a7dc2d346dd
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
test/jasmine/tests/plot_api_test.jshttps://github.com/plotly/plotly.js/pull/2561/files/82677ac8745ca56da740302977533dffcd5521b6#diff-7bf8ec1007c64f73d819779672f7da92e2dad599bb9a0171abdcd78f35412e74
etpinardhttps://github.com/etpinard
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181861481
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
test/jasmine/tests/plot_api_test.jshttps://github.com/plotly/plotly.js/pull/2561/files/82677ac8745ca56da740302977533dffcd5521b6#diff-7bf8ec1007c64f73d819779672f7da92e2dad599bb9a0171abdcd78f35412e74
etpinardhttps://github.com/etpinard
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181861944
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
can redraw with no changes as a noophttps://github.com/plotly/plotly.js/blob/7d91d29a48bc882afccda635054dfa1a7ece85fd/test/jasmine/tests/plot_api_test.js#L2856
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181910049
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
plotly.js/test/jasmine/tests/plot_api_test.jshttps://github.com/plotly/plotly.js/blob/7d91d29a48bc882afccda635054dfa1a7ece85fd/test/jasmine/tests/plot_api_test.js#L2826
7d91d29https://github.com/plotly/plotly.js/commit/7d91d29a48bc882afccda635054dfa1a7ece85fd
https://github.com/plotly/plotly.js/pull/2561/files#diff-5a140ce1cc87a420496039bbf8d699f1L2913https://github.com/plotly/plotly.js/pull/2561/files#diff-5a140ce1cc87a420496039bbf8d699f1L2913
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
test/jasmine/tests/select_test.jshttps://github.com/plotly/plotly.js/pull/2561/files/82677ac8745ca56da740302977533dffcd5521b6#diff-a7c1ee8a848c27897ce911fda564a5355511c4e8646a1a97024da39874ddbc83
etpinardhttps://github.com/etpinard
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181862356
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
etpinardhttps://github.com/etpinard
Apr 16, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r181862445
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
Apr 17, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r182060384
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
OHLC calculations are off on category axes #2004https://github.com/plotly/plotly.js/issues/2004
Event data for transformed traces is inconsistent #1807https://github.com/plotly/plotly.js/issues/1807
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
April 16, 2018 16:30https://github.com/plotly/plotly.js/pull/2561#commits-pushed-71fa112
https://github.com/alexcjohnson
remove plotSchema change from before we decided to refactor finance t…https://github.com/plotly/plotly.js/pull/2561/commits/71fa112bd5ec727338158f573c7d81d6a86930b1
71fa112https://github.com/plotly/plotly.js/pull/2561/commits/71fa112bd5ec727338158f573c7d81d6a86930b1
https://github.com/alexcjohnson
fix for box & candlestick together on one subplothttps://github.com/plotly/plotly.js/pull/2561/commits/0b7541e34d63ce74cddb5d243a652b2df0430b70
0b7541ehttps://github.com/plotly/plotly.js/pull/2561/commits/0b7541e34d63ce74cddb5d243a652b2df0430b70
#2004https://github.com/plotly/plotly.js/issues/2004
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Apr 16, 2018 https://github.com/plotly/plotly.js/pull/2561#ref-issue-314843312
Better update pattern for cartesian SVG #2563 https://github.com/plotly/plotly.js/issues/2563
alexcjohnsonhttps://github.com/alexcjohnson
April 16, 2018 19:01https://github.com/plotly/plotly.js/pull/2561#commits-pushed-f84dfae
https://github.com/alexcjohnson
change to shorter dash in finance_style mockhttps://github.com/plotly/plotly.js/pull/2561/commits/f84dfae9d46b48fb84fd1be21c710a7dc2d346dd
f84dfaehttps://github.com/plotly/plotly.js/pull/2561/commits/f84dfae9d46b48fb84fd1be21c710a7dc2d346dd
https://github.com/alexcjohnson
remove TODO that's been OK'd as ishttps://github.com/plotly/plotly.js/pull/2561/commits/d64fab68bcde681186e47b48b537e614cd67dcc6
d64fab6https://github.com/plotly/plotly.js/pull/2561/commits/d64fab68bcde681186e47b48b537e614cd67dcc6
https://github.com/alexcjohnson
undefined -> BADNUM in ohlc/calchttps://github.com/plotly/plotly.js/pull/2561/commits/dc016858219587070e633f32b248ae5497e384b4
dc01685https://github.com/plotly/plotly.js/pull/2561/commits/dc016858219587070e633f32b248ae5497e384b4
https://github.com/alexcjohnson
Merge branch 'master' into finance-refactorhttps://github.com/plotly/plotly.js/pull/2561/commits/c8b03ee27c10183692e1f85195f9140a746d43b5
c8b03eehttps://github.com/plotly/plotly.js/pull/2561/commits/c8b03ee27c10183692e1f85195f9140a746d43b5
https://github.com/alexcjohnson
update new getModuleCalcData callers to new APIhttps://github.com/plotly/plotly.js/pull/2561/commits/302d1e6b128a583ec9ae3b345035abcb1be49f52
302d1e6https://github.com/plotly/plotly.js/pull/2561/commits/302d1e6b128a583ec9ae3b345035abcb1be49f52
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Apr 17, 2018 https://github.com/plotly/plotly.js/pull/2561#pullrequestreview-112799350
View reviewed changes https://github.com/plotly/plotly.js/pull/2561/files/302d1e6b128a583ec9ae3b345035abcb1be49f52
src/traces/splom/base_plot.jshttps://github.com/plotly/plotly.js/pull/2561/files/c8b03ee27c10183692e1f85195f9140a746d43b5..302d1e6b128a583ec9ae3b345035abcb1be49f52#diff-d37ca2140c8ee23da6b0ce7fa6d67161b1de65c61f93b57bc8157b58b4a7915c
alexcjohnsonhttps://github.com/alexcjohnson
Apr 17, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r182064236
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@etpinardhttps://github.com/etpinard
0b7541ehttps://github.com/plotly/plotly.js/commit/0b7541e34d63ce74cddb5d243a652b2df0430b70
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
etpinardhttps://github.com/etpinard
Apr 17, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r182079018
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
0b7541ehttps://github.com/plotly/plotly.js/commit/0b7541e34d63ce74cddb5d243a652b2df0430b70
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 17, 2018 https://github.com/plotly/plotly.js/pull/2561#pullrequestreview-112815712
View reviewed changes https://github.com/plotly/plotly.js/pull/2561/files/0b7541e34d63ce74cddb5d243a652b2df0430b70
src/plots/get_data.jshttps://github.com/plotly/plotly.js/pull/2561/files/71fa112bd5ec727338158f573c7d81d6a86930b1..0b7541e34d63ce74cddb5d243a652b2df0430b70#diff-c0acb056af4b62464ae8bbdd7935887071a3b95fe2f289ab77762748b686f021
etpinardhttps://github.com/etpinard
Apr 17, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r182077260
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 17, 2018 https://github.com/plotly/plotly.js/pull/2561#pullrequestreview-112819045
View reviewed changes https://github.com/plotly/plotly.js/pull/2561/files/302d1e6b128a583ec9ae3b345035abcb1be49f52
src/components/legend/style.jshttps://github.com/plotly/plotly.js/pull/2561/files/302d1e6b128a583ec9ae3b345035abcb1be49f52#diff-3f7cb083e91b0a4c750484d81114195ba135277cb648d2b6751cdeaeacaffacf
etpinardhttps://github.com/etpinard
Apr 17, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r182080005
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
Apr 17, 2018https://github.com/plotly/plotly.js/pull/2561#discussion_r182083160
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
alexcjohnsonhttps://github.com/alexcjohnson
April 17, 2018 10:11https://github.com/plotly/plotly.js/pull/2561#commits-pushed-f498bd0
https://github.com/alexcjohnson
set to null instead of delete in ohlc/calchttps://github.com/plotly/plotly.js/pull/2561/commits/f498bd04e0541a4b6de7f7785d752fd6f1bb6481
f498bd0https://github.com/plotly/plotly.js/pull/2561/commits/f498bd04e0541a4b6de7f7785d752fd6f1bb6481
https://github.com/alexcjohnson
test that selection applies to plot, not rangesliderhttps://github.com/plotly/plotly.js/pull/2561/commits/c77a8a319ccfc6aeff044e48cee561e281dec21a
c77a8a3https://github.com/plotly/plotly.js/pull/2561/commits/c77a8a319ccfc6aeff044e48cee561e281dec21a
https://github.com/alexcjohnson
🔪 fithttps://github.com/plotly/plotly.js/pull/2561/commits/3f432531f59e73b2b36b1aad498c286f4efee53a
3f43253https://github.com/plotly/plotly.js/pull/2561/commits/3f432531f59e73b2b36b1aad498c286f4efee53a
https://github.com/alexcjohnson
mark polar drag test flakyhttps://github.com/plotly/plotly.js/pull/2561/commits/13204a9be522b20ec030b25f1a35d0e763281776
13204a9https://github.com/plotly/plotly.js/pull/2561/commits/13204a9be522b20ec030b25f1a35d0e763281776
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 17, 2018https://github.com/plotly/plotly.js/pull/2561#issuecomment-382024483
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
2a628dfhttps://github.com/plotly/plotly.js/commit/2a628df314029daedae3423d82c0e9b63d58fd55
Apr 17, 2018https://github.com/plotly/plotly.js/pull/2561#event-1579073950
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
April 17, 2018 14:59https://github.com/plotly/plotly.js/pull/2561#event-1579074114
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 17, 2018 https://github.com/plotly/plotly.js/pull/2561#ref-issue-306722280
Extra hover text not work in Candlestick charts #2481 https://github.com/plotly/plotly.js/issues/2481
https://github.com/chriddyp
chriddyphttps://github.com/chriddyp
Aug 28, 2018 https://github.com/plotly/plotly.js/pull/2561#ref-issue-354509129
relayoutData fails with Candlestick plots plotly/dash#355 https://github.com/plotly/dash/issues/355
https://github.com/rmarren1
rmarren1https://github.com/rmarren1
Aug 28, 2018 https://github.com/plotly/plotly.js/pull/2561#ref-pullrequest-354830611
Fix #260, allow '{}' as Graph.figure plotly/dash-core-components#285 https://github.com/plotly/dash-core-components/pull/285
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2561
https://github.com/etpinard
etpinard https://github.com/etpinard
https://github.com/plotly/plotly.js/pull/2561/files/302d1e6b128a583ec9ae3b345035abcb1be49f52
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
feature https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature
v1.36.0 https://github.com/plotly/plotly.js/milestone/32
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2561
https://github.com/alexcjohnson
https://github.com/etpinard
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.