| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:28650175-a4e7-9a43-b0fd-e61e18d7bc41 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AAC6:9FF13:15634CA:1D87235:6A57263A |
| html-safe-nonce | 0c3664601446aae4b2be09e8fed4a176974cfcadc777c7a521d88c7dc492500d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQUM2OjlGRjEzOjE1NjM0Q0E6MUQ4NzIzNTo2QTU3MjYzQSIsInZpc2l0b3JfaWQiOiIxMzE4ODI4ODY0NjA1NDY0MTIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1b3fc0a84c401d13013a27864f74bee6974e8aa35298b071d183497144cd6367 |
| hovercard-subject-tag | pull_request:59418223 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/255/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/32135e1b60e76690c31eb982e9f7b88dafe9b46d262b7e47e4cdeaef415d0f12/plotly/plotly.js/pull/255 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/32135e1b60e76690c31eb982e9f7b88dafe9b46d262b7e47e4cdeaef415d0f12/plotly/plotly.js/pull/255 |
| og:image:alt | As requested by @cpsievert in plotly/plotly.R#416 .
This PR also introduces jasmine tests for select and lasso event data.
Part of #145 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | etpinard |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98 |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2576d1f0198cf1588faf2edf27f1ed120903be10 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/255#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F255 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F255 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/255 |
| Reload | https://github.com/plotly/plotly.js/pull/255 |
| Reload | https://github.com/plotly/plotly.js/pull/255 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/255 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/255 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
772
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
58
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| emit-doubleclick | https://github.com/plotly/plotly.js/tree/emit-doubleclick |
| Conversation | https://github.com/plotly/plotly.js/pull/255 |
| Commits15 (15) | https://github.com/plotly/plotly.js/pull/255/commits |
| Checks | https://github.com/plotly/plotly.js/pull/255/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/255/files |
| Add doubleclick events | https://github.com/plotly/plotly.js/pull/255#top |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| emit-doubleclick | https://github.com/plotly/plotly.js/tree/emit-doubleclick |
|
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Feb 15, 2016 | https://github.com/plotly/plotly.js/pull/255#issue-133826960 |
| @cpsievert | https://github.com/cpsievert |
| plotly/plotly.R#416 | https://github.com/plotly/plotly.R/pull/416 |
| #145 | https://github.com/plotly/plotly.js/issues/145 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/255 |
| etpinard | https://github.com/etpinard |
| February 15, 2016 13:56 | https://github.com/plotly/plotly.js/pull/255#commits-pushed-bd6995e |
|
| https://github.com/etpinard |
| wip emit double click eventData | https://github.com/plotly/plotly.js/pull/255/commits/bd6995e484512070002128f3d25888425319b292 |
| bd6995e | https://github.com/plotly/plotly.js/pull/255/commits/bd6995e484512070002128f3d25888425319b292 |
|
| https://github.com/etpinard |
| emit 'plotly_doubleclick' events, | https://github.com/plotly/plotly.js/pull/255/commits/10cded2cf70a91a63458345cfb7b59a29b614b5c |
|
| https://github.com/plotly/plotly.js/commit/10cded2cf70a91a63458345cfb7b59a29b614b5c#comments |
| 10cded2 | https://github.com/plotly/plotly.js/pull/255/commits/10cded2cf70a91a63458345cfb7b59a29b614b5c |
|
| https://github.com/etpinard |
| flatten click test describe struc | https://github.com/plotly/plotly.js/pull/255/commits/8b6783f6608980e210ea249e44031029f6bab8a7 |
| 8b6783f | https://github.com/plotly/plotly.js/pull/255/commits/8b6783f6608980e210ea249e44031029f6bab8a7 |
|
| https://github.com/etpinard |
| add double click test | https://github.com/plotly/plotly.js/pull/255/commits/e8ef66306b4ebaf7df709de8880371026d6bbdf9 |
|
| https://github.com/plotly/plotly.js/commit/e8ef66306b4ebaf7df709de8880371026d6bbdf9#comments |
| e8ef663 | https://github.com/plotly/plotly.js/pull/255/commits/e8ef66306b4ebaf7df709de8880371026d6bbdf9 |
|
| https://github.com/etpinard |
| add select/lasso jasmine tests | https://github.com/plotly/plotly.js/pull/255/commits/d46ae26f89ef53de6bccebe1e2c6422c88e80846 |
|
| https://github.com/plotly/plotly.js/commit/d46ae26f89ef53de6bccebe1e2c6422c88e80846#comments |
| d46ae26 | https://github.com/plotly/plotly.js/pull/255/commits/d46ae26f89ef53de6bccebe1e2c6422c88e80846 |
|
| https://github.com/etpinard |
| revert Plots object in register, | https://github.com/plotly/plotly.js/pull/255/commits/02eca97ddf6c1398a407f30ab3c147a1c0635391 |
|
| https://github.com/plotly/plotly.js/commit/02eca97ddf6c1398a407f30ab3c147a1c0635391#comments |
| 02eca97 | https://github.com/plotly/plotly.js/pull/255/commits/02eca97ddf6c1398a407f30ab3c147a1c0635391 |
|
| https://github.com/etpinard |
| use toBeCloseTo to assert selection ranges, | https://github.com/plotly/plotly.js/pull/255/commits/782f6926a6abd552fc44a9f22e95f36d0daffa46 |
| 782f692 | https://github.com/plotly/plotly.js/pull/255/commits/782f6926a6abd552fc44a9f22e95f36d0daffa46 |
| mdtusz | https://github.com/mdtusz |
|
Feb 16, 2016
| https://github.com/plotly/plotly.js/pull/255#discussion-diff-53072818 |
| View reviewed changes
| https://github.com/plotly/plotly.js/pull/255/files/782f6926a6abd552fc44a9f22e95f36d0daffa46#diff-268a05547a93070b8548ae7745dfc38000d0fab658e844d83dc58b0f59b47e72 |
| test/jasmine/tests/register_test.js | https://github.com/plotly/plotly.js/pull/255/files#diff-268a05547a93070b8548ae7745dfc38000d0fab658e844d83dc58b0f59b47e72 |
| mdtusz | https://github.com/mdtusz |
| Feb 16, 2016 | https://github.com/plotly/plotly.js/pull/255#discussion_r53072818 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/255 |
| etpinard | https://github.com/etpinard |
| Feb 16, 2016 | https://github.com/plotly/plotly.js/pull/255#discussion_r53073088 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/255 |
| mdtusz | https://github.com/mdtusz |
| Feb 16, 2016 | https://github.com/plotly/plotly.js/pull/255#discussion_r53073468 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/255 |
| etpinard | https://github.com/etpinard |
| February 17, 2016 11:23 | https://github.com/plotly/plotly.js/pull/255#commits-pushed-5b1e895 |
|
| https://github.com/etpinard |
| add comment about click events simulators | https://github.com/plotly/plotly.js/pull/255/commits/5b1e89568cdd420e7969c4aa19118e88acadb02c |
| 5b1e895 | https://github.com/plotly/plotly.js/pull/255/commits/5b1e89568cdd420e7969c4aa19118e88acadb02c |
|
| https://github.com/etpinard |
| make jasmine describe more explicit | https://github.com/plotly/plotly.js/pull/255/commits/c41a7565a55a489cc9db010399272f93bd309a32 |
| c41a756 | https://github.com/plotly/plotly.js/pull/255/commits/c41a7565a55a489cc9db010399272f93bd309a32 |
|
| https://github.com/etpinard |
| try sending hoverdata on double click: | https://github.com/plotly/plotly.js/pull/255/commits/9c19406d25df3f90c033feb0fdcc488b85febbea |
| 9c19406 | https://github.com/plotly/plotly.js/pull/255/commits/9c19406d25df3f90c033feb0fdcc488b85febbea |
|
| https://github.com/etpinard |
| Merge branch 'master' into emit-doubleclick | https://github.com/plotly/plotly.js/pull/255/commits/e7e08890d03b59499a7279ee0d611f2628128dce |
| e7e0889 | https://github.com/plotly/plotly.js/pull/255/commits/e7e08890d03b59499a7279ee0d611f2628128dce |
|
| https://github.com/etpinard |
| move destroyGraphDiv to suite level | https://github.com/plotly/plotly.js/pull/255/commits/848f4a555dd51d41ae65ef6a637e8ffd130c115c |
| 848f4a5 | https://github.com/plotly/plotly.js/pull/255/commits/848f4a555dd51d41ae65ef6a637e8ffd130c115c |
|
| https://github.com/etpinard |
| send null on plotly_doubleclick events: | https://github.com/plotly/plotly.js/pull/255/commits/4c5103f01e0016b6ee08037d705627b96bcbf26d |
| 4c5103f | https://github.com/plotly/plotly.js/pull/255/commits/4c5103f01e0016b6ee08037d705627b96bcbf26d |
|
| https://github.com/etpinard |
| make doubleclick in select/lasso mode emit its own event: plotly_dese… | https://github.com/plotly/plotly.js/pull/255/commits/d517c4fad97eb181109abfeb99ffb8cc791de015 |
| d517c4f | https://github.com/plotly/plotly.js/pull/255/commits/d517c4fad97eb181109abfeb99ffb8cc791de015 |
|
| https://github.com/etpinard |
| update click and select tests | https://github.com/plotly/plotly.js/pull/255/commits/90edb188ff68bde7bfd7e8befbe5059781187a89 |
| 90edb18 | https://github.com/plotly/plotly.js/pull/255/commits/90edb188ff68bde7bfd7e8befbe5059781187a89 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
| Feb 24, 2016 | https://github.com/plotly/plotly.js/pull/255#event-564081700 |
| https://github.com/mdtusz |
| mdtusz | https://github.com/mdtusz |
| Feb 24, 2016 | https://github.com/plotly/plotly.js/pull/255#issuecomment-188402014 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/255 |
| etpinard | https://github.com/etpinard |
|
Feb 24, 2016
| https://github.com/plotly/plotly.js/pull/255#discussion-diff-53989467 |
| View reviewed changes
| https://github.com/plotly/plotly.js/pull/255/files/90edb188ff68bde7bfd7e8befbe5059781187a89#diff-bd7d37269e85636499f7ab275126298608f098fa35eb9e56375b97463f17683d |
| src/plots/cartesian/select.js | https://github.com/plotly/plotly.js/pull/255/files#diff-bd7d37269e85636499f7ab275126298608f098fa35eb9e56375b97463f17683d |
| etpinard | https://github.com/etpinard |
| Feb 24, 2016 | https://github.com/plotly/plotly.js/pull/255#discussion_r53989467 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @cpsievert | https://github.com/cpsievert |
| Please reload this page | https://github.com/plotly/plotly.js/pull/255 |
| etpinard | https://github.com/etpinard |
|
Feb 24, 2016
| https://github.com/plotly/plotly.js/pull/255#ref-commit-5d35fd6 |
|
| https://github.com/etpinard |
| Merge pull request | https://github.com/plotly/plotly.js/commit/5d35fd6ed5605f0e700ee1c37b9b849c6051ecb0 |
| #255 | https://github.com/plotly/plotly.js/pull/255 |
| from plotly/emit-doubleclick | https://github.com/plotly/plotly.js/commit/5d35fd6ed5605f0e700ee1c37b9b849c6051ecb0 |
| 5d35fd6 | https://github.com/plotly/plotly.js/commit/5d35fd6ed5605f0e700ee1c37b9b849c6051ecb0 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| 5d35fd6 | https://github.com/plotly/plotly.js/commit/5d35fd6ed5605f0e700ee1c37b9b849c6051ecb0 |
| Feb 24, 2016 | https://github.com/plotly/plotly.js/pull/255#event-564168228 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| February 24, 2016 19:09 | https://github.com/plotly/plotly.js/pull/255#event-564168267 |
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
| Feb 25, 2016 | https://github.com/plotly/plotly.js/pull/255#issuecomment-188647818 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/255 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Nov 14, 2016
| https://github.com/plotly/plotly.js/pull/255#ref-issue-189081779 |
|
Double click event not fired anymore after selection
#1138
| https://github.com/plotly/plotly.js/issues/1138 |
| https://github.com/aravindb26 |
| aravindb26 | https://github.com/aravindb26 |
|
Dec 29, 2023
| https://github.com/plotly/plotly.js/pull/255#ref-pullrequest-2060286304 |
|
[Snyk] Upgrade tinycolor2 from 1.4.2 to 1.6.0
aravindb26/plotly.js#1
| https://github.com/aravindb26/plotly.js/pull/1 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F255 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/255 |
|
| https://github.com/etpinard |
|
| https://github.com/mdtusz |
|
| https://github.com/cpsievert |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |