René's URL Explorer Experiment


Title: ZERO circular dependency by etpinard · Pull Request #2429 · plotly/plotly.js · GitHub

Open Graph Title: ZERO circular dependency by etpinard · Pull Request #2429 · plotly/plotly.js

X Title: ZERO circular dependency by etpinard · Pull Request #2429 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - ZERO circular dependency by etpinard · Pull Request #2429 · plotly/plotly.js

Open Graph Description: resolves #236 and closes milestone/9. I started working on this PR when I noticed that the new layout grid module from #2399 has a circular dependency: This went unnoticed because some other PR(s)...

X Description: resolves #236 and closes milestone/9. I started working on this PR when I noticed that the new layout grid module from #2399 has a circular dependency: This went unnoticed because some other PR(s)...

Opengraph URL: https://github.com/plotly/plotly.js/pull/2429

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8635ea5a-8f09-e0d3-4791-35ed19e09aa8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9EFA:C9C8C:1600786:200185F:6A54CD40
html-safe-nonce161da6ee8f0ee46f862ae62c4368201ae748d02a7ef12d2e71d7349fb2f93ed8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUZBOkM5QzhDOjE2MDA3ODY6MjAwMTg1Rjo2QTU0Q0Q0MCIsInZpc2l0b3JfaWQiOiIxMTYyMjUwNTE4OTU1MDg1MTIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac8933b391c606c1ecf47e5cf9980ac6ef9c75d52e9c093df715f61f6a46531a7c
hovercard-subject-tagpull_request:172357649
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/2429/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/7ddc715eb596ec55f8d86871e11f17a21aba59f9f6b5609327a3c16119c69920/plotly/plotly.js/pull/2429
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7ddc715eb596ec55f8d86871e11f17a21aba59f9f6b5609327a3c16119c69920/plotly/plotly.js/pull/2429
og:image:altresolves #236 and closes milestone/9. I started working on this PR when I noticed that the new layout grid module from #2399 has a circular dependency: This went unnoticed because some other PR(s)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameetpinard
hostnamegithub.com
expected-hostnamegithub.com
None6e5f2e6ff3f430aa60a674066f957bca9f2106017e1b68126417422b58ce6e1e
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebe4d48619391052c9d312c7b587bb2ac38a97f57
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/2429#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2429
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2429
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/2429
Reloadhttps://github.com/plotly/plotly.js/pull/2429
Reloadhttps://github.com/plotly/plotly.js/pull/2429
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
plotly https://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
Notifications https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Fork 2k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Star 18.3k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Code https://github.com/plotly/plotly.js
Issues 773 https://github.com/plotly/plotly.js/issues
Pull requests 61 https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality 0 https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
Code https://github.com/plotly/plotly.js
Issues https://github.com/plotly/plotly.js/issues
Pull requests https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
zero-circular-dephttps://github.com/plotly/plotly.js/tree/zero-circular-dep
Conversationhttps://github.com/plotly/plotly.js/pull/2429
Commits17 (17)https://github.com/plotly/plotly.js/pull/2429/commits
Checkshttps://github.com/plotly/plotly.js/pull/2429/checks
Files changedhttps://github.com/plotly/plotly.js/pull/2429/files
ZERO circular dependency https://github.com/plotly/plotly.js/pull/2429#top
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
zero-circular-dephttps://github.com/plotly/plotly.js/tree/zero-circular-dep
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2429#issue-301564662
#236https://github.com/plotly/plotly.js/issues/236
milestone/9https://github.com/plotly/plotly.js/milestone/9
#2399https://github.com/plotly/plotly.js/pull/2399
https://user-images.githubusercontent.com/6675409/36869791-fa922fa4-1d6a-11e8-9c5b-affb9354bddd.png
https://user-images.githubusercontent.com/6675409/36869847-2ac54670-1d6b-11e8-92c4-85288f2c7770.png
16 or lesshttps://github.com/plotly/plotly.js/blob/113b3618732f28d1a2158771544bf4e60e00c084/tasks/test_syntax.js#L264
bee37ddhttps://github.com/plotly/plotly.js/commit/bee37dd1ca6f9f96d9c466baa8c1d8a22f7e33d2
87275afhttps://github.com/plotly/plotly.js/commit/87275afe4b9db337c3201cbbee629d7f3b80f8bb
Eliminate circular dependencies #2032 (comment)https://github.com/plotly/plotly.js/pull/2032#issuecomment-332272263
browser-pack-flathttps://github.com/goto-bus-stop/browser-pack-flat
tinyifyhttps://github.com/browserify/tinyify
@alexcjohnsonhttps://github.com/alexcjohnson
@nicolaskruchtenhttps://github.com/nicolaskruchten
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
etpinardhttps://github.com/etpinard
March 1, 2018 15:31https://github.com/plotly/plotly.js/pull/2429#commits-pushed-bee37dd
https://github.com/etpinard
move grid module to components/https://github.com/plotly/plotly.js/pull/2429/commits/bee37dd1ca6f9f96d9c466baa8c1d8a22f7e33d2
bee37ddhttps://github.com/plotly/plotly.js/pull/2429/commits/bee37dd1ca6f9f96d9c466baa8c1d8a22f7e33d2
https://github.com/etpinard
merge src/plot_api/register.js into src/registry.jshttps://github.com/plotly/plotly.js/pull/2429/commits/973abbc9f2fb95ea247c0a28cbd3323bf2f4022a
973abbchttps://github.com/plotly/plotly.js/pull/2429/commits/973abbc9f2fb95ea247c0a28cbd3323bf2f4022a
https://github.com/etpinard
fixeshttps://github.com/plotly/plotly.js/pull/2429/commits/b08c4020e74e1a2df028afd74f4ec44c44ea1430
#621https://github.com/plotly/plotly.js/issues/621
- make x/y/z dependent error bar attributeshttps://github.com/plotly/plotly.js/pull/2429/commits/b08c4020e74e1a2df028afd74f4ec44c44ea1430
b08c402https://github.com/plotly/plotly.js/pull/2429/commits/b08c4020e74e1a2df028afd74f4ec44c44ea1430
https://github.com/etpinard
use errorbars methods via getComponentMethodhttps://github.com/plotly/plotly.js/pull/2429/commits/87275afe4b9db337c3201cbbee629d7f3b80f8bb
87275afhttps://github.com/plotly/plotly.js/pull/2429/commits/87275afe4b9db337c3201cbbee629d7f3b80f8bb
https://github.com/etpinard
add apiMethodRegistry in src/registryhttps://github.com/plotly/plotly.js/pull/2429/commits/52b83b322a23374d7b35db032d723a00dc17a1ef
52b83b3https://github.com/plotly/plotly.js/pull/2429/commits/52b83b322a23374d7b35db032d723a00dc17a1ef
https://github.com/etpinard
add Registry.call method + use it to 🔪 circular deps !!!https://github.com/plotly/plotly.js/pull/2429/commits/9fc8832944275872b40a9ffd0966476847ba4833
9fc8832https://github.com/plotly/plotly.js/pull/2429/commits/9fc8832944275872b40a9ffd0966476847ba4833
https://github.com/etpinard
move Plotly.setPlotConfig to plot_api.jshttps://github.com/plotly/plotly.js/pull/2429/commits/381b6e402326395b228e6dbb97cedd66c1c6e8d1
381b6e4https://github.com/plotly/plotly.js/pull/2429/commits/381b6e402326395b228e6dbb97cedd66c1c6e8d1
https://github.com/etpinard
use Registry.traceIs instead of plots.traceIs copyhttps://github.com/plotly/plotly.js/pull/2429/commits/ed8d56daaed2f07e4d48bfd999cc91403a64b1f3
ed8d56dhttps://github.com/plotly/plotly.js/pull/2429/commits/ed8d56daaed2f07e4d48bfd999cc91403a64b1f3
https://github.com/etpinard
🔪 src/plotly.js !!!https://github.com/plotly/plotly.js/pull/2429/commits/204799c12e9cc455761fcfec6c9ce883a454fdf4
204799chttps://github.com/plotly/plotly.js/pull/2429/commits/204799c12e9cc455761fcfec6c9ce883a454fdf4
https://github.com/etpinard
🔒 down circular dep test at 0️⃣https://github.com/plotly/plotly.js/pull/2429/commits/2c529ec5515b48c93cbf2b5290ed09777e5b4da9
2c529echttps://github.com/plotly/plotly.js/pull/2429/commits/2c529ec5515b48c93cbf2b5290ed09777e5b4da9
https://github.com/etpinard
update tests (mostly update ref to spyOn modules)https://github.com/plotly/plotly.js/pull/2429/commits/c6df699be0c4c51921d31923b6abfaf63bec7d5f
c6df699https://github.com/plotly/plotly.js/pull/2429/commits/c6df699be0c4c51921d31923b6abfaf63bec7d5f
https://github.com/etpinard
add flaky tag to scattergl visible toggle testhttps://github.com/plotly/plotly.js/pull/2429/commits/011443eb73ea89aef14e798570c4ad200ae25b5b
011443ehttps://github.com/plotly/plotly.js/pull/2429/commits/011443eb73ea89aef14e798570c4ad200ae25b5b
https://github.com/etpinard
etpinardhttps://github.com/etpinard
type: maintenance https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22type%3A%20maintenance%22
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2429#event-1499976070
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Decircularise src dependencieshttps://github.com/plotly/plotly.js/milestone/9
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2429#event-1499976073
https://github.com/nicolaskruchten
nicolaskruchtenhttps://github.com/nicolaskruchten
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2429#issuecomment-369737515
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018 https://github.com/plotly/plotly.js/pull/2429#pullrequestreview-100622101
View reviewed changes https://github.com/plotly/plotly.js/pull/2429/files/bee37dd1ca6f9f96d9c466baa8c1d8a22f7e33d2
src/plots/plots.jshttps://github.com/plotly/plotly.js/pull/2429/files/bee37dd1ca6f9f96d9c466baa8c1d8a22f7e33d2#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171718028
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
etpinardhttps://github.com/etpinard
Mar 2, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171919366
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
9246fdahttps://github.com/plotly/plotly.js/commit/9246fdad6a85f812d23900e772ae210bac52d283
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018 https://github.com/plotly/plotly.js/pull/2429#pullrequestreview-100626486
View reviewed changes https://github.com/plotly/plotly.js/pull/2429/files/973abbc9f2fb95ea247c0a28cbd3323bf2f4022a
test/jasmine/tests/register_test.jshttps://github.com/plotly/plotly.js/pull/2429/files/bee37dd1ca6f9f96d9c466baa8c1d8a22f7e33d2..973abbc9f2fb95ea247c0a28cbd3323bf2f4022a#diff-268a05547a93070b8548ae7745dfc38000d0fab658e844d83dc58b0f59b47e72
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171721589
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
etpinardhttps://github.com/etpinard
Mar 2, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171919405
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
e05f4f0https://github.com/plotly/plotly.js/commit/e05f4f0db66c6797a88d62eaa67a07a7e1f5fe32
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018 https://github.com/plotly/plotly.js/pull/2429#pullrequestreview-100627814
View reviewed changes https://github.com/plotly/plotly.js/pull/2429/files/973abbc9f2fb95ea247c0a28cbd3323bf2f4022a
test/jasmine/tests/register_test.jshttps://github.com/plotly/plotly.js/pull/2429/files/bee37dd1ca6f9f96d9c466baa8c1d8a22f7e33d2..973abbc9f2fb95ea247c0a28cbd3323bf2f4022a#diff-268a05547a93070b8548ae7745dfc38000d0fab658e844d83dc58b0f59b47e72
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171722831
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
etpinardhttps://github.com/etpinard
Mar 2, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171919454
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
e05f4f0https://github.com/plotly/plotly.js/commit/e05f4f0db66c6797a88d62eaa67a07a7e1f5fe32
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018 https://github.com/plotly/plotly.js/pull/2429#pullrequestreview-100634927
View reviewed changes https://github.com/plotly/plotly.js/pull/2429/files/9fc8832944275872b40a9ffd0966476847ba4833
src/registry.jshttps://github.com/plotly/plotly.js/pull/2429/files/52b83b322a23374d7b35db032d723a00dc17a1ef..9fc8832944275872b40a9ffd0966476847ba4833#diff-6efa459195aa6a16acf1881f44b29387517661c51663be454b427ae815f6eded
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171728952
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
etpinardhttps://github.com/etpinard
Mar 2, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171884486
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
blockhttps://github.com/plotly/plotly.js/blob/113b3618732f28d1a2158771544bf4e60e00c084/src/plots/command.js#L264-L281
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
alexcjohnsonhttps://github.com/alexcjohnson
Mar 2, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171897670
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
etpinardhttps://github.com/etpinard
Mar 2, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171919596
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
705aed6https://github.com/plotly/plotly.js/commit/705aed622d42648d55b4497c93486ea96921e1a0
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018 https://github.com/plotly/plotly.js/pull/2429#pullrequestreview-100635803
View reviewed changes https://github.com/plotly/plotly.js/pull/2429/files/2c529ec5515b48c93cbf2b5290ed09777e5b4da9
tasks/test_syntax.jshttps://github.com/plotly/plotly.js/pull/2429/files/204799c12e9cc455761fcfec6c9ce883a454fdf4..2c529ec5515b48c93cbf2b5290ed09777e5b4da9#diff-c8f6e94ef0c816b82b00993d5ba5a427998386763e5aab80684e18ab5cf330c1
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171729711
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
etpinardhttps://github.com/etpinard
Mar 2, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171919516
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
d27b3bahttps://github.com/plotly/plotly.js/commit/d27b3baa880b8b41fd61d9caf3050d26ce7a7f19
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2429#issuecomment-369772530
@etpinardhttps://github.com/etpinard
Registry.call signaturehttps://github.com/plotly/plotly.js/pull/2429#discussion_r171728952
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
etpinardhttps://github.com/etpinard
March 2, 2018 12:16https://github.com/plotly/plotly.js/pull/2429#commits-pushed-9246fda
https://github.com/etpinard
grab Grid module method using Registry.getComponentMethodhttps://github.com/plotly/plotly.js/pull/2429/commits/9246fdad6a85f812d23900e772ae210bac52d283
9246fdahttps://github.com/plotly/plotly.js/pull/2429/commits/9246fdad6a85f812d23900e772ae210bac52d283
https://github.com/etpinard
fix typo in test_syntaxhttps://github.com/plotly/plotly.js/pull/2429/commits/d27b3baa880b8b41fd61d9caf3050d26ce7a7f19
d27b3bahttps://github.com/plotly/plotly.js/pull/2429/commits/d27b3baa880b8b41fd61d9caf3050d26ce7a7f19
https://github.com/etpinard
rename register_test -> registry_test & improve it!https://github.com/plotly/plotly.js/pull/2429/commits/e05f4f0db66c6797a88d62eaa67a07a7e1f5fe32
e05f4f0https://github.com/plotly/plotly.js/pull/2429/commits/e05f4f0db66c6797a88d62eaa67a07a7e1f5fe32
https://github.com/etpinard
replace Registry.call('', []) with Registry.call('', ...[])https://github.com/plotly/plotly.js/pull/2429/commits/705aed622d42648d55b4497c93486ea96921e1a0
705aed6https://github.com/plotly/plotly.js/pull/2429/commits/705aed622d42648d55b4497c93486ea96921e1a0
https://github.com/etpinard
no need for Registry in plot_api/to_imagehttps://github.com/plotly/plotly.js/pull/2429/commits/a851aa5a4c63bd385ab08e6e2867c01cf8570ff7
a851aa5https://github.com/plotly/plotly.js/pull/2429/commits/a851aa5a4c63bd385ab08e6e2867c01cf8570ff7
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Mar 2, 2018https://github.com/plotly/plotly.js/pull/2429#issuecomment-370003418
https://github.com/plotly/plotly-webpack/issues/2#issuecomment-333256054https://github.com/plotly/plotly-webpack/issues/2#issuecomment-333256054
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Mar 2, 2018 https://github.com/plotly/plotly.js/pull/2429#pullrequestreview-100882905
View reviewed changes https://github.com/plotly/plotly.js/pull/2429/files/a851aa5a4c63bd385ab08e6e2867c01cf8570ff7
src/plot_api/to_image.jshttps://github.com/plotly/plotly.js/pull/2429/files/705aed622d42648d55b4497c93486ea96921e1a0..a851aa5a4c63bd385ab08e6e2867c01cf8570ff7#diff-6aa51b427928317ed30c4f63936705428df517f7cb91121222aeac348d8d0a57
alexcjohnsonhttps://github.com/alexcjohnson
Mar 2, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171937819
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
etpinardhttps://github.com/etpinard
Mar 2, 2018https://github.com/plotly/plotly.js/pull/2429#discussion_r171942252
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Mar 2, 2018https://github.com/plotly/plotly.js/pull/2429#issuecomment-370025966
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
https://github.com/etpinard
etpinardhttps://github.com/etpinard
13eb982https://github.com/plotly/plotly.js/commit/13eb982ec9700ee9fe6cb8a93ee12d4ee8b0a215
Mar 2, 2018https://github.com/plotly/plotly.js/pull/2429#event-1501845692
https://github.com/etpinard
etpinardhttps://github.com/etpinard
March 2, 2018 19:34https://github.com/plotly/plotly.js/pull/2429#event-1501845777
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Mar 6, 2018 https://github.com/plotly/plotly.js/pull/2429#ref-pullrequest-302804040
Bundle with browser-pack-flat plugin #2447 https://github.com/plotly/plotly.js/pull/2447
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2429
https://github.com/alexcjohnson
alexcjohnson https://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/2429/files/a851aa5a4c63bd385ab08e6e2867c01cf8570ff7
Decircularise src dependencies https://github.com/plotly/plotly.js/milestone/9
De-circularize plotly.js require statements https://github.com/plotly/plotly.js/issues/236
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2429
https://github.com/etpinard
https://github.com/nicolaskruchten
https://github.com/alexcjohnson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.