René's URL Explorer Experiment


Title: Legend scroll fix by alexcjohnson · Pull Request #2426 · plotly/plotly.js · GitHub

Open Graph Title: Legend scroll fix by alexcjohnson · Pull Request #2426 · plotly/plotly.js

X Title: Legend scroll fix by alexcjohnson · Pull Request #2426 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Legend scroll fix by alexcjohnson · Pull Request #2426 · plotly/plotly.js

Open Graph Description: Fixes #2387 - don't allow dragging from the scroll box of a legend, only from the scroll bar itself, and even then not on right clicks, only left click. I also made the scroll bar handle a litt...

X Description: Fixes #2387 - don't allow dragging from the scroll box of a legend, only from the scroll bar itself, and even then not on right clicks, only left click. I also made the scroll bar handle a ...

Opengraph URL: https://github.com/plotly/plotly.js/pull/2426

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0fcdcedb-b13b-b3c4-7eb4-607f1b79ea02
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDA92:2E124E:355EB4E:4434276:6B01F02C
html-safe-nonce35355d6d2804d148ae4168c860a30985bbc70429a8ba0a6891b0ee880f2a88c0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTkyOjJFMTI0RTozNTVFQjRFOjQ0MzQyNzY6NkIwMUYwMkMiLCJ2aXNpdG9yX2lkIjoiNDcxMTYwMDQ0NTcyNDk0NjQ3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4b2ee15844f5d68da1a8cffb83411c0ef4f9013fe971b8b2f017262ced5e5c30
hovercard-subject-tagpull_request:172071952
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/2426/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/16656a2e5b8ac78005feaffa94d2ba3e33b9d518c4e59f26611c38456bfbc137/plotly/plotly.js/pull/2426
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/16656a2e5b8ac78005feaffa94d2ba3e33b9d518c4e59f26611c38456bfbc137/plotly/plotly.js/pull/2426
og:image:altFixes #2387 - don't allow dragging from the scroll box of a legend, only from the scroll bar itself, and even then not on right clicks, only left click. I also made the scroll bar handle a litt...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealexcjohnson
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/2426#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2426
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2426
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/2426
Reloadhttps://github.com/plotly/plotly.js/pull/2426
Reloadhttps://github.com/plotly/plotly.js/pull/2426
plotlyhttps://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Codehttps://github.com/plotly/plotly.js
Issues726 (726)https://github.com/plotly/plotly.js/issues
Pull requests84 (84)https://github.com/plotly/plotly.js/pulls
Actionshttps://github.com/plotly/plotly.js/actions
Security and qualityhttps://github.com/plotly/plotly.js/security
Insightshttps://github.com/plotly/plotly.js/insights
https://github.com/plotly/plotly.js
alexcjohnsonhttps://github.com/alexcjohnson
masterhttps://github.com/plotly/plotly.js/tree/master
legend-scroll-fixhttps://github.com/plotly/plotly.js/tree/legend-scroll-fix
Conversationhttps://github.com/plotly/plotly.js/pull/2426
Commits6 (6)https://github.com/plotly/plotly.js/pull/2426/commits
Checkshttps://github.com/plotly/plotly.js/pull/2426/checks
Files changedhttps://github.com/plotly/plotly.js/pull/2426/files
Legend scroll fixhttps://github.com/plotly/plotly.js/pull/2426#top
alexcjohnsonhttps://github.com/alexcjohnson
masterhttps://github.com/plotly/plotly.js/tree/master
legend-scroll-fixhttps://github.com/plotly/plotly.js/tree/legend-scroll-fix
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Feb 28, 2018https://github.com/plotly/plotly.js/pull/2426#issue-301182357
#2387https://github.com/plotly/plotly.js/issues/2387
#1859https://github.com/plotly/plotly.js/issues/1859
@etpinardhttps://github.com/etpinard
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
alexcjohnsonhttps://github.com/alexcjohnson
February 28, 2018 15:59https://github.com/plotly/plotly.js/pull/2426#commits-pushed-f75f5ba
https://github.com/alexcjohnson
fixhttps://github.com/plotly/plotly.js/pull/2426/commits/f75f5ba325e7c80d93272b71585d0e31ceac4f48
#2387https://github.com/plotly/plotly.js/issues/2387
- prevent legend scrolling from scrollBox drag or right clickhttps://github.com/plotly/plotly.js/pull/2426/commits/f75f5ba325e7c80d93272b71585d0e31ceac4f48
f75f5bahttps://github.com/plotly/plotly.js/pull/2426/commits/f75f5ba325e7c80d93272b71585d0e31ceac4f48
https://github.com/alexcjohnson
grab the legend scrollbar at the cursor, not at its middlehttps://github.com/plotly/plotly.js/pull/2426/commits/ec42784f1b05fd66dee5a2f7ad11aeeaf6e0a0f3
ec42784https://github.com/plotly/plotly.js/pull/2426/commits/ec42784f1b05fd66dee5a2f7ad11aeeaf6e0a0f3
https://github.com/alexcjohnson
make legend scrollbar scale to the visible fractionhttps://github.com/plotly/plotly.js/pull/2426/commits/246b77fb563c21176df56aad31bf366c734530a3
246b77fhttps://github.com/plotly/plotly.js/pull/2426/commits/246b77fb563c21176df56aad31bf366c734530a3
#1859https://github.com/plotly/plotly.js/issues/1859
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Feb 28, 2018https://github.com/plotly/plotly.js/pull/2426#issuecomment-369387272
https://user-images.githubusercontent.com/2678795/36813714-7990149c-1ca3-11e8-88c9-033ba5375e6d.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
Feb 28, 2018https://github.com/plotly/plotly.js/pull/2426#event-1497701470
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Feb 28, 2018https://github.com/plotly/plotly.js/pull/2426#issuecomment-369389245
#1859https://github.com/plotly/plotly.js/issues/1859
#2054https://github.com/plotly/plotly.js/issues/2054
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Feb 28, 2018 https://github.com/plotly/plotly.js/pull/2426#pullrequestreview-100236522
View reviewed changes https://github.com/plotly/plotly.js/pull/2426/files/f75f5ba325e7c80d93272b71585d0e31ceac4f48
test/jasmine/tests/legend_scroll_test.jshttps://github.com/plotly/plotly.js/pull/2426/files/f75f5ba325e7c80d93272b71585d0e31ceac4f48#diff-1c9011cecef7c5fa1a9ae135b7282735601013c5e703ee0da2f47853c0f462ba
etpinardhttps://github.com/etpinard
Feb 28, 2018https://github.com/plotly/plotly.js/pull/2426#discussion_r171391622
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#2387https://github.com/plotly/plotly.js/issues/2387
#2387https://github.com/plotly/plotly.js/issues/2387
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
alexcjohnsonhttps://github.com/alexcjohnson
Feb 28, 2018https://github.com/plotly/plotly.js/pull/2426#discussion_r171412657
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#2387https://github.com/plotly/plotly.js/issues/2387
#2387https://github.com/plotly/plotly.js/issues/2387
scrollBox draghttps://github.com/plotly/plotly.js/pull/2426/commits/f75f5ba325e7c80d93272b71585d0e31ceac4f48#diff-f48c57dae9095e916f13f364ae740f69L296
next onehttps://github.com/plotly/plotly.js/pull/2426/commits/f75f5ba325e7c80d93272b71585d0e31ceac4f48#diff-ed9e861dab1a2e0cbdeacb9c7bd74db1R145
third new testhttps://github.com/plotly/plotly.js/pull/2426/commits/f75f5ba325e7c80d93272b71585d0e31ceac4f48#diff-ed9e861dab1a2e0cbdeacb9c7bd74db1R154
#2387https://github.com/plotly/plotly.js/issues/2387
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Feb 28, 2018https://github.com/plotly/plotly.js/pull/2426#issuecomment-369395487
#808https://github.com/plotly/plotly.js/issues/808
legend_scrollhttps://rreusser.github.io/plotly-mock-viewer/#legend_scroll
https://user-images.githubusercontent.com/6675409/36814946-23b65014-1ca7-11e8-8469-e354178f08ed.gif
#808https://github.com/plotly/plotly.js/issues/808
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Feb 28, 2018 https://github.com/plotly/plotly.js/pull/2426#pullrequestreview-100261885
View reviewed changes https://github.com/plotly/plotly.js/pull/2426/files/ec42784f1b05fd66dee5a2f7ad11aeeaf6e0a0f3
test/jasmine/tests/legend_scroll_test.jshttps://github.com/plotly/plotly.js/pull/2426/files/f75f5ba325e7c80d93272b71585d0e31ceac4f48..ec42784f1b05fd66dee5a2f7ad11aeeaf6e0a0f3#diff-1c9011cecef7c5fa1a9ae135b7282735601013c5e703ee0da2f47853c0f462ba
alexcjohnsonhttps://github.com/alexcjohnson
Feb 28, 2018https://github.com/plotly/plotly.js/pull/2426#discussion_r171413092
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
alexcjohnsonhttps://github.com/alexcjohnson
February 28, 2018 21:50https://github.com/plotly/plotly.js/pull/2426#commits-pushed-569b378
https://github.com/alexcjohnson
fixhttps://github.com/plotly/plotly.js/pull/2426/commits/569b37893c7082e9ed43740dd87a2d2fc36ce41b
#808https://github.com/plotly/plotly.js/issues/808
- update scrollBar when changing other legend attributeshttps://github.com/plotly/plotly.js/pull/2426/commits/569b37893c7082e9ed43740dd87a2d2fc36ce41b
569b378https://github.com/plotly/plotly.js/pull/2426/commits/569b37893c7082e9ed43740dd87a2d2fc36ce41b
https://github.com/alexcjohnson
🔪 call when not in a chainhttps://github.com/plotly/plotly.js/pull/2426/commits/5660bf57c25ac936d243dada472bfed57098513c
5660bf5https://github.com/plotly/plotly.js/pull/2426/commits/5660bf57c25ac936d243dada472bfed57098513c
https://github.com/alexcjohnson
turn scrollBoxY into a positive numberhttps://github.com/plotly/plotly.js/pull/2426/commits/f2d8cfd41742cba519caefd54146130bdd7c0d0f
f2d8cfdhttps://github.com/plotly/plotly.js/pull/2426/commits/f2d8cfd41742cba519caefd54146130bdd7c0d0f
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2426#issuecomment-369460104
#808https://github.com/plotly/plotly.js/issues/808
#2426 (comment)https://github.com/plotly/plotly.js/pull/2426#issuecomment-369395487
569b378https://github.com/plotly/plotly.js/commit/569b37893c7082e9ed43740dd87a2d2fc36ce41b
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Mar 1, 2018 https://github.com/plotly/plotly.js/pull/2426#pullrequestreview-100470607
View reviewed changes https://github.com/plotly/plotly.js/pull/2426/files/569b37893c7082e9ed43740dd87a2d2fc36ce41b
src/components/legend/draw.jshttps://github.com/plotly/plotly.js/pull/2426/files/246b77fb563c21176df56aad31bf366c734530a3..569b37893c7082e9ed43740dd87a2d2fc36ce41b#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578
etpinardhttps://github.com/etpinard
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2426#discussion_r171591459
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Mar 1, 2018 https://github.com/plotly/plotly.js/pull/2426#pullrequestreview-100472106
View reviewed changes https://github.com/plotly/plotly.js/pull/2426/files/f2d8cfd41742cba519caefd54146130bdd7c0d0f
src/components/legend/draw.jshttps://github.com/plotly/plotly.js/pull/2426/files/5660bf57c25ac936d243dada472bfed57098513c..f2d8cfd41742cba519caefd54146130bdd7c0d0f#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578
etpinardhttps://github.com/etpinard
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2426#discussion_r171592674
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2426#issuecomment-369626676
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
113b361https://github.com/plotly/plotly.js/commit/113b3618732f28d1a2158771544bf4e60e00c084
Mar 1, 2018https://github.com/plotly/plotly.js/pull/2426#event-1499250100
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
March 1, 2018 15:26https://github.com/plotly/plotly.js/pull/2426#event-1499250221
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Mar 1, 2018 https://github.com/plotly/plotly.js/pull/2426#ref-issue-241164090
Updatemenu scroll handle has the wrong size #1859 https://github.com/plotly/plotly.js/issues/1859
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Sep 18, 2018 https://github.com/plotly/plotly.js/pull/2426#ref-pullrequest-360557287
Fix support for Latex in legends #3018 https://github.com/plotly/plotly.js/pull/3018
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Sep 18, 2018 https://github.com/plotly/plotly.js/pull/2426#ref-issue-178631849
MathJax makes the legend scroll unnecessarily #966 https://github.com/plotly/plotly.js/issues/966
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2426
https://github.com/etpinard
etpinard https://github.com/etpinard
https://github.com/plotly/plotly.js/pull/2426/files/f2d8cfd41742cba519caefd54146130bdd7c0d0f
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
Clicking legend item causes legend to scroll https://github.com/plotly/plotly.js/issues/2387
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2426
https://github.com/alexcjohnson
https://github.com/etpinard
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.