René's URL Explorer Experiment


Title: Persistent point selection with transforms compatibility by etpinard · Pull Request #2163 · plotly/plotly.js · GitHub

Open Graph Title: Persistent point selection with transforms compatibility by etpinard · Pull Request #2163 · plotly/plotly.js

X Title: Persistent point selection with transforms compatibility by etpinard · Pull Request #2163 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Persistent point selection with transforms compatibility by etpinard · Pull Request #2163 · plotly/plotly.js

Open Graph Description: These few commits essentially addresses #2135 (comment) while cleaning up a few things in event data land - mainly making hover and selection event data reuse the same logic. In brief, this PR add...

X Description: These few commits essentially addresses #2135 (comment) while cleaning up a few things in event data land - mainly making hover and selection event data reuse the same logic. In brief, this PR add...

Opengraph URL: https://github.com/plotly/plotly.js/pull/2163

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4fb03d23-5fd8-14cc-978a-c82411968408
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB330:2A2344:CB9137:1149F50:6A57E902
html-safe-nonce576bc759c468e6c57da77f55e249f2e6eb3437316f24fb72088a00f75a3038b3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzMwOjJBMjM0NDpDQjkxMzc6MTE0OUY1MDo2QTU3RTkwMiIsInZpc2l0b3JfaWQiOiIzNzA5OTc4Mjk5NTAzOTk1MTM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbb3c495bb730f928499dcbb379cfde5e6002eb3cb90fe18aff7880ce0510d29b
hovercard-subject-tagpull_request:152874766
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/2163/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/14d6159c70fd7321724ffafe56b09bcb54e6e39473a39bb37effc5f43223c469/plotly/plotly.js/pull/2163
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/14d6159c70fd7321724ffafe56b09bcb54e6e39473a39bb37effc5f43223c469/plotly/plotly.js/pull/2163
og:image:altThese few commits essentially addresses #2135 (comment) while cleaning up a few things in event data land - mainly making hover and selection event data reuse the same logic. In brief, this PR add...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameetpinard
hostnamegithub.com
expected-hostnamegithub.com
None49c8c15fabcbf356d607a90ca115c13b273e42ff8b74155de050fd229a9b0121
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release72a32c9d47294b6b7eb7f0250253277920c7a987
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/2163#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2163
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2163
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/2163
Reloadhttps://github.com/plotly/plotly.js/pull/2163
Reloadhttps://github.com/plotly/plotly.js/pull/2163
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
plotly https://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
Notifications https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Fork 2k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Star 18.3k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Code https://github.com/plotly/plotly.js
Issues 772 https://github.com/plotly/plotly.js/issues
Pull requests 58 https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality 0 https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
Code https://github.com/plotly/plotly.js
Issues https://github.com/plotly/plotly.js/issues
Pull requests https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
etpinardhttps://github.com/etpinard
persistent-point-selectionhttps://github.com/plotly/plotly.js/tree/persistent-point-selection
persistent-point-selection-compat-transformshttps://github.com/plotly/plotly.js/tree/persistent-point-selection-compat-transforms
Conversationhttps://github.com/plotly/plotly.js/pull/2163
Commits11 (11)https://github.com/plotly/plotly.js/pull/2163/commits
Checkshttps://github.com/plotly/plotly.js/pull/2163/checks
Files changedhttps://github.com/plotly/plotly.js/pull/2163/files
Persistent point selection with transforms compatibilityhttps://github.com/plotly/plotly.js/pull/2163#top
etpinardhttps://github.com/etpinard
persistent-point-selectionhttps://github.com/plotly/plotly.js/tree/persistent-point-selection
persistent-point-selection-compat-transformshttps://github.com/plotly/plotly.js/tree/persistent-point-selection-compat-transforms
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Nov 15, 2017https://github.com/plotly/plotly.js/pull/2163#issue-274290597
#2135 (comment)https://github.com/plotly/plotly.js/pull/2135#issuecomment-341811820
@monferahttps://github.com/monfera
@alexcjohnsonhttps://github.com/alexcjohnson
#2135https://github.com/plotly/plotly.js/pull/2135
@monferahttps://github.com/monfera
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
etpinardhttps://github.com/etpinard
November 15, 2017 15:07https://github.com/plotly/plotly.js/pull/2163#commits-pushed-54cc67b
https://github.com/etpinard
make hover AND select use same event data pipelinehttps://github.com/plotly/plotly.js/pull/2163/commits/54cc67bf4dcc33da28d44cf2fae68643f4bf0961
54cc67bhttps://github.com/plotly/plotly.js/pull/2163/commits/54cc67bf4dcc33da28d44cf2fae68643f4bf0961
https://github.com/etpinard
adapt Histogram.eventData so that it works with selection ptshttps://github.com/plotly/plotly.js/pull/2163/commits/638d03db45d0f00bff2f0666b782185d0e861095
638d03dhttps://github.com/plotly/plotly.js/pull/2163/commits/638d03db45d0f00bff2f0666b782185d0e861095
https://github.com/etpinard
add Scattercarpet.eventData methodhttps://github.com/plotly/plotly.js/pull/2163/commits/b30fab46a7fb8812d464c2da324167e0cf94ba18
b30fab4https://github.com/plotly/plotly.js/pull/2163/commits/b30fab46a7fb8812d464c2da324167e0cf94ba18
https://github.com/etpinard
add ScatterTernary.eventData methodhttps://github.com/plotly/plotly.js/pull/2163/commits/949b311f81b46caf1fad77139e13ab1d9369a461
949b311https://github.com/plotly/plotly.js/pull/2163/commits/949b311f81b46caf1fad77139e13ab1d9369a461
https://github.com/etpinard
add Lib.tagSelected made to make selectedpoints work w/ transformshttps://github.com/plotly/plotly.js/pull/2163/commits/315e6327bbd512b20cec61e651f6bb945c1521d0
315e632https://github.com/plotly/plotly.js/pull/2163/commits/315e6327bbd512b20cec61e651f6bb945c1521d0
https://github.com/etpinard
add support for selection of aggregationshttps://github.com/plotly/plotly.js/pull/2163/commits/9b79b3faa758f69edc36f1f2b12342bd9932fc6c
9b79b3fhttps://github.com/plotly/plotly.js/pull/2163/commits/9b79b3faa758f69edc36f1f2b12342bd9932fc6c
https://github.com/etpinard
update point-selection baselinehttps://github.com/plotly/plotly.js/pull/2163/commits/92102788e6dc0f95b10424205032798429f65296
9210278https://github.com/plotly/plotly.js/pull/2163/commits/92102788e6dc0f95b10424205032798429f65296
https://github.com/etpinard
update event-data jasmine tests (mostly adding pointIndex)https://github.com/plotly/plotly.js/pull/2163/commits/261387dcb04502b82634e2ea220d3d828d3d3f8e
261387dhttps://github.com/plotly/plotly.js/pull/2163/commits/261387dcb04502b82634e2ea220d3d828d3d3f8e
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Nov 15, 2017https://github.com/plotly/plotly.js/pull/2163#issuecomment-344716805
#2126 (review)https://github.com/plotly/plotly.js/pull/2126#pullrequestreview-72395582
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Nov 16, 2017 https://github.com/plotly/plotly.js/pull/2163#pullrequestreview-77184145
View reviewed changes https://github.com/plotly/plotly.js/pull/2163/files/949b311f81b46caf1fad77139e13ab1d9369a461
src/traces/scatterternary/event_data.jshttps://github.com/plotly/plotly.js/pull/2163/files/b30fab46a7fb8812d464c2da324167e0cf94ba18..949b311f81b46caf1fad77139e13ab1d9369a461#diff-6b7ad87b8e7aa673aab4e7b2df4bd7d9c92813688493e9314ff71b312fc1d838
alexcjohnsonhttps://github.com/alexcjohnson
Nov 16, 2017https://github.com/plotly/plotly.js/pull/2163#discussion_r151470752
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
etpinardhttps://github.com/etpinard
Nov 16, 2017https://github.com/plotly/plotly.js/pull/2163#discussion_r151501603
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
c8d715bhttps://github.com/plotly/plotly.js/commit/c8d715b98e26e88c2e6fdbfa5b39f3fbb353fcba
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Nov 16, 2017 https://github.com/plotly/plotly.js/pull/2163#pullrequestreview-77192051
View reviewed changes https://github.com/plotly/plotly.js/pull/2163/files/315e6327bbd512b20cec61e651f6bb945c1521d0
src/lib/index.jshttps://github.com/plotly/plotly.js/pull/2163/files/949b311f81b46caf1fad77139e13ab1d9369a461..315e6327bbd512b20cec61e651f6bb945c1521d0#diff-94bf5f11334ccba786d331039367a21a9fe004d13fe75ec72f9d15961ef1c0b5
alexcjohnsonhttps://github.com/alexcjohnson
Nov 16, 2017https://github.com/plotly/plotly.js/pull/2163#discussion_r151477367
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
etpinardhttps://github.com/etpinard
Nov 16, 2017https://github.com/plotly/plotly.js/pull/2163#discussion_r151477784
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
alexcjohnsonhttps://github.com/alexcjohnson
Nov 16, 2017https://github.com/plotly/plotly.js/pull/2163#discussion_r151483371
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
etpinardhttps://github.com/etpinard
Nov 16, 2017https://github.com/plotly/plotly.js/pull/2163#discussion_r151501653
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
c8d715bhttps://github.com/plotly/plotly.js/commit/c8d715b98e26e88c2e6fdbfa5b39f3fbb353fcba
451778bhttps://github.com/plotly/plotly.js/commit/451778b2adf7e4584bb5d55406712da9ef85eb7d
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Nov 16, 2017 https://github.com/plotly/plotly.js/pull/2163#pullrequestreview-77201703
View reviewed changes https://github.com/plotly/plotly.js/pull/2163/files/315e6327bbd512b20cec61e651f6bb945c1521d0
src/traces/histogram/calc.jshttps://github.com/plotly/plotly.js/pull/2163/files/949b311f81b46caf1fad77139e13ab1d9369a461..315e6327bbd512b20cec61e651f6bb945c1521d0#diff-126ca1d6751051e2e4a54fb2865f672db5682f64fca56bbfd50a5736c55c45f8
alexcjohnsonhttps://github.com/alexcjohnson
Nov 16, 2017https://github.com/plotly/plotly.js/pull/2163#discussion_r151485660
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
main binning loophttps://github.com/plotly/plotly.js/blob/315e6327bbd512b20cec61e651f6bb945c1521d0/src/traces/histogram/calc.js#L128
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
etpinardhttps://github.com/etpinard
Nov 16, 2017https://github.com/plotly/plotly.js/pull/2163#discussion_r151499437
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
directlyhttps://github.com/plotly/plotly.js/blob/261387dcb04502b82634e2ea220d3d828d3d3f8e/src/traces/bar/select.js#L33
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
etpinardhttps://github.com/etpinard
Nov 16, 2017https://github.com/plotly/plotly.js/pull/2163#discussion_r151501550
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
7543dc6https://github.com/plotly/plotly.js/commit/7543dc6a146d0438caa521036fa38cb220031b58
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
alexcjohnsonhttps://github.com/alexcjohnson
Nov 16, 2017https://github.com/plotly/plotly.js/pull/2163#discussion_r151507816
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
etpinardhttps://github.com/etpinard
November 16, 2017 13:19https://github.com/plotly/plotly.js/pull/2163#commits-pushed-451778b
https://github.com/etpinard
speed up is-pt-index-valid checkhttps://github.com/plotly/plotly.js/pull/2163/commits/451778b2adf7e4584bb5d55406712da9ef85eb7d
451778bhttps://github.com/plotly/plotly.js/pull/2163/commits/451778b2adf7e4584bb5d55406712da9ef85eb7d
https://github.com/etpinard
emit 'normalized' a/b/c coords in scatterternary event datahttps://github.com/plotly/plotly.js/pull/2163/commits/c8d715b98e26e88c2e6fdbfa5b39f3fbb353fcba
c8d715bhttps://github.com/plotly/plotly.js/pull/2163/commits/c8d715b98e26e88c2e6fdbfa5b39f3fbb353fcba
https://github.com/etpinard
move ptNumber2cdIndex computation to main binning loophttps://github.com/plotly/plotly.js/pull/2163/commits/7543dc6a146d0438caa521036fa38cb220031b58
7543dc6https://github.com/plotly/plotly.js/pull/2163/commits/7543dc6a146d0438caa521036fa38cb220031b58
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Nov 16, 2017https://github.com/plotly/plotly.js/pull/2163#issuecomment-345029764
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
https://github.com/etpinard
etpinardhttps://github.com/etpinard
a95e47bhttps://github.com/plotly/plotly.js/commit/a95e47b36c9860eac81f71e1f139c21c77e37909
Nov 16, 2017https://github.com/plotly/plotly.js/pull/2163#event-1345808969
https://github.com/etpinard
etpinardhttps://github.com/etpinard
November 16, 2017 19:21https://github.com/plotly/plotly.js/pull/2163#event-1345809040
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Nov 17, 2017 https://github.com/plotly/plotly.js/pull/2163#ref-pullrequest-270054888
Persistent point selection #2135 https://github.com/plotly/plotly.js/pull/2135
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2163
https://github.com/alexcjohnson
alexcjohnson https://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/2163/files/315e6327bbd512b20cec61e651f6bb945c1521d0
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2163
https://github.com/etpinard
https://github.com/alexcjohnson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.