René's URL Explorer Experiment


Title: Selection on `choropleth` to work even if an invisible trace is present by monfera · Pull Request #2099 · plotly/plotly.js · GitHub

Open Graph Title: Selection on `choropleth` to work even if an invisible trace is present by monfera · Pull Request #2099 · plotly/plotly.js

X Title: Selection on `choropleth` to work even if an invisible trace is present by monfera · Pull Request #2099 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Selection on `choropleth` to work even if an invisible trace is present by monfera · Pull Request #2099 · plotly/plotly.js

Open Graph Description: Box select and lasso to work in the presence of an invisible choropleth trace. Updated test case signals if the small fix is commented out.

X Description: Box select and lasso to work in the presence of an invisible choropleth trace. Updated test case signals if the small fix is commented out.

Opengraph URL: https://github.com/plotly/plotly.js/pull/2099

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ed3b9336-9ee6-23a9-c48b-13bc32f424c6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB58:39D6FF:27190B2:3547EA5:6A53AE0E
html-safe-nonce859d428bea6cc201592d171ddc510d0454ea713df42cb63ed08e35cc453f17b2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjU4OjM5RDZGRjoyNzE5MEIyOjM1NDdFQTU6NkE1M0FFMEUiLCJ2aXNpdG9yX2lkIjoiOTA5NzYxMDI4MDkwNTcxNTIxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3bb6f3551763dd7860f831031335be2009e628cceb6ddb2b60db3903ed909ebf
hovercard-subject-tagpull_request:147355610
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/2099/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/76f986306b841a4159dd4a8a0b12692cf195daa89ae6d4d0e094f2bda5bc97bd/plotly/plotly.js/pull/2099
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/76f986306b841a4159dd4a8a0b12692cf195daa89ae6d4d0e094f2bda5bc97bd/plotly/plotly.js/pull/2099
og:image:altBox select and lasso to work in the presence of an invisible choropleth trace. Updated test case signals if the small fix is commented out.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemonfera
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/2099#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2099
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2099
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/2099
Reloadhttps://github.com/plotly/plotly.js/pull/2099
Reloadhttps://github.com/plotly/plotly.js/pull/2099
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
plotly https://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
Notifications https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Fork 2k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Star 18.3k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Code https://github.com/plotly/plotly.js
Issues 773 https://github.com/plotly/plotly.js/issues
Pull requests 60 https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality 0 https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
Code https://github.com/plotly/plotly.js
Issues https://github.com/plotly/plotly.js/issues
Pull requests https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
monferahttps://github.com/monfera
masterhttps://github.com/plotly/plotly.js/tree/master
invisible-selecthttps://github.com/plotly/plotly.js/tree/invisible-select
Conversationhttps://github.com/plotly/plotly.js/pull/2099
Commits5 (5)https://github.com/plotly/plotly.js/pull/2099/commits
Checkshttps://github.com/plotly/plotly.js/pull/2099/checks
Files changedhttps://github.com/plotly/plotly.js/pull/2099/files
Selection on choropleth to work even if an invisible trace is presenthttps://github.com/plotly/plotly.js/pull/2099#top
monferahttps://github.com/monfera
masterhttps://github.com/plotly/plotly.js/tree/master
invisible-selecthttps://github.com/plotly/plotly.js/tree/invisible-select
https://github.com/monfera
monferahttps://github.com/monfera
Oct 18, 2017https://github.com/plotly/plotly.js/pull/2099#issue-266566083
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
monferahttps://github.com/monfera
October 18, 2017 16:42https://github.com/plotly/plotly.js/pull/2099#commits-pushed-6d78036
https://github.com/monfera
handle trace with no points, resulting in invisible trace and node3 u…https://github.com/plotly/plotly.js/pull/2099/commits/6d7803685e49de62c359703a0820ebd65c8dcbf6
6d78036https://github.com/plotly/plotly.js/pull/2099/commits/6d7803685e49de62c359703a0820ebd65c8dcbf6
https://github.com/monfera
test: handle trace with no points, resulting in invisible trace and n…https://github.com/plotly/plotly.js/pull/2099/commits/314fbe1b8d6ed8e44c09c8036ac74070806283e6
314fbe1https://github.com/plotly/plotly.js/pull/2099/commits/314fbe1b8d6ed8e44c09c8036ac74070806283e6
https://github.com/monfera
monferahttps://github.com/monfera
Oct 18, 2017https://github.com/plotly/plotly.js/pull/2099#event-1299502747
https://github.com/monfera
monferahttps://github.com/monfera
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
Oct 18, 2017https://github.com/plotly/plotly.js/pull/2099#event-1299503225
https://github.com/monfera
monferahttps://github.com/monfera
alexcjohnsonhttps://github.com/alexcjohnson
etpinardhttps://github.com/etpinard
October 18, 2017 16:55https://github.com/plotly/plotly.js/pull/2099#event-1299503763
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Oct 18, 2017 https://github.com/plotly/plotly.js/pull/2099#pullrequestreview-70295481
View reviewed changes https://github.com/plotly/plotly.js/pull/2099/files/314fbe1b8d6ed8e44c09c8036ac74070806283e6
alexcjohnsonhttps://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/2099#pullrequestreview-70295481
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
herehttps://github.com/plotly/plotly.js/blob/master/src/plots/cartesian/select.js#L77
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
https://github.com/monfera
monferahttps://github.com/monfera
Oct 18, 2017https://github.com/plotly/plotly.js/pull/2099#issuecomment-337674211
@alexcjohnsonhttps://github.com/alexcjohnson
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Oct 18, 2017https://github.com/plotly/plotly.js/pull/2099#issuecomment-337679196
@monferahttps://github.com/monfera
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Oct 18, 2017https://github.com/plotly/plotly.js/pull/2099#issuecomment-337680464
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
https://github.com/monfera
more upstream fix for avoiding invisible traceshttps://github.com/plotly/plotly.js/pull/2099/commits/8cb0c1adcf15f89bb01221097c0ec99f5120c321
8cb0c1ahttps://github.com/plotly/plotly.js/pull/2099/commits/8cb0c1adcf15f89bb01221097c0ec99f5120c321
https://github.com/monfera
monferahttps://github.com/monfera
Oct 18, 2017 https://github.com/plotly/plotly.js/pull/2099#ref-issue-266642777
Lasso/select to not raise an error on choropleth if one of the traces is invisible #2103 https://github.com/plotly/plotly.js/issues/2103
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Oct 18, 2017 https://github.com/plotly/plotly.js/pull/2099#pullrequestreview-70377502
View reviewed changes https://github.com/plotly/plotly.js/pull/2099/files/8cb0c1adcf15f89bb01221097c0ec99f5120c321
src/plots/cartesian/select.jshttps://github.com/plotly/plotly.js/pull/2099/files/8cb0c1adcf15f89bb01221097c0ec99f5120c321#diff-bd7d37269e85636499f7ab275126298608f098fa35eb9e56375b97463f17683d
etpinardhttps://github.com/etpinard
Oct 18, 2017https://github.com/plotly/plotly.js/pull/2099#discussion_r145559324
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
herehttps://github.com/plotly/plotly.js/blob/master/src/traces/bar/select.js#L20
herehttps://github.com/plotly/plotly.js/blob/master/src/traces/scatter/select.js#L29
herehttps://github.com/plotly/plotly.js/blob/master/src/traces/scattergeo/select.js#L25
herehttps://github.com/plotly/plotly.js/blob/86e7135f54fedfa1e89b3e299833491369baa96e/src/traces/scattermapbox/select.js#L27
herehttps://github.com/plotly/plotly.js/blob/master/src/traces/scattergl/select.js#L29
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
monferahttps://github.com/monfera
Oct 18, 2017https://github.com/plotly/plotly.js/pull/2099#discussion_r145562280
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
https://github.com/monfera
discontinuing per-trace type visibility checkhttps://github.com/plotly/plotly.js/pull/2099/commits/b9817ad1cb4a6e26f3baac129423d09c24c0ec57
b9817adhttps://github.com/plotly/plotly.js/pull/2099/commits/b9817ad1cb4a6e26f3baac129423d09c24c0ec57
https://github.com/monfera
monferahttps://github.com/monfera
Oct 18, 2017https://github.com/plotly/plotly.js/pull/2099#issuecomment-337752408
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
https://github.com/monfera
moving check more upstreamhttps://github.com/plotly/plotly.js/pull/2099/commits/fc0ad56dc5a8d898b9602830752838e059e7c9b3
fc0ad56https://github.com/plotly/plotly.js/pull/2099/commits/fc0ad56dc5a8d898b9602830752838e059e7c9b3
https://github.com/monfera
monferahttps://github.com/monfera
force-pushedhttps://github.com/plotly/plotly.js/compare/e757114e83a67e3eeef9fdd9bdcf190952bd0dbe..fc0ad56dc5a8d898b9602830752838e059e7c9b3
e757114https://github.com/plotly/plotly.js/commit/e757114e83a67e3eeef9fdd9bdcf190952bd0dbe
fc0ad56https://github.com/plotly/plotly.js/commit/fc0ad56dc5a8d898b9602830752838e059e7c9b3
Compare https://github.com/plotly/plotly.js/compare/e757114e83a67e3eeef9fdd9bdcf190952bd0dbe..fc0ad56dc5a8d898b9602830752838e059e7c9b3
October 18, 2017 23:03https://github.com/plotly/plotly.js/pull/2099#event-1300091740
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Oct 18, 2017https://github.com/plotly/plotly.js/pull/2099#issuecomment-337755020
@monferahttps://github.com/monfera
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
https://github.com/monfera
monferahttps://github.com/monfera
Oct 18, 2017https://github.com/plotly/plotly.js/pull/2099#issuecomment-337755206
@etpinardhttps://github.com/etpinard
@alexcjohnsonhttps://github.com/alexcjohnson
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
https://github.com/monfera
monferahttps://github.com/monfera
fff9c6ehttps://github.com/plotly/plotly.js/commit/fff9c6e3543eb24ecd39776db55083810ec8785a
Oct 18, 2017https://github.com/plotly/plotly.js/pull/2099#event-1300107620
https://github.com/monfera
monferahttps://github.com/monfera
October 18, 2017 23:19https://github.com/plotly/plotly.js/pull/2099#event-1300107682
etpinardhttps://github.com/etpinard
Oct 20, 2017 https://github.com/plotly/plotly.js/pull/2099#ref-commit-1760d66
https://github.com/etpinard
fixup choropleth select testhttps://github.com/plotly/plotly.js/commit/1760d660b7815c5adfed7b7edd26ea26dac2a77e
1760d66https://github.com/plotly/plotly.js/commit/1760d660b7815c5adfed7b7edd26ea26dac2a77e
#2099https://github.com/plotly/plotly.js/pull/2099
#2081https://github.com/plotly/plotly.js/pull/2081
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Oct 20, 2017 https://github.com/plotly/plotly.js/pull/2099#ref-pullrequest-267190570
Fixup choropleth select test #2109 https://github.com/plotly/plotly.js/pull/2109
etpinardhttps://github.com/etpinard
Oct 23, 2017 https://github.com/plotly/plotly.js/pull/2099#ref-commit-6b44d39
https://github.com/etpinard
fixup choropleth select testhttps://github.com/plotly/plotly.js/commit/6b44d39fafe02c917cf8c887643088ab532f2133
6b44d39https://github.com/plotly/plotly.js/commit/6b44d39fafe02c917cf8c887643088ab532f2133
#2099https://github.com/plotly/plotly.js/pull/2099
#2081https://github.com/plotly/plotly.js/pull/2081
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Oct 23, 2017 https://github.com/plotly/plotly.js/pull/2099#ref-pullrequest-267692424
Branch for 1.31.2 #2111 https://github.com/plotly/plotly.js/pull/2111
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2099
https://github.com/alexcjohnson
alexcjohnson https://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/2099/files/314fbe1b8d6ed8e44c09c8036ac74070806283e6
https://github.com/etpinard
etpinard https://github.com/etpinard
https://github.com/plotly/plotly.js/pull/2099/files/8cb0c1adcf15f89bb01221097c0ec99f5120c321
https://github.com/monfera
monfera https://github.com/monfera
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
Please reload this pagehttps://github.com/plotly/plotly.js/pull/2099
https://github.com/monfera
https://github.com/alexcjohnson
https://github.com/etpinard
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.