| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2313cfb1-daef-84ca-88ce-79eb91537b7a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D178:1A6FEB:27A4CB8:363303F:6A54453D |
| html-safe-nonce | 7565f9696b98a69288e256b6ef58143ef3db0cb4bde58785e01752b3db14ba99 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTc4OjFBNkZFQjoyN0E0Q0I4OjM2MzMwM0Y6NkE1NDQ1M0QiLCJ2aXNpdG9yX2lkIjoiODUwNjkxNzYxNzU5NjEyMjQyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 285a0e9bb9d39923e2dabfefdfb5dbffc015a8d6c4aecb36386ccbc6ce211777 |
| hovercard-subject-tag | pull_request:144312735 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/2052/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/8ccb956fcf2ded9700f3c157375a9da2641dc95a44950624b4209562d15ed749/plotly/plotly.js/pull/2052 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8ccb956fcf2ded9700f3c157375a9da2641dc95a44950624b4209562d15ed749/plotly/plotly.js/pull/2052 |
| og:image:alt | Squashed version of #1834
Before starting review, I'd push proper mocks, also as codepen examples. I'll also need to recheck attributes and add jasmine tests. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | monfera |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/2052#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2052 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2052 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/2052 |
| Reload | https://github.com/plotly/plotly.js/pull/2052 |
| Reload | https://github.com/plotly/plotly.js/pull/2052 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
773
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
61
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| monfera | https://github.com/monfera |
| master | https://github.com/plotly/plotly.js/tree/master |
| table-squashed | https://github.com/plotly/plotly.js/tree/table-squashed |
| Conversation | https://github.com/plotly/plotly.js/pull/2052 |
| Commits44 (44) | https://github.com/plotly/plotly.js/pull/2052/commits |
| Checks | https://github.com/plotly/plotly.js/pull/2052/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/2052/files |
| Table view - squashed | https://github.com/plotly/plotly.js/pull/2052#top |
| monfera | https://github.com/monfera |
| master | https://github.com/plotly/plotly.js/tree/master |
| table-squashed | https://github.com/plotly/plotly.js/tree/table-squashed |
|
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#issue-262267706 |
| #1834 | https://github.com/plotly/plotly.js/pull/1834 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
|
| https://github.com/monfera |
| table - initial commit (squashed feature branch) | https://github.com/plotly/plotly.js/pull/2052/commits/c4244dbf0d0a4c854cf1bb7e74a6081412a50e5f |
| c4244db | https://github.com/plotly/plotly.js/pull/2052/commits/c4244dbf0d0a4c854cf1bb7e74a6081412a50e5f |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#event-1275089253 |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
|
status: in progress
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#event-1275089537 |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| v1.31.0 | https://github.com/plotly/plotly.js/milestone/27 |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#event-1275091182 |
|
| https://github.com/monfera |
| adding birds mock | https://github.com/plotly/plotly.js/pull/2052/commits/865e4441eae1818cc70961a2b795562aa232af10 |
| 865e444 | https://github.com/plotly/plotly.js/pull/2052/commits/865e4441eae1818cc70961a2b795562aa232af10 |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#issuecomment-333852747 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| @etpinard | https://github.com/etpinard |
| https://user-images.githubusercontent.com/1548516/31130380-86529800-a857-11e7-913c-8814c269fa27.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| etpinard | https://github.com/etpinard |
| October 3, 2017 14:13 | https://github.com/plotly/plotly.js/pull/2052#event-1276053609 |
|
| https://github.com/monfera |
| minor mock change | https://github.com/plotly/plotly.js/pull/2052/commits/2648e51d865ea0afb438b73dbdedf193fd431205 |
| 2648e51 | https://github.com/plotly/plotly.js/pull/2052/commits/2648e51d865ea0afb438b73dbdedf193fd431205 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 3, 2017
| https://github.com/plotly/plotly.js/pull/2052#pullrequestreview-66766593 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2052/files/c4244dbf0d0a4c854cf1bb7e74a6081412a50e5f |
| etpinard | https://github.com/etpinard |
| https://github.com/plotly/plotly.js/pull/2052#pullrequestreview-66766593 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| src/traces/table/attributes.js | https://github.com/plotly/plotly.js/pull/2052/files/c4244dbf0d0a4c854cf1bb7e74a6081412a50e5f#diff-d76e1125f17d05512521f5e6783edce4624e8fd052684cd36a150c587b9f5997 |
| etpinard | https://github.com/etpinard |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142410512 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| src/traces/table/attributes.js | https://github.com/plotly/plotly.js/pull/2052/files/c4244dbf0d0a4c854cf1bb7e74a6081412a50e5f#diff-d76e1125f17d05512521f5e6783edce4624e8fd052684cd36a150c587b9f5997 |
| etpinard | https://github.com/etpinard |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142410635 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| monfera | https://github.com/monfera |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142448916 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://user-images.githubusercontent.com/1548516/31135780-54918dc6-a866-11e7-8a51-2a5af96a164e.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| src/traces/table/attributes.js | https://github.com/plotly/plotly.js/pull/2052/files/c4244dbf0d0a4c854cf1bb7e74a6081412a50e5f#diff-d76e1125f17d05512521f5e6783edce4624e8fd052684cd36a150c587b9f5997 |
| etpinard | https://github.com/etpinard |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142410981 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/plotly/plotly.js/blob/master/src/plots/font_attributes.js | https://github.com/plotly/plotly.js/blob/master/src/plots/font_attributes.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| src/traces/table/attributes.js | https://github.com/plotly/plotly.js/pull/2052/files/c4244dbf0d0a4c854cf1bb7e74a6081412a50e5f#diff-d76e1125f17d05512521f5e6783edce4624e8fd052684cd36a150c587b9f5997 |
| etpinard | https://github.com/etpinard |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142411340 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| monfera | https://github.com/monfera |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142449507 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://user-images.githubusercontent.com/1548516/31135905-d54775c0-a866-11e7-9f90-a960bd688629.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| src/traces/table/attributes.js | https://github.com/plotly/plotly.js/pull/2052/files/865e4441eae1818cc70961a2b795562aa232af10#diff-d76e1125f17d05512521f5e6783edce4624e8fd052684cd36a150c587b9f5997 |
| etpinard | https://github.com/etpinard |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142411654 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #1999 | https://github.com/plotly/plotly.js/pull/1999 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| src/traces/table/plot.js | https://github.com/plotly/plotly.js/pull/2052/files/2648e51d865ea0afb438b73dbdedf193fd431205#diff-a91bc9cf1aa139390314f9a2014c47f969532a1eab25763d03a9a969a2b0c79b |
| etpinard | https://github.com/etpinard |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142422653 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| src/traces/table/plot.js | https://github.com/plotly/plotly.js/pull/2052/files/2648e51d865ea0afb438b73dbdedf193fd431205#diff-a91bc9cf1aa139390314f9a2014c47f969532a1eab25763d03a9a969a2b0c79b |
| etpinard | https://github.com/etpinard |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142422917 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| alexcjohnson | https://github.com/alexcjohnson |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142467135 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://codepen.io/anon/pen/XjakQy | https://codepen.io/anon/pen/XjakQy |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| monfera | https://github.com/monfera |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142532091 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #2053 | https://github.com/plotly/plotly.js/issues/2053 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| src/traces/table/plot.js | https://github.com/plotly/plotly.js/pull/2052/files/2648e51d865ea0afb438b73dbdedf193fd431205#diff-a91bc9cf1aa139390314f9a2014c47f969532a1eab25763d03a9a969a2b0c79b |
| etpinard | https://github.com/etpinard |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142423168 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| alexcjohnson | https://github.com/alexcjohnson |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142469257 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| here | https://github.com/plotly/plotly.js/blob/master/src/lib/svg_text_utils.js#L118 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| monfera | https://github.com/monfera |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142481355 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| alexcjohnson | https://github.com/alexcjohnson |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142488730 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| monfera | https://github.com/monfera |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142490967 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| monfera | https://github.com/monfera |
| Oct 4, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142811572 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @alexcjohnson | https://github.com/alexcjohnson |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| etpinard | https://github.com/etpinard |
| Oct 5, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142827451 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #2056 | https://github.com/plotly/plotly.js/issues/2056 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| test/jasmine/tests/table_test.js | https://github.com/plotly/plotly.js/pull/2052/files/2648e51d865ea0afb438b73dbdedf193fd431205#diff-48231a90fbc7a0ecb66d42871c10f2a3820973fa4e13cda031656e0dba77c79e |
| etpinard | https://github.com/etpinard |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142426484 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| monfera | https://github.com/monfera |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142481520 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| test/jasmine/tests/table_test.js | https://github.com/plotly/plotly.js/pull/2052/files/2648e51d865ea0afb438b73dbdedf193fd431205#diff-48231a90fbc7a0ecb66d42871c10f2a3820973fa4e13cda031656e0dba77c79e |
| etpinard | https://github.com/etpinard |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142426562 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| monfera | https://github.com/monfera |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142481771 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#issuecomment-333874540 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://codepen.io/monfera/pen/ZXXMLo?editors=1010#0 | https://codepen.io/monfera/pen/ZXXMLo?editors=1010#0 |
| https://user-images.githubusercontent.com/6675409/31132611-3c75f618-a82b-11e7-9c61-c26a9929e487.gif |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Oct 3, 2017
| https://github.com/plotly/plotly.js/pull/2052#pullrequestreview-66794772 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2052/files/2648e51d865ea0afb438b73dbdedf193fd431205 |
| test/image/mocks/table_plain_birds.json | https://github.com/plotly/plotly.js/pull/2052/files/2648e51d865ea0afb438b73dbdedf193fd431205#diff-853c24b78569d7dd7e06ff7953eaffb64e7c5b1d094ab2419fc06d7fe82191bd |
| etpinard | https://github.com/etpinard |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#discussion_r142434323 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#issuecomment-333902632 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#issuecomment-333906922 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| @alexcjohnson | https://github.com/alexcjohnson |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#issuecomment-333934166 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#issuecomment-333936079 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| @alexcjohnson | https://github.com/alexcjohnson |
| @rreusser | https://github.com/rreusser |
| @rreusser | https://github.com/rreusser |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#issuecomment-333937882 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| @monfera | https://github.com/monfera |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#issuecomment-333949519 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| util | https://github.com/plotly/plotly.js/blob/master/src/lib/throttle.js |
| @etpinard | https://github.com/etpinard |
| #2030 | https://github.com/plotly/plotly.js/pull/2030 |
| @monfera | https://github.com/monfera |
| #2056 | https://github.com/plotly/plotly.js/issues/2056 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Oct 3, 2017 | https://github.com/plotly/plotly.js/pull/2052#issuecomment-333950868 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
|
Unification of text rendering and wrapping
#2053
| https://github.com/plotly/plotly.js/issues/2053 |
|
Consider and possibly put in place a common, unified scroller solution
#2054
| https://github.com/plotly/plotly.js/issues/2054 |
| monfera | https://github.com/monfera |
| October 3, 2017 23:02 | https://github.com/plotly/plotly.js/pull/2052#commits-pushed-1922721 |
|
| https://github.com/monfera |
| avoid crispEdges in cell contents and scrollbar; minor mock change | https://github.com/plotly/plotly.js/pull/2052/commits/1922721db654fecc10932ba4b5f5b37c859cfa42 |
| 1922721 | https://github.com/plotly/plotly.js/pull/2052/commits/1922721db654fecc10932ba4b5f5b37c859cfa42 |
|
| https://github.com/monfera |
| doc change | https://github.com/plotly/plotly.js/pull/2052/commits/30cbaa02174c531c5f3312d433558021d5e4a4d6 |
| 30cbaa0 | https://github.com/plotly/plotly.js/pull/2052/commits/30cbaa02174c531c5f3312d433558021d5e4a4d6 |
|
| https://github.com/monfera |
| fewer accessor uses | https://github.com/plotly/plotly.js/pull/2052/commits/aa0c116fb0754737c4637ddcae2f8b20ec82c9ea |
| aa0c116 | https://github.com/plotly/plotly.js/pull/2052/commits/aa0c116fb0754737c4637ddcae2f8b20ec82c9ea |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
|
Oct 3, 2017
| https://github.com/plotly/plotly.js/pull/2052#ref-issue-262588414 |
|
Open items for future PRs related primarily to table
#2056
| https://github.com/plotly/plotly.js/issues/2056 |
|
| https://github.com/monfera |
| doc update | https://github.com/plotly/plotly.js/pull/2052/commits/c0ac2131cbeb120548f0f30e34bfc60ae74b73fd |
| c0ac213 | https://github.com/plotly/plotly.js/pull/2052/commits/c0ac2131cbeb120548f0f30e34bfc60ae74b73fd |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
|
Oct 3, 2017
| https://github.com/plotly/plotly.js/pull/2052#ref-issue-262590237 |
|
Centralize drag handlers
#2057
| https://github.com/plotly/plotly.js/issues/2057 |
| monfera | https://github.com/monfera |
| October 3, 2017 23:23 | https://github.com/plotly/plotly.js/pull/2052#commits-pushed-732bd46 |
|
| https://github.com/monfera |
| more idiomatic D3 | https://github.com/plotly/plotly.js/pull/2052/commits/732bd4634fc240c90458838d028057dd57615dff |
| 732bd46 | https://github.com/plotly/plotly.js/pull/2052/commits/732bd4634fc240c90458838d028057dd57615dff |
|
| https://github.com/monfera |
| no prefixing with window | https://github.com/plotly/plotly.js/pull/2052/commits/22e23e3de3347ff7a65b15a30590eb29cdb2e708 |
| 22e23e3 | https://github.com/plotly/plotly.js/pull/2052/commits/22e23e3de3347ff7a65b15a30590eb29cdb2e708 |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
|
Oct 3, 2017
| https://github.com/plotly/plotly.js/pull/2052#ref-issue-262600308 |
|
Code style rework: class names; extracted utils
#2058
| https://github.com/plotly/plotly.js/issues/2058 |
|
| https://github.com/monfera |
| removed clipView debug option | https://github.com/plotly/plotly.js/pull/2052/commits/2be591f5b67a43493d613b5da6559daa65f18d48 |
| 2be591f | https://github.com/plotly/plotly.js/pull/2052/commits/2be591f5b67a43493d613b5da6559daa65f18d48 |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| force-pushed | https://github.com/plotly/plotly.js/compare/8ad24bf5d5d46283296d9ababeb2b4c5d61c01bd..2be591f5b67a43493d613b5da6559daa65f18d48 |
| 8ad24bf | https://github.com/plotly/plotly.js/commit/8ad24bf5d5d46283296d9ababeb2b4c5d61c01bd |
| 2be591f | https://github.com/plotly/plotly.js/commit/2be591f5b67a43493d613b5da6559daa65f18d48 |
|
Compare
| https://github.com/plotly/plotly.js/compare/8ad24bf5d5d46283296d9ababeb2b4c5d61c01bd..2be591f5b67a43493d613b5da6559daa65f18d48 |
| October 5, 2017 08:24 | https://github.com/plotly/plotly.js/pull/2052#event-1279438872 |
|
| https://github.com/monfera |
| allow cell text selection | https://github.com/plotly/plotly.js/pull/2052/commits/addb85b3d0ae576488031d7a38681c331359966b |
| addb85b | https://github.com/plotly/plotly.js/pull/2052/commits/addb85b3d0ae576488031d7a38681c331359966b |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| force-pushed | https://github.com/plotly/plotly.js/compare/45b6843fa9b9a08c38e23dcf1017b8dd51b7ba92..addb85b3d0ae576488031d7a38681c331359966b |
| 45b6843 | https://github.com/plotly/plotly.js/commit/45b6843fa9b9a08c38e23dcf1017b8dd51b7ba92 |
| addb85b | https://github.com/plotly/plotly.js/commit/addb85b3d0ae576488031d7a38681c331359966b |
|
Compare
| https://github.com/plotly/plotly.js/compare/45b6843fa9b9a08c38e23dcf1017b8dd51b7ba92..addb85b3d0ae576488031d7a38681c331359966b |
| October 5, 2017 13:20 | https://github.com/plotly/plotly.js/pull/2052#event-1279898660 |
|
| https://github.com/monfera |
| fixing server image gen issue - thanks Étienne - and removing the pos… | https://github.com/plotly/plotly.js/pull/2052/commits/c2f251f31177c8016fa6fbf288554f55b96b8a0f |
| c2f251f | https://github.com/plotly/plotly.js/pull/2052/commits/c2f251f31177c8016fa6fbf288554f55b96b8a0f |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| force-pushed | https://github.com/plotly/plotly.js/compare/85fdc93f73307a66d5dc89459a1afe914e3206be..c2f251f31177c8016fa6fbf288554f55b96b8a0f |
| 85fdc93 | https://github.com/plotly/plotly.js/commit/85fdc93f73307a66d5dc89459a1afe914e3206be |
| c2f251f | https://github.com/plotly/plotly.js/commit/c2f251f31177c8016fa6fbf288554f55b96b8a0f |
|
Compare
| https://github.com/plotly/plotly.js/compare/85fdc93f73307a66d5dc89459a1afe914e3206be..c2f251f31177c8016fa6fbf288554f55b96b8a0f |
| October 5, 2017 14:33 | https://github.com/plotly/plotly.js/pull/2052#event-1280047531 |
| monfera | https://github.com/monfera |
| October 5, 2017 16:57 | https://github.com/plotly/plotly.js/pull/2052#commits-pushed-3cab51d |
|
| https://github.com/monfera |
| adding baselines | https://github.com/plotly/plotly.js/pull/2052/commits/3cab51de9d1f2a4571843fa6bc11ef8b5cc5d903 |
| 3cab51d | https://github.com/plotly/plotly.js/pull/2052/commits/3cab51de9d1f2a4571843fa6bc11ef8b5cc5d903 |
|
| https://github.com/monfera |
| globally safe clipPath | https://github.com/plotly/plotly.js/pull/2052/commits/fa84c68060042045f0670609d9a8f3a839d26f85 |
| #1 | https://github.com/plotly/plotly.js/pull/1 |
| fa84c68 | https://github.com/plotly/plotly.js/pull/2052/commits/fa84c68060042045f0670609d9a8f3a839d26f85 |
|
| https://github.com/etpinard |
| use overrideAll in table attributes | https://github.com/plotly/plotly.js/pull/2052/commits/465b45b242df5e050965d5ea77ceb8a84a6752a8 |
| 465b45b | https://github.com/plotly/plotly.js/pull/2052/commits/465b45b242df5e050965d5ea77ceb8a84a6752a8 |
|
| https://github.com/monfera |
| globally safe clipPath | https://github.com/plotly/plotly.js/pull/2052/commits/0fa1cc8ae19555cc164fb58900f34966b2eb1790 |
| #2 | https://github.com/plotly/plotly.js/pull/2 |
| 0fa1cc8 | https://github.com/plotly/plotly.js/pull/2052/commits/0fa1cc8ae19555cc164fb58900f34966b2eb1790 |
|
| https://github.com/monfera |
| Merge branch 'table-squashed' of | https://github.com/plotly/plotly.js/pull/2052/commits/cd0578ddadba614271f733b6c29906ddf65fb009 |
| https://github.com/plotly/plotly.js | https://github.com/plotly/plotly.js |
| … | https://github.com/plotly/plotly.js/pull/2052/commits/cd0578ddadba614271f733b6c29906ddf65fb009 |
| cd0578d | https://github.com/plotly/plotly.js/pull/2052/commits/cd0578ddadba614271f733b6c29906ddf65fb009 |
|
| https://github.com/etpinard |
| add baselines | https://github.com/plotly/plotly.js/pull/2052/commits/a6c49350636f28b5b1e5392fadac319d35602d15 |
| a6c4935 | https://github.com/plotly/plotly.js/pull/2052/commits/a6c49350636f28b5b1e5392fadac319d35602d15 |
|
| https://github.com/monfera |
| preparing for user-specified stroke/stroke-opacity, fill/fill-opacity… | https://github.com/plotly/plotly.js/pull/2052/commits/0ad1a0cb823988208a6fe5c067ed58aa1cab3ca0 |
| 0ad1a0c | https://github.com/plotly/plotly.js/pull/2052/commits/0ad1a0cb823988208a6fe5c067ed58aa1cab3ca0 |
|
| https://github.com/monfera |
| user-specified stroke/stroke-opacity, fill/fill-opacity setting via C… | https://github.com/plotly/plotly.js/pull/2052/commits/1254c9fb79f5f672e51898a83417cc90e06fea86 |
| 1254c9f | https://github.com/plotly/plotly.js/pull/2052/commits/1254c9fb79f5f672e51898a83417cc90e06fea86 |
|
| https://github.com/monfera |
| Merge branch 'table-squashed' of | https://github.com/plotly/plotly.js/pull/2052/commits/e38b7cf159b14a66d45e021ece312b6f55f6e422 |
| https://github.com/plotly/plotly.js | https://github.com/plotly/plotly.js |
| … | https://github.com/plotly/plotly.js/pull/2052/commits/e38b7cf159b14a66d45e021ece312b6f55f6e422 |
| e38b7cf | https://github.com/plotly/plotly.js/pull/2052/commits/e38b7cf159b14a66d45e021ece312b6f55f6e422 |
|
| https://github.com/monfera |
| Merge branch 'table-textselect' into table-squashed | https://github.com/plotly/plotly.js/pull/2052/commits/94338f4169b66f514368a747ef1edd2ff9fed888 |
| 94338f4 | https://github.com/plotly/plotly.js/pull/2052/commits/94338f4169b66f514368a747ef1edd2ff9fed888 |
|
| https://github.com/monfera |
| minor simplification before rewiring event handlers to enable text copy | https://github.com/plotly/plotly.js/pull/2052/commits/628855988701f5d92252b61fd669ffd0496132b0 |
| 6288559 | https://github.com/plotly/plotly.js/pull/2052/commits/628855988701f5d92252b61fd669ffd0496132b0 |
|
| https://github.com/monfera |
| allow both dragging and text cell copying | https://github.com/plotly/plotly.js/pull/2052/commits/154ab24826fe606a5af960b46d941cf1ef6383ae |
| 154ab24 | https://github.com/plotly/plotly.js/pull/2052/commits/154ab24826fe606a5af960b46d941cf1ef6383ae |
|
| https://github.com/monfera |
| disable visible scrollbar on initial load | https://github.com/plotly/plotly.js/pull/2052/commits/94020208fd4316cc8ee7ebb352393fa1a8e20da2 |
| 9402020 | https://github.com/plotly/plotly.js/pull/2052/commits/94020208fd4316cc8ee7ebb352393fa1a8e20da2 |
|
| https://github.com/monfera |
| updating other mocks | https://github.com/plotly/plotly.js/pull/2052/commits/d4f0ed77499ebee9ef8dbf4d324e4cef44b849e0 |
| d4f0ed7 | https://github.com/plotly/plotly.js/pull/2052/commits/d4f0ed77499ebee9ef8dbf4d324e4cef44b849e0 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Oct 5, 2017 | https://github.com/plotly/plotly.js/pull/2052#issuecomment-334570021 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://user-images.githubusercontent.com/6675409/31248467-d5b2909a-a9e1-11e7-8769-a2f8837dd26a.png |
| @monfera | https://github.com/monfera |
| @monfera | https://github.com/monfera |
| #2056 | https://github.com/plotly/plotly.js/issues/2056 |
| #2053 | https://github.com/plotly/plotly.js/issues/2053 |
| #2057 | https://github.com/plotly/plotly.js/issues/2057 |
| #2054 | https://github.com/plotly/plotly.js/issues/2054 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
|
Provide a data table view usable via JavaScript
#991
| https://github.com/plotly/plotly.js/issues/991 |
|
[WIP] Table view
#1834
| https://github.com/plotly/plotly.js/pull/1834 |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| Oct 5, 2017 | https://github.com/plotly/plotly.js/pull/2052#issuecomment-334570876 |
| @etpinard | https://github.com/etpinard |
| @alexcjohnson | https://github.com/alexcjohnson |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| Oct 5, 2017 | https://github.com/plotly/plotly.js/pull/2052#event-1280605558 |
| https://github.com/monfera |
| monfera | https://github.com/monfera |
| 50e933c | https://github.com/plotly/plotly.js/commit/50e933cd1bea3a65fc5b3f265a5f00951b287698 |
| Oct 5, 2017 | https://github.com/plotly/plotly.js/pull/2052#event-1280605910 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| October 5, 2017 19:45 | https://github.com/plotly/plotly.js/pull/2052#event-1280612749 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2052 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/2052/files/2648e51d865ea0afb438b73dbdedf193fd431205 |
|
| https://github.com/etpinard |
|
etpinard
| https://github.com/etpinard |
|
| https://github.com/plotly/plotly.js/pull/2052/files/2648e51d865ea0afb438b73dbdedf193fd431205 |
|
| https://github.com/monfera |
|
monfera
| https://github.com/monfera |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
|
v1.31.0
| https://github.com/plotly/plotly.js/milestone/27 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2052 |
|
| https://github.com/monfera |
|
| https://github.com/etpinard |
|
| https://github.com/alexcjohnson |
|
| https://github.com/rreusser |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |