| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e2f412b2-d72a-d5dc-bcec-604cdaefb817 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A570:2A95D0:125516E:1AAF0DB:6A563927 |
| html-safe-nonce | 8f2aa9f769fdfc10edc25e94b74a7edd8ed0c46cd0a0a78fa8ace8df2827fa81 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTcwOjJBOTVEMDoxMjU1MTZFOjFBQUYwREI6NkE1NjM5MjciLCJ2aXNpdG9yX2lkIjoiMzc0NDYyMTI1MjMxMDM1MDExOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 860d63361b50b97571a4a7a27aad59d23d6d4dd3cadca3dfa929831a4a20c006 |
| hovercard-subject-tag | pull_request:142692424 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/2032/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ce86fa3cf0c190b856b7a37b0a6e0dcc08da448d508506779f00e4f809edfa35/plotly/plotly.js/pull/2032 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ce86fa3cf0c190b856b7a37b0a6e0dcc08da448d508506779f00e4f809edfa35/plotly/plotly.js/pull/2032 |
| og:image:alt | resolves #236.
This PR eliminates all circular dependencies (🎉), mainly by adding gd._plotAPI.* (as suggested in #236) which binds (curries?) the gd to the arguments automatically. That is, you can... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rreusser |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9d78ea552aac0685ca5f006d44f88166cbbf3bb96843f8da0c5a2c0b9908430b |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423b2fb76ac2b90de5ab599b7a76a0d2b2c83f24 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/2032#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2032 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2032 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/2032 |
| Reload | https://github.com/plotly/plotly.js/pull/2032 |
| Reload | https://github.com/plotly/plotly.js/pull/2032 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
771
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
56
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| rreusser | https://github.com/rreusser |
| master | https://github.com/plotly/plotly.js/tree/master |
| eliminate-circularity | https://github.com/plotly/plotly.js/tree/eliminate-circularity |
| Conversation | https://github.com/plotly/plotly.js/pull/2032 |
| Commits5 (5) | https://github.com/plotly/plotly.js/pull/2032/commits |
| Checks | https://github.com/plotly/plotly.js/pull/2032/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/2032/files |
| Eliminate circular dependencies | https://github.com/plotly/plotly.js/pull/2032#top |
| rreusser | https://github.com/rreusser |
| master | https://github.com/plotly/plotly.js/tree/master |
| eliminate-circularity | https://github.com/plotly/plotly.js/tree/eliminate-circularity |
|
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 23, 2017 | https://github.com/plotly/plotly.js/pull/2032#issue-259968627 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| #236 | https://github.com/plotly/plotly.js/issues/236 |
| #236 | https://github.com/plotly/plotly.js/issues/236 |
| #236 | https://github.com/plotly/plotly.js/issues/236 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
|
| https://github.com/rreusser |
| Eliminiate circular dependencies | https://github.com/plotly/plotly.js/pull/2032/commits/9a45c5c96479e469c3de852cc1e83428ef36dd4a |
| 9a45c5c | https://github.com/plotly/plotly.js/pull/2032/commits/9a45c5c96479e469c3de852cc1e83428ef36dd4a |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
type: maintenance
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22type%3A%20maintenance%22 |
| Sep 23, 2017 | https://github.com/plotly/plotly.js/pull/2032#event-1262150254 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
Sep 23, 2017
| https://github.com/plotly/plotly.js/pull/2032#pullrequestreview-64726233 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2032/files/9a45c5c96479e469c3de852cc1e83428ef36dd4a |
| src/plots/get_subplot_ids.js | https://github.com/plotly/plotly.js/pull/2032/files/9a45c5c96479e469c3de852cc1e83428ef36dd4a#diff-537fcda3abb82f5f6ebbdb74b2a749ab3768f4b27dff3f61583e9f4696fbb7d4 |
| rreusser | https://github.com/rreusser |
| Sep 23, 2017 | https://github.com/plotly/plotly.js/pull/2032#discussion_r140620522 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
Sep 23, 2017
| https://github.com/plotly/plotly.js/pull/2032#pullrequestreview-64726318 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2032/files/9a45c5c96479e469c3de852cc1e83428ef36dd4a |
| src/plots/font_weight.js | https://github.com/plotly/plotly.js/pull/2032/files/9a45c5c96479e469c3de852cc1e83428ef36dd4a#diff-fff12264c5a9e8d0bc456f4a7029d4ec90c3bc0045088ff50440a2f4d1d08c81 |
| rreusser | https://github.com/rreusser |
| Sep 23, 2017 | https://github.com/plotly/plotly.js/pull/2032#discussion_r140620604 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| alexcjohnson | https://github.com/alexcjohnson |
| Sep 25, 2017 | https://github.com/plotly/plotly.js/pull/2032#discussion_r140907084 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| etpinard | https://github.com/etpinard |
| Sep 25, 2017 | https://github.com/plotly/plotly.js/pull/2032#discussion_r140916206 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| this | https://github.com/plotly/streambed/blob/master/shelly/plotlyjs/static/plotlyjs/src/styles/open_office_2015.js#L12 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| alexcjohnson | https://github.com/alexcjohnson |
| Sep 26, 2017 | https://github.com/plotly/plotly.js/pull/2032#discussion_r140942524 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| this | https://github.com/plotly/streambed/blob/master/shelly/plotlyjs/static/plotlyjs/src/styles/open_office_2015.js#L12 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
Sep 23, 2017
| https://github.com/plotly/plotly.js/pull/2032#pullrequestreview-64726368 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2032/files/9a45c5c96479e469c3de852cc1e83428ef36dd4a |
| src/plots/plots.js | https://github.com/plotly/plotly.js/pull/2032/files/9a45c5c96479e469c3de852cc1e83428ef36dd4a#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970 |
| rreusser | https://github.com/rreusser |
| Sep 23, 2017 | https://github.com/plotly/plotly.js/pull/2032#discussion_r140620641 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
Sep 23, 2017
| https://github.com/plotly/plotly.js/pull/2032#pullrequestreview-64726394 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2032/files/9a45c5c96479e469c3de852cc1e83428ef36dd4a |
| test/jasmine/tests/lib_test.js | https://github.com/plotly/plotly.js/pull/2032/files/9a45c5c96479e469c3de852cc1e83428ef36dd4a#diff-23641dad47ba17a58afef1e21b4f4f325ec165a7f5a8cd43539e451cafa70159 |
| rreusser | https://github.com/rreusser |
| Sep 23, 2017 | https://github.com/plotly/plotly.js/pull/2032#discussion_r140620671 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| rreusser | https://github.com/rreusser |
| September 22, 2017 17:53 | https://github.com/plotly/plotly.js/pull/2032#commits-pushed-6155d55 |
|
| https://github.com/rreusser |
| Fix commmand test spy | https://github.com/plotly/plotly.js/pull/2032/commits/6155d5560a64b1cb2d3ea5e8a09401b533a715ad |
| 6155d55 | https://github.com/plotly/plotly.js/pull/2032/commits/6155d5560a64b1cb2d3ea5e8a09401b533a715ad |
|
| https://github.com/rreusser |
| Delete a line to re-trigger circle-ci | https://github.com/plotly/plotly.js/pull/2032/commits/8c09468c496a538b75d30dc5a1b4e534bb3435ca |
| 8c09468 | https://github.com/plotly/plotly.js/pull/2032/commits/8c09468c496a538b75d30dc5a1b4e534bb3435ca |
|
| https://github.com/rreusser |
| Fix _plotAPI typo | https://github.com/plotly/plotly.js/pull/2032/commits/ec1bf51741377ccd3ea2b47c486a8befb22934ee |
| ec1bf51 | https://github.com/plotly/plotly.js/pull/2032/commits/ec1bf51741377ccd3ea2b47c486a8befb22934ee |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 23, 2017 | https://github.com/plotly/plotly.js/pull/2032#event-1262169668 |
|
| https://github.com/rreusser |
| Fix plots test | https://github.com/plotly/plotly.js/pull/2032/commits/d9a3df8d73d84af7013451a42ec9b5d11c65e88d |
| d9a3df8 | https://github.com/plotly/plotly.js/pull/2032/commits/d9a3df8d73d84af7013451a42ec9b5d11c65e88d |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Sep 25, 2017
| https://github.com/plotly/plotly.js/pull/2032#pullrequestreview-65003286 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/2032/files/d9a3df8d73d84af7013451a42ec9b5d11c65e88d |
| tasks/test_syntax.js | https://github.com/plotly/plotly.js/pull/2032/files/d9a3df8d73d84af7013451a42ec9b5d11c65e88d#diff-c8f6e94ef0c816b82b00993d5ba5a427998386763e5aab80684e18ab5cf330c1 |
| etpinard | https://github.com/etpinard |
| Sep 25, 2017 | https://github.com/plotly/plotly.js/pull/2032#discussion_r140869837 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| rreusser | https://github.com/rreusser |
| Sep 25, 2017 | https://github.com/plotly/plotly.js/pull/2032#discussion_r140870461 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
status: on hold
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20on%20hold%22 |
|
status: in progress
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22 |
| Sep 26, 2017 | https://github.com/plotly/plotly.js/pull/2032#event-1266221321 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Sep 26, 2017 | https://github.com/plotly/plotly.js/pull/2032#issuecomment-332272263 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Oct 12, 2017 | https://github.com/plotly/plotly.js/pull/2032#issuecomment-336153125 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| plotly/plotly.R#483 | https://github.com/plotly/plotly.R/issues/483 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Decircularise src dependencies | https://github.com/plotly/plotly.js/milestone/9 |
| Nov 17, 2017 | https://github.com/plotly/plotly.js/pull/2032#event-1347469869 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Nov 17, 2017 | https://github.com/plotly/plotly.js/pull/2032#issuecomment-345290916 |
| https://github.com/plotly/plotly.js/milestone/9 | https://github.com/plotly/plotly.js/milestone/9 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Nov 17, 2017 | https://github.com/plotly/plotly.js/pull/2032#event-1347471391 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| November 17, 2017 16:25 | https://github.com/plotly/plotly.js/pull/2032#event-1347471521 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Nov 17, 2017
| https://github.com/plotly/plotly.js/pull/2032#ref-issue-131089584 |
|
De-circularize plotly.js require statements
#236
| https://github.com/plotly/plotly.js/issues/236 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Mar 1, 2018
| https://github.com/plotly/plotly.js/pull/2032#ref-pullrequest-301564662 |
|
ZERO circular dependency
#2429
| https://github.com/plotly/plotly.js/pull/2429 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F2032 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/2032/files/9a45c5c96479e469c3de852cc1e83428ef36dd4a |
|
| https://github.com/etpinard |
|
etpinard
| https://github.com/etpinard |
|
| https://github.com/plotly/plotly.js/pull/2032/files/9a45c5c96479e469c3de852cc1e83428ef36dd4a |
|
Decircularise src dependencies
| https://github.com/plotly/plotly.js/milestone/9 |
|
De-circularize plotly.js require statements
| https://github.com/plotly/plotly.js/issues/236 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/2032 |
|
| https://github.com/rreusser |
|
| https://github.com/etpinard |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |