| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:4d05cfcc-a972-79e3-3f1f-315dff25b463 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ECD2:5FC26:18311B6:2309B24:6A54E54B |
| html-safe-nonce | 0a1a2b7beb2abaa63f46d1a5554ec3c5f6dece86be5e6f48d1c4975597fa80fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0QyOjVGQzI2OjE4MzExQjY6MjMwOUIyNDo2QTU0RTU0QiIsInZpc2l0b3JfaWQiOiIzMTc2OTY4MDEzMzQ3MDg3NjkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 51c91d65836084469bb0250c543746cccbbcaa78daa8a696d15515115b665fd2 |
| hovercard-subject-tag | pull_request:125247229 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/1781/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/e32a049df7a3c18a3a1e7d97dd82b5605e2e1290c451df7d041444049c6d47e9/plotly/plotly.js/pull/1781 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e32a049df7a3c18a3a1e7d97dd82b5605e2e1290c451df7d041444049c6d47e9/plotly/plotly.js/pull/1781 |
| og:image:alt | Supersedes #1550 with better mocks and fine tuning via gl-vis/gl-scatter2d-sdf#4 and b1bccdc
TODO:
bump gl-scatter2d-sdf once @dfcreative 's Update markers alignment gl-vis/gl-scatter2d-sdf#4... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | etpinard |
| hostname | github.com |
| expected-hostname | github.com |
| None | eae2aab99907699a22d2c8449aa683ca74454fca87211b98f7c7b722086b2839 |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bb1b4ffdc07c66de20ad344214f55df0aa364bd3 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/1781#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1781 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1781 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/1781 |
| Reload | https://github.com/plotly/plotly.js/pull/1781 |
| Reload | https://github.com/plotly/plotly.js/pull/1781 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
773
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
61
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| gl2d-more-symbols | https://github.com/plotly/plotly.js/tree/gl2d-more-symbols |
| Conversation | https://github.com/plotly/plotly.js/pull/1781 |
| Commits19 (19) | https://github.com/plotly/plotly.js/pull/1781/commits |
| Checks | https://github.com/plotly/plotly.js/pull/1781/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/1781/files |
| More gl2d symbols! | https://github.com/plotly/plotly.js/pull/1781#top |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| gl2d-more-symbols | https://github.com/plotly/plotly.js/tree/gl2d-more-symbols |
|
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Jun 12, 2017 | https://github.com/plotly/plotly.js/pull/1781#issue-235389386 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| #1550 | https://github.com/plotly/plotly.js/pull/1550 |
| gl-vis/gl-scatter2d-sdf#4 | https://github.com/gl-vis/gl-scatter2d-sdf/pull/4 |
| b1bccdc | https://github.com/plotly/plotly.js/commit/b1bccdc8993ff73175531939e432a690f998f885 |
| @dfcreative | https://github.com/dfcreative |
| Update markers alignment gl-vis/gl-scatter2d-sdf#4 | https://github.com/gl-vis/gl-scatter2d-sdf/pull/4 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| June 12, 2017 13:55 | https://github.com/plotly/plotly.js/pull/1781#commits-pushed-2ab37c7 |
|
| https://github.com/etpinard |
| Add 49 more unicode symbols for scattergl symbol types | https://github.com/plotly/plotly.js/pull/1781/commits/2ab37c7a637480679c23edc481a885c78fa9900b |
| 2ab37c7 | https://github.com/plotly/plotly.js/pull/1781/commits/2ab37c7a637480679c23edc481a885c78fa9900b |
|
| https://github.com/etpinard |
| revert devtools folder to master | https://github.com/plotly/plotly.js/pull/1781/commits/9890966039ee948f28cf9ce81d613978af259541 |
| 9890966 | https://github.com/plotly/plotly.js/pull/1781/commits/9890966039ee948f28cf9ce81d613978af259541 |
|
| https://github.com/etpinard |
| Changed gl_marker 'cross' back to original symbol and ran npm lint-fix | https://github.com/plotly/plotly.js/pull/1781/commits/ee67e23020059f8b08bdfb28897973918013f08b |
| ee67e23 | https://github.com/plotly/plotly.js/pull/1781/commits/ee67e23020059f8b08bdfb28897973918013f08b |
|
| https://github.com/etpinard |
| add 'scatter' marker symbol mock | https://github.com/plotly/plotly.js/pull/1781/commits/083b00a9832211dfa1f02e511fdaf8698fedce1d |
| 083b00a | https://github.com/plotly/plotly.js/pull/1781/commits/083b00a9832211dfa1f02e511fdaf8698fedce1d |
|
| https://github.com/etpinard |
| update gl symbol list so that they all render in imagetest container | https://github.com/plotly/plotly.js/pull/1781/commits/151b9860e81b8510343964ae8b6baeb776ae0e2e |
| 151b986 | https://github.com/plotly/plotly.js/pull/1781/commits/151b9860e81b8510343964ae8b6baeb776ae0e2e |
|
| https://github.com/etpinard |
| split gl markers into gl2d and gl3d lists | https://github.com/plotly/plotly.js/pull/1781/commits/70fe7567e613033a69b05ba8d544423aaa7ff2c5 |
| 70fe756 | https://github.com/plotly/plotly.js/pull/1781/commits/70fe7567e613033a69b05ba8d544423aaa7ff2c5 |
|
| https://github.com/etpinard |
| add gl3d marker symbols mock | https://github.com/plotly/plotly.js/pull/1781/commits/fe4cbe0eaae7f4066c74f03ad77b289a3aca3079 |
| fe4cbe0 | https://github.com/plotly/plotly.js/pull/1781/commits/fe4cbe0eaae7f4066c74f03ad77b289a3aca3079 |
|
| https://github.com/etpinard |
| improve scattergl symbol coloring and border width | https://github.com/plotly/plotly.js/pull/1781/commits/b1bccdc8993ff73175531939e432a690f998f885 |
| b1bccdc | https://github.com/plotly/plotly.js/pull/1781/commits/b1bccdc8993ff73175531939e432a690f998f885 |
|
| https://github.com/etpinard |
| update gl2d marker symbols mock | https://github.com/plotly/plotly.js/pull/1781/commits/b4db0efc205bb8377872a6747185a332d6a30f4a |
| b4db0ef | https://github.com/plotly/plotly.js/pull/1781/commits/b4db0efc205bb8377872a6747185a332d6a30f4a |
| https://codepen.io/etpinard/pen/WOxxaO | https://codepen.io/etpinard/pen/WOxxaO |
|
| https://github.com/etpinard |
| new scattergl baselines (w/ gl-scatter2d-sdf#4) | https://github.com/plotly/plotly.js/pull/1781/commits/5b89cf2a5e232732da863d751030a58b407048c8 |
| 5b89cf2 | https://github.com/plotly/plotly.js/pull/1781/commits/5b89cf2a5e232732da863d751030a58b407048c8 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
| Jun 12, 2017 | https://github.com/plotly/plotly.js/pull/1781#event-1120415088 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| 1.28.0 | https://github.com/plotly/plotly.js/milestone/22 |
| Jun 12, 2017 | https://github.com/plotly/plotly.js/pull/1781#event-1120415091 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Jun 12, 2017
| https://github.com/plotly/plotly.js/pull/1781#ref-pullrequest-219033357 |
|
More symbols for gl2d and gl3d plots
#1550
| https://github.com/plotly/plotly.js/pull/1550 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Jun 12, 2017
| https://github.com/plotly/plotly.js/pull/1781#pullrequestreview-43585187 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1781/files/083b00a9832211dfa1f02e511fdaf8698fedce1d |
| test/image/mocks/marker_symbols.json | https://github.com/plotly/plotly.js/pull/1781/files/ee67e23020059f8b08bdfb28897973918013f08b..083b00a9832211dfa1f02e511fdaf8698fedce1d#diff-836db9a1b0a38cb758a7bd754f3ab0aa2b644313eb72f7092934c2220ef5d478 |
| etpinard | https://github.com/etpinard |
| Jun 12, 2017 | https://github.com/plotly/plotly.js/pull/1781#discussion_r121547158 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://codepen.io/etpinard/pen/LLZGZV | https://codepen.io/etpinard/pen/LLZGZV |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Jun 12, 2017 | https://github.com/plotly/plotly.js/pull/1781#issuecomment-307959067 |
| https://user-images.githubusercontent.com/6675409/27058825-8377bb6a-4fa1-11e7-9685-b523b1200106.png |
| https://user-images.githubusercontent.com/6675409/27058821-7ccf1c72-4fa1-11e7-9f4f-2b80eea35034.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Jun 12, 2017
| https://github.com/plotly/plotly.js/pull/1781#pullrequestreview-43585862 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1781/files/fe4cbe0eaae7f4066c74f03ad77b289a3aca3079 |
| test/image/mocks/gl3d_marker_symbols.json | https://github.com/plotly/plotly.js/pull/1781/files/70fe7567e613033a69b05ba8d544423aaa7ff2c5..fe4cbe0eaae7f4066c74f03ad77b289a3aca3079#diff-11c16746dc83ee6127e0fad59570734a9174bbcbcd899faaff9bccf9ba91b984 |
| etpinard | https://github.com/etpinard |
| Jun 12, 2017 | https://github.com/plotly/plotly.js/pull/1781#discussion_r121547810 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| https://github.com/dy |
| dy | https://github.com/dy |
| Jun 12, 2017 | https://github.com/plotly/plotly.js/pull/1781#issuecomment-307963066 |
| @etpinard | https://github.com/etpinard |
| #949 | https://github.com/plotly/plotly.js/issues/949 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Jun 13, 2017 | https://github.com/plotly/plotly.js/pull/1781#issuecomment-307974513 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| https://github.com/dy |
| dy | https://github.com/dy |
| Jun 13, 2017 | https://github.com/plotly/plotly.js/pull/1781#issuecomment-307976215 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| @alexcjohnson | https://github.com/alexcjohnson |
| font-atlas-sdf | https://github.com/dfcreative/font-atlas-sdf |
| tiny-sdf | https://github.com/mourner/tiny-sdf |
| unicode box cross symbol | https://unicode-table.com/en/2573/ |
| any other cross | https://unicode-table.com/en/search/?q=cross |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Jun 13, 2017 | https://github.com/plotly/plotly.js/pull/1781#issuecomment-307979384 |
| https://user-images.githubusercontent.com/2678795/27061797-c505235c-4fb4-11e7-82a9-9eafd9080dd7.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
|
| https://github.com/etpinard |
| AJ-proof gl2d marker symbols | https://github.com/plotly/plotly.js/pull/1781/commits/bb9a46c808352503bca429abd4f74ef08c9fb455 |
|
| https://github.com/plotly/plotly.js/commit/bb9a46c808352503bca429abd4f74ef08c9fb455#comments |
| bb9a46c | https://github.com/plotly/plotly.js/pull/1781/commits/bb9a46c808352503bca429abd4f74ef08c9fb455 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Jun 13, 2017 | https://github.com/plotly/plotly.js/pull/1781#issuecomment-308140665 |
| @alexcjohnson | https://github.com/alexcjohnson |
| bb9a46c | https://github.com/plotly/plotly.js/commit/bb9a46c808352503bca429abd4f74ef08c9fb455 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
|
| https://github.com/etpinard |
| bump gl-scatter2d-sdf to ^1.3.10 | https://github.com/plotly/plotly.js/pull/1781/commits/612921fed3d6f241bc11670d45f58a090256e26e |
| 612921f | https://github.com/plotly/plotly.js/pull/1781/commits/612921fed3d6f241bc11670d45f58a090256e26e |
| https://github.com/dy |
| dy | https://github.com/dy |
| Jun 13, 2017 | https://github.com/plotly/plotly.js/pull/1781#issuecomment-308179105 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| @alexcjohnson | https://github.com/alexcjohnson |
| dy/font-atlas-sdf@1f610fe | https://github.com/dy/font-atlas-sdf/commit/1f610febece7ec8b7bbee2cf50d7e08016248916 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Jun 13, 2017 | https://github.com/plotly/plotly.js/pull/1781#issuecomment-308209841 |
| it | https://github.com/plotly/plotly.js/blob/85e8770998a0e0ca4ee3a3de3ede6f494a3ec91f/src/constants/gl_markers.js#L20 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| etpinard | https://github.com/etpinard |
| June 13, 2017 16:08 | https://github.com/plotly/plotly.js/pull/1781#commits-pushed-f15db4b |
|
| https://github.com/etpinard |
| add non-white bg to marker symbols mock | https://github.com/plotly/plotly.js/pull/1781/commits/f15db4b2c7d17eb67c2d2e4da85b0180aec584d6 |
| f15db4b | https://github.com/plotly/plotly.js/pull/1781/commits/f15db4b2c7d17eb67c2d2e4da85b0180aec584d6 |
|
| https://github.com/etpinard |
| check in font-atlas-sdf in dependencies | https://github.com/plotly/plotly.js/pull/1781/commits/c35fcb37ee0dbdedbd633c4ed1a72d0ad2764c62 |
| c35fcb3 | https://github.com/plotly/plotly.js/pull/1781/commits/c35fcb37ee0dbdedbd633c4ed1a72d0ad2764c62 |
|
| https://github.com/etpinard |
| add back 'x' and add 'cross-open' & 'x-open' | https://github.com/plotly/plotly.js/pull/1781/commits/9c9346ae8b6e1ceda13d37a328b79452586500cc |
| 9c9346a | https://github.com/plotly/plotly.js/pull/1781/commits/9c9346ae8b6e1ceda13d37a328b79452586500cc |
|
| https://github.com/etpinard |
| update gl2d baselines for font-atlas-sdf@1.3.3 | https://github.com/plotly/plotly.js/pull/1781/commits/39618de0c98be4fc743d59bd135bf0c5e7399dc6 |
| 39618de | https://github.com/plotly/plotly.js/pull/1781/commits/39618de0c98be4fc743d59bd135bf0c5e7399dc6 |
|
| https://github.com/etpinard |
| simplify scattergl per-symbol logic | https://github.com/plotly/plotly.js/pull/1781/commits/fffc70258ad106ab734a8db96696e5448a00d4c8 |
| fffc702 | https://github.com/plotly/plotly.js/pull/1781/commits/fffc70258ad106ab734a8db96696e5448a00d4c8 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Jun 13, 2017
| https://github.com/plotly/plotly.js/pull/1781#pullrequestreview-43880498 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1781/files/fffc70258ad106ab734a8db96696e5448a00d4c8 |
| src/traces/scattergl/convert.js | https://github.com/plotly/plotly.js/pull/1781/files/fffc70258ad106ab734a8db96696e5448a00d4c8#diff-1253837d934fd14bd257b24aede5af812700ea5250acc4668e1a3426739f9c9a |
| alexcjohnson | https://github.com/alexcjohnson |
| Jun 13, 2017 | https://github.com/plotly/plotly.js/pull/1781#discussion_r121820798 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| etpinard | https://github.com/etpinard |
| Jun 14, 2017 | https://github.com/plotly/plotly.js/pull/1781#discussion_r121968112 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://codepen.io/etpinard/pen/JJRMxo?editors=0010 | https://codepen.io/etpinard/pen/JJRMxo?editors=0010 |
| fffc702 | https://github.com/plotly/plotly.js/commit/fffc70258ad106ab734a8db96696e5448a00d4c8 |
| https://user-images.githubusercontent.com/6675409/27138510-a05334aa-50ee-11e7-8330-eaea2c8f6dac.png |
| https://user-images.githubusercontent.com/6675409/27138301-3d566f0c-50ee-11e7-991f-fce5a5417f57.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| etpinard | https://github.com/etpinard |
| Jun 14, 2017 | https://github.com/plotly/plotly.js/pull/1781#discussion_r121993298 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @alexcjohnson | https://github.com/alexcjohnson |
| gl2d-more-symbols...gl2d-more-symbols-line-width | https://github.com/plotly/plotly.js/compare/gl2d-more-symbols...gl2d-more-symbols-line-width |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| alexcjohnson | https://github.com/alexcjohnson |
| Jun 14, 2017 | https://github.com/plotly/plotly.js/pull/1781#discussion_r121999563 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| etpinard | https://github.com/etpinard |
| Jun 14, 2017 | https://github.com/plotly/plotly.js/pull/1781#discussion_r122005780 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 3f664a1 | https://github.com/plotly/plotly.js/commit/3f664a1744467f191a230384dbf74549ab1452a2 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| alexcjohnson | https://github.com/alexcjohnson |
| Jun 14, 2017 | https://github.com/plotly/plotly.js/pull/1781#discussion_r122009771 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Jun 13, 2017 | https://github.com/plotly/plotly.js/pull/1781#issuecomment-308276668 |
| @etpinard | https://github.com/etpinard |
| https://github.com/plotly/plotly.js/pull/1781/files#r121820798 | https://github.com/plotly/plotly.js/pull/1781/files#r121820798 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| etpinard | https://github.com/etpinard |
|
Jun 14, 2017
| https://github.com/plotly/plotly.js/pull/1781#ref-commit-b848a0d |
|
| https://github.com/etpinard |
| pre 1.28.0 dist | https://github.com/plotly/plotly.js/commit/b848a0d75835d2986e615823e4059f8fa1279bb7 |
| b848a0d | https://github.com/plotly/plotly.js/commit/b848a0d75835d2986e615823e4059f8fa1279bb7 |
| #1657 | https://github.com/plotly/plotly.js/pull/1657 |
| gl-vis/gl-scatter2d-sdf#5 | https://github.com/gl-vis/gl-scatter2d-sdf/pull/5 |
| #1781 | https://github.com/plotly/plotly.js/pull/1781 |
| #1770 | https://github.com/plotly/plotly.js/pull/1770 |
| etpinard | https://github.com/etpinard |
| June 14, 2017 13:54 | https://github.com/plotly/plotly.js/pull/1781#commits-pushed-c7a49eb |
|
| https://github.com/etpinard |
| replace bwFactor logic with minBorderWidth | https://github.com/plotly/plotly.js/pull/1781/commits/c7a49eb7e7fdb5d8b7bcfedec3b2780e2082cde7 |
| c7a49eb | https://github.com/plotly/plotly.js/pull/1781/commits/c7a49eb7e7fdb5d8b7bcfedec3b2780e2082cde7 |
| #1781 (review) | https://github.com/plotly/plotly.js/pull/1781#pullrequestreview-43880498 |
|
| https://github.com/etpinard |
| add svg and gl2d mocks for marker line width scaling | https://github.com/plotly/plotly.js/pull/1781/commits/4444c36b8ccd327115e9e341d68398bfa787a3f7 |
| 4444c36 | https://github.com/plotly/plotly.js/pull/1781/commits/4444c36b8ccd327115e9e341d68398bfa787a3f7 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Jun 14, 2017 | https://github.com/plotly/plotly.js/pull/1781#issuecomment-308552632 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| 91c0b8d | https://github.com/plotly/plotly.js/commit/91c0b8d73f3af7fe160ec483807737413bfc66d8 |
| Jun 14, 2017 | https://github.com/plotly/plotly.js/pull/1781#event-1124032443 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| June 14, 2017 20:46 | https://github.com/plotly/plotly.js/pull/1781#event-1124032507 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1781 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/1781/files/fffc70258ad106ab734a8db96696e5448a00d4c8 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
|
1.28.0
| https://github.com/plotly/plotly.js/milestone/22 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1781 |
|
| https://github.com/etpinard |
|
| https://github.com/dy |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |