René's URL Explorer Experiment


Title: More gl2d symbols! by etpinard · Pull Request #1781 · plotly/plotly.js · GitHub

Open Graph Title: More gl2d symbols! by etpinard · Pull Request #1781 · plotly/plotly.js

X Title: More gl2d symbols! by etpinard · Pull Request #1781 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - More gl2d symbols! by etpinard · Pull Request #1781 · plotly/plotly.js

Open Graph Description: Supersedes #1550 with better mocks and fine tuning via gl-vis/gl-scatter2d-sdf#4 and b1bccdc TODO: bump gl-scatter2d-sdf once @dfcreative 's Update markers alignment gl-vis/gl-scatter2d-sdf#4...

X Description: Supersedes #1550 with better mocks and fine tuning via gl-vis/gl-scatter2d-sdf#4 and b1bccdc TODO: bump gl-scatter2d-sdf once @dfcreative 's Update markers alignment gl-vis/gl-scatter2d-s...

Opengraph URL: https://github.com/plotly/plotly.js/pull/1781

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4d05cfcc-a972-79e3-3f1f-315dff25b463
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECD2:5FC26:18311B6:2309B24:6A54E54B
html-safe-nonce0a1a2b7beb2abaa63f46d1a5554ec3c5f6dece86be5e6f48d1c4975597fa80fc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0QyOjVGQzI2OjE4MzExQjY6MjMwOUIyNDo2QTU0RTU0QiIsInZpc2l0b3JfaWQiOiIzMTc2OTY4MDEzMzQ3MDg3NjkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac51c91d65836084469bb0250c543746cccbbcaa78daa8a696d15515115b665fd2
hovercard-subject-tagpull_request:125247229
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/1781/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e32a049df7a3c18a3a1e7d97dd82b5605e2e1290c451df7d041444049c6d47e9/plotly/plotly.js/pull/1781
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e32a049df7a3c18a3a1e7d97dd82b5605e2e1290c451df7d041444049c6d47e9/plotly/plotly.js/pull/1781
og:image:altSupersedes #1550 with better mocks and fine tuning via gl-vis/gl-scatter2d-sdf#4 and b1bccdc TODO: bump gl-scatter2d-sdf once @dfcreative 's Update markers alignment gl-vis/gl-scatter2d-sdf#4...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameetpinard
hostnamegithub.com
expected-hostnamegithub.com
Noneeae2aab99907699a22d2c8449aa683ca74454fca87211b98f7c7b722086b2839
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebb1b4ffdc07c66de20ad344214f55df0aa364bd3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/1781#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1781
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1781
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/1781
Reloadhttps://github.com/plotly/plotly.js/pull/1781
Reloadhttps://github.com/plotly/plotly.js/pull/1781
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
plotly https://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
Notifications https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Fork 2k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Star 18.3k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Code https://github.com/plotly/plotly.js
Issues 773 https://github.com/plotly/plotly.js/issues
Pull requests 61 https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality 0 https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
Code https://github.com/plotly/plotly.js
Issues https://github.com/plotly/plotly.js/issues
Pull requests https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
gl2d-more-symbolshttps://github.com/plotly/plotly.js/tree/gl2d-more-symbols
Conversationhttps://github.com/plotly/plotly.js/pull/1781
Commits19 (19)https://github.com/plotly/plotly.js/pull/1781/commits
Checkshttps://github.com/plotly/plotly.js/pull/1781/checks
Files changedhttps://github.com/plotly/plotly.js/pull/1781/files
More gl2d symbols!https://github.com/plotly/plotly.js/pull/1781#top
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
gl2d-more-symbolshttps://github.com/plotly/plotly.js/tree/gl2d-more-symbols
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 12, 2017https://github.com/plotly/plotly.js/pull/1781#issue-235389386
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
#1550https://github.com/plotly/plotly.js/pull/1550
gl-vis/gl-scatter2d-sdf#4https://github.com/gl-vis/gl-scatter2d-sdf/pull/4
b1bccdchttps://github.com/plotly/plotly.js/commit/b1bccdc8993ff73175531939e432a690f998f885
@dfcreativehttps://github.com/dfcreative
Update markers alignment gl-vis/gl-scatter2d-sdf#4https://github.com/gl-vis/gl-scatter2d-sdf/pull/4
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
June 12, 2017 13:55https://github.com/plotly/plotly.js/pull/1781#commits-pushed-2ab37c7
https://github.com/etpinard
Add 49 more unicode symbols for scattergl symbol typeshttps://github.com/plotly/plotly.js/pull/1781/commits/2ab37c7a637480679c23edc481a885c78fa9900b
2ab37c7https://github.com/plotly/plotly.js/pull/1781/commits/2ab37c7a637480679c23edc481a885c78fa9900b
https://github.com/etpinard
revert devtools folder to masterhttps://github.com/plotly/plotly.js/pull/1781/commits/9890966039ee948f28cf9ce81d613978af259541
9890966https://github.com/plotly/plotly.js/pull/1781/commits/9890966039ee948f28cf9ce81d613978af259541
https://github.com/etpinard
Changed gl_marker 'cross' back to original symbol and ran npm lint-fixhttps://github.com/plotly/plotly.js/pull/1781/commits/ee67e23020059f8b08bdfb28897973918013f08b
ee67e23https://github.com/plotly/plotly.js/pull/1781/commits/ee67e23020059f8b08bdfb28897973918013f08b
https://github.com/etpinard
add 'scatter' marker symbol mockhttps://github.com/plotly/plotly.js/pull/1781/commits/083b00a9832211dfa1f02e511fdaf8698fedce1d
083b00ahttps://github.com/plotly/plotly.js/pull/1781/commits/083b00a9832211dfa1f02e511fdaf8698fedce1d
https://github.com/etpinard
update gl symbol list so that they all render in imagetest containerhttps://github.com/plotly/plotly.js/pull/1781/commits/151b9860e81b8510343964ae8b6baeb776ae0e2e
151b986https://github.com/plotly/plotly.js/pull/1781/commits/151b9860e81b8510343964ae8b6baeb776ae0e2e
https://github.com/etpinard
split gl markers into gl2d and gl3d listshttps://github.com/plotly/plotly.js/pull/1781/commits/70fe7567e613033a69b05ba8d544423aaa7ff2c5
70fe756https://github.com/plotly/plotly.js/pull/1781/commits/70fe7567e613033a69b05ba8d544423aaa7ff2c5
https://github.com/etpinard
add gl3d marker symbols mockhttps://github.com/plotly/plotly.js/pull/1781/commits/fe4cbe0eaae7f4066c74f03ad77b289a3aca3079
fe4cbe0https://github.com/plotly/plotly.js/pull/1781/commits/fe4cbe0eaae7f4066c74f03ad77b289a3aca3079
https://github.com/etpinard
improve scattergl symbol coloring and border widthhttps://github.com/plotly/plotly.js/pull/1781/commits/b1bccdc8993ff73175531939e432a690f998f885
b1bccdchttps://github.com/plotly/plotly.js/pull/1781/commits/b1bccdc8993ff73175531939e432a690f998f885
https://github.com/etpinard
update gl2d marker symbols mockhttps://github.com/plotly/plotly.js/pull/1781/commits/b4db0efc205bb8377872a6747185a332d6a30f4a
b4db0efhttps://github.com/plotly/plotly.js/pull/1781/commits/b4db0efc205bb8377872a6747185a332d6a30f4a
https://codepen.io/etpinard/pen/WOxxaOhttps://codepen.io/etpinard/pen/WOxxaO
https://github.com/etpinard
new scattergl baselines (w/ gl-scatter2d-sdf#4)https://github.com/plotly/plotly.js/pull/1781/commits/5b89cf2a5e232732da863d751030a58b407048c8
5b89cf2https://github.com/plotly/plotly.js/pull/1781/commits/5b89cf2a5e232732da863d751030a58b407048c8
https://github.com/etpinard
etpinardhttps://github.com/etpinard
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
feature https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature
Jun 12, 2017https://github.com/plotly/plotly.js/pull/1781#event-1120415088
https://github.com/etpinard
etpinardhttps://github.com/etpinard
1.28.0https://github.com/plotly/plotly.js/milestone/22
Jun 12, 2017https://github.com/plotly/plotly.js/pull/1781#event-1120415091
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 12, 2017 https://github.com/plotly/plotly.js/pull/1781#ref-pullrequest-219033357
More symbols for gl2d and gl3d plots #1550 https://github.com/plotly/plotly.js/pull/1550
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 12, 2017 https://github.com/plotly/plotly.js/pull/1781#pullrequestreview-43585187
View reviewed changes https://github.com/plotly/plotly.js/pull/1781/files/083b00a9832211dfa1f02e511fdaf8698fedce1d
test/image/mocks/marker_symbols.jsonhttps://github.com/plotly/plotly.js/pull/1781/files/ee67e23020059f8b08bdfb28897973918013f08b..083b00a9832211dfa1f02e511fdaf8698fedce1d#diff-836db9a1b0a38cb758a7bd754f3ab0aa2b644313eb72f7092934c2220ef5d478
etpinardhttps://github.com/etpinard
Jun 12, 2017https://github.com/plotly/plotly.js/pull/1781#discussion_r121547158
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://codepen.io/etpinard/pen/LLZGZVhttps://codepen.io/etpinard/pen/LLZGZV
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 12, 2017https://github.com/plotly/plotly.js/pull/1781#issuecomment-307959067
https://user-images.githubusercontent.com/6675409/27058825-8377bb6a-4fa1-11e7-9685-b523b1200106.png
https://user-images.githubusercontent.com/6675409/27058821-7ccf1c72-4fa1-11e7-9f4f-2b80eea35034.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 12, 2017 https://github.com/plotly/plotly.js/pull/1781#pullrequestreview-43585862
View reviewed changes https://github.com/plotly/plotly.js/pull/1781/files/fe4cbe0eaae7f4066c74f03ad77b289a3aca3079
test/image/mocks/gl3d_marker_symbols.jsonhttps://github.com/plotly/plotly.js/pull/1781/files/70fe7567e613033a69b05ba8d544423aaa7ff2c5..fe4cbe0eaae7f4066c74f03ad77b289a3aca3079#diff-11c16746dc83ee6127e0fad59570734a9174bbcbcd899faaff9bccf9ba91b984
etpinardhttps://github.com/etpinard
Jun 12, 2017https://github.com/plotly/plotly.js/pull/1781#discussion_r121547810
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
https://github.com/dy
dyhttps://github.com/dy
Jun 12, 2017https://github.com/plotly/plotly.js/pull/1781#issuecomment-307963066
@etpinardhttps://github.com/etpinard
#949https://github.com/plotly/plotly.js/issues/949
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jun 13, 2017https://github.com/plotly/plotly.js/pull/1781#issuecomment-307974513
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
https://github.com/dy
dyhttps://github.com/dy
Jun 13, 2017https://github.com/plotly/plotly.js/pull/1781#issuecomment-307976215
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
@alexcjohnsonhttps://github.com/alexcjohnson
font-atlas-sdfhttps://github.com/dfcreative/font-atlas-sdf
tiny-sdfhttps://github.com/mourner/tiny-sdf
unicode box cross symbolhttps://unicode-table.com/en/2573/
any other crosshttps://unicode-table.com/en/search/?q=cross
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jun 13, 2017https://github.com/plotly/plotly.js/pull/1781#issuecomment-307979384
https://user-images.githubusercontent.com/2678795/27061797-c505235c-4fb4-11e7-82a9-9eafd9080dd7.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
https://github.com/etpinard
AJ-proof gl2d marker symbolshttps://github.com/plotly/plotly.js/pull/1781/commits/bb9a46c808352503bca429abd4f74ef08c9fb455
https://github.com/plotly/plotly.js/commit/bb9a46c808352503bca429abd4f74ef08c9fb455#comments
bb9a46chttps://github.com/plotly/plotly.js/pull/1781/commits/bb9a46c808352503bca429abd4f74ef08c9fb455
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 13, 2017https://github.com/plotly/plotly.js/pull/1781#issuecomment-308140665
@alexcjohnsonhttps://github.com/alexcjohnson
bb9a46chttps://github.com/plotly/plotly.js/commit/bb9a46c808352503bca429abd4f74ef08c9fb455
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
https://github.com/etpinard
bump gl-scatter2d-sdf to ^1.3.10https://github.com/plotly/plotly.js/pull/1781/commits/612921fed3d6f241bc11670d45f58a090256e26e
612921fhttps://github.com/plotly/plotly.js/pull/1781/commits/612921fed3d6f241bc11670d45f58a090256e26e
https://github.com/dy
dyhttps://github.com/dy
Jun 13, 2017https://github.com/plotly/plotly.js/pull/1781#issuecomment-308179105
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
@alexcjohnsonhttps://github.com/alexcjohnson
dy/font-atlas-sdf@1f610fehttps://github.com/dy/font-atlas-sdf/commit/1f610febece7ec8b7bbee2cf50d7e08016248916
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 13, 2017https://github.com/plotly/plotly.js/pull/1781#issuecomment-308209841
ithttps://github.com/plotly/plotly.js/blob/85e8770998a0e0ca4ee3a3de3ede6f494a3ec91f/src/constants/gl_markers.js#L20
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
etpinardhttps://github.com/etpinard
June 13, 2017 16:08https://github.com/plotly/plotly.js/pull/1781#commits-pushed-f15db4b
https://github.com/etpinard
add non-white bg to marker symbols mockhttps://github.com/plotly/plotly.js/pull/1781/commits/f15db4b2c7d17eb67c2d2e4da85b0180aec584d6
f15db4bhttps://github.com/plotly/plotly.js/pull/1781/commits/f15db4b2c7d17eb67c2d2e4da85b0180aec584d6
https://github.com/etpinard
check in font-atlas-sdf in dependencieshttps://github.com/plotly/plotly.js/pull/1781/commits/c35fcb37ee0dbdedbd633c4ed1a72d0ad2764c62
c35fcb3https://github.com/plotly/plotly.js/pull/1781/commits/c35fcb37ee0dbdedbd633c4ed1a72d0ad2764c62
https://github.com/etpinard
add back 'x' and add 'cross-open' & 'x-open'https://github.com/plotly/plotly.js/pull/1781/commits/9c9346ae8b6e1ceda13d37a328b79452586500cc
9c9346ahttps://github.com/plotly/plotly.js/pull/1781/commits/9c9346ae8b6e1ceda13d37a328b79452586500cc
https://github.com/etpinard
update gl2d baselines for font-atlas-sdf@1.3.3https://github.com/plotly/plotly.js/pull/1781/commits/39618de0c98be4fc743d59bd135bf0c5e7399dc6
39618dehttps://github.com/plotly/plotly.js/pull/1781/commits/39618de0c98be4fc743d59bd135bf0c5e7399dc6
https://github.com/etpinard
simplify scattergl per-symbol logichttps://github.com/plotly/plotly.js/pull/1781/commits/fffc70258ad106ab734a8db96696e5448a00d4c8
fffc702https://github.com/plotly/plotly.js/pull/1781/commits/fffc70258ad106ab734a8db96696e5448a00d4c8
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jun 13, 2017 https://github.com/plotly/plotly.js/pull/1781#pullrequestreview-43880498
View reviewed changes https://github.com/plotly/plotly.js/pull/1781/files/fffc70258ad106ab734a8db96696e5448a00d4c8
src/traces/scattergl/convert.jshttps://github.com/plotly/plotly.js/pull/1781/files/fffc70258ad106ab734a8db96696e5448a00d4c8#diff-1253837d934fd14bd257b24aede5af812700ea5250acc4668e1a3426739f9c9a
alexcjohnsonhttps://github.com/alexcjohnson
Jun 13, 2017https://github.com/plotly/plotly.js/pull/1781#discussion_r121820798
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
etpinardhttps://github.com/etpinard
Jun 14, 2017https://github.com/plotly/plotly.js/pull/1781#discussion_r121968112
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://codepen.io/etpinard/pen/JJRMxo?editors=0010https://codepen.io/etpinard/pen/JJRMxo?editors=0010
fffc702https://github.com/plotly/plotly.js/commit/fffc70258ad106ab734a8db96696e5448a00d4c8
https://user-images.githubusercontent.com/6675409/27138510-a05334aa-50ee-11e7-8330-eaea2c8f6dac.png
https://user-images.githubusercontent.com/6675409/27138301-3d566f0c-50ee-11e7-991f-fce5a5417f57.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
etpinardhttps://github.com/etpinard
Jun 14, 2017https://github.com/plotly/plotly.js/pull/1781#discussion_r121993298
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@alexcjohnsonhttps://github.com/alexcjohnson
gl2d-more-symbols...gl2d-more-symbols-line-widthhttps://github.com/plotly/plotly.js/compare/gl2d-more-symbols...gl2d-more-symbols-line-width
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
alexcjohnsonhttps://github.com/alexcjohnson
Jun 14, 2017https://github.com/plotly/plotly.js/pull/1781#discussion_r121999563
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
etpinardhttps://github.com/etpinard
Jun 14, 2017https://github.com/plotly/plotly.js/pull/1781#discussion_r122005780
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
3f664a1https://github.com/plotly/plotly.js/commit/3f664a1744467f191a230384dbf74549ab1452a2
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
alexcjohnsonhttps://github.com/alexcjohnson
Jun 14, 2017https://github.com/plotly/plotly.js/pull/1781#discussion_r122009771
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jun 13, 2017https://github.com/plotly/plotly.js/pull/1781#issuecomment-308276668
@etpinardhttps://github.com/etpinard
https://github.com/plotly/plotly.js/pull/1781/files#r121820798https://github.com/plotly/plotly.js/pull/1781/files#r121820798
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
etpinardhttps://github.com/etpinard
Jun 14, 2017 https://github.com/plotly/plotly.js/pull/1781#ref-commit-b848a0d
https://github.com/etpinard
pre 1.28.0 disthttps://github.com/plotly/plotly.js/commit/b848a0d75835d2986e615823e4059f8fa1279bb7
b848a0dhttps://github.com/plotly/plotly.js/commit/b848a0d75835d2986e615823e4059f8fa1279bb7
#1657https://github.com/plotly/plotly.js/pull/1657
gl-vis/gl-scatter2d-sdf#5https://github.com/gl-vis/gl-scatter2d-sdf/pull/5
#1781https://github.com/plotly/plotly.js/pull/1781
#1770https://github.com/plotly/plotly.js/pull/1770
etpinardhttps://github.com/etpinard
June 14, 2017 13:54https://github.com/plotly/plotly.js/pull/1781#commits-pushed-c7a49eb
https://github.com/etpinard
replace bwFactor logic with minBorderWidthhttps://github.com/plotly/plotly.js/pull/1781/commits/c7a49eb7e7fdb5d8b7bcfedec3b2780e2082cde7
c7a49ebhttps://github.com/plotly/plotly.js/pull/1781/commits/c7a49eb7e7fdb5d8b7bcfedec3b2780e2082cde7
#1781 (review)https://github.com/plotly/plotly.js/pull/1781#pullrequestreview-43880498
https://github.com/etpinard
add svg and gl2d mocks for marker line width scalinghttps://github.com/plotly/plotly.js/pull/1781/commits/4444c36b8ccd327115e9e341d68398bfa787a3f7
4444c36https://github.com/plotly/plotly.js/pull/1781/commits/4444c36b8ccd327115e9e341d68398bfa787a3f7
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
Jun 14, 2017https://github.com/plotly/plotly.js/pull/1781#issuecomment-308552632
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
https://github.com/etpinard
etpinardhttps://github.com/etpinard
91c0b8dhttps://github.com/plotly/plotly.js/commit/91c0b8d73f3af7fe160ec483807737413bfc66d8
Jun 14, 2017https://github.com/plotly/plotly.js/pull/1781#event-1124032443
https://github.com/etpinard
etpinardhttps://github.com/etpinard
June 14, 2017 20:46https://github.com/plotly/plotly.js/pull/1781#event-1124032507
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1781
https://github.com/alexcjohnson
alexcjohnson https://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/1781/files/fffc70258ad106ab734a8db96696e5448a00d4c8
feature https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature
1.28.0 https://github.com/plotly/plotly.js/milestone/22
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1781
https://github.com/etpinard
https://github.com/dy
https://github.com/alexcjohnson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.