René's URL Explorer Experiment


Title: Drawing perf take2 by etpinard · Pull Request #1690 · plotly/plotly.js · GitHub

Open Graph Title: Drawing perf take2 by etpinard · Pull Request #1690 · plotly/plotly.js

X Title: Drawing perf take2 by etpinard · Pull Request #1690 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Drawing perf take2 by etpinard · Pull Request #1690 · plotly/plotly.js

Open Graph Description: fixes #1675 Take 2 of 29abb5d from @hy9be's #1585 to be merged in #1683 @hy9be would you mind checking that this solution here is as fast as yours?

X Description: fixes #1675 Take 2 of 29abb5d from @hy9be's #1585 to be merged in #1683 @hy9be would you mind checking that this solution here is as fast as yours?

Opengraph URL: https://github.com/plotly/plotly.js/pull/1690

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2365ff74-fe11-b987-e3ca-462af6fd0993
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBBEA:277ED1:4F6E753:67E628D:6A5D74A4
html-safe-nonced74708248225997b14000c1f7b882e5bdec6e1b3543f705be123631959f1bcc0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQkVBOjI3N0VEMTo0RjZFNzUzOjY3RTYyOEQ6NkE1RDc0QTQiLCJ2aXNpdG9yX2lkIjoiMjM3Mjk1MTcyODk2OTMxNTQ5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac71da8460064af269a5ae89733e0ecfe66c1c742443eb784b03a71119a02501ac
hovercard-subject-tagpull_request:120699919
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/1690/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/054701dfaa22a72944b996bd39471de263ca9330cc7e8296048afd48b347e315/plotly/plotly.js/pull/1690
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/054701dfaa22a72944b996bd39471de263ca9330cc7e8296048afd48b347e315/plotly/plotly.js/pull/1690
og:image:altfixes #1675 Take 2 of 29abb5d from @hy9be's #1585 to be merged in #1683 @hy9be would you mind checking that this solution here is as fast as yours?
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameetpinard
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/1690#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1690
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1690
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/1690
Reloadhttps://github.com/plotly/plotly.js/pull/1690
Reloadhttps://github.com/plotly/plotly.js/pull/1690
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
plotly https://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
Notifications https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Fork 2k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Star 18.3k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Code https://github.com/plotly/plotly.js
Issues 773 https://github.com/plotly/plotly.js/issues
Pull requests 59 https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality 0 https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
Code https://github.com/plotly/plotly.js
Issues https://github.com/plotly/plotly.js/issues
Pull requests https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
etpinardhttps://github.com/etpinard
annotation-text-position-fixhttps://github.com/plotly/plotly.js/tree/annotation-text-position-fix
drawing-perf-take2https://github.com/plotly/plotly.js/tree/drawing-perf-take2
Conversationhttps://github.com/plotly/plotly.js/pull/1690
Commits5 (5)https://github.com/plotly/plotly.js/pull/1690/commits
Checkshttps://github.com/plotly/plotly.js/pull/1690/checks
Files changedhttps://github.com/plotly/plotly.js/pull/1690/files
Drawing perf take2https://github.com/plotly/plotly.js/pull/1690#top
etpinardhttps://github.com/etpinard
annotation-text-position-fixhttps://github.com/plotly/plotly.js/tree/annotation-text-position-fix
drawing-perf-take2https://github.com/plotly/plotly.js/tree/drawing-perf-take2
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 15, 2017https://github.com/plotly/plotly.js/pull/1690#issue-228852953
#1675https://github.com/plotly/plotly.js/issues/1675
29abb5dhttps://github.com/plotly/plotly.js/commit/29abb5d8ec3dea92cc71f438fffa6785463d1fb1
@hy9behttps://github.com/hy9be
#1585https://github.com/plotly/plotly.js/pull/1585
#1683https://github.com/plotly/plotly.js/pull/1683
@hy9behttps://github.com/hy9be
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
etpinardhttps://github.com/etpinard
May 15, 2017 17:30https://github.com/plotly/plotly.js/pull/1690#commits-pushed-0c62890
https://github.com/etpinard
cache ref to tester div and tester ref on drawing module objecthttps://github.com/plotly/plotly.js/pull/1690/commits/0c62890b6f04e87201c921581d9c9d8abc193f2e
0c62890https://github.com/plotly/plotly.js/pull/1690/commits/0c62890b6f04e87201c921581d9c9d8abc193f2e
https://github.com/etpinard
cache DOMParser instance on svg utils module objecthttps://github.com/plotly/plotly.js/pull/1690/commits/273a4c37701241d6224a9c4c7fa3c9f84444f66f
273a4c3https://github.com/plotly/plotly.js/pull/1690/commits/273a4c37701241d6224a9c4c7fa3c9f84444f66f
https://github.com/etpinard
etpinardhttps://github.com/etpinard
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
May 15, 2017https://github.com/plotly/plotly.js/pull/1690#event-1083088208
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 16, 2017 https://github.com/plotly/plotly.js/pull/1690#ref-pullrequest-228399621
Drawing bbox fix for window scroll #1683 https://github.com/plotly/plotly.js/pull/1683
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
May 16, 2017 https://github.com/plotly/plotly.js/pull/1690#pullrequestreview-38409680
View reviewed changes https://github.com/plotly/plotly.js/pull/1690/files/273a4c37701241d6224a9c4c7fa3c9f84444f66f
src/components/drawing/index.jshttps://github.com/plotly/plotly.js/pull/1690/files/273a4c37701241d6224a9c4c7fa3c9f84444f66f#diff-e8c93e83ebf0c3a486f3187d44d91b1709f51bccaba559fcadab2a3e3f9f56c6
alexcjohnsonhttps://github.com/alexcjohnson
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#discussion_r116763075
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
etpinardhttps://github.com/etpinard
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#discussion_r116787474
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#702https://github.com/plotly/plotly.js/issues/702
#764https://github.com/plotly/plotly.js/pull/764
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
alexcjohnsonhttps://github.com/alexcjohnson
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#discussion_r116793609
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
codepenhttp://codepen.io/anon/pen/RRpMzL
@nielsenb-jfhttps://github.com/nielsenb-jf
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
etpinardhttps://github.com/etpinard
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#discussion_r116803261
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
etpinardhttps://github.com/etpinard
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#discussion_r116811349
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
http://codepen.io/etpinard/pen/LyBQLj?editors=0010http://codepen.io/etpinard/pen/LyBQLj?editors=0010
https://cloud.githubusercontent.com/assets/6675409/26120301/379568b4-3a3e-11e7-9b8c-32ad2fa7185d.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
etpinardhttps://github.com/etpinard
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#discussion_r116813394
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@alexcjohnsonhttps://github.com/alexcjohnson
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
alexcjohnsonhttps://github.com/alexcjohnson
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#discussion_r116817089
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
alexcjohnsonhttps://github.com/alexcjohnson
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#discussion_r116818066
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
etpinardhttps://github.com/etpinard
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#discussion_r116820129
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
etpinardhttps://github.com/etpinard
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#discussion_r116822211
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
c3c3b3ahttps://github.com/plotly/plotly.js/commit/c3c3b3ab331fc96769885a3c6abaa0e64b2fe846
a8fba03https://github.com/plotly/plotly.js/commit/a8fba0336791e92956f8a0da6708ed0ab89329b0
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
May 16, 2017 https://github.com/plotly/plotly.js/pull/1690#pullrequestreview-38411112
View reviewed changes https://github.com/plotly/plotly.js/pull/1690/files/273a4c37701241d6224a9c4c7fa3c9f84444f66f
src/lib/svg_text_utils.jshttps://github.com/plotly/plotly.js/pull/1690/files/273a4c37701241d6224a9c4c7fa3c9f84444f66f#diff-9176580674d19e2a42673387c6b93371cf1e3c884648745fef5107fb746ee962
alexcjohnsonhttps://github.com/alexcjohnson
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#discussion_r116764392
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
etpinardhttps://github.com/etpinard
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#discussion_r116788762
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
e0050f7https://github.com/plotly/plotly.js/commit/e0050f73c57c54755a6131584b152151bf0c7c06
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
etpinardhttps://github.com/etpinard
May 16, 2017 12:12https://github.com/plotly/plotly.js/pull/1690#commits-pushed-e0050f7
https://github.com/etpinard
don't expose DOMParser instance on svg utils module objecthttps://github.com/plotly/plotly.js/pull/1690/commits/e0050f73c57c54755a6131584b152151bf0c7c06
e0050f7https://github.com/plotly/plotly.js/pull/1690/commits/e0050f73c57c54755a6131584b152151bf0c7c06
https://github.com/etpinard
🔪 gd._testref (wasn't used anywhere)https://github.com/plotly/plotly.js/pull/1690/commits/c3c3b3ab331fc96769885a3c6abaa0e64b2fe846
c3c3b3ahttps://github.com/plotly/plotly.js/pull/1690/commits/c3c3b3ab331fc96769885a3c6abaa0e64b2fe846
https://github.com/etpinard
replace gd._tester with drawing._testerhttps://github.com/plotly/plotly.js/pull/1690/commits/a8fba0336791e92956f8a0da6708ed0ab89329b0
a8fba03https://github.com/plotly/plotly.js/pull/1690/commits/a8fba0336791e92956f8a0da6708ed0ab89329b0
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#issuecomment-301876973
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
https://github.com/etpinard
etpinardhttps://github.com/etpinard
66259edhttps://github.com/plotly/plotly.js/commit/66259edd09fffcfea9d303909d8b56bd70bcb054
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#event-1084707513
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 16, 2017 18:44https://github.com/plotly/plotly.js/pull/1690#event-1084707574
https://github.com/hy9be
hy9behttps://github.com/hy9be
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#issuecomment-301903782
@etpinardhttps://github.com/etpinard
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 16, 2017https://github.com/plotly/plotly.js/pull/1690#issuecomment-301904231
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
@hy9behttps://github.com/hy9be
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1690
https://github.com/alexcjohnson
alexcjohnson https://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/1690/files/273a4c37701241d6224a9c4c7fa3c9f84444f66f
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1690
https://github.com/etpinard
https://github.com/alexcjohnson
https://github.com/hy9be
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.