René's URL Explorer Experiment


Title: Drawing bbox fix for window scroll by etpinard · Pull Request #1683 · plotly/plotly.js · GitHub

Open Graph Title: Drawing bbox fix for window scroll by etpinard · Pull Request #1683 · plotly/plotly.js

X Title: Drawing bbox fix for window scroll by etpinard · Pull Request #1683 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Drawing bbox fix for window scroll by etpinard · Pull Request #1683 · plotly/plotly.js

Open Graph Description: fixes #1678 I decide to play it safe an revert 29abb5d until we 🔒 the Drawing.bBox behavior better. Reverting 29abb5d also fixes #1675, but maybe we could do better there. cc @alexcjohnson

X Description: fixes #1678 I decide to play it safe an revert 29abb5d until we 🔒 the Drawing.bBox behavior better. Reverting 29abb5d also fixes #1675, but maybe we could do better there. cc @alexcjohnson

Opengraph URL: https://github.com/plotly/plotly.js/pull/1683

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1b49fda8-9817-f860-a814-9e4162d1a00a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA672:53774:ACC771:E8A28D:6A5CE83F
html-safe-nonce9451e7ec37a299456f77f16d0a6fce79e98eff79955c96a2ec2f7bf7c456187a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjcyOjUzNzc0OkFDQzc3MTpFOEEyOEQ6NkE1Q0U4M0YiLCJ2aXNpdG9yX2lkIjoiNTY3MzYwOTg0NjU1OTkyNjMzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaef92e0effa91cfd9d06fe53aa2a0e80367d498560dc0502181db5ef1bfbbc74
hovercard-subject-tagpull_request:120400119
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/1683/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/60f5c4dfe8979b7020c6460bdb073cb9731ceab117c84da93632e55cbc071536/plotly/plotly.js/pull/1683
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/60f5c4dfe8979b7020c6460bdb073cb9731ceab117c84da93632e55cbc071536/plotly/plotly.js/pull/1683
og:image:altfixes #1678 I decide to play it safe an revert 29abb5d until we 🔒 the Drawing.bBox behavior better. Reverting 29abb5d also fixes #1675, but maybe we could do better there. cc @alexcjohnson
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameetpinard
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/1683#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1683
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1683
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/1683
Reloadhttps://github.com/plotly/plotly.js/pull/1683
Reloadhttps://github.com/plotly/plotly.js/pull/1683
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1683
plotly https://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1683
Notifications https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Fork 2k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Star 18.3k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Code https://github.com/plotly/plotly.js
Issues 773 https://github.com/plotly/plotly.js/issues
Pull requests 59 https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality 0 https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
Code https://github.com/plotly/plotly.js
Issues https://github.com/plotly/plotly.js/issues
Pull requests https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
annotation-text-position-fixhttps://github.com/plotly/plotly.js/tree/annotation-text-position-fix
Conversationhttps://github.com/plotly/plotly.js/pull/1683
Commits9 (9)https://github.com/plotly/plotly.js/pull/1683/commits
Checkshttps://github.com/plotly/plotly.js/pull/1683/checks
Files changedhttps://github.com/plotly/plotly.js/pull/1683/files
Drawing bbox fix for window scrollhttps://github.com/plotly/plotly.js/pull/1683#top
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
annotation-text-position-fixhttps://github.com/plotly/plotly.js/tree/annotation-text-position-fix
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 12, 2017https://github.com/plotly/plotly.js/pull/1683#issue-228399621
#1678https://github.com/plotly/plotly.js/issues/1678
29abb5dhttps://github.com/plotly/plotly.js/commit/29abb5d8ec3dea92cc71f438fffa6785463d1fb1
29abb5dhttps://github.com/plotly/plotly.js/commit/29abb5d8ec3dea92cc71f438fffa6785463d1fb1
#1675https://github.com/plotly/plotly.js/issues/1675
@alexcjohnsonhttps://github.com/alexcjohnson
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1683
etpinardhttps://github.com/etpinard
May 12, 2017 15:03https://github.com/plotly/plotly.js/pull/1683#commits-pushed-83b3d64
https://github.com/etpinard
Revert "Cache DOM nodes and selected d3 node"https://github.com/plotly/plotly.js/pull/1683/commits/83b3d6493f519616f4d035308a5413853adf81d9
83b3d64https://github.com/plotly/plotly.js/pull/1683/commits/83b3d6493f519616f4d035308a5413853adf81d9
29abb5dhttps://github.com/plotly/plotly.js/commit/29abb5d8ec3dea92cc71f438fffa6785463d1fb1
https://github.com/etpinard
add drawing bb testhttps://github.com/plotly/plotly.js/pull/1683/commits/9af534ab5650462448003bb205d6aa6a3564bac1
9af534ahttps://github.com/plotly/plotly.js/pull/1683/commits/9af534ab5650462448003bb205d6aa6a3564bac1
#1678https://github.com/plotly/plotly.js/issues/1678
https://github.com/etpinard
etpinardhttps://github.com/etpinard
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
May 12, 2017https://github.com/plotly/plotly.js/pull/1683#event-1080611320
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 12, 2017 https://github.com/plotly/plotly.js/pull/1683#pullrequestreview-37937032
View reviewed changes https://github.com/plotly/plotly.js/pull/1683/files/9af534ab5650462448003bb205d6aa6a3564bac1
test/jasmine/tests/drawing_test.jshttps://github.com/plotly/plotly.js/pull/1683/files/9af534ab5650462448003bb205d6aa6a3564bac1#diff-b35e9984fc04f614f610d6d028c218ad4e82bf6274fcbab33d9c909909e8d0fc
etpinardhttps://github.com/etpinard
May 12, 2017https://github.com/plotly/plotly.js/pull/1683#discussion_r116318133
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
29abb5dhttps://github.com/plotly/plotly.js/commit/29abb5d8ec3dea92cc71f438fffa6785463d1fb1
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1683
etpinardhttps://github.com/etpinard
May 12, 2017https://github.com/plotly/plotly.js/pull/1683#discussion_r116318427
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1683
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1683
etpinardhttps://github.com/etpinard
May 12, 2017https://github.com/plotly/plotly.js/pull/1683#discussion_r116320020
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://cloud.githubusercontent.com/assets/6675409/26016047/756b9344-3731-11e7-8622-dbd625125b13.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1683
etpinardhttps://github.com/etpinard
May 15, 2017https://github.com/plotly/plotly.js/pull/1683#discussion_r116603565
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
3fdb308https://github.com/plotly/plotly.js/commit/3fdb3081ad2c8231145a57443cf381b6eac14688
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1683
etpinardhttps://github.com/etpinard
May 15, 2017 17:04https://github.com/plotly/plotly.js/pull/1683#commits-pushed-3fdb308
https://github.com/etpinard
make bbox test more robusthttps://github.com/plotly/plotly.js/pull/1683/commits/3fdb3081ad2c8231145a57443cf381b6eac14688
3fdb308https://github.com/plotly/plotly.js/pull/1683/commits/3fdb3081ad2c8231145a57443cf381b6eac14688
https://github.com/etpinard
cache ref to tester div and tester ref on drawing module objecthttps://github.com/plotly/plotly.js/pull/1683/commits/0c62890b6f04e87201c921581d9c9d8abc193f2e
0c62890https://github.com/plotly/plotly.js/pull/1683/commits/0c62890b6f04e87201c921581d9c9d8abc193f2e
https://github.com/etpinard
cache DOMParser instance on svg utils module objecthttps://github.com/plotly/plotly.js/pull/1683/commits/273a4c37701241d6224a9c4c7fa3c9f84444f66f
273a4c3https://github.com/plotly/plotly.js/pull/1683/commits/273a4c37701241d6224a9c4c7fa3c9f84444f66f
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 15, 2017 https://github.com/plotly/plotly.js/pull/1683#ref-pullrequest-228852953
Drawing perf take2 #1690 https://github.com/plotly/plotly.js/pull/1690
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
May 16, 2017 https://github.com/plotly/plotly.js/pull/1683#pullrequestreview-38264240
View reviewed changes https://github.com/plotly/plotly.js/pull/1683/files/3fdb3081ad2c8231145a57443cf381b6eac14688
src/components/drawing/index.jshttps://github.com/plotly/plotly.js/pull/1683/files/3fdb3081ad2c8231145a57443cf381b6eac14688#diff-e8c93e83ebf0c3a486f3187d44d91b1709f51bccaba559fcadab2a3e3f9f56c6
alexcjohnsonhttps://github.com/alexcjohnson
May 16, 2017https://github.com/plotly/plotly.js/pull/1683#discussion_r116628896
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#1585https://github.com/plotly/plotly.js/pull/1585
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1683
etpinardhttps://github.com/etpinard
May 16, 2017https://github.com/plotly/plotly.js/pull/1683#discussion_r116746692
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#1690https://github.com/plotly/plotly.js/pull/1690
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1683
etpinardhttps://github.com/etpinard
May 16, 2017 12:12https://github.com/plotly/plotly.js/pull/1683#commits-pushed-e0050f7
https://github.com/etpinard
don't expose DOMParser instance on svg utils module objecthttps://github.com/plotly/plotly.js/pull/1683/commits/e0050f73c57c54755a6131584b152151bf0c7c06
e0050f7https://github.com/plotly/plotly.js/pull/1683/commits/e0050f73c57c54755a6131584b152151bf0c7c06
https://github.com/etpinard
🔪 gd._testref (wasn't used anywhere)https://github.com/plotly/plotly.js/pull/1683/commits/c3c3b3ab331fc96769885a3c6abaa0e64b2fe846
c3c3b3ahttps://github.com/plotly/plotly.js/pull/1683/commits/c3c3b3ab331fc96769885a3c6abaa0e64b2fe846
https://github.com/etpinard
replace gd._tester with drawing._testerhttps://github.com/plotly/plotly.js/pull/1683/commits/a8fba0336791e92956f8a0da6708ed0ab89329b0
a8fba03https://github.com/plotly/plotly.js/pull/1683/commits/a8fba0336791e92956f8a0da6708ed0ab89329b0
https://github.com/etpinard
Merge pull requesthttps://github.com/plotly/plotly.js/pull/1683/commits/66259edd09fffcfea9d303909d8b56bd70bcb054
#1690https://github.com/plotly/plotly.js/pull/1690
from plotly/drawing-perf-take2https://github.com/plotly/plotly.js/pull/1683/commits/66259edd09fffcfea9d303909d8b56bd70bcb054
66259edhttps://github.com/plotly/plotly.js/pull/1683/commits/66259edd09fffcfea9d303909d8b56bd70bcb054
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
May 16, 2017https://github.com/plotly/plotly.js/pull/1683#issuecomment-301877505
#1690https://github.com/plotly/plotly.js/pull/1690
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1683
https://github.com/etpinard
etpinardhttps://github.com/etpinard
2e0cca1https://github.com/plotly/plotly.js/commit/2e0cca1eef274407eacb2ffe5e313308032870b4
May 16, 2017https://github.com/plotly/plotly.js/pull/1683#event-1084756019
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 16, 2017 19:15https://github.com/plotly/plotly.js/pull/1683#event-1084756081
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 24, 2017 https://github.com/plotly/plotly.js/pull/1683#ref-pullrequest-225197515
Introducing 3D annotations #1638 https://github.com/plotly/plotly.js/pull/1638
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1683
https://github.com/alexcjohnson
alexcjohnson https://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/1683/files/3fdb3081ad2c8231145a57443cf381b6eac14688
bug https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug
Annotation text not getting placed correctly on relayout when page is scrolled https://github.com/plotly/plotly.js/issues/1678
No longer possible to run tests for components which import plotly without a browser https://github.com/plotly/plotly.js/issues/1675
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1683
https://github.com/etpinard
https://github.com/alexcjohnson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.