| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cf4228f8-fc2c-0e00-4832-11877a5a6968 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 92C2:2F6413:8FE17BF:C1DF8B1:6A5E5DA4 |
| html-safe-nonce | f6b1da7344f7b7d30ffe8c06356b9ff09f256953ae11a59e33374f76c5651ed2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkMyOjJGNjQxMzo4RkUxN0JGOkMxREY4QjE6NkE1RTVEQTQiLCJ2aXNpdG9yX2lkIjoiNjYxNDI0Nzg5ODE2MjgxNDM3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | f0146302b677081ac9ff2c5c22d1fe7ae6a69228bc84c47bd830ba6940d54e93 |
| hovercard-subject-tag | pull_request:118238094 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/1638/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4c582d883c31ce3bef3a172ba717dcf4d93110e12e60e583e8b9ac1148a7d4ed/plotly/plotly.js/pull/1638 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4c582d883c31ce3bef3a172ba717dcf4d93110e12e60e583e8b9ac1148a7d4ed/plotly/plotly.js/pull/1638 |
| og:image:alt | resolves #751 and more precisely implements #751 (comment).
This PR is still a very much WIP. Here are some TODOs:
get the autorange logic hooked in
get this to work with category axes types
r... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | etpinard |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4c92a536c69af79290536ba65c054743bf2747e6bf7150d78fe0e566af9ac459 |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b8eaa813b53afacb4b93991504272e5396731873 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/1638#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1638 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1638 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/1638 |
| Reload | https://github.com/plotly/plotly.js/pull/1638 |
| Reload | https://github.com/plotly/plotly.js/pull/1638 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
773
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
58
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| gl3d-annotations | https://github.com/plotly/plotly.js/tree/gl3d-annotations |
| Conversation | https://github.com/plotly/plotly.js/pull/1638 |
| Commits29 (29) | https://github.com/plotly/plotly.js/pull/1638/commits |
| Checks | https://github.com/plotly/plotly.js/pull/1638/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/1638/files |
| Introducing 3D annotations | https://github.com/plotly/plotly.js/pull/1638#top |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| gl3d-annotations | https://github.com/plotly/plotly.js/tree/gl3d-annotations |
|
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Apr 28, 2017 | https://github.com/plotly/plotly.js/pull/1638#issue-225197515 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| #751 | https://github.com/plotly/plotly.js/issues/751 |
| #751 (comment) | https://github.com/plotly/plotly.js/issues/751#issuecomment-277280113 |
| https://cloud.githubusercontent.com/assets/6675409/25547971/451f9072-2c38-11e7-9f0f-4e0c347ba2a4.gif |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| etpinard | https://github.com/etpinard |
| April 28, 2017 17:08 | https://github.com/plotly/plotly.js/pull/1638#commits-pushed-aa58118 |
|
| https://github.com/etpinard |
| replace forEach with for-loop over ['x', 'y'] | https://github.com/plotly/plotly.js/pull/1638/commits/aa58118e3665dd60d3fdda689ae58cf1814f99c2 |
| aa58118 | https://github.com/plotly/plotly.js/pull/1638/commits/aa58118e3665dd60d3fdda689ae58cf1814f99c2 |
|
| https://github.com/etpinard |
| don't (uselessly) add data-index to ann text+bg & arrow groups | https://github.com/plotly/plotly.js/pull/1638/commits/8b8bdeae0c359d0958477b57012b84ea4651aaad |
| 8b8bdea | https://github.com/plotly/plotly.js/pull/1638/commits/8b8bdeae0c359d0958477b57012b84ea4651aaad |
|
| https://github.com/etpinard |
| don't (uselessly) add annotation class to ann text group inner | https://github.com/plotly/plotly.js/pull/1638/commits/1a8f1ed1e855fb9157f728c191b00784fe3f1258 |
| 1a8f1ed | https://github.com/plotly/plotly.js/pull/1638/commits/1a8f1ed1e855fb9157f728c191b00784fe3f1258 |
|
| https://github.com/etpinard |
| fine tune annotation arrow selector | https://github.com/plotly/plotly.js/pull/1638/commits/f4b14e686c30daf011cf82a675042979dcc4c213 |
| f4b14e6 | https://github.com/plotly/plotly.js/pull/1638/commits/f4b14e686c30daf011cf82a675042979dcc4c213 |
|
| https://github.com/etpinard |
| use ax.?2? while composing convert methods | https://github.com/plotly/plotly.js/pull/1638/commits/4dc16e4cb5e1d5f37f267c170c37e2f506a65bbf |
| 4dc16e4 | https://github.com/plotly/plotly.js/pull/1638/commits/4dc16e4cb5e1d5f37f267c170c37e2f506a65bbf |
|
| https://github.com/etpinard |
| split annotation drawOne into drawRaw | https://github.com/plotly/plotly.js/pull/1638/commits/8e6ab7d051ce8d163639d312524248aa2a2a2d2d |
| 8e6ab7d | https://github.com/plotly/plotly.js/pull/1638/commits/8e6ab7d051ce8d163639d312524248aa2a2a2d2d |
|
| https://github.com/etpinard |
| introduce 3D annotations | https://github.com/plotly/plotly.js/pull/1638/commits/c5f6eb2b7973bd558f12bede16f2936ca15aa1cd |
| c5f6eb2 | https://github.com/plotly/plotly.js/pull/1638/commits/c5f6eb2b7973bd558f12bede16f2936ca15aa1cd |
|
| https://github.com/etpinard |
| don't try to edit x,y,z positions for 3D annotations | https://github.com/plotly/plotly.js/pull/1638/commits/b7ab656d697a2c03b2ab0fee27fcee533496d524 |
| b7ab656 | https://github.com/plotly/plotly.js/pull/1638/commits/b7ab656d697a2c03b2ab0fee27fcee533496d524 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
status: in progress
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
| Apr 28, 2017 | https://github.com/plotly/plotly.js/pull/1638#event-1062838478 |
| etpinard | https://github.com/etpinard |
| May 9, 2017 10:40 | https://github.com/plotly/plotly.js/pull/1638#commits-pushed-fbdcee8 |
|
| https://github.com/etpinard |
| Merge branch 'master' into gl3d-annotations | https://github.com/plotly/plotly.js/pull/1638/commits/fbdcee8c8fa86b96ef6a33290c178f5c1e26dd58 |
| fbdcee8 | https://github.com/plotly/plotly.js/pull/1638/commits/fbdcee8c8fa86b96ef6a33290c178f5c1e26dd58 |
|
| https://github.com/etpinard |
| Merge branch 'master' into gl3d-annotations | https://github.com/plotly/plotly.js/pull/1638/commits/981b1a1ef41a016cddc254cd13d61d10c5d253ae |
| 981b1a1 | https://github.com/plotly/plotly.js/pull/1638/commits/981b1a1ef41a016cddc254cd13d61d10c5d253ae |
|
| https://github.com/etpinard |
| rename anchor -> anchor3 so that it doesn't conflict w/ for-loop block | https://github.com/plotly/plotly.js/pull/1638/commits/94b940d96e70016b7203a62b2ac062de1909c79e |
| 94b940d | https://github.com/plotly/plotly.js/pull/1638/commits/94b940d96e70016b7203a62b2ac062de1909c79e |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| 1.28.0 | https://github.com/plotly/plotly.js/milestone/22 |
| May 18, 2017 | https://github.com/plotly/plotly.js/pull/1638#event-1087978819 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
May 19, 2017
| https://github.com/plotly/plotly.js/pull/1638#ref-issue-229941199 |
|
No shape and no marker 'cross-thin' on scattergeo plot
#1707
| https://github.com/plotly/plotly.js/issues/1707 |
| etpinard | https://github.com/etpinard |
| May 24, 2017 09:47 | https://github.com/plotly/plotly.js/pull/1638#commits-pushed-8ac2551 |
|
| https://github.com/etpinard |
| Merge branch 'master' into gl3d-annotations | https://github.com/plotly/plotly.js/pull/1638/commits/8ac2551f71e7efa2fee9a478725a73321942ee65 |
| 8ac2551 | https://github.com/plotly/plotly.js/pull/1638/commits/8ac2551f71e7efa2fee9a478725a73321942ee65 |
|
| https://github.com/etpinard |
| Revert "don't (uselessly) add annotation class to ann text group inner" | https://github.com/plotly/plotly.js/pull/1638/commits/ababc49990ea8e6be7e07a5f85ec366e54a1d70d |
| ababc49 | https://github.com/plotly/plotly.js/pull/1638/commits/ababc49990ea8e6be7e07a5f85ec366e54a1d70d |
| 1a8f1ed | https://github.com/plotly/plotly.js/commit/1a8f1ed1e855fb9157f728c191b00784fe3f1258 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
May 24, 2017
| https://github.com/plotly/plotly.js/pull/1638#pullrequestreview-40044642 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1638/files/1a8f1ed1e855fb9157f728c191b00784fe3f1258 |
| src/components/annotations/draw.js | https://github.com/plotly/plotly.js/pull/1638/files/8b8bdeae0c359d0958477b57012b84ea4651aaad..1a8f1ed1e855fb9157f728c191b00784fe3f1258#diff-f818f18714f996d292004b717d41debd5e0c325acb6e2e208192f0b00ed0c2cf |
| etpinard | https://github.com/etpinard |
| May 24, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118269612 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| ababc49 | https://github.com/plotly/plotly.js/commit/ababc49990ea8e6be7e07a5f85ec366e54a1d70d |
| #1683 | https://github.com/plotly/plotly.js/pull/1683 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| alexcjohnson | https://github.com/alexcjohnson |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118564399 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| ababc49 | https://github.com/plotly/plotly.js/commit/ababc49990ea8e6be7e07a5f85ec366e54a1d70d |
| #1683 | https://github.com/plotly/plotly.js/pull/1683 |
| a31549d | https://github.com/plotly/plotly.js/commit/a31549d3b7532c48200289607ab435e4e80d891f |
| ababc49 | https://github.com/plotly/plotly.js/commit/ababc49990ea8e6be7e07a5f85ec366e54a1d70d |
| 1a8f1ed | https://github.com/plotly/plotly.js/commit/1a8f1ed1e855fb9157f728c191b00784fe3f1258 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| etpinard | https://github.com/etpinard |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118564958 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| a31549d | https://github.com/plotly/plotly.js/commit/a31549d3b7532c48200289607ab435e4e80d891f |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| etpinard | https://github.com/etpinard |
| May 24, 2017 19:19 | https://github.com/plotly/plotly.js/pull/1638#commits-pushed-7cfba36 |
|
| https://github.com/etpinard |
| fix 3d annotations on type: 'category' axes | https://github.com/plotly/plotly.js/pull/1638/commits/7cfba365f9ffe8011e7eaddb5253c60bdaffd230 |
| 7cfba36 | https://github.com/plotly/plotly.js/pull/1638/commits/7cfba365f9ffe8011e7eaddb5253c60bdaffd230 |
|
| https://github.com/etpinard |
| make sure to clear 3d annotations when parent scene gets removed | https://github.com/plotly/plotly.js/pull/1638/commits/8f9e3703dcb17301c3bf6843420064e8235d9398 |
| 8f9e370 | https://github.com/plotly/plotly.js/pull/1638/commits/8f9e3703dcb17301c3bf6843420064e8235d9398 |
|
| https://github.com/etpinard |
| implement autorange logic for annotations | https://github.com/plotly/plotly.js/pull/1638/commits/1bbabad04c1ebe3d3896247ce03c0d116cddd4a7 |
| 1bbabad | https://github.com/plotly/plotly.js/pull/1638/commits/1bbabad04c1ebe3d3896247ce03c0d116cddd4a7 |
|
| https://github.com/etpinard |
| first pass 3d annotations jasmine tests | https://github.com/plotly/plotly.js/pull/1638/commits/952094317a6544d4ccf62b3c6a230ce6f9af71d7 |
| 9520943 | https://github.com/plotly/plotly.js/pull/1638/commits/952094317a6544d4ccf62b3c6a230ce6f9af71d7 |
|
| https://github.com/etpinard |
| first pass 3d annotation image test support | https://github.com/plotly/plotly.js/pull/1638/commits/f61cd4dc99b91247e409bcad64cf79558f265a23 |
| f61cd4d | https://github.com/plotly/plotly.js/pull/1638/commits/f61cd4dc99b91247e409bcad64cf79558f265a23 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| May 24, 2017 | https://github.com/plotly/plotly.js/pull/1638#issuecomment-303880293 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
|
status: in progress
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22 |
| May 24, 2017 | https://github.com/plotly/plotly.js/pull/1638#event-1096513353 |
| etpinard | https://github.com/etpinard |
| May 25, 2017 10:48 | https://github.com/plotly/plotly.js/pull/1638#commits-pushed-8cb10c1 |
|
| https://github.com/etpinard |
| try to make test that update the scene camera more robust | https://github.com/plotly/plotly.js/pull/1638/commits/8cb10c16c308fed5c3c2b4141c791ccc2b7358e3 |
| 8cb10c1 | https://github.com/plotly/plotly.js/pull/1638/commits/8cb10c16c308fed5c3c2b4141c791ccc2b7358e3 |
|
| https://github.com/etpinard |
| replace 'annotation' class for 'annotation-text' for annation text nodes | https://github.com/plotly/plotly.js/pull/1638/commits/a31549d3b7532c48200289607ab435e4e80d891f |
| a31549d | https://github.com/plotly/plotly.js/pull/1638/commits/a31549d3b7532c48200289607ab435e4e80d891f |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
May 25, 2017
| https://github.com/plotly/plotly.js/pull/1638#pullrequestreview-40366291 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f |
| src/plots/gl3d/scene.js | https://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f#diff-2392186e2cc7368a027c29bfe4e6df7a0e910a57b0c6285f5809c64ee301f54a |
| alexcjohnson | https://github.com/alexcjohnson |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118561697 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| alexcjohnson | https://github.com/alexcjohnson |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118567806 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| etpinard | https://github.com/etpinard |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118573245 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#issuecomment-304097628 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
May 25, 2017
| https://github.com/plotly/plotly.js/pull/1638#pullrequestreview-40370687 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f |
| src/components/annotations/draw.js | https://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f#diff-f818f18714f996d292004b717d41debd5e0c325acb6e2e208192f0b00ed0c2cf |
| alexcjohnson | https://github.com/alexcjohnson |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118565726 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| etpinard | https://github.com/etpinard |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118573015 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| c084da0 | https://github.com/plotly/plotly.js/commit/c084da0e2282c6ea2e680e4e01dfcbbe910a949f |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
May 25, 2017
| https://github.com/plotly/plotly.js/pull/1638#pullrequestreview-40373732 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f |
| src/plots/gl3d/layout/layout_attributes.js | https://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f#diff-a8a6ec637f76c92dca699f90dba9c85c2c5c74dfec1adc48089326d879f367b4 |
| alexcjohnson | https://github.com/alexcjohnson |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118568490 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| etpinard | https://github.com/etpinard |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118573145 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| adfc305 | https://github.com/plotly/plotly.js/commit/adfc305a0918c4afcb8b17b737e281517ec09613 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
May 25, 2017
| https://github.com/plotly/plotly.js/pull/1638#pullrequestreview-40376226 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f |
| src/components/annotations/draw.js | https://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f#diff-f818f18714f996d292004b717d41debd5e0c325acb6e2e208192f0b00ed0c2cf |
| alexcjohnson | https://github.com/alexcjohnson |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118570661 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| etpinard | https://github.com/etpinard |
| May 25, 2017 16:01 | https://github.com/plotly/plotly.js/pull/1638#commits-pushed-bd9c867 |
|
| https://github.com/etpinard |
| mv 3d annotations code out of plots/gl3d into component/annotations3d | https://github.com/plotly/plotly.js/pull/1638/commits/bd9c867cd6b4cd985dcdd8f3ab3e4ea02376f325 |
| bd9c867 | https://github.com/plotly/plotly.js/pull/1638/commits/bd9c867cd6b4cd985dcdd8f3ab3e4ea02376f325 |
|
| https://github.com/etpinard |
| add common annotations defaults modules | https://github.com/plotly/plotly.js/pull/1638/commits/21c8cc6041a7e30368bda531446c2a49f88a916c |
| 21c8cc6 | https://github.com/plotly/plotly.js/pull/1638/commits/21c8cc6041a7e30368bda531446c2a49f88a916c |
|
| https://github.com/etpinard |
| declare ax and ay as valType: number for annotation3d | https://github.com/plotly/plotly.js/pull/1638/commits/adfc305a0918c4afcb8b17b737e281517ec09613 |
| adfc305 | https://github.com/plotly/plotly.js/pull/1638/commits/adfc305a0918c4afcb8b17b737e281517ec09613 |
|
| https://github.com/etpinard |
| rename _scene ref to scene id in annotation container _sceneId | https://github.com/plotly/plotly.js/pull/1638/commits/c084da0e2282c6ea2e680e4e01dfcbbe910a949f |
| c084da0 | https://github.com/plotly/plotly.js/pull/1638/commits/c084da0e2282c6ea2e680e4e01dfcbbe910a949f |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| force-pushed | https://github.com/plotly/plotly.js/compare/21a5a0e6100c77aa523e9884c508e1c3ae655acb..876b37b38007dc76c5e8211e104d553e14e373e1 |
| 21a5a0e | https://github.com/plotly/plotly.js/commit/21a5a0e6100c77aa523e9884c508e1c3ae655acb |
| 876b37b | https://github.com/plotly/plotly.js/commit/876b37b38007dc76c5e8211e104d553e14e373e1 |
|
Compare
| https://github.com/plotly/plotly.js/compare/21a5a0e6100c77aa523e9884c508e1c3ae655acb..876b37b38007dc76c5e8211e104d553e14e373e1 |
| May 25, 2017 20:26 | https://github.com/plotly/plotly.js/pull/1638#event-1097944383 |
|
| https://github.com/etpinard |
| put 'captureevents' under common annotation defaults | https://github.com/plotly/plotly.js/pull/1638/commits/ef985cfd5f94181a0defd5c91978b618d73a5a76 |
| ef985cf | https://github.com/plotly/plotly.js/pull/1638/commits/ef985cfd5f94181a0defd5c91978b618d73a5a76 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| force-pushed | https://github.com/plotly/plotly.js/compare/876b37b38007dc76c5e8211e104d553e14e373e1..ef985cfd5f94181a0defd5c91978b618d73a5a76 |
| 876b37b | https://github.com/plotly/plotly.js/commit/876b37b38007dc76c5e8211e104d553e14e373e1 |
| ef985cf | https://github.com/plotly/plotly.js/commit/ef985cfd5f94181a0defd5c91978b618d73a5a76 |
|
Compare
| https://github.com/plotly/plotly.js/compare/876b37b38007dc76c5e8211e104d553e14e373e1..ef985cfd5f94181a0defd5c91978b618d73a5a76 |
| May 25, 2017 20:30 | https://github.com/plotly/plotly.js/pull/1638#event-1097949570 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
May 25, 2017
| https://github.com/plotly/plotly.js/pull/1638#pullrequestreview-40386072 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1638/files/ef985cfd5f94181a0defd5c91978b618d73a5a76 |
| src/components/annotations3d/attributes.js | https://github.com/plotly/plotly.js/pull/1638/files/c084da0e2282c6ea2e680e4e01dfcbbe910a949f..ef985cfd5f94181a0defd5c91978b618d73a5a76#diff-10842e0a75bd119a19e132f24b925185c614512653d01f2f13798f32929692f0 |
| etpinard | https://github.com/etpinard |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118579244 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://cloud.githubusercontent.com/assets/6675409/26469595/94a5809e-4168-11e7-8ada-349db5396d5e.gif |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| alexcjohnson | https://github.com/alexcjohnson |
| May 25, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118593734 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| etpinard | https://github.com/etpinard |
| May 26, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118719442 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 8b8a088 | https://github.com/plotly/plotly.js/commit/8b8a088b8e0e9e8f48b5d9c036398c8e1ba7976a |
| 1d5606a | https://github.com/plotly/plotly.js/commit/1d5606a8ff4bed24b9ba5e43de162f62d026b2d6 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| etpinard | https://github.com/etpinard |
| May 26, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118724628 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 1d5606a | https://github.com/plotly/plotly.js/commit/1d5606a8ff4bed24b9ba5e43de162f62d026b2d6 |
| this | https://github.com/plotly/plotly.js/blob/78b82b85206bde93c7117706278ac698b480139d/test/jasmine/tests/annotations_test.js#L1202 |
| that | https://github.com/plotly/plotly.js/blob/78b82b85206bde93c7117706278ac698b480139d/test/jasmine/tests/annotations_test.js#L1226 |
| @alexcjohnson | https://github.com/alexcjohnson |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| alexcjohnson | https://github.com/alexcjohnson |
| May 26, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118726170 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| my comment | https://github.com/plotly/plotly.js/pull/1638#commitcomment-22295724 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| etpinard | https://github.com/etpinard |
| May 26, 2017 | https://github.com/plotly/plotly.js/pull/1638#discussion_r118728335 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 46ab63d | https://github.com/plotly/plotly.js/commit/46ab63dcf3fa3128957d60e0b592a316150e1823 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| etpinard | https://github.com/etpinard |
| May 25, 2017 17:28 | https://github.com/plotly/plotly.js/pull/1638#commits-pushed-0b4214f |
|
| https://github.com/etpinard |
| Merge branch 'master' into gl3d-annotations | https://github.com/plotly/plotly.js/pull/1638/commits/0b4214f3383b50149c3838e4b8d8b5a2dfff01b1 |
| 0b4214f | https://github.com/plotly/plotly.js/pull/1638/commits/0b4214f3383b50149c3838e4b8d8b5a2dfff01b1 |
|
| https://github.com/etpinard |
| pass subplotId as arg to Annotations.drawRaw | https://github.com/plotly/plotly.js/pull/1638/commits/8b8a088b8e0e9e8f48b5d9c036398c8e1ba7976a |
| 8b8a088 | https://github.com/plotly/plotly.js/pull/1638/commits/8b8a088b8e0e9e8f48b5d9c036398c8e1ba7976a |
|
| https://github.com/etpinard |
| include subplotId in clickannotation event data | https://github.com/plotly/plotly.js/pull/1638/commits/1d5606a8ff4bed24b9ba5e43de162f62d026b2d6 |
|
| https://github.com/plotly/plotly.js/commit/1d5606a8ff4bed24b9ba5e43de162f62d026b2d6#comments |
| 1d5606a | https://github.com/plotly/plotly.js/pull/1638/commits/1d5606a8ff4bed24b9ba5e43de162f62d026b2d6 |
|
| https://github.com/etpinard |
| rm subplotId key from clickannotations event data when falsy | https://github.com/plotly/plotly.js/pull/1638/commits/46ab63dcf3fa3128957d60e0b592a316150e1823 |
| 46ab63d | https://github.com/plotly/plotly.js/pull/1638/commits/46ab63dcf3fa3128957d60e0b592a316150e1823 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| May 26, 2017 | https://github.com/plotly/plotly.js/pull/1638#issuecomment-304323899 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| 6b7c9d7 | https://github.com/plotly/plotly.js/commit/6b7c9d7aeba575c3ff5a35a03e111c051e001ed7 |
| May 26, 2017 | https://github.com/plotly/plotly.js/pull/1638#event-1099191416 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| May 26, 2017 16:14 | https://github.com/plotly/plotly.js/pull/1638#event-1099191518 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Jun 14, 2017
| https://github.com/plotly/plotly.js/pull/1638#ref-pullrequest-235915665 |
|
hide off-plot annotations
#1786
| https://github.com/plotly/plotly.js/pull/1786 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Feb 20, 2020
| https://github.com/plotly/plotly.js/pull/1638#ref-issue-568005348 |
|
anchor shapes to map axes
#4594
| https://github.com/plotly/plotly.js/issues/4594 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1638 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/1638/files/ef985cfd5f94181a0defd5c91978b618d73a5a76 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
|
1.28.0
| https://github.com/plotly/plotly.js/milestone/22 |
|
Data-referenced annotations on 3D graphs
| https://github.com/plotly/plotly.js/issues/751 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1638 |
|
| https://github.com/etpinard |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |