René's URL Explorer Experiment


Title: Introducing 3D annotations by etpinard · Pull Request #1638 · plotly/plotly.js · GitHub

Open Graph Title: Introducing 3D annotations by etpinard · Pull Request #1638 · plotly/plotly.js

X Title: Introducing 3D annotations by etpinard · Pull Request #1638 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Introducing 3D annotations by etpinard · Pull Request #1638 · plotly/plotly.js

Open Graph Description: resolves #751 and more precisely implements #751 (comment). This PR is still a very much WIP. Here are some TODOs: get the autorange logic hooked in get this to work with category axes types r...

X Description: resolves #751 and more precisely implements #751 (comment). This PR is still a very much WIP. Here are some TODOs: get the autorange logic hooked in get this to work with category axes types r...

Opengraph URL: https://github.com/plotly/plotly.js/pull/1638

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:cf4228f8-fc2c-0e00-4832-11877a5a6968
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id92C2:2F6413:8FE17BF:C1DF8B1:6A5E5DA4
html-safe-noncef6b1da7344f7b7d30ffe8c06356b9ff09f256953ae11a59e33374f76c5651ed2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkMyOjJGNjQxMzo4RkUxN0JGOkMxREY4QjE6NkE1RTVEQTQiLCJ2aXNpdG9yX2lkIjoiNjYxNDI0Nzg5ODE2MjgxNDM3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf0146302b677081ac9ff2c5c22d1fe7ae6a69228bc84c47bd830ba6940d54e93
hovercard-subject-tagpull_request:118238094
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/1638/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4c582d883c31ce3bef3a172ba717dcf4d93110e12e60e583e8b9ac1148a7d4ed/plotly/plotly.js/pull/1638
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c582d883c31ce3bef3a172ba717dcf4d93110e12e60e583e8b9ac1148a7d4ed/plotly/plotly.js/pull/1638
og:image:altresolves #751 and more precisely implements #751 (comment). This PR is still a very much WIP. Here are some TODOs: get the autorange logic hooked in get this to work with category axes types r...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameetpinard
hostnamegithub.com
expected-hostnamegithub.com
None4c92a536c69af79290536ba65c054743bf2747e6bf7150d78fe0e566af9ac459
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseb8eaa813b53afacb4b93991504272e5396731873
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/1638#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1638
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
Code QualityEnforce quality at mergehttps://github.com/features/code-quality
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1638
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/1638
Reloadhttps://github.com/plotly/plotly.js/pull/1638
Reloadhttps://github.com/plotly/plotly.js/pull/1638
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
plotly https://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
Notifications https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Fork 2k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Star 18.3k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Code https://github.com/plotly/plotly.js
Issues 773 https://github.com/plotly/plotly.js/issues
Pull requests 58 https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality 0 https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
Code https://github.com/plotly/plotly.js
Issues https://github.com/plotly/plotly.js/issues
Pull requests https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
gl3d-annotationshttps://github.com/plotly/plotly.js/tree/gl3d-annotations
Conversationhttps://github.com/plotly/plotly.js/pull/1638
Commits29 (29)https://github.com/plotly/plotly.js/pull/1638/commits
Checkshttps://github.com/plotly/plotly.js/pull/1638/checks
Files changedhttps://github.com/plotly/plotly.js/pull/1638/files
Introducing 3D annotationshttps://github.com/plotly/plotly.js/pull/1638#top
etpinardhttps://github.com/etpinard
masterhttps://github.com/plotly/plotly.js/tree/master
gl3d-annotationshttps://github.com/plotly/plotly.js/tree/gl3d-annotations
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 28, 2017https://github.com/plotly/plotly.js/pull/1638#issue-225197515
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
#751https://github.com/plotly/plotly.js/issues/751
#751 (comment)https://github.com/plotly/plotly.js/issues/751#issuecomment-277280113
https://cloud.githubusercontent.com/assets/6675409/25547971/451f9072-2c38-11e7-9f0f-4e0c347ba2a4.gif
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
etpinardhttps://github.com/etpinard
April 28, 2017 17:08https://github.com/plotly/plotly.js/pull/1638#commits-pushed-aa58118
https://github.com/etpinard
replace forEach with for-loop over ['x', 'y']https://github.com/plotly/plotly.js/pull/1638/commits/aa58118e3665dd60d3fdda689ae58cf1814f99c2
aa58118https://github.com/plotly/plotly.js/pull/1638/commits/aa58118e3665dd60d3fdda689ae58cf1814f99c2
https://github.com/etpinard
don't (uselessly) add data-index to ann text+bg & arrow groupshttps://github.com/plotly/plotly.js/pull/1638/commits/8b8bdeae0c359d0958477b57012b84ea4651aaad
8b8bdeahttps://github.com/plotly/plotly.js/pull/1638/commits/8b8bdeae0c359d0958477b57012b84ea4651aaad
https://github.com/etpinard
don't (uselessly) add annotation class to ann text group innerhttps://github.com/plotly/plotly.js/pull/1638/commits/1a8f1ed1e855fb9157f728c191b00784fe3f1258
1a8f1edhttps://github.com/plotly/plotly.js/pull/1638/commits/1a8f1ed1e855fb9157f728c191b00784fe3f1258
https://github.com/etpinard
fine tune annotation arrow selectorhttps://github.com/plotly/plotly.js/pull/1638/commits/f4b14e686c30daf011cf82a675042979dcc4c213
f4b14e6https://github.com/plotly/plotly.js/pull/1638/commits/f4b14e686c30daf011cf82a675042979dcc4c213
https://github.com/etpinard
use ax.?2? while composing convert methodshttps://github.com/plotly/plotly.js/pull/1638/commits/4dc16e4cb5e1d5f37f267c170c37e2f506a65bbf
4dc16e4https://github.com/plotly/plotly.js/pull/1638/commits/4dc16e4cb5e1d5f37f267c170c37e2f506a65bbf
https://github.com/etpinard
split annotation drawOne into drawRawhttps://github.com/plotly/plotly.js/pull/1638/commits/8e6ab7d051ce8d163639d312524248aa2a2a2d2d
8e6ab7dhttps://github.com/plotly/plotly.js/pull/1638/commits/8e6ab7d051ce8d163639d312524248aa2a2a2d2d
https://github.com/etpinard
introduce 3D annotationshttps://github.com/plotly/plotly.js/pull/1638/commits/c5f6eb2b7973bd558f12bede16f2936ca15aa1cd
c5f6eb2https://github.com/plotly/plotly.js/pull/1638/commits/c5f6eb2b7973bd558f12bede16f2936ca15aa1cd
https://github.com/etpinard
don't try to edit x,y,z positions for 3D annotationshttps://github.com/plotly/plotly.js/pull/1638/commits/b7ab656d697a2c03b2ab0fee27fcee533496d524
b7ab656https://github.com/plotly/plotly.js/pull/1638/commits/b7ab656d697a2c03b2ab0fee27fcee533496d524
https://github.com/etpinard
etpinardhttps://github.com/etpinard
status: in progress https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22
feature https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature
Apr 28, 2017https://github.com/plotly/plotly.js/pull/1638#event-1062838478
etpinardhttps://github.com/etpinard
May 9, 2017 10:40https://github.com/plotly/plotly.js/pull/1638#commits-pushed-fbdcee8
https://github.com/etpinard
Merge branch 'master' into gl3d-annotationshttps://github.com/plotly/plotly.js/pull/1638/commits/fbdcee8c8fa86b96ef6a33290c178f5c1e26dd58
fbdcee8https://github.com/plotly/plotly.js/pull/1638/commits/fbdcee8c8fa86b96ef6a33290c178f5c1e26dd58
https://github.com/etpinard
Merge branch 'master' into gl3d-annotationshttps://github.com/plotly/plotly.js/pull/1638/commits/981b1a1ef41a016cddc254cd13d61d10c5d253ae
981b1a1https://github.com/plotly/plotly.js/pull/1638/commits/981b1a1ef41a016cddc254cd13d61d10c5d253ae
https://github.com/etpinard
rename anchor -> anchor3 so that it doesn't conflict w/ for-loop blockhttps://github.com/plotly/plotly.js/pull/1638/commits/94b940d96e70016b7203a62b2ac062de1909c79e
94b940dhttps://github.com/plotly/plotly.js/pull/1638/commits/94b940d96e70016b7203a62b2ac062de1909c79e
https://github.com/etpinard
etpinardhttps://github.com/etpinard
1.28.0https://github.com/plotly/plotly.js/milestone/22
May 18, 2017https://github.com/plotly/plotly.js/pull/1638#event-1087978819
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 19, 2017 https://github.com/plotly/plotly.js/pull/1638#ref-issue-229941199
No shape and no marker 'cross-thin' on scattergeo plot #1707 https://github.com/plotly/plotly.js/issues/1707
etpinardhttps://github.com/etpinard
May 24, 2017 09:47https://github.com/plotly/plotly.js/pull/1638#commits-pushed-8ac2551
https://github.com/etpinard
Merge branch 'master' into gl3d-annotationshttps://github.com/plotly/plotly.js/pull/1638/commits/8ac2551f71e7efa2fee9a478725a73321942ee65
8ac2551https://github.com/plotly/plotly.js/pull/1638/commits/8ac2551f71e7efa2fee9a478725a73321942ee65
https://github.com/etpinard
Revert "don't (uselessly) add annotation class to ann text group inner"https://github.com/plotly/plotly.js/pull/1638/commits/ababc49990ea8e6be7e07a5f85ec366e54a1d70d
ababc49https://github.com/plotly/plotly.js/pull/1638/commits/ababc49990ea8e6be7e07a5f85ec366e54a1d70d
1a8f1edhttps://github.com/plotly/plotly.js/commit/1a8f1ed1e855fb9157f728c191b00784fe3f1258
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 24, 2017 https://github.com/plotly/plotly.js/pull/1638#pullrequestreview-40044642
View reviewed changes https://github.com/plotly/plotly.js/pull/1638/files/1a8f1ed1e855fb9157f728c191b00784fe3f1258
src/components/annotations/draw.jshttps://github.com/plotly/plotly.js/pull/1638/files/8b8bdeae0c359d0958477b57012b84ea4651aaad..1a8f1ed1e855fb9157f728c191b00784fe3f1258#diff-f818f18714f996d292004b717d41debd5e0c325acb6e2e208192f0b00ed0c2cf
etpinardhttps://github.com/etpinard
May 24, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118269612
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
ababc49https://github.com/plotly/plotly.js/commit/ababc49990ea8e6be7e07a5f85ec366e54a1d70d
#1683https://github.com/plotly/plotly.js/pull/1683
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
alexcjohnsonhttps://github.com/alexcjohnson
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118564399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
ababc49https://github.com/plotly/plotly.js/commit/ababc49990ea8e6be7e07a5f85ec366e54a1d70d
#1683https://github.com/plotly/plotly.js/pull/1683
a31549dhttps://github.com/plotly/plotly.js/commit/a31549d3b7532c48200289607ab435e4e80d891f
ababc49https://github.com/plotly/plotly.js/commit/ababc49990ea8e6be7e07a5f85ec366e54a1d70d
1a8f1edhttps://github.com/plotly/plotly.js/commit/1a8f1ed1e855fb9157f728c191b00784fe3f1258
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
etpinardhttps://github.com/etpinard
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118564958
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
a31549dhttps://github.com/plotly/plotly.js/commit/a31549d3b7532c48200289607ab435e4e80d891f
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
etpinardhttps://github.com/etpinard
May 24, 2017 19:19https://github.com/plotly/plotly.js/pull/1638#commits-pushed-7cfba36
https://github.com/etpinard
fix 3d annotations on type: 'category' axeshttps://github.com/plotly/plotly.js/pull/1638/commits/7cfba365f9ffe8011e7eaddb5253c60bdaffd230
7cfba36https://github.com/plotly/plotly.js/pull/1638/commits/7cfba365f9ffe8011e7eaddb5253c60bdaffd230
https://github.com/etpinard
make sure to clear 3d annotations when parent scene gets removedhttps://github.com/plotly/plotly.js/pull/1638/commits/8f9e3703dcb17301c3bf6843420064e8235d9398
8f9e370https://github.com/plotly/plotly.js/pull/1638/commits/8f9e3703dcb17301c3bf6843420064e8235d9398
https://github.com/etpinard
implement autorange logic for annotationshttps://github.com/plotly/plotly.js/pull/1638/commits/1bbabad04c1ebe3d3896247ce03c0d116cddd4a7
1bbabadhttps://github.com/plotly/plotly.js/pull/1638/commits/1bbabad04c1ebe3d3896247ce03c0d116cddd4a7
https://github.com/etpinard
first pass 3d annotations jasmine testshttps://github.com/plotly/plotly.js/pull/1638/commits/952094317a6544d4ccf62b3c6a230ce6f9af71d7
9520943https://github.com/plotly/plotly.js/pull/1638/commits/952094317a6544d4ccf62b3c6a230ce6f9af71d7
https://github.com/etpinard
first pass 3d annotation image test supporthttps://github.com/plotly/plotly.js/pull/1638/commits/f61cd4dc99b91247e409bcad64cf79558f265a23
f61cd4dhttps://github.com/plotly/plotly.js/pull/1638/commits/f61cd4dc99b91247e409bcad64cf79558f265a23
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 24, 2017https://github.com/plotly/plotly.js/pull/1638#issuecomment-303880293
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
https://github.com/etpinard
etpinardhttps://github.com/etpinard
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
status: in progress https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22
May 24, 2017https://github.com/plotly/plotly.js/pull/1638#event-1096513353
etpinardhttps://github.com/etpinard
May 25, 2017 10:48https://github.com/plotly/plotly.js/pull/1638#commits-pushed-8cb10c1
https://github.com/etpinard
try to make test that update the scene camera more robusthttps://github.com/plotly/plotly.js/pull/1638/commits/8cb10c16c308fed5c3c2b4141c791ccc2b7358e3
8cb10c1https://github.com/plotly/plotly.js/pull/1638/commits/8cb10c16c308fed5c3c2b4141c791ccc2b7358e3
https://github.com/etpinard
replace 'annotation' class for 'annotation-text' for annation text nodeshttps://github.com/plotly/plotly.js/pull/1638/commits/a31549d3b7532c48200289607ab435e4e80d891f
a31549dhttps://github.com/plotly/plotly.js/pull/1638/commits/a31549d3b7532c48200289607ab435e4e80d891f
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
May 25, 2017 https://github.com/plotly/plotly.js/pull/1638#pullrequestreview-40366291
View reviewed changes https://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f
src/plots/gl3d/scene.jshttps://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f#diff-2392186e2cc7368a027c29bfe4e6df7a0e910a57b0c6285f5809c64ee301f54a
alexcjohnsonhttps://github.com/alexcjohnson
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118561697
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
alexcjohnsonhttps://github.com/alexcjohnson
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118567806
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
etpinardhttps://github.com/etpinard
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118573245
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#issuecomment-304097628
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
May 25, 2017 https://github.com/plotly/plotly.js/pull/1638#pullrequestreview-40370687
View reviewed changes https://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f
src/components/annotations/draw.jshttps://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f#diff-f818f18714f996d292004b717d41debd5e0c325acb6e2e208192f0b00ed0c2cf
alexcjohnsonhttps://github.com/alexcjohnson
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118565726
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
etpinardhttps://github.com/etpinard
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118573015
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
c084da0https://github.com/plotly/plotly.js/commit/c084da0e2282c6ea2e680e4e01dfcbbe910a949f
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
May 25, 2017 https://github.com/plotly/plotly.js/pull/1638#pullrequestreview-40373732
View reviewed changes https://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f
src/plots/gl3d/layout/layout_attributes.jshttps://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f#diff-a8a6ec637f76c92dca699f90dba9c85c2c5c74dfec1adc48089326d879f367b4
alexcjohnsonhttps://github.com/alexcjohnson
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118568490
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
etpinardhttps://github.com/etpinard
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118573145
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
adfc305https://github.com/plotly/plotly.js/commit/adfc305a0918c4afcb8b17b737e281517ec09613
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
May 25, 2017 https://github.com/plotly/plotly.js/pull/1638#pullrequestreview-40376226
View reviewed changes https://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f
src/components/annotations/draw.jshttps://github.com/plotly/plotly.js/pull/1638/files/a31549d3b7532c48200289607ab435e4e80d891f#diff-f818f18714f996d292004b717d41debd5e0c325acb6e2e208192f0b00ed0c2cf
alexcjohnsonhttps://github.com/alexcjohnson
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118570661
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
etpinardhttps://github.com/etpinard
May 25, 2017 16:01https://github.com/plotly/plotly.js/pull/1638#commits-pushed-bd9c867
https://github.com/etpinard
mv 3d annotations code out of plots/gl3d into component/annotations3dhttps://github.com/plotly/plotly.js/pull/1638/commits/bd9c867cd6b4cd985dcdd8f3ab3e4ea02376f325
bd9c867https://github.com/plotly/plotly.js/pull/1638/commits/bd9c867cd6b4cd985dcdd8f3ab3e4ea02376f325
https://github.com/etpinard
add common annotations defaults moduleshttps://github.com/plotly/plotly.js/pull/1638/commits/21c8cc6041a7e30368bda531446c2a49f88a916c
21c8cc6https://github.com/plotly/plotly.js/pull/1638/commits/21c8cc6041a7e30368bda531446c2a49f88a916c
https://github.com/etpinard
declare ax and ay as valType: number for annotation3dhttps://github.com/plotly/plotly.js/pull/1638/commits/adfc305a0918c4afcb8b17b737e281517ec09613
adfc305https://github.com/plotly/plotly.js/pull/1638/commits/adfc305a0918c4afcb8b17b737e281517ec09613
https://github.com/etpinard
rename _scene ref to scene id in annotation container _sceneIdhttps://github.com/plotly/plotly.js/pull/1638/commits/c084da0e2282c6ea2e680e4e01dfcbbe910a949f
c084da0https://github.com/plotly/plotly.js/pull/1638/commits/c084da0e2282c6ea2e680e4e01dfcbbe910a949f
https://github.com/etpinard
etpinardhttps://github.com/etpinard
force-pushedhttps://github.com/plotly/plotly.js/compare/21a5a0e6100c77aa523e9884c508e1c3ae655acb..876b37b38007dc76c5e8211e104d553e14e373e1
21a5a0ehttps://github.com/plotly/plotly.js/commit/21a5a0e6100c77aa523e9884c508e1c3ae655acb
876b37bhttps://github.com/plotly/plotly.js/commit/876b37b38007dc76c5e8211e104d553e14e373e1
Compare https://github.com/plotly/plotly.js/compare/21a5a0e6100c77aa523e9884c508e1c3ae655acb..876b37b38007dc76c5e8211e104d553e14e373e1
May 25, 2017 20:26https://github.com/plotly/plotly.js/pull/1638#event-1097944383
https://github.com/etpinard
put 'captureevents' under common annotation defaultshttps://github.com/plotly/plotly.js/pull/1638/commits/ef985cfd5f94181a0defd5c91978b618d73a5a76
ef985cfhttps://github.com/plotly/plotly.js/pull/1638/commits/ef985cfd5f94181a0defd5c91978b618d73a5a76
https://github.com/etpinard
etpinardhttps://github.com/etpinard
force-pushedhttps://github.com/plotly/plotly.js/compare/876b37b38007dc76c5e8211e104d553e14e373e1..ef985cfd5f94181a0defd5c91978b618d73a5a76
876b37bhttps://github.com/plotly/plotly.js/commit/876b37b38007dc76c5e8211e104d553e14e373e1
ef985cfhttps://github.com/plotly/plotly.js/commit/ef985cfd5f94181a0defd5c91978b618d73a5a76
Compare https://github.com/plotly/plotly.js/compare/876b37b38007dc76c5e8211e104d553e14e373e1..ef985cfd5f94181a0defd5c91978b618d73a5a76
May 25, 2017 20:30https://github.com/plotly/plotly.js/pull/1638#event-1097949570
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 25, 2017 https://github.com/plotly/plotly.js/pull/1638#pullrequestreview-40386072
View reviewed changes https://github.com/plotly/plotly.js/pull/1638/files/ef985cfd5f94181a0defd5c91978b618d73a5a76
src/components/annotations3d/attributes.jshttps://github.com/plotly/plotly.js/pull/1638/files/c084da0e2282c6ea2e680e4e01dfcbbe910a949f..ef985cfd5f94181a0defd5c91978b618d73a5a76#diff-10842e0a75bd119a19e132f24b925185c614512653d01f2f13798f32929692f0
etpinardhttps://github.com/etpinard
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118579244
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://cloud.githubusercontent.com/assets/6675409/26469595/94a5809e-4168-11e7-8ada-349db5396d5e.gif
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
alexcjohnsonhttps://github.com/alexcjohnson
May 25, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118593734
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
etpinardhttps://github.com/etpinard
May 26, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118719442
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
8b8a088https://github.com/plotly/plotly.js/commit/8b8a088b8e0e9e8f48b5d9c036398c8e1ba7976a
1d5606ahttps://github.com/plotly/plotly.js/commit/1d5606a8ff4bed24b9ba5e43de162f62d026b2d6
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
etpinardhttps://github.com/etpinard
May 26, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118724628
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
1d5606ahttps://github.com/plotly/plotly.js/commit/1d5606a8ff4bed24b9ba5e43de162f62d026b2d6
thishttps://github.com/plotly/plotly.js/blob/78b82b85206bde93c7117706278ac698b480139d/test/jasmine/tests/annotations_test.js#L1202
thathttps://github.com/plotly/plotly.js/blob/78b82b85206bde93c7117706278ac698b480139d/test/jasmine/tests/annotations_test.js#L1226
@alexcjohnsonhttps://github.com/alexcjohnson
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
alexcjohnsonhttps://github.com/alexcjohnson
May 26, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118726170
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
my commenthttps://github.com/plotly/plotly.js/pull/1638#commitcomment-22295724
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
etpinardhttps://github.com/etpinard
May 26, 2017https://github.com/plotly/plotly.js/pull/1638#discussion_r118728335
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
46ab63dhttps://github.com/plotly/plotly.js/commit/46ab63dcf3fa3128957d60e0b592a316150e1823
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
etpinardhttps://github.com/etpinard
May 25, 2017 17:28https://github.com/plotly/plotly.js/pull/1638#commits-pushed-0b4214f
https://github.com/etpinard
Merge branch 'master' into gl3d-annotationshttps://github.com/plotly/plotly.js/pull/1638/commits/0b4214f3383b50149c3838e4b8d8b5a2dfff01b1
0b4214fhttps://github.com/plotly/plotly.js/pull/1638/commits/0b4214f3383b50149c3838e4b8d8b5a2dfff01b1
https://github.com/etpinard
pass subplotId as arg to Annotations.drawRawhttps://github.com/plotly/plotly.js/pull/1638/commits/8b8a088b8e0e9e8f48b5d9c036398c8e1ba7976a
8b8a088https://github.com/plotly/plotly.js/pull/1638/commits/8b8a088b8e0e9e8f48b5d9c036398c8e1ba7976a
https://github.com/etpinard
include subplotId in clickannotation event datahttps://github.com/plotly/plotly.js/pull/1638/commits/1d5606a8ff4bed24b9ba5e43de162f62d026b2d6
https://github.com/plotly/plotly.js/commit/1d5606a8ff4bed24b9ba5e43de162f62d026b2d6#comments
1d5606ahttps://github.com/plotly/plotly.js/pull/1638/commits/1d5606a8ff4bed24b9ba5e43de162f62d026b2d6
https://github.com/etpinard
rm subplotId key from clickannotations event data when falsyhttps://github.com/plotly/plotly.js/pull/1638/commits/46ab63dcf3fa3128957d60e0b592a316150e1823
46ab63dhttps://github.com/plotly/plotly.js/pull/1638/commits/46ab63dcf3fa3128957d60e0b592a316150e1823
https://github.com/alexcjohnson
alexcjohnsonhttps://github.com/alexcjohnson
May 26, 2017https://github.com/plotly/plotly.js/pull/1638#issuecomment-304323899
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
https://github.com/etpinard
etpinardhttps://github.com/etpinard
6b7c9d7https://github.com/plotly/plotly.js/commit/6b7c9d7aeba575c3ff5a35a03e111c051e001ed7
May 26, 2017https://github.com/plotly/plotly.js/pull/1638#event-1099191416
https://github.com/etpinard
etpinardhttps://github.com/etpinard
May 26, 2017 16:14https://github.com/plotly/plotly.js/pull/1638#event-1099191518
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Jun 14, 2017 https://github.com/plotly/plotly.js/pull/1638#ref-pullrequest-235915665
hide off-plot annotations #1786 https://github.com/plotly/plotly.js/pull/1786
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Feb 20, 2020 https://github.com/plotly/plotly.js/pull/1638#ref-issue-568005348
anchor shapes to map axes #4594 https://github.com/plotly/plotly.js/issues/4594
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1638
https://github.com/alexcjohnson
alexcjohnson https://github.com/alexcjohnson
https://github.com/plotly/plotly.js/pull/1638/files/ef985cfd5f94181a0defd5c91978b618d73a5a76
feature https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature
1.28.0 https://github.com/plotly/plotly.js/milestone/22
Data-referenced annotations on 3D graphs https://github.com/plotly/plotly.js/issues/751
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1638
https://github.com/etpinard
https://github.com/alexcjohnson
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.