| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:0348f956-284f-8f26-1f1b-3e85d8107e38 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BDF2:2C0C9B:3556D8A:46C4CF4:6A6552A2 |
| html-safe-nonce | 509bd2762db5d672de100b37ae82ed87799a56d7f0472d27f412eb2e377f198c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREYyOjJDMEM5QjozNTU2RDhBOjQ2QzRDRjQ6NkE2NTUyQTIiLCJ2aXNpdG9yX2lkIjoiODAxNjExMTc1NDU2MDIzMDA1MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 341c10bdc5933927e6ff34981d1624be5f1f9996897d8f9eb59d345f554d6f39 |
| hovercard-subject-tag | pull_request:115803411 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
| twitter:image | https://avatars.githubusercontent.com/u/572717?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/572717?s=400&v=4 |
| og:image:alt | This PR breaks up a couple not-really-related or loosely-related commits from carpet plots into separate commits and rebases all of carpet plots into one big commit. Supersedes #1239. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 309153364422b3c499922d1a2a6404910a58ed8e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1595%2Fcommits%2Fc2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| Code QualityEnforce quality at merge | https://github.com/features/code-quality |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1595%2Fcommits%2Fc2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
| Reload | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
| Reload | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
774
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
54
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fplotly%2Fplotly.js%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fplotly%2Fplotly.js%2Fissues%2Fnew%2Fchoose |
| rreusser | https://github.com/rreusser |
| master | https://github.com/plotly/plotly.js/tree/master |
| carpet-rebase | https://github.com/plotly/plotly.js/tree/carpet-rebase |
|
Conversation
29
| https://github.com/plotly/plotly.js/pull/1595 |
|
Commits
23
| https://github.com/plotly/plotly.js/pull/1595/commits |
|
Checks
0
| https://github.com/plotly/plotly.js/pull/1595/checks |
|
Files changed
| https://github.com/plotly/plotly.js/pull/1595/files |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
|
Carpet plot rebase
| https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf#top |
|
Show all changes
23 commits
| https://github.com/plotly/plotly.js/pull/1595/files |
|
eee837f
Add ensure array lib function to allocate/resize
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/eee837f997e391d29c43695a05bc249be75a281e |
|
5a0b788
Add axis cartesian axis visibility option
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/5a0b7887a1922f3559e541205978d5ca7f1258a2 |
|
89e095e
Add measureText function to drawing
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/89e095efe25d66b08c41254d80548fa89ba5dc46 |
|
e1a0417
Tweak showscale to allow unset (instead of strictly false)
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/e1a0417cc5e74e1949b7d8765ecd92b2d9f8350b |
|
620cd43
Contour plot lines to use non-scaling stroke
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/620cd43a3dd16f51761feb8ad329397594ad9843 |
|
728a6f4
Genericize heatmap xyz variable names
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/728a6f41e089d2955a7f6e184fc9b79fcd63de10 |
|
c2994e7
More carefully track legend trace isolation indices
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
|
fe9850c
Add optional overrides to contour handleStyleDefaults
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/fe9850cc1288e468ddd48b0e3618b816902d9d67 |
|
d1f2258
Genericize tolerances in find_all_paths to make way for carpet
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/d1f225828c0de5114cbff3bc8062d153c2b950b8 |
|
4bcf438
Add flag to disable scatter marker culling (needed for carpet)
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/4bcf438c6c863bad064540dc41030273891d7279 |
|
6b896d8
Tweak contour colorscale logic since carpet may set infinities
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/6b896d895ae68cf122a7bca0e431bf411cd6317a |
|
b8c71e1
Add group to plot
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/b8c71e1e656a462a88dc9025d3f42af1bd641c24 |
|
e4971ef
Carpet plots
rreusser Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/e4971ef2343b1a80c155883dee2263f613b3dd21 |
|
c98553a
make rreusser's carpet tests pass
etpinard Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/c98553a9f14b32ede6afd79ca5a86a3793d72d9c |
|
71b96f3
add a few carpet interaction tests
etpinard Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/71b96f3f4db001e5a3f364993f4523310daa32c0 |
|
bc1c5c8
:hocho: arraytools dep (sorry @bpostlethwaite)
etpinard Apr 14, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/bc1c5c840d1a6a3f1601918b1ed092895fb60f4a |
|
9c76d7a
exit early in axis defaults when visible is false
etpinard Apr 14, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/9c76d7af1680e0bf20472ae26bdfa78ac94b7350 |
|
85d6b8a
add axis `visible: false` mock
etpinard Apr 14, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/85d6b8af377ab7212f251cab314fb42e1f55458c |
|
54f092d
implement axis visible in 3D
etpinard Apr 14, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/54f092d95d0696f65da911dba6187a4cbefe9766 |
|
d9cb011
add 3d axis `visible: false` mock
etpinard Apr 14, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/d9cb011819c8d9fb663a4eb06ab6791010d2d2a7 |
|
f1e8aee
Merge pull request #1596 from plotly/carpet-test-etienne
etpinard Apr 17, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/f1e8aeea74f83b3f753a61a796cafd71c3f1bdb0 |
|
bc0f890
extendFlat -> slice
etpinard Apr 17, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/bc0f8902f00ad2e29e59140a2cebe23db4ed6eea |
|
c2a7092
Merge pull request #1599 from plotly/axis-visible-3d
etpinard Apr 17, 2017
| https://github.com/plotly/plotly.js/pull/1595/commits/c2a7092ed5faab6bd88d61d0309a92d79b56bc04 |
|
Clear filters
| https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
|
Prev
| https://github.com/plotly/plotly.js/pull/1595/commits/728a6f41e089d2955a7f6e184fc9b79fcd63de10 |
|
Next
| https://github.com/plotly/plotly.js/pull/1595/commits/fe9850cc1288e468ddd48b0e3618b816902d9d67 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
|
| https://github.com/rreusser |
| rreusser | https://github.com/plotly/plotly.js/commits?author=rreusser |
| src/components/legend/draw.js | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578 |
|
View file
| https://github.com/plotly/plotly.js/blob/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf/src/components/legend/draw.js |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/1595/commits/{{ revealButtonHref }} |
|
| https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578 |
|
| https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578 |
|
| https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578 |
|
| https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf#diff-d8edc6534e1e0d8e389e68825f8ecdcdc8a607d22ab022006515ad1077182578 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |