| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:585b8514-ea7f-8247-d232-b7b2e6f86fd8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8F0A:B3489:45EB90:61067F:6A5A4DF3 |
| html-safe-nonce | 71b36a90c037ce9bffc9a0f8a800163cc73c15fcdfb88fa0cb5d4bbfe193a7d8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjBBOkIzNDg5OjQ1RUI5MDo2MTA2N0Y6NkE1QTRERjMiLCJ2aXNpdG9yX2lkIjoiODgzMjUyMzMzOTIwMjc1OTU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a64681a9709fe52ac15e801de5853c53fb87b561b5cf6c307e59c4759cb00055 |
| hovercard-subject-tag | pull_request:115803411 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/1595/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/61aa97027e0d822f635e794ca2cc096a4eeb2b3bb37920cbf83fbfa1d1125454/plotly/plotly.js/pull/1595 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/61aa97027e0d822f635e794ca2cc096a4eeb2b3bb37920cbf83fbfa1d1125454/plotly/plotly.js/pull/1595 |
| og:image:alt | This PR breaks up a couple not-really-related or loosely-related commits from carpet plots into separate commits and rebases all of carpet plots into one big commit. Supersedes #1239. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | rreusser |
| hostname | github.com |
| expected-hostname | github.com |
| None | a793cd1fa898929111edad5857ee1f24ecf4bf7702525e67357cabc9df136fc3 |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 311929384671aa49f385b6fcc680ae3933943203 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/1595#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1595 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1595 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/1595 |
| Reload | https://github.com/plotly/plotly.js/pull/1595 |
| Reload | https://github.com/plotly/plotly.js/pull/1595 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
773
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
57
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| rreusser | https://github.com/rreusser |
| master | https://github.com/plotly/plotly.js/tree/master |
| carpet-rebase | https://github.com/plotly/plotly.js/tree/carpet-rebase |
| Conversation | https://github.com/plotly/plotly.js/pull/1595 |
| Commits23 (23) | https://github.com/plotly/plotly.js/pull/1595/commits |
| Checks | https://github.com/plotly/plotly.js/pull/1595/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/1595/files |
| Carpet plot rebase | https://github.com/plotly/plotly.js/pull/1595#top |
| rreusser | https://github.com/rreusser |
| master | https://github.com/plotly/plotly.js/tree/master |
| carpet-rebase | https://github.com/plotly/plotly.js/tree/carpet-rebase |
|
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#issue-221628167 |
| #1239 | https://github.com/plotly/plotly.js/pull/1239 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| rreusser | https://github.com/rreusser |
| April 13, 2017 13:09 | https://github.com/plotly/plotly.js/pull/1595#commits-pushed-eee837f |
|
| https://github.com/rreusser |
| Add ensure array lib function to allocate/resize | https://github.com/plotly/plotly.js/pull/1595/commits/eee837f997e391d29c43695a05bc249be75a281e |
| eee837f | https://github.com/plotly/plotly.js/pull/1595/commits/eee837f997e391d29c43695a05bc249be75a281e |
|
| https://github.com/rreusser |
| Add axis cartesian axis visibility option | https://github.com/plotly/plotly.js/pull/1595/commits/5a0b7887a1922f3559e541205978d5ca7f1258a2 |
| 5a0b788 | https://github.com/plotly/plotly.js/pull/1595/commits/5a0b7887a1922f3559e541205978d5ca7f1258a2 |
|
| https://github.com/rreusser |
| Add measureText function to drawing | https://github.com/plotly/plotly.js/pull/1595/commits/89e095efe25d66b08c41254d80548fa89ba5dc46 |
| 89e095e | https://github.com/plotly/plotly.js/pull/1595/commits/89e095efe25d66b08c41254d80548fa89ba5dc46 |
|
| https://github.com/rreusser |
| Tweak showscale to allow unset (instead of strictly false) | https://github.com/plotly/plotly.js/pull/1595/commits/e1a0417cc5e74e1949b7d8765ecd92b2d9f8350b |
| e1a0417 | https://github.com/plotly/plotly.js/pull/1595/commits/e1a0417cc5e74e1949b7d8765ecd92b2d9f8350b |
|
| https://github.com/rreusser |
| Contour plot lines to use non-scaling stroke | https://github.com/plotly/plotly.js/pull/1595/commits/620cd43a3dd16f51761feb8ad329397594ad9843 |
| 620cd43 | https://github.com/plotly/plotly.js/pull/1595/commits/620cd43a3dd16f51761feb8ad329397594ad9843 |
|
| https://github.com/rreusser |
| Genericize heatmap xyz variable names | https://github.com/plotly/plotly.js/pull/1595/commits/728a6f41e089d2955a7f6e184fc9b79fcd63de10 |
| 728a6f4 | https://github.com/plotly/plotly.js/pull/1595/commits/728a6f41e089d2955a7f6e184fc9b79fcd63de10 |
|
| https://github.com/rreusser |
| More carefully track legend trace isolation indices | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
| c2994e7 | https://github.com/plotly/plotly.js/pull/1595/commits/c2994e7c11c8f7b520c2d737dc3d81429d2f2adf |
|
| https://github.com/rreusser |
| Add optional overrides to contour handleStyleDefaults | https://github.com/plotly/plotly.js/pull/1595/commits/fe9850cc1288e468ddd48b0e3618b816902d9d67 |
| fe9850c | https://github.com/plotly/plotly.js/pull/1595/commits/fe9850cc1288e468ddd48b0e3618b816902d9d67 |
|
| https://github.com/rreusser |
| Genericize tolerances in find_all_paths to make way for carpet | https://github.com/plotly/plotly.js/pull/1595/commits/d1f225828c0de5114cbff3bc8062d153c2b950b8 |
| d1f2258 | https://github.com/plotly/plotly.js/pull/1595/commits/d1f225828c0de5114cbff3bc8062d153c2b950b8 |
|
| https://github.com/rreusser |
| Add flag to disable scatter marker culling (needed for carpet) | https://github.com/plotly/plotly.js/pull/1595/commits/4bcf438c6c863bad064540dc41030273891d7279 |
| 4bcf438 | https://github.com/plotly/plotly.js/pull/1595/commits/4bcf438c6c863bad064540dc41030273891d7279 |
|
| https://github.com/rreusser |
| Tweak contour colorscale logic since carpet may set infinities | https://github.com/plotly/plotly.js/pull/1595/commits/6b896d895ae68cf122a7bca0e431bf411cd6317a |
| 6b896d8 | https://github.com/plotly/plotly.js/pull/1595/commits/6b896d895ae68cf122a7bca0e431bf411cd6317a |
|
| https://github.com/rreusser |
| Add group to plot | https://github.com/plotly/plotly.js/pull/1595/commits/b8c71e1e656a462a88dc9025d3f42af1bd641c24 |
| b8c71e1 | https://github.com/plotly/plotly.js/pull/1595/commits/b8c71e1e656a462a88dc9025d3f42af1bd641c24 |
|
| https://github.com/rreusser |
| Carpet plots | https://github.com/plotly/plotly.js/pull/1595/commits/e4971ef2343b1a80c155883dee2263f613b3dd21 |
| e4971ef | https://github.com/plotly/plotly.js/pull/1595/commits/e4971ef2343b1a80c155883dee2263f613b3dd21 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
|
Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595#ref-pullrequest-194333752 |
|
[WIP] Carpet plots
#1239
| https://github.com/plotly/plotly.js/pull/1239 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| v1.26.0 | https://github.com/plotly/plotly.js/milestone/19 |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#event-1042341573 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#event-1042341715 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595#pullrequestreview-32704743 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1595/files/5a0b7887a1922f3559e541205978d5ca7f1258a2 |
| src/plots/gl3d/layout/axis_attributes.js | https://github.com/plotly/plotly.js/pull/1595/files/eee837f997e391d29c43695a05bc249be75a281e..5a0b7887a1922f3559e541205978d5ca7f1258a2#diff-bb0d67f3a9001810ad9198c684c04ec8057df718de361849da1096c2f9f57d52 |
| etpinard | https://github.com/etpinard |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111455286 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| rreusser | https://github.com/rreusser |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111457973 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| rreusser | https://github.com/rreusser |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111458116 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| etpinard | https://github.com/etpinard |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111458506 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| etpinard | https://github.com/etpinard |
| Apr 14, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111520870 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #1599 | https://github.com/plotly/plotly.js/pull/1599 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| rreusser | https://github.com/rreusser |
| Apr 14, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111524752 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| etpinard | https://github.com/etpinard |
| Apr 17, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111744115 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #1599 | https://github.com/plotly/plotly.js/pull/1599 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#issuecomment-293985829 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#issuecomment-293986086 |
| https://cloud.githubusercontent.com/assets/572717/25018894/a6f2cab4-2056-11e7-9601-ca4db995c619.gif |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595#pullrequestreview-32707659 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1595/files/eee837f997e391d29c43695a05bc249be75a281e |
| src/lib/ensure_array.js | https://github.com/plotly/plotly.js/pull/1595/files/eee837f997e391d29c43695a05bc249be75a281e#diff-aa22c6da17d2e82d418087a2da82d7a63a97b74f408d67e5c7826d24be44bf55 |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111458010 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| rreusser | https://github.com/rreusser |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111458534 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| etpinard | https://github.com/etpinard |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111458796 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/length | https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/length |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| rreusser | https://github.com/rreusser |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111475189 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595#pullrequestreview-32711937 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1595/files/89e095efe25d66b08c41254d80548fa89ba5dc46 |
| src/components/drawing/index.js | https://github.com/plotly/plotly.js/pull/1595/files/5a0b7887a1922f3559e541205978d5ca7f1258a2..89e095efe25d66b08c41254d80548fa89ba5dc46#diff-e8c93e83ebf0c3a486f3187d44d91b1709f51bccaba559fcadab2a3e3f9f56c6 |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111461982 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| rreusser | https://github.com/rreusser |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111465434 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| rreusser | https://github.com/rreusser |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111465666 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595#pullrequestreview-32723707 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1595/files/e4971ef2343b1a80c155883dee2263f613b3dd21 |
| test/jasmine/tests/carpet_test.js | https://github.com/plotly/plotly.js/pull/1595/files/e4971ef2343b1a80c155883dee2263f613b3dd21#diff-8fb2991cead782f4870442938c2ec557034ac914be30c36a76cec76d6c97d8b2 |
| etpinard | https://github.com/etpinard |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111472869 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @rreusser | https://github.com/rreusser |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| etpinard | https://github.com/etpinard |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111474983 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @rreusser | https://github.com/rreusser |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| rreusser | https://github.com/rreusser |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111475584 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| etpinard | https://github.com/etpinard |
| Apr 13, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r111481358 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| c98553a | https://github.com/plotly/plotly.js/commit/c98553a9f14b32ede6afd79ca5a86a3793d72d9c |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| etpinard | https://github.com/etpinard |
| April 13, 2017 16:34 | https://github.com/plotly/plotly.js/pull/1595#commits-pushed-c98553a |
|
| https://github.com/etpinard |
| make rreusser's carpet tests pass | https://github.com/plotly/plotly.js/pull/1595/commits/c98553a9f14b32ede6afd79ca5a86a3793d72d9c |
| c98553a | https://github.com/plotly/plotly.js/pull/1595/commits/c98553a9f14b32ede6afd79ca5a86a3793d72d9c |
|
| https://github.com/etpinard |
| add a few carpet interaction tests | https://github.com/plotly/plotly.js/pull/1595/commits/71b96f3f4db001e5a3f364993f4523310daa32c0 |
| 71b96f3 | https://github.com/plotly/plotly.js/pull/1595/commits/71b96f3f4db001e5a3f364993f4523310daa32c0 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Apr 13, 2017
| https://github.com/plotly/plotly.js/pull/1595#ref-pullrequest-221674926 |
|
A few more carpet plot tests
#1596
| https://github.com/plotly/plotly.js/pull/1596 |
| etpinard | https://github.com/etpinard |
| April 13, 2017 22:26 | https://github.com/plotly/plotly.js/pull/1595#commits-pushed-bc1c5c8 |
|
| https://github.com/etpinard |
| 🔪 arraytools dep (sorry | https://github.com/plotly/plotly.js/pull/1595/commits/bc1c5c840d1a6a3f1601918b1ed092895fb60f4a |
| @bpostlethwaite | https://github.com/bpostlethwaite |
| ) | https://github.com/plotly/plotly.js/pull/1595/commits/bc1c5c840d1a6a3f1601918b1ed092895fb60f4a |
| bc1c5c8 | https://github.com/plotly/plotly.js/pull/1595/commits/bc1c5c840d1a6a3f1601918b1ed092895fb60f4a |
|
| https://github.com/etpinard |
| exit early in axis defaults when visible is false | https://github.com/plotly/plotly.js/pull/1595/commits/9c76d7af1680e0bf20472ae26bdfa78ac94b7350 |
| 9c76d7a | https://github.com/plotly/plotly.js/pull/1595/commits/9c76d7af1680e0bf20472ae26bdfa78ac94b7350 |
|
| https://github.com/etpinard |
| add axis visible: false mock | https://github.com/plotly/plotly.js/pull/1595/commits/85d6b8af377ab7212f251cab314fb42e1f55458c |
| 85d6b8a | https://github.com/plotly/plotly.js/pull/1595/commits/85d6b8af377ab7212f251cab314fb42e1f55458c |
|
| https://github.com/etpinard |
| implement axis visible in 3D | https://github.com/plotly/plotly.js/pull/1595/commits/54f092d95d0696f65da911dba6187a4cbefe9766 |
| 54f092d | https://github.com/plotly/plotly.js/pull/1595/commits/54f092d95d0696f65da911dba6187a4cbefe9766 |
|
| https://github.com/etpinard |
| add 3d axis visible: false mock | https://github.com/plotly/plotly.js/pull/1595/commits/d9cb011819c8d9fb663a4eb06ab6791010d2d2a7 |
| d9cb011 | https://github.com/plotly/plotly.js/pull/1595/commits/d9cb011819c8d9fb663a4eb06ab6791010d2d2a7 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Apr 14, 2017
| https://github.com/plotly/plotly.js/pull/1595#ref-pullrequest-221727809 |
|
Axis visible in 3D
#1599
| https://github.com/plotly/plotly.js/pull/1599 |
| etpinard | https://github.com/etpinard |
| April 17, 2017 09:20 | https://github.com/plotly/plotly.js/pull/1595#commits-pushed-f1e8aee |
|
| https://github.com/etpinard |
| Merge pull request | https://github.com/plotly/plotly.js/pull/1595/commits/f1e8aeea74f83b3f753a61a796cafd71c3f1bdb0 |
| #1596 | https://github.com/plotly/plotly.js/pull/1596 |
| from plotly/carpet-test-etienne | https://github.com/plotly/plotly.js/pull/1595/commits/f1e8aeea74f83b3f753a61a796cafd71c3f1bdb0 |
| f1e8aee | https://github.com/plotly/plotly.js/pull/1595/commits/f1e8aeea74f83b3f753a61a796cafd71c3f1bdb0 |
|
| https://github.com/etpinard |
| extendFlat -> slice | https://github.com/plotly/plotly.js/pull/1595/commits/bc0f8902f00ad2e29e59140a2cebe23db4ed6eea |
| bc0f890 | https://github.com/plotly/plotly.js/pull/1595/commits/bc0f8902f00ad2e29e59140a2cebe23db4ed6eea |
|
| https://github.com/etpinard |
| Merge pull request | https://github.com/plotly/plotly.js/pull/1595/commits/c2a7092ed5faab6bd88d61d0309a92d79b56bc04 |
| #1599 | https://github.com/plotly/plotly.js/pull/1599 |
| from plotly/axis-visible-3d | https://github.com/plotly/plotly.js/pull/1595/commits/c2a7092ed5faab6bd88d61d0309a92d79b56bc04 |
| c2a7092 | https://github.com/plotly/plotly.js/pull/1595/commits/c2a7092ed5faab6bd88d61d0309a92d79b56bc04 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Apr 17, 2017 | https://github.com/plotly/plotly.js/pull/1595#issuecomment-294489528 |
| @rreusser | https://github.com/rreusser |
| @alexcjohnson | https://github.com/alexcjohnson |
| #1595 (comment) | https://github.com/plotly/plotly.js/pull/1595#discussion_r111461982 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 17, 2017 | https://github.com/plotly/plotly.js/pull/1595#issuecomment-294500719 |
| @alexcjohnson | https://github.com/alexcjohnson |
| #1595 | https://github.com/plotly/plotly.js/pull/1595 |
| @rreusser | https://github.com/rreusser |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Apr 17, 2017 | https://github.com/plotly/plotly.js/pull/1595#issuecomment-294502019 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| ba0e3a5 | https://github.com/plotly/plotly.js/commit/ba0e3a500284a7986ace141b1917ce7a20480c20 |
| Apr 17, 2017 | https://github.com/plotly/plotly.js/pull/1595#event-1045097789 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| April 17, 2017 15:17 | https://github.com/plotly/plotly.js/pull/1595#event-1045097883 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Jun 28, 2017
| https://github.com/plotly/plotly.js/pull/1595#ref-issue-190811956 |
|
Carpet plots
#1179
| https://github.com/plotly/plotly.js/issues/1179 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Sep 1, 2017
| https://github.com/plotly/plotly.js/pull/1595#pullrequestreview-60261695 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1595/files/e4971ef2343b1a80c155883dee2263f613b3dd21 |
| src/traces/carpet/attributes.js | https://github.com/plotly/plotly.js/pull/1595/files/b8c71e1e656a462a88dc9025d3f42af1bd641c24..e4971ef2343b1a80c155883dee2263f613b3dd21#diff-2278cb471b736a41488aad438eec83823922d031a24e89754da6d70dd76f7fd8 |
| alexcjohnson | https://github.com/alexcjohnson |
| Sep 1, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r136682722 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @rreusser | https://github.com/rreusser |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| rreusser | https://github.com/rreusser |
| Sep 2, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r136685039 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| alexcjohnson | https://github.com/alexcjohnson |
| Sep 2, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r136686811 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| etpinard | https://github.com/etpinard |
| Sep 5, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r136975310 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Sep 2, 2017
| https://github.com/plotly/plotly.js/pull/1595#pullrequestreview-60262275 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1595/files/e4971ef2343b1a80c155883dee2263f613b3dd21 |
| src/traces/carpet/axis_attributes.js | https://github.com/plotly/plotly.js/pull/1595/files/b8c71e1e656a462a88dc9025d3f42af1bd641c24..e4971ef2343b1a80c155883dee2263f613b3dd21#diff-25dfb357283f433a9089cdcdb7f758fa89042b2236efbf9fdf58c5f57e81605f |
| alexcjohnson | https://github.com/alexcjohnson |
| Sep 2, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r136683200 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @rreusser | https://github.com/rreusser |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| rreusser | https://github.com/rreusser |
| Sep 2, 2017 | https://github.com/plotly/plotly.js/pull/1595#discussion_r136685001 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1595 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/1595/files/e4971ef2343b1a80c155883dee2263f613b3dd21 |
|
| https://github.com/etpinard |
|
etpinard
| https://github.com/etpinard |
|
| https://github.com/plotly/plotly.js/pull/1595/files/e4971ef2343b1a80c155883dee2263f613b3dd21 |
|
feature
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Afeature |
|
v1.26.0
| https://github.com/plotly/plotly.js/milestone/19 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1595 |
|
| https://github.com/rreusser |
|
| https://github.com/etpinard |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |