René's URL Explorer Experiment


Title: Remove the performance overhead of showLink property by hy9be · Pull Request #1557 · plotly/plotly.js · GitHub

Open Graph Title: Remove the performance overhead of showLink property by hy9be · Pull Request #1557 · plotly/plotly.js

X Title: Remove the performance overhead of showLink property by hy9be · Pull Request #1557 · plotly/plotly.js

Description: Open-source JavaScript charting library behind Plotly and Dash - Remove the performance overhead of showLink property by hy9be · Pull Request #1557 · plotly/plotly.js

Open Graph Description: A fix for: #1554. Do nothing if showLink is set to be false, to avoid performance overhead caused by measuring and reflows.

X Description: A fix for: #1554. Do nothing if showLink is set to be false, to avoid performance overhead caused by measuring and reflows.

Opengraph URL: https://github.com/plotly/plotly.js/pull/1557

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1ec075ad-1556-6656-13d0-bc4e3c3acd6d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECD4:3ECAA9:2800E7:3443D8:6A5B8330
html-safe-noncec803b66d38a9158a374218e7b1d38e5f050356fbaa18758cf2c785eb0c7e3a0d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0Q0OjNFQ0FBOToyODAwRTc6MzQ0M0Q4OjZBNUI4MzMwIiwidmlzaXRvcl9pZCI6Ijg5ODk1MTg1OTg0NDk2Mjc5NTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6e0322cd1897659b88152eee65baa5342ca04628bf36e708201f3c0cc4851590
hovercard-subject-tagpull_request:114454533
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/1557/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/17b2c05742711cd7f42d9bbab0ed4af268b51705c96e4a31262c2cb0bffa293a/plotly/plotly.js/pull/1557
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/17b2c05742711cd7f42d9bbab0ed4af268b51705c96e4a31262c2cb0bffa293a/plotly/plotly.js/pull/1557
og:image:altA fix for: #1554. Do nothing if showLink is set to be false, to avoid performance overhead caused by measuring and reflows.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamehy9be
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/plotly/plotly.js/pull/1557#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1557
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1557
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/pull/1557
Reloadhttps://github.com/plotly/plotly.js/pull/1557
Reloadhttps://github.com/plotly/plotly.js/pull/1557
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
plotly https://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
Notifications https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Fork 2k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Star 18.3k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Code https://github.com/plotly/plotly.js
Issues 773 https://github.com/plotly/plotly.js/issues
Pull requests 58 https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality 0 https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
Code https://github.com/plotly/plotly.js
Issues https://github.com/plotly/plotly.js/issues
Pull requests https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
etpinardhttps://github.com/etpinard
plotly:masterhttps://github.com/plotly/plotly.js/tree/master
hy9be:perf-addLinkshttps://github.com/hy9be/plotly.js/tree/perf-addLinks
Conversationhttps://github.com/plotly/plotly.js/pull/1557
Commits6 (6)https://github.com/plotly/plotly.js/pull/1557/commits
Checkshttps://github.com/plotly/plotly.js/pull/1557/checks
Files changedhttps://github.com/plotly/plotly.js/pull/1557/files
Remove the performance overhead of showLink propertyhttps://github.com/plotly/plotly.js/pull/1557#top
etpinardhttps://github.com/etpinard
plotly:masterhttps://github.com/plotly/plotly.js/tree/master
hy9be:perf-addLinkshttps://github.com/hy9be/plotly.js/tree/perf-addLinks
https://github.com/hy9be
hy9behttps://github.com/hy9be
Apr 5, 2017https://github.com/plotly/plotly.js/pull/1557#issue-219690237
#1554https://github.com/plotly/plotly.js/issues/1554
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
hy9behttps://github.com/hy9be
April 5, 2017 15:26https://github.com/plotly/plotly.js/pull/1557#commits-pushed-d5a26a4
https://github.com/hy9be
Do nothing when showLink is set to be falsehttps://github.com/plotly/plotly.js/pull/1557/commits/d5a26a43d7d7b61ff7661ca160a65d00699b9356
d5a26a4https://github.com/plotly/plotly.js/pull/1557/commits/d5a26a43d7d7b61ff7661ca160a65d00699b9356
https://github.com/hy9be
Update unit test for showLinkhttps://github.com/plotly/plotly.js/pull/1557/commits/72a604cd3879d1c54bf2d9b09a0d018d989c65bb
72a604chttps://github.com/plotly/plotly.js/pull/1557/commits/72a604cd3879d1c54bf2d9b09a0d018d989c65bb
https://github.com/hy9be
Remove spaces as the CI check returns errorhttps://github.com/plotly/plotly.js/pull/1557/commits/69bc864971d64575d4c9390005bdd347be5fddbe
69bc864https://github.com/plotly/plotly.js/pull/1557/commits/69bc864971d64575d4c9390005bdd347be5fddbe
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 5, 2017 https://github.com/plotly/plotly.js/pull/1557#pullrequestreview-31182446
View reviewed changes https://github.com/plotly/plotly.js/pull/1557/files/69bc864971d64575d4c9390005bdd347be5fddbe
src/plots/plots.jshttps://github.com/plotly/plotly.js/pull/1557/files/69bc864971d64575d4c9390005bdd347be5fddbe#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970
etpinardhttps://github.com/etpinard
Apr 5, 2017https://github.com/plotly/plotly.js/pull/1557#discussion_r110039327
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
showSourceshttps://github.com/plotly/plotly.js/blob/ce06ea9cea377c5ed87ed7baa088a14a1997dbb7/src/plot_api/plot_config.js#L67
belowhttps://github.com/plotly/plotly.js/blob/ce06ea9cea377c5ed87ed7baa088a14a1997dbb7/src/plots/plots.js#L308
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
hy9behttps://github.com/hy9be
Apr 6, 2017https://github.com/plotly/plotly.js/pull/1557#discussion_r110167287
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
https://github.com/etpinard
etpinardhttps://github.com/etpinard
status: in progress https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22
Apr 5, 2017https://github.com/plotly/plotly.js/pull/1557#event-1031239080
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 5, 2017 https://github.com/plotly/plotly.js/pull/1557#ref-issue-219636268
plots.addLinks is still called even set { showLink: false } #1554 https://github.com/plotly/plotly.js/issues/1554
https://github.com/hy9be
Handle showSource confighttps://github.com/plotly/plotly.js/pull/1557/commits/5bd40955e240f6c714a2c10f73d3743255404758
5bd4095https://github.com/plotly/plotly.js/pull/1557/commits/5bd40955e240f6c714a2c10f73d3743255404758
https://github.com/hy9be
hy9behttps://github.com/hy9be
Apr 6, 2017https://github.com/plotly/plotly.js/pull/1557#issuecomment-292181011
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 6, 2017https://github.com/plotly/plotly.js/pull/1557#issuecomment-292191422
https://cloud.githubusercontent.com/assets/6675409/24759480/93ce07b2-1ab3-11e7-9eb4-2a12bed43a6f.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
https://github.com/hy9be
hy9behttps://github.com/hy9be
Apr 6, 2017https://github.com/plotly/plotly.js/pull/1557#issuecomment-292249940
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
Change the OR conditon to AND for triggering addLinks logichttps://github.com/plotly/plotly.js/pull/1557/commits/7636cb531a5f0cf3599e5bf24293bc6e1e2a3366
7636cb5https://github.com/plotly/plotly.js/pull/1557/commits/7636cb531a5f0cf3599e5bf24293bc6e1e2a3366
https://github.com/hy9be
hy9behttps://github.com/hy9be
Apr 6, 2017https://github.com/plotly/plotly.js/pull/1557#issuecomment-292289684
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
https://github.com/hy9be
hy9behttps://github.com/hy9be
Apr 6, 2017https://github.com/plotly/plotly.js/pull/1557#issuecomment-292312421
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
https://cloud.githubusercontent.com/assets/3392907/24774732/0b311e32-1ae8-11e7-931d-3181185c9d62.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 6, 2017https://github.com/plotly/plotly.js/pull/1557#issuecomment-292322121
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
https://github.com/hy9be
hy9behttps://github.com/hy9be
Apr 6, 2017https://github.com/plotly/plotly.js/pull/1557#issuecomment-292332723
https://cloud.githubusercontent.com/assets/3392907/24776792/5f0dcc96-1af0-11e7-8353-1b242f885d6a.png
https://cloud.githubusercontent.com/assets/3392907/24776796/66f5bf04-1af0-11e7-9db3-fe88dbc441b0.png
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
https://github.com/hy9be
hy9behttps://github.com/hy9be
Apr 7, 2017https://github.com/plotly/plotly.js/pull/1557#event-1034333574
https://github.com/hy9be
hy9behttps://github.com/hy9be
Apr 7, 2017https://github.com/plotly/plotly.js/pull/1557#event-1034333636
https://github.com/hy9be
Add commentshttps://github.com/plotly/plotly.js/pull/1557/commits/603656cc737f2f43d5fbcc271ad1e8a334c5b32c
603656chttps://github.com/plotly/plotly.js/pull/1557/commits/603656cc737f2f43d5fbcc271ad1e8a334c5b32c
https://github.com/hy9be
hy9behttps://github.com/hy9be
Apr 7, 2017https://github.com/plotly/plotly.js/pull/1557#issuecomment-292580811
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
https://github.com/etpinard
etpinardhttps://github.com/etpinard
status: reviewable https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22
status: in progress https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22
Apr 7, 2017https://github.com/plotly/plotly.js/pull/1557#event-1034530559
https://github.com/etpinard
etpinardhttps://github.com/etpinard
v1.26.0https://github.com/plotly/plotly.js/milestone/19
Apr 7, 2017https://github.com/plotly/plotly.js/pull/1557#event-1034530631
https://github.com/etpinard
etpinardhttps://github.com/etpinard
Apr 7, 2017https://github.com/plotly/plotly.js/pull/1557#issuecomment-292608597
@hy9behttps://github.com/hy9be
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
https://github.com/etpinard
etpinardhttps://github.com/etpinard
9e9d756https://github.com/plotly/plotly.js/commit/9e9d756c5714cf4a0381625a55e8e8d517d4b7ea
Apr 7, 2017https://github.com/plotly/plotly.js/pull/1557#event-1034531177
https://github.com/hy9be
hy9behttps://github.com/hy9be
Apr 11, 2017 https://github.com/plotly/plotly.js/pull/1557#ref-pullrequest-221082306
Misc performance optimization #1585 https://github.com/plotly/plotly.js/pull/1585
https://github.co/hiddenchars
https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1557
https://github.com/etpinard
etpinard https://github.com/etpinard
https://github.com/plotly/plotly.js/pull/1557/files/69bc864971d64575d4c9390005bdd347be5fddbe
v1.26.0 https://github.com/plotly/plotly.js/milestone/19
Please reload this pagehttps://github.com/plotly/plotly.js/pull/1557
https://github.com/hy9be
https://github.com/etpinard
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.