| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:40a0913a-67b6-0e68-dff7-11354b3d2b9e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E57A:2F6413:1C14E85:2463E10:6A5C7198 |
| html-safe-nonce | 58f523d24f3a4d68e5225e6cb9a3cf1b636ee3c58b7f5d6bac7526bfd0f513fb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTdBOjJGNjQxMzoxQzE0RTg1OjI0NjNFMTA6NkE1QzcxOTgiLCJ2aXNpdG9yX2lkIjoiNzI0OTMwMzg4ODU1ODA1OTkyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 38fc55b338c3bfdc44dbe7e2ff51b4282fe965b9b97e61d3642848dbc60e06f8 |
| hovercard-subject-tag | pull_request:113736984 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/1544/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9a1c767e35d2cf96adddb5db87086577874902d8be6f1d8b5197438be8d60a4d/plotly/plotly.js/pull/1544 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9a1c767e35d2cf96adddb5db87086577874902d8be6f1d8b5197438be8d60a4d/plotly/plotly.js/pull/1544 |
| og:image:alt | I added an auxiliary map for ax._categories array to avoid using Array.prototype.indexOf function searching for the existence of a category.
I tested here and observed ~20% performance improvements... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | hy9be |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9c975978430e9ad293956f2bbdaf153b1bd84a99 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/1544#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1544 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1544 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/1544 |
| Reload | https://github.com/plotly/plotly.js/pull/1544 |
| Reload | https://github.com/plotly/plotly.js/pull/1544 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
773
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
59
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| alexcjohnson | https://github.com/alexcjohnson |
| plotly:master | https://github.com/plotly/plotly.js/tree/master |
| hy9be:perf-setcategoryindex | https://github.com/hy9be/plotly.js/tree/perf-setcategoryindex |
| Conversation | https://github.com/plotly/plotly.js/pull/1544 |
| Commits13 (13) | https://github.com/plotly/plotly.js/pull/1544/commits |
| Checks | https://github.com/plotly/plotly.js/pull/1544/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/1544/files |
| Optimize performance of setCategoryIndex | https://github.com/plotly/plotly.js/pull/1544#top |
| alexcjohnson | https://github.com/alexcjohnson |
| plotly:master | https://github.com/plotly/plotly.js/tree/master |
| hy9be:perf-setcategoryindex | https://github.com/hy9be/plotly.js/tree/perf-setcategoryindex |
|
| https://github.com/hy9be |
| hy9be | https://github.com/hy9be |
| Mar 31, 2017 | https://github.com/plotly/plotly.js/pull/1544#issue-218622725 |
| here | https://jsfiddle.net/smileyhaowen/cvLzxz7L/2/ |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| hy9be | https://github.com/hy9be |
| March 31, 2017 16:56 | https://github.com/plotly/plotly.js/pull/1544#commits-pushed-40e69d3 |
|
| https://github.com/hy9be |
| Optimize performance of setCategoryIndex | https://github.com/plotly/plotly.js/pull/1544/commits/40e69d39ebd4ee0f28918d58c738c9f19eaf4a2c |
| 40e69d3 | https://github.com/plotly/plotly.js/pull/1544/commits/40e69d39ebd4ee0f28918d58c738c9f19eaf4a2c |
| https://jsfiddle.net/smileyhaowen/cvLzxz7L/2/ | https://jsfiddle.net/smileyhaowen/cvLzxz7L/2/ |
|
| https://github.com/hy9be |
| Update unit test | https://github.com/plotly/plotly.js/pull/1544/commits/b47c7afb6bf851cf2ddb87f34436c210b8cf7051 |
| b47c7af | https://github.com/plotly/plotly.js/pull/1544/commits/b47c7afb6bf851cf2ddb87f34436c210b8cf7051 |
| https://github.com/hy9be |
| hy9be | https://github.com/hy9be |
|
Mar 31, 2017
| https://github.com/plotly/plotly.js/pull/1544#ref-issue-218232612 |
|
Suboptimal performance when rendering large amount of traces
#1535
| https://github.com/plotly/plotly.js/issues/1535 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Mar 31, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-290837751 |
| @hy9be | https://github.com/hy9be |
| https://cloud.githubusercontent.com/assets/6675409/24570433/6d169f22-1639-11e7-80b5-58decdd34939.png |
| README | https://github.com/plotly/plotly.js/blob/master/test/image/README.md |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://github.com/hy9be |
| hy9be | https://github.com/hy9be |
| Mar 31, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-290838020 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Mar 31, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-290838022 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://github.com/hy9be |
| hy9be | https://github.com/hy9be |
| Mar 31, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-290858405 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
status: in progress
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20in%20progress%22 |
| Apr 3, 2017 | https://github.com/plotly/plotly.js/pull/1544#event-1026436288 |
| https://github.com/hy9be |
| hy9be | https://github.com/hy9be |
| Apr 3, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-291195237 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Apr 3, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-291196167 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://github.com/hy9be |
| hy9be | https://github.com/hy9be |
| Apr 3, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-291196396 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| hy9be | https://github.com/hy9be |
| April 3, 2017 18:45 | https://github.com/plotly/plotly.js/pull/1544#commits-pushed-e8941d6 |
|
| https://github.com/hy9be |
| Refactor the changes | https://github.com/plotly/plotly.js/pull/1544/commits/e8941d6367dd138e54d9c89aecd8caf824c1af16 |
| e8941d6 | https://github.com/plotly/plotly.js/pull/1544/commits/e8941d6367dd138e54d9c89aecd8caf824c1af16 |
|
| https://github.com/hy9be |
| Build the lookup map for initialized categories | https://github.com/plotly/plotly.js/pull/1544/commits/b3fb03d45b8b46fb81e0e7c6e8530d50d8f1f83e |
| b3fb03d | https://github.com/plotly/plotly.js/pull/1544/commits/b3fb03d45b8b46fb81e0e7c6e8530d50d8f1f83e |
|
| https://github.com/hy9be |
| Reset the lookup map when the categories are reset | https://github.com/plotly/plotly.js/pull/1544/commits/2992126c335b2182e00f6b69732ae0edb6a020d7 |
| 2992126 | https://github.com/plotly/plotly.js/pull/1544/commits/2992126c335b2182e00f6b69732ae0edb6a020d7 |
| https://github.com/hy9be |
| hy9be | https://github.com/hy9be |
| Apr 3, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-291311930 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| @etpinard | https://github.com/etpinard |
| https://github.com/plotly/plotly.js/blob/master/test/jasmine/tests/axes_test.js#L1853-L1877 | https://github.com/plotly/plotly.js/blob/master/test/jasmine/tests/axes_test.js#L1853-L1877 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 5, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-291909204 |
| https://github.com/plotly/plotly.js/blob/master/test/jasmine/tests/axes_test.js#L1853-L1877 | https://github.com/plotly/plotly.js/blob/master/test/jasmine/tests/axes_test.js#L1853-L1877 |
| https://plot.ly/javascript/axes/#enumerated-ticks-with-tickvals-and-ticktext | https://plot.ly/javascript/axes/#enumerated-ticks-with-tickvals-and-ticktext |
| https://cloud.githubusercontent.com/assets/2678795/24714479/a6b46ba4-19f6-11e7-8db6-06814e3a372b.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
|
| https://github.com/hy9be |
| Optimize the scatter trace sorting comparator with map | https://github.com/plotly/plotly.js/pull/1544/commits/989f07a67091733f9b1621de48fee6ea6660142c |
| 989f07a | https://github.com/plotly/plotly.js/pull/1544/commits/989f07a67091733f9b1621de48fee6ea6660142c |
| https://github.com/hy9be |
| hy9be | https://github.com/hy9be |
| Apr 5, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-291931159 |
| @alexcjohnson | https://github.com/alexcjohnson |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| hy9be | https://github.com/hy9be |
| April 8, 2017 12:48 | https://github.com/plotly/plotly.js/pull/1544#commits-pushed-91cfaa4 |
|
| https://github.com/hy9be |
| Merge remote-tracking branch 'origin/master' into perf-setcategoryindex | https://github.com/plotly/plotly.js/pull/1544/commits/91cfaa42ed987eb745da06d5ef75a68936a7cb35 |
| 91cfaa4 | https://github.com/plotly/plotly.js/pull/1544/commits/91cfaa42ed987eb745da06d5ef75a68936a7cb35 |
|
| https://github.com/hy9be |
| Clean ESLint errors in CI | https://github.com/plotly/plotly.js/pull/1544/commits/abcd729299f735e37391306e7abb8fb2ace66b4b |
| abcd729 | https://github.com/plotly/plotly.js/pull/1544/commits/abcd729299f735e37391306e7abb8fb2ace66b4b |
|
| https://github.com/hy9be |
| getCategoryIndex falls back to the former implementation to fix the f… | https://github.com/plotly/plotly.js/pull/1544/commits/153f547810a48c408fa32a08808ba6bef40e075b |
| 153f547 | https://github.com/plotly/plotly.js/pull/1544/commits/153f547810a48c408fa32a08808ba6bef40e075b |
|
| https://github.com/hy9be |
| Fix another problem in getCategoryIndex | https://github.com/plotly/plotly.js/pull/1544/commits/ff043b458a6e6d95dc26399bc9f6a92486571880 |
| ff043b4 | https://github.com/plotly/plotly.js/pull/1544/commits/ff043b458a6e6d95dc26399bc9f6a92486571880 |
| https://github.com/hy9be |
| hy9be | https://github.com/hy9be |
| Apr 8, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-292742235 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://cloud.githubusercontent.com/assets/3392907/24832029/fa580dbc-1c74-11e7-8c24-249b85d30bc0.png |
| https://cloud.githubusercontent.com/assets/3392907/24832026/efb02f48-1c74-11e7-8610-a43a2605de34.png |
| https://cloud.githubusercontent.com/assets/3392907/24832074/c1f5a938-1c75-11e7-94fa-7b4edf64e0b5.png |
| https://cloud.githubusercontent.com/assets/3392907/24832076/ca5a81fc-1c75-11e7-8495-234e77bf7073.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
|
| https://github.com/hy9be |
| Add comments | https://github.com/plotly/plotly.js/pull/1544/commits/c32163e63babdea0fe1d018dcb5254e6279f1bd0 |
| c32163e | https://github.com/plotly/plotly.js/pull/1544/commits/c32163e63babdea0fe1d018dcb5254e6279f1bd0 |
| https://github.com/hy9be |
| hy9be | https://github.com/hy9be |
| Apr 8, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-292742353 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 8, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-292748387 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Apr 8, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-292750878 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://github.com/hy9be |
| hy9be | https://github.com/hy9be |
| Apr 9, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-292803265 |
| @rreusser | https://github.com/rreusser |
| https://cloud.githubusercontent.com/assets/3392907/24839903/e4adeb5a-1d30-11e7-85de-53e40d306b47.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 10, 2017 | https://github.com/plotly/plotly.js/pull/1544#issuecomment-292842951 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Apr 10, 2017
| https://github.com/plotly/plotly.js/pull/1544#pullrequestreview-31750632 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1544/files/153f547810a48c408fa32a08808ba6bef40e075b |
| src/plots/cartesian/set_convert.js | https://github.com/plotly/plotly.js/pull/1544/files/abcd729299f735e37391306e7abb8fb2ace66b4b..153f547810a48c408fa32a08808ba6bef40e075b#diff-10cca8c9eea1420164e53bbf7ed6b1bef79c17ad4116f5ecc079ed72f725da64 |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 10, 2017 | https://github.com/plotly/plotly.js/pull/1544#discussion_r110568785 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| the mock ax object | https://github.com/plotly/plotly.js/blob/master/test/jasmine/tests/axes_test.js#L1854-L1862 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| hy9be | https://github.com/hy9be |
| Apr 10, 2017 | https://github.com/plotly/plotly.js/pull/1544#discussion_r110704542 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 10, 2017 | https://github.com/plotly/plotly.js/pull/1544#discussion_r110719057 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
|
| https://github.com/hy9be |
| Remove the fallback to indexOf search in getCategoryIndex, update the… | https://github.com/plotly/plotly.js/pull/1544/commits/d2be6c94f3291c42666bf5c3f086968f42010ba2 |
| d2be6c9 | https://github.com/plotly/plotly.js/pull/1544/commits/d2be6c94f3291c42666bf5c3f086968f42010ba2 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Apr 10, 2017
| https://github.com/plotly/plotly.js/pull/1544#pullrequestreview-31910258 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1544/files/d2be6c94f3291c42666bf5c3f086968f42010ba2 |
| src/plots/cartesian/set_convert.js | https://github.com/plotly/plotly.js/pull/1544/files/c32163e63babdea0fe1d018dcb5254e6279f1bd0..d2be6c94f3291c42666bf5c3f086968f42010ba2#diff-10cca8c9eea1420164e53bbf7ed6b1bef79c17ad4116f5ecc079ed72f725da64 |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 10, 2017 | https://github.com/plotly/plotly.js/pull/1544#discussion_r110717608 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| comment above this | https://github.com/plotly/plotly.js/pull/1544/commits/d2be6c94f3291c42666bf5c3f086968f42010ba2#diff-bddbbac00596941548be19d6840c720aL151 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| hy9be | https://github.com/hy9be |
| Apr 10, 2017 | https://github.com/plotly/plotly.js/pull/1544#discussion_r110747252 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 10, 2017 | https://github.com/plotly/plotly.js/pull/1544#discussion_r110752595 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| hy9be | https://github.com/hy9be |
| Apr 10, 2017 | https://github.com/plotly/plotly.js/pull/1544#discussion_r110769718 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| jsperf | https://jsperf.com/check-null-overhead/1 |
| https://cloud.githubusercontent.com/assets/3392907/24883737/3f929f8c-1e14-11e7-922e-f8719605097a.png |
| https://cloud.githubusercontent.com/assets/3392907/24883693/0f89de40-1e14-11e7-8aec-69fd77275a84.png |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 10, 2017 | https://github.com/plotly/plotly.js/pull/1544#discussion_r110789283 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @hy9be | https://github.com/hy9be |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
| hy9be | https://github.com/hy9be |
| Apr 11, 2017 | https://github.com/plotly/plotly.js/pull/1544#discussion_r110796647 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @alexcjohnson | https://github.com/alexcjohnson |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
|
| https://github.com/hy9be |
| Remove out of date comments | https://github.com/plotly/plotly.js/pull/1544/commits/14d66495c2f3f889856ae0db7513012904835038 |
| 14d6649 | https://github.com/plotly/plotly.js/pull/1544/commits/14d66495c2f3f889856ae0db7513012904835038 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| 630816f | https://github.com/plotly/plotly.js/commit/630816ffab3a642bbfcf000113ffc0bc85a1ceac |
| Apr 10, 2017 | https://github.com/plotly/plotly.js/pull/1544#event-1037420173 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| v1.26.0 | https://github.com/plotly/plotly.js/milestone/19 |
| Apr 11, 2017 | https://github.com/plotly/plotly.js/pull/1544#event-1037437553 |
| https://github.com/hy9be |
| hy9be | https://github.com/hy9be |
|
Apr 11, 2017
| https://github.com/plotly/plotly.js/pull/1544#ref-pullrequest-221082306 |
|
Misc performance optimization
#1585
| https://github.com/plotly/plotly.js/pull/1585 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1544 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/1544/files/d2be6c94f3291c42666bf5c3f086968f42010ba2 |
|
v1.26.0
| https://github.com/plotly/plotly.js/milestone/19 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1544 |
|
| https://github.com/hy9be |
|
| https://github.com/etpinard |
|
| https://github.com/alexcjohnson |
|
| https://github.com/rreusser |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |