| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6f412cfe-4b0f-63ae-1026-e5a56c5a91a2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9406:26EB7:1CBB42F:29B2773:6A57992A |
| html-safe-nonce | 65b82784b581ee11dcf336fb1a0def577322e5a29d34a7947dc1705c6de5433d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDA2OjI2RUI3OjFDQkI0MkY6MjlCMjc3Mzo2QTU3OTkyQSIsInZpc2l0b3JfaWQiOiI2NTEwOTgxMzU4MDU5NzU1ODE4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 958bc67c738322f561aa8c0266eec3d1a7bf7756b6f9a6d60793173ffd7f9056 |
| hovercard-subject-tag | pull_request:113723016 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/1543/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f5aa553dbd0ef23574439aafc30b77ffc68af519c849730b8d7d5e51045adfa7/plotly/plotly.js/pull/1543 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f5aa553dbd0ef23574439aafc30b77ffc68af519c849730b8d7d5e51045adfa7/plotly/plotly.js/pull/1543 |
| og:image:alt | to be merged in #1538 - fixing the test failures there.
In brief, this PR:
makes scattermapbox/calc.js reuse scattergeo/calc.js ♻️
🔪 the last remaining signs of calcdata placeholder
bumps mapbox-g... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | etpinard |
| hostname | github.com |
| expected-hostname | github.com |
| None | a87fc68e9bdf22e1c7e48ac6a60b98882f4bb103314b3f26b3460c61fc5441ae |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a2198d0212ed703af207673eb4d0868d4f867a5b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/1543#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1543 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1543 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/1543 |
| Reload | https://github.com/plotly/plotly.js/pull/1543 |
| Reload | https://github.com/plotly/plotly.js/pull/1543 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1543 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1543 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
772
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
59
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| etpinard | https://github.com/etpinard |
| scattergeo-badnum | https://github.com/plotly/plotly.js/tree/scattergeo-badnum |
| scattermapbox-badnum | https://github.com/plotly/plotly.js/tree/scattermapbox-badnum |
| Conversation | https://github.com/plotly/plotly.js/pull/1543 |
| Commits6 (6) | https://github.com/plotly/plotly.js/pull/1543/commits |
| Checks | https://github.com/plotly/plotly.js/pull/1543/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/1543/files |
| Scattermapbox BADNUM + mapbox-gl@0.33.1 | https://github.com/plotly/plotly.js/pull/1543#top |
| etpinard | https://github.com/etpinard |
| scattergeo-badnum | https://github.com/plotly/plotly.js/tree/scattergeo-badnum |
| scattermapbox-badnum | https://github.com/plotly/plotly.js/tree/scattermapbox-badnum |
|
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Mar 31, 2017 | https://github.com/plotly/plotly.js/pull/1543#issue-218603967 |
| #1538 | https://github.com/plotly/plotly.js/pull/1538 |
| ^0.33.1 | https://github.com/mapbox/mapbox-gl-js/blob/master/CHANGELOG.md#0331-march-10-2017 |
| identity | https://www.mapbox.com/mapbox-gl-js/example/data-driven-lines/ |
| here | https://gist.github.com/etpinard/5d58ef47d65d65cd1e93d825659936af#news |
| @bpostlethwaite | https://github.com/bpostlethwaite |
| broken | https://github.com/mapbox/mapbox-gl-js/pull/4486/ |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1543 |
| etpinard | https://github.com/etpinard |
| March 31, 2017 14:30 | https://github.com/plotly/plotly.js/pull/1543#commits-pushed-1196fd3 |
|
| https://github.com/etpinard |
| flatten scattegeo_test.js | https://github.com/plotly/plotly.js/pull/1543/commits/1196fd3a780808d451dd8a6517c1794eb4fac6c0 |
| 1196fd3 | https://github.com/plotly/plotly.js/pull/1543/commits/1196fd3a780808d451dd8a6517c1794eb4fac6c0 |
|
| https://github.com/etpinard |
| set lonlat to [BADNUM, BADNUM] if lon OR lat is non-numeric | https://github.com/plotly/plotly.js/pull/1543/commits/2a91da672fbed5023849da99b9c9ad8f24b4e896 |
| 2a91da6 | https://github.com/plotly/plotly.js/pull/1543/commits/2a91da672fbed5023849da99b9c9ad8f24b4e896 |
|
| https://github.com/etpinard |
| only need to check lonlat[0] === BADNUM | https://github.com/plotly/plotly.js/pull/1543/commits/28d94da4530c76c25fec9e91ee3e9a99c972d45a |
| 28d94da | https://github.com/plotly/plotly.js/pull/1543/commits/28d94da4530c76c25fec9e91ee3e9a99c972d45a |
|
| https://github.com/etpinard |
| bump mapbox-gl to 0.33.1 | https://github.com/plotly/plotly.js/pull/1543/commits/da7748c454441498265f491b688fd7fea85a1717 |
| da7748c | https://github.com/plotly/plotly.js/pull/1543/commits/da7748c454441498265f491b688fd7fea85a1717 |
|
| https://github.com/etpinard |
| refactor scattermapbox calc & convert steps | https://github.com/plotly/plotly.js/pull/1543/commits/1ca15262251e911cc260e06857104b2c23140005 |
| 1ca1526 | https://github.com/plotly/plotly.js/pull/1543/commits/1ca15262251e911cc260e06857104b2c23140005 |
|
| https://github.com/etpinard |
| 🔪 last remaining signs of placeholder key in calcdata | https://github.com/plotly/plotly.js/pull/1543/commits/7dabdd03c00b2956f6074e0b7fe4a3c760fd4731 |
| 7dabdd0 | https://github.com/plotly/plotly.js/pull/1543/commits/7dabdd03c00b2956f6074e0b7fe4a3c760fd4731 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
|
bug
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug |
| Mar 31, 2017 | https://github.com/plotly/plotly.js/pull/1543#event-1024698237 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| v1.26.0 | https://github.com/plotly/plotly.js/milestone/19 |
| Mar 31, 2017 | https://github.com/plotly/plotly.js/pull/1543#event-1024698244 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Mar 31, 2017
| https://github.com/plotly/plotly.js/pull/1543#ref-pullrequest-218320527 |
|
Scattergeo BADNUM
#1538
| https://github.com/plotly/plotly.js/pull/1538 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
|
Apr 3, 2017
| https://github.com/plotly/plotly.js/pull/1543#pullrequestreview-30524841 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1543/files/7dabdd03c00b2956f6074e0b7fe4a3c760fd4731 |
| src/plots/plots.js | https://github.com/plotly/plotly.js/pull/1543/files/7dabdd03c00b2956f6074e0b7fe4a3c760fd4731#diff-bb59a2aa90fd14ef3218544010e7fe42f370e10f0c8ee702b3f85ab86887d970 |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 3, 2017 | https://github.com/plotly/plotly.js/pull/1543#discussion_r109424804 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1543 |
| etpinard | https://github.com/etpinard |
| Apr 3, 2017 | https://github.com/plotly/plotly.js/pull/1543#discussion_r109425282 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1543 |
| etpinard | https://github.com/etpinard |
| Apr 7, 2017 | https://github.com/plotly/plotly.js/pull/1543#discussion_r110429511 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| b5cd573 | https://github.com/plotly/plotly.js/commit/b5cd57308c60b584ba47ba93b35bb02efdd15418 |
| here | https://github.com/plotly/plotly.js/blob/master/src/components/legend/style.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1543 |
| https://github.com/alexcjohnson |
| alexcjohnson | https://github.com/alexcjohnson |
| Apr 3, 2017 | https://github.com/plotly/plotly.js/pull/1543#issuecomment-291166274 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1543 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Apr 7, 2017
| https://github.com/plotly/plotly.js/pull/1543#ref-pullrequest-220262834 |
|
Scattermapbox BADNUM (w/o upgrading mapbox-gl)
#1564
| https://github.com/plotly/plotly.js/pull/1564 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Apr 7, 2017 | https://github.com/plotly/plotly.js/pull/1543#issuecomment-292584415 |
| #1564 | https://github.com/plotly/plotly.js/pull/1564 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1543 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Apr 7, 2017 | https://github.com/plotly/plotly.js/pull/1543#event-1034396558 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| April 7, 2017 16:28 | https://github.com/plotly/plotly.js/pull/1543#event-1034396608 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
May 23, 2017
| https://github.com/plotly/plotly.js/pull/1543#ref-issue-230674599 |
|
Dependency Mapbox-gl requires outdated package
#1714
| https://github.com/plotly/plotly.js/issues/1714 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Nov 17, 2017
| https://github.com/plotly/plotly.js/pull/1543#ref-pullrequest-259649581 |
|
Update mapbox-gl requirement
#2029
| https://github.com/plotly/plotly.js/pull/2029 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1543 |
|
| https://github.com/alexcjohnson |
|
alexcjohnson
| https://github.com/alexcjohnson |
|
| https://github.com/plotly/plotly.js/pull/1543/files/7dabdd03c00b2956f6074e0b7fe4a3c760fd4731 |
|
bug
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3Abug |
|
v1.26.0
| https://github.com/plotly/plotly.js/milestone/19 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1543 |
|
| https://github.com/etpinard |
|
| https://github.com/alexcjohnson |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |