| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:13119115-65bc-5d54-7b89-18735723dd9c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C8C6:8F893:914B89:D3A982:6A57585C |
| html-safe-nonce | 53a3ebb66f6c372e39acf11d350e3d5f57945d018d2510c458def9503977b1c3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEM2OjhGODkzOjkxNEI4OTpEM0E5ODI6NkE1NzU4NUMiLCJ2aXNpdG9yX2lkIjoiNTk4MjQ3NDQ2OTY2NjkzNjkyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 63ea4e891298ad8efbcdee14a25a230db7792cce3acadd9f901bce5c4cdd09ff |
| hovercard-subject-tag | pull_request:95940844 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.js/1211/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/ee0eb5665c2bf38a7552f473f06f9e634cb49ab0b3e69821e91d12d7928439a4/plotly/plotly.js/pull/1211 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ee0eb5665c2bf38a7552f473f06f9e634cb49ab0b3e69821e91d12d7928439a4/plotly/plotly.js/pull/1211 |
| og:image:alt | resolves #666 (hopefully)
How good does this
feel?
cc @rreusser @n-riesco @alexcjohnson @monfera |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | etpinard |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98 |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 602250ea3b6dd8302a7220ef98adb828dbc807e4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/plotly/plotly.js/pull/1211#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1211 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1211 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.js |
| Reload | https://github.com/plotly/plotly.js/pull/1211 |
| Reload | https://github.com/plotly/plotly.js/pull/1211 |
| Reload | https://github.com/plotly/plotly.js/pull/1211 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1211 |
|
plotly
| https://github.com/plotly |
| plotly.js | https://github.com/plotly/plotly.js |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1211 |
|
Notifications
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Fork
2k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Star
18.3k
| https://github.com/login?return_to=%2Fplotly%2Fplotly.js |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
772
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
58
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
0
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
|
Code
| https://github.com/plotly/plotly.js |
|
Issues
| https://github.com/plotly/plotly.js/issues |
|
Pull requests
| https://github.com/plotly/plotly.js/pulls |
|
Actions
| https://github.com/plotly/plotly.js/actions |
|
Security and quality
| https://github.com/plotly/plotly.js/security |
|
Insights
| https://github.com/plotly/plotly.js/pulse |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| fix-citest-jasmine | https://github.com/plotly/plotly.js/tree/fix-citest-jasmine |
| Conversation | https://github.com/plotly/plotly.js/pull/1211 |
| Commits9 (9) | https://github.com/plotly/plotly.js/pull/1211/commits |
| Checks | https://github.com/plotly/plotly.js/pull/1211/checks |
| Files changed | https://github.com/plotly/plotly.js/pull/1211/files |
| Make citest-jasmine pass locally | https://github.com/plotly/plotly.js/pull/1211#top |
| etpinard | https://github.com/etpinard |
| master | https://github.com/plotly/plotly.js/tree/master |
| fix-citest-jasmine | https://github.com/plotly/plotly.js/tree/fix-citest-jasmine |
|
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Nov 30, 2016 | https://github.com/plotly/plotly.js/pull/1211#issue-192634015 |
| #666 | https://github.com/plotly/plotly.js/issues/666 |
| https://cloud.githubusercontent.com/assets/6675409/20764225/42c6c910-b6fb-11e6-933d-8f8de2d5c8bf.png |
| @rreusser | https://github.com/rreusser |
| @n-riesco | https://github.com/n-riesco |
| @alexcjohnson | https://github.com/alexcjohnson |
| @monfera | https://github.com/monfera |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1211 |
| etpinard | https://github.com/etpinard |
| November 29, 2016 18:11 | https://github.com/plotly/plotly.js/pull/1211#commits-pushed-3408b1e |
|
| https://github.com/etpinard |
| mapbox: don't try to emit 'plotly_relayout' after map.remove() | https://github.com/plotly/plotly.js/pull/1211/commits/3408b1ec365e0dec100e300451fe13598e275da1 |
| 3408b1e | https://github.com/plotly/plotly.js/pull/1211/commits/3408b1ec365e0dec100e300451fe13598e275da1 |
| http://codepen.io/etpinard/pen/ZBabVW | http://codepen.io/etpinard/pen/ZBabVW |
|
| https://github.com/etpinard |
| lint | https://github.com/plotly/plotly.js/pull/1211/commits/51f873ec93aaab5c9ef1bd28d13d1fc6e54b4499 |
| 51f873e | https://github.com/plotly/plotly.js/pull/1211/commits/51f873ec93aaab5c9ef1bd28d13d1fc6e54b4499 |
|
| https://github.com/etpinard |
| pass TIMEOUT_INTERVAL to mapbox cases | https://github.com/plotly/plotly.js/pull/1211/commits/b43cba4691dd0a79fdf37f6c1787ba992e0d10ae |
| b43cba4 | https://github.com/plotly/plotly.js/pull/1211/commits/b43cba4691dd0a79fdf37f6c1787ba992e0d10ae |
| jasmine/jasmine@68ba5b6 | https://github.com/jasmine/jasmine/commit/68ba5b6d48624c063b4eeae1bdd63c5aa84a3177 |
|
| https://github.com/etpinard |
| replace beforeEach-afterEach TIMEOUT_INTERVAL hack by it-arg | https://github.com/plotly/plotly.js/pull/1211/commits/8433627cb0288b62e44724f9bb08bf216638d9f0 |
| 8433627 | https://github.com/plotly/plotly.js/pull/1211/commits/8433627cb0288b62e44724f9bb08bf216638d9f0 |
| jasmine/jasmine@68ba5b6 | https://github.com/jasmine/jasmine/commit/68ba5b6d48624c063b4eeae1bdd63c5aa84a3177 |
|
| https://github.com/etpinard |
| bump event max listeners to remove console warnings | https://github.com/plotly/plotly.js/pull/1211/commits/133d71bb719e3feb2637485eb6e5123bd7b927bc |
| 133d71b | https://github.com/plotly/plotly.js/pull/1211/commits/133d71bb719e3feb2637485eb6e5123bd7b927bc |
|
| https://github.com/etpinard |
| set window size when running jasmine tests in FF | https://github.com/plotly/plotly.js/pull/1211/commits/86e0303c252b9783295bccd3f71c1a01a4b300ee |
| 86e0303 | https://github.com/plotly/plotly.js/pull/1211/commits/86e0303c252b9783295bccd3f71c1a01a4b300ee |
|
| https://github.com/etpinard |
| adjust hover label test to work in both Chrome and FF | https://github.com/plotly/plotly.js/pull/1211/commits/60573f6b008c8e26b06ccff08580a20748fa6616 |
| 60573f6 | https://github.com/plotly/plotly.js/pull/1211/commits/60573f6b008c8e26b06ccff08580a20748fa6616 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
status: reviewable
| https://github.com/plotly/plotly.js/issues?q=state%3Aopen%20label%3A%22status%3A%20reviewable%22 |
| Nov 30, 2016 | https://github.com/plotly/plotly.js/pull/1211#event-877249208 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Nov 30, 2016
| https://github.com/plotly/plotly.js/pull/1211#pullrequestreview-10809604 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1211/files/60573f6b008c8e26b06ccff08580a20748fa6616 |
| test/jasmine/tests/download_test.js | https://github.com/plotly/plotly.js/pull/1211/files/60573f6b008c8e26b06ccff08580a20748fa6616#diff-ff32f2f0869c6558b44fe949b4a4c67180381178e55f0f0a94415a4ad17c3b1b |
| etpinard | https://github.com/etpinard |
| Nov 30, 2016 | https://github.com/plotly/plotly.js/pull/1211#discussion_r90288053 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| jasmine/jasmine@68ba5b6 | https://github.com/jasmine/jasmine/commit/68ba5b6d48624c063b4eeae1bdd63c5aa84a3177 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1211 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
|
Nov 30, 2016
| https://github.com/plotly/plotly.js/pull/1211#pullrequestreview-10809830 |
|
View reviewed changes
| https://github.com/plotly/plotly.js/pull/1211/files/60573f6b008c8e26b06ccff08580a20748fa6616 |
| test/jasmine/tests/hover_label_test.js | https://github.com/plotly/plotly.js/pull/1211/files/60573f6b008c8e26b06ccff08580a20748fa6616#diff-cfd23075dfa021e046f24be2b4f2cf2ee1a8e86aeec566e4d66dea1c09218140 |
| etpinard | https://github.com/etpinard |
| Nov 30, 2016 | https://github.com/plotly/plotly.js/pull/1211#discussion_r90288312 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @alexcjohnson | https://github.com/alexcjohnson |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1211 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| Nov 30, 2016 | https://github.com/plotly/plotly.js/pull/1211#issuecomment-263944792 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1211 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1211 |
|
| https://github.com/etpinard |
| fix typo in heatmapgl attributes | https://github.com/plotly/plotly.js/pull/1211/commits/6886efbbbc37cf47cfd5b0a327eef90fc92db245 |
| 6886efb | https://github.com/plotly/plotly.js/pull/1211/commits/6886efbbbc37cf47cfd5b0a327eef90fc92db245 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Dec 1, 2016 | https://github.com/plotly/plotly.js/pull/1211#issuecomment-264315994 |
| updatemenus_test.js:569 | https://github.com/plotly/plotly.js/blame/fix-citest-jasmine/test/jasmine/tests/updatemenus_test.js#L569 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1211 |
| https://github.com/rreusser |
| rreusser | https://github.com/rreusser |
| Dec 1, 2016 | https://github.com/plotly/plotly.js/pull/1211#issuecomment-264323046 |
| @etpinard | https://github.com/etpinard |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1211 |
|
| https://github.com/etpinard |
| bump tolerance (for Ricky's computer) | https://github.com/plotly/plotly.js/pull/1211/commits/caea87ad2c06e5cfe0fca76aad02386b721efeac |
| caea87a | https://github.com/plotly/plotly.js/pull/1211/commits/caea87ad2c06e5cfe0fca76aad02386b721efeac |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| 2dbdf07 | https://github.com/plotly/plotly.js/commit/2dbdf0756887a3a587e55868610122fca70ff6b0 |
| Dec 1, 2016 | https://github.com/plotly/plotly.js/pull/1211#event-879301418 |
| https://github.com/etpinard |
| etpinard | https://github.com/etpinard |
| December 1, 2016 23:30 | https://github.com/plotly/plotly.js/pull/1211#event-879301440 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.js/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fpull%2F1211 |
|
npm run citest-jasmine fails locally
| https://github.com/plotly/plotly.js/issues/666 |
| Please reload this page | https://github.com/plotly/plotly.js/pull/1211 |
|
| https://github.com/etpinard |
|
| https://github.com/rreusser |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |