René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve 'relink private keys' steps","articleBody":"### Synopsis\r\n\r\nAt the moment, during `Plots.supplyDefaults` we loop over all keys found in the _old_ trace and layout containers in order to _relink_ all _private keys_ **not set** during the defaults step in the new trace and layout containers (remember, `fullData` and `fullLayout` start as empty `[]` and `{}` respectively in every `Plots.supplyDefaults` call).\r\n\r\nThese _private keys_ are linked to subplot instances (e.g `fullLayout.scene._scene`), computed values (e.g. `fullLayout.xaxis._m`), graph svg selections (e.g. `fullLayout._infolayer`) etc ...\r\n### In brief\r\n\r\nLooping over all keys is dumb, slow and hard to maintain ; we can do better!\r\n### Observations\r\n\r\nNot relinking private keys in trace objects results in:\r\n- geo trace visibility toggle not functioning (`_module` isn't defined anymore for `visible: false` traces)\r\n- contour restyle not working as `trace._emptypoints` isn't relinked\r\n\r\nNot relinking array container results in:\r\n- annotations not behaving correctly on zoom -\u003e double-click interactions\r\n### Possible solution\r\n\r\nMake the trace and base plot module (and possibly the component module) `clean` method relink the _sticky_ keys that need to be relinked during `Plots.supplyDefaults`.  This would make the `clean` methods handle all old container --\u003e new container logic in one go.\r\n\r\nFor example, most base plot modules have a  `clean` method that looks like:\r\n\r\n``` js\r\noldSubplotIds.forEach((id) =\u003e {\r\n  if(!newFullLayout[id]._subplot \u0026\u0026 !!oldFullLayout[id]._subplot) {\r\n     oldFullLayout[id]._subplot.destroy();\r\n     return;\r\n  }\r\n\r\n  // it would be then be easy to relink the active subplot objects here\r\n  newFullLayout[id]._subplot = oldFullLayout[id]._subplot;\r\n});\r\n```\r\n\r\nIt might be convenient to put private keys generated in [`makePlotFramework`](https://github.com/plotly/plotly.js/blob/7ae437bbbb81ec1f49fee7145fc796d64e688bc6/src/plot_api/plot_api.js#L2592) under one object in fullLayout (e.g  `fullLayout_base._toppaper`) to keep track of private keys more easily. \r\n","author":{"url":"https://github.com/etpinard","@type":"Person","name":"etpinard"},"datePublished":"2016-07-18T19:16:05.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/749/plotly.js/issues/749"}