Title: CircleCI publishes outdated `plot-schema.json` · Issue #3159 · plotly/plotly.js · GitHub
Open Graph Title: CircleCI publishes outdated `plot-schema.json` · Issue #3159 · plotly/plotly.js
X Title: CircleCI publishes outdated `plot-schema.json` · Issue #3159 · plotly/plotly.js
Description: Open-source JavaScript charting library behind Plotly and Dash - CircleCI publishes outdated `plot-schema.json` · Issue #3159 · plotly/plotly.js
Open Graph Description: Open-source JavaScript charting library behind Plotly and Dash - CircleCI publishes outdated `plot-schema.json` · Issue #3159 · plotly/plotly.js
X Description: Open-source JavaScript charting library behind Plotly and Dash - CircleCI publishes outdated `plot-schema.json` · Issue #3159 · plotly/plotly.js
Opengraph URL: https://github.com/plotly/plotly.js
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"CircleCI publishes outdated `plot-schema.json`","articleBody":"On CircleCI `publish` happens right after the `build` job.\r\n\r\nThe build job on the CI is `npm run cibuild` which doesn't update the `plot-schema.json`. We should update it either by:\r\n1. adding code to https://github.com/plotly/plotly.js/blob/master/tasks/cibundle.js \r\n2. creating a new task only for that purpose which would only be executed in the `publish` job.\r\n\r\nOption 1 adds 15 seconds to the build step. So I would favor option 2 since it can be runned in parallel.\r\n\r\n## Poor's man benchmark\r\n### master\r\n``` \r\n[antoine@newton:~/plotly/plotly.js]$ time npm run cibuild\r\n\r\n> plotly.js@1.41.3 cibuild /home/antoine/plotly/plotly.js\r\n> npm run preprocess && node tasks/cibundle.js\r\n\r\n###\r\n> plotly.js@1.41.3 preprocess /home/antoine/plotly/plotly.js\r\n> node tasks/preprocess.js\r\n\r\nok plotly-geo-assets.js\r\nok plotly.js\r\nok plotly.min.js\r\n\r\nreal 0m39.960s\r\nuser 0m59.195s\r\nsys 0m2.339s\r\n```\r\n### Option 1\r\n```\r\n[antoine@newton:~/plotly/plotly.js]$ time npm run cibuild\r\n\r\n> plotly.js@1.41.3 cibuild /home/antoine/plotly/plotly.js\r\n> npm run preprocess && node tasks/cibundle.js\r\n\r\n\r\n> plotly.js@1.41.3 preprocess /home/antoine/plotly/plotly.js\r\n> node tasks/preprocess.js\r\n\r\nok plotly-geo-assets.js\r\nok plotly-with-meta.js\r\nok plot-schema.json\r\nok plotly.js\r\nok plotly.min.js\r\n\r\nreal 0m53.048s\r\nuser 1m21.699s\r\nsys 0m3.376s\r\n```\r\n\r\n","author":{"url":"https://github.com/antoinerg","@type":"Person","name":"antoinerg"},"datePublished":"2018-10-25T18:19:14Z","url":"https://github.com/plotly/plotly.js/issues/3159"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/issues/:id(.:format) |
| route-controller | issues |
| route-action | show |
| fetch-nonce | v2:503f6907-f169-6c79-33c2-378da0182d12 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C612:31D532:F188C0:140F065:6B01D912 |
| html-safe-nonce | 770ca07d640c64bb5f1427c30473350e11ec454bacfb8e1a2e84d9049e2d4785 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjEyOjMxRDUzMjpGMTg4QzA6MTQwRjA2NTo2QjAxRDkxMiIsInZpc2l0b3JfaWQiOiIzMTgwOTU1MjAzMjk3OTkwOTMwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 09c569a6460c516a802f171d59427a0e461020283010f049e62045198bb6a4e6 |
| hovercard-subject-tag | repository:45646037 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/plotly/plotly.js/issues/3159 |
| twitter:image | https://opengraph.githubassets.com/57c90a5c507b7a2eb6579efb5bc579af0d74a853bc50c558b9dda8d7e24ca1dc/plotly/plotly.js |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/57c90a5c507b7a2eb6579efb5bc579af0d74a853bc50c558b9dda8d7e24ca1dc/plotly/plotly.js |
| og:image:alt | Open-source JavaScript charting library behind Plotly and Dash - CircleCI publishes outdated `plot-schema.json` · Issue #3159 · plotly/plotly.js |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width