Title: Automargin pipeline · Issue #2704 · plotly/plotly.js · GitHub
Open Graph Title: Automargin pipeline · Issue #2704 · plotly/plotly.js
X Title: Automargin pipeline · Issue #2704 · plotly/plotly.js
Description: Our automatic margin expansion system is a mess: components generally determine their sizes - and thus the amount they need to increase the margin - only while being drawn. So in order for the new margin to take effect, the component get...
Open Graph Description: Our automatic margin expansion system is a mess: components generally determine their sizes - and thus the amount they need to increase the margin - only while being drawn. So in order for the new ...
X Description: Our automatic margin expansion system is a mess: components generally determine their sizes - and thus the amount they need to increase the margin - only while being drawn. So in order for the new ...
Opengraph URL: https://github.com/plotly/plotly.js/issues/2704
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Automargin pipeline","articleBody":"Our automatic margin expansion system is a mess: components generally determine their sizes - and thus the amount they need to increase the margin - only while being drawn. So in order for the new margin to take effect, the component gets drawn, which updates the margin calculation, then all of these components need to be drawn again if the new margin is different from the old one. The situation is even worse for axis automargins, since axes are drawn later in the process, changes they make to the margins result in an entire redraw of the plot, ie nearly doubling the initial plot time.\r\n\r\nMuch better would be to separate out margin calculations from component drawing; that way we can determine all sizes before we draw anything, then each component need only be drawn once. The challenge with this is that these sizes depend on text bounding boxes, so in order for this not to add its own overhead we may need to create the text elements as part of the margin calculation step, stash them somewhere hidden, and then pull them back out during the drawing step and attach them to the component. Or perhaps the two steps are 1) component creation and sizing, 2) component positioning and updating?\r\n\r\nSome related discussion happened during #2681. See also #1988 and #2434.","author":{"url":"https://github.com/alexcjohnson","@type":"Person","name":"alexcjohnson"},"datePublished":"2018-06-06T16:53:38Z","url":"https://github.com/plotly/plotly.js/issues/2704"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:7fb0097c-83e1-b43d-91fb-af97710ef9f1 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B006:2454CC:216B8ED:2A5C6FF:6B017746 |
| html-safe-nonce | e8cf836b64f2900d70da185c380e8438bf7aa852b326db55d9b176b6c2b0929a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDA2OjI0NTRDQzoyMTZCOEVEOjJBNUM2RkY6NkIwMTc3NDYiLCJ2aXNpdG9yX2lkIjoiMTgzODA2NzQ3NTU3NzY2NTM1MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0a5bc2558efd16f714ce71298e85db50fdf115567e99f87314c2dd1f87f6d0ac |
| hovercard-subject-tag | issue:329951423 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/plotly/plotly.js/2704/issue_layout |
| twitter:image | https://opengraph.githubassets.com/63ab7e898b3ae82bddfe603c2ffbff814b4bd270283eba7cf8fddc78ac19871c/plotly/plotly.js/issues/2704 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/63ab7e898b3ae82bddfe603c2ffbff814b4bd270283eba7cf8fddc78ac19871c/plotly/plotly.js/issues/2704 |
| og:image:alt | Our automatic margin expansion system is a mess: components generally determine their sizes - and thus the amount they need to increase the margin - only while being drawn. So in order for the new ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | alexcjohnson |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width