Title: open items uncovered during Plotly.react push · Issue #2353 · plotly/plotly.js · GitHub
Open Graph Title: open items uncovered during Plotly.react push · Issue #2353 · plotly/plotly.js
X Title: open items uncovered during Plotly.react push · Issue #2353 · plotly/plotly.js
Description: Some rules that were good ideas before but become crucial with Plotly.react so that we recognize a non-change correctly: Never create new arrays in the supplyDefaults step - for example reshaping 1D to 2D arrays. That should be done in a...
Open Graph Description: Some rules that were good ideas before but become crucial with Plotly.react so that we recognize a non-change correctly: Never create new arrays in the supplyDefaults step - for example reshaping 1...
X Description: Some rules that were good ideas before but become crucial with Plotly.react so that we recognize a non-change correctly: Never create new arrays in the supplyDefaults step - for example reshaping 1...
Opengraph URL: https://github.com/plotly/plotly.js/issues/2353
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"open items uncovered during Plotly.react push","articleBody":"Some rules that were good ideas before but become crucial with `Plotly.react` so that we recognize a non-change correctly:\r\n- Never create new arrays in the `supplyDefaults` step - for example reshaping 1D to 2D arrays. That should be done in a `calc` step and NOT pushed back into `_fullData`.\r\n- Don't modify attributes after finishing `supplyDefaults`, unless you're going to push the results back to the input (`data`/`layout`) as well, like `autorange`/`range`.\r\n- When you're stashing things on `_full*`, always make `_private` attributes.\r\n\r\nMost of the instances of this are taken care of in #2341, but a few are open:\r\n- [ ] `tick0`, `dtick` -\u003e default filled in late (After SD) - also for tickmode=array, not needed at all\r\n- [ ] `camera` doesn’t push back into `_fullLlayout` after drag, only `layout`?\r\n- [ ] tests for `scatter3d` with uneven or missing x/y/z\r\n- [ ] tests for `surface` with uneven, missing, or ragged x/y/z\r\n- [x] `autocolorscale`: first time it gets set on, second time off - is that intentional? cauto sometimes shows a similar effect… see `gl3d_scatter-color-mono-and-palette` **resolved in:** https://github.com/plotly/plotly.js/pull/3341\r\n- [ ] `contourcarpet`: `zmin`/`zmax` get filled in (after `supplyDefaults`) but they aren't actually attributes of `contourcarpet`. They should be!\r\n- [ ] `autorange: 'reversed'` should get replaced in `layout` once it has been acted on. There's a polar mock where this doesn't happen until the second draw.","author":{"url":"https://github.com/alexcjohnson","@type":"Person","name":"alexcjohnson"},"datePublished":"2018-02-08T22:56:11.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/2353/plotly.js/issues/2353"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:98f5674e-37cf-ae45-0602-459fb0374211 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8620:8F893:FEBF7C:171E0DE:6A576E8D |
| html-safe-nonce | 27220e505ba07be47c713ab89e97568abd506662ecb42e7d61e7217d3ead1422 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NjIwOjhGODkzOkZFQkY3QzoxNzFFMERFOjZBNTc2RThEIiwidmlzaXRvcl9pZCI6IjE5ODAwNDcwNDI2OTQwNDk0MjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5836ac56acb78bd1ff9ebcaddadf3697de5db24c485cedac5c106ea8630c7ddd |
| hovercard-subject-tag | issue:295695362 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/plotly/plotly.js/2353/issue_layout |
| twitter:image | https://opengraph.githubassets.com/12ebf26ecaca9301dfd7d0347cc5e7e72d6cc647e329dbbc848411c08eb784ca/plotly/plotly.js/issues/2353 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/12ebf26ecaca9301dfd7d0347cc5e7e72d6cc647e329dbbc848411c08eb784ca/plotly/plotly.js/issues/2353 |
| og:image:alt | Some rules that were good ideas before but become crucial with Plotly.react so that we recognize a non-change correctly: Never create new arrays in the supplyDefaults step - for example reshaping 1... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | alexcjohnson |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98 |
| turbo-cache-control | no-preview |
| go-import | github.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 45646037 |
| octolytics-dimension-repository_nwo | plotly/plotly.js |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 45646037 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.js |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c0ca805e53f128ba1f966be1d3ccd81d0d1959c7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width