René's URL Explorer Experiment


Title: No longer possible to run tests for components which import plotly without a browser · Issue #1675 · plotly/plotly.js · GitHub

Open Graph Title: No longer possible to run tests for components which import plotly without a browser · Issue #1675 · plotly/plotly.js

X Title: No longer possible to run tests for components which import plotly without a browser · Issue #1675 · plotly/plotly.js

Description: Recently a change was made to svg_text_utils.js which instantiates a DOMParser at the top level of that module: plotly.js/src/lib/svg_text_utils.js Line 22 in ce970f1 var parser = new DOMParser(); . This has broken a number of tests I ha...

Open Graph Description: Recently a change was made to svg_text_utils.js which instantiates a DOMParser at the top level of that module: plotly.js/src/lib/svg_text_utils.js Line 22 in ce970f1 var parser = new DOMParser(); ...

X Description: Recently a change was made to svg_text_utils.js which instantiates a DOMParser at the top level of that module: plotly.js/src/lib/svg_text_utils.js Line 22 in ce970f1 var parser = new DOMParser(); ...

Opengraph URL: https://github.com/plotly/plotly.js/issues/1675

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"No longer possible to run tests for components which import plotly without a browser","articleBody":"Recently a change was made to _svg_text_utils.js_ which instantiates a DOMParser at the top level of that module: https://github.com/plotly/plotly.js/blob/ce970f112a8fff0d09909529be8a713f5d4f36cc/src/lib/svg_text_utils.js#L22.\r\n\r\nThis has broken a number of tests I have which do not use a browser (or jsdom etc..) because the DOMParser will be instantiated on import, giving the following:\r\n```\r\nvar parser = new DOMParser();\r\n                 ^\r\n\r\nReferenceError: DOMParser is not defined\r\n    at Object.\u003canonymous\u003e (/home/user/repo/node_modules/plotly.js/src/lib/svg_text_utils.js:22:18)\r\n...\r\n```\r\nFor now I've applied a very quick fix:\r\n```\r\nvar parser;\r\nfunction cachingParser() {\r\n  parser = parser === undefined ? new DOMParser(): parser;\r\n  return parser\r\n};\r\n...\r\nvar dom = cachingParser().parseFromString(skeleton, 'application/xml'),\r\n        childNode = dom.documentElement.firstChild;\r\n...\r\n```\r\nCan this be updated to something like the above? If not, then does the DOMParser really need to be at the top level?","author":{"url":"https://github.com/wayofthepie","@type":"Person","name":"wayofthepie"},"datePublished":"2017-05-11T21:45:01.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":3},"url":"https://github.com/1675/plotly.js/issues/1675"}

route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ff220a61-cd5d-cd76-4d38-5c07dd74047b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id91B6:151D81:69698A:8B27F2:6A5BDC56
html-safe-nonce6151c0329481ff9789d50d2456b897aed99a269b6f78551b8dcf1b6789c14528
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MUI2OjE1MUQ4MTo2OTY5OEE6OEIyN0YyOjZBNUJEQzU2IiwidmlzaXRvcl9pZCI6IjUxNTU4NDA5OTkxNzczMTMzNjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac38a91d476308cef5fd94215b62bedc9e5d6f4791e62c346454040596b562ca32
hovercard-subject-tagissue:228130234
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/plotly/plotly.js/1675/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7c0429cc2b220b44a629f647914491b12c8fd8bcf94acf0cc96e1b1402d727e9/plotly/plotly.js/issues/1675
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7c0429cc2b220b44a629f647914491b12c8fd8bcf94acf0cc96e1b1402d727e9/plotly/plotly.js/issues/1675
og:image:altRecently a change was made to svg_text_utils.js which instantiates a DOMParser at the top level of that module: plotly.js/src/lib/svg_text_utils.js Line 22 in ce970f1 var parser = new DOMParser(); ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewayofthepie
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-preview
go-importgithub.com/plotly/plotly.js git https://github.com/plotly/plotly.js.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id45646037
octolytics-dimension-repository_nwoplotly/plotly.js
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id45646037
octolytics-dimension-repository_network_root_nwoplotly/plotly.js
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/plotly/plotly.js/issues/1675#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fissues%2F1675
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.js%2Fissues%2F1675
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=plotly%2Fplotly.js
Reloadhttps://github.com/plotly/plotly.js/issues/1675
Reloadhttps://github.com/plotly/plotly.js/issues/1675
Reloadhttps://github.com/plotly/plotly.js/issues/1675
Please reload this pagehttps://github.com/plotly/plotly.js/issues/1675
plotly https://github.com/plotly
plotly.jshttps://github.com/plotly/plotly.js
Please reload this pagehttps://github.com/plotly/plotly.js/issues/1675
Notifications https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Fork 2k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Star 18.3k https://github.com/login?return_to=%2Fplotly%2Fplotly.js
Code https://github.com/plotly/plotly.js
Issues 773 https://github.com/plotly/plotly.js/issues
Pull requests 58 https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality 0 https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
Code https://github.com/plotly/plotly.js
Issues https://github.com/plotly/plotly.js/issues
Pull requests https://github.com/plotly/plotly.js/pulls
Actions https://github.com/plotly/plotly.js/actions
Security and quality https://github.com/plotly/plotly.js/security
Insights https://github.com/plotly/plotly.js/pulse
#1683https://github.com/plotly/plotly.js/pull/1683
No longer possible to run tests for components which import plotly without a browserhttps://github.com/plotly/plotly.js/issues/1675#top
#1683https://github.com/plotly/plotly.js/pull/1683
https://github.com/wayofthepie
wayofthepiehttps://github.com/wayofthepie
on May 11, 2017https://github.com/plotly/plotly.js/issues/1675#issue-228130234
plotly.js/src/lib/svg_text_utils.jshttps://github.com/plotly/plotly.js/blob/ce970f112a8fff0d09909529be8a713f5d4f36cc/src/lib/svg_text_utils.js#L22
ce970f1https://github.com/plotly/plotly.js/commit/ce970f112a8fff0d09909529be8a713f5d4f36cc
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.