| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8980534a-1726-a46e-011a-231dd94f7b4c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8A32:EA06E:12EBEC5:1839654:6B010CF1 |
| html-safe-nonce | 54b8be45275bea69837b5bffe780703b1404085bedca0eccaa9af27b2900545c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTMyOkVBMDZFOjEyRUJFQzU6MTgzOTY1NDo2QjAxMENGMSIsInZpc2l0b3JfaWQiOiIyMzEzMDM0ODI2MzcxODk0NTEzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | b54e7e5ce173d25e95ec55adf05c98d45f82ec28c5a4b62cb01c43e55947314e |
| hovercard-subject-tag | pull_request:1546091334 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.R/2301/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/25e72ce5507de8885fcd3fe1e8155b3602a91d3f3d755bde57c43280ebc36581/plotly/plotly.R/pull/2301 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/25e72ce5507de8885fcd3fe1e8155b3602a91d3f3d755bde57c43280ebc36581/plotly/plotly.R/pull/2301 |
| og:image:alt | This is just a draft for now -- starting a PR to get visual testing results back
TODO
Double-check these fixes work well with CRAN version of ggplot2 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cpsievert |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.R git https://github.com/plotly/plotly.R.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 14579179 |
| octolytics-dimension-repository_nwo | plotly/plotly.R |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14579179 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.R |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/plotly/plotly.R/pull/2301#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.R%2Fpull%2F2301 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.R%2Fpull%2F2301 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.R |
| Reload | https://github.com/plotly/plotly.R/pull/2301 |
| Reload | https://github.com/plotly/plotly.R/pull/2301 |
| Reload | https://github.com/plotly/plotly.R/pull/2301 |
| plotly | https://github.com/plotly |
| plotly.R | https://github.com/plotly/plotly.R |
| Code | https://github.com/plotly/plotly.R |
| Issues716 (716) | https://github.com/plotly/plotly.R/issues |
| Pull requests47 (47) | https://github.com/plotly/plotly.R/pulls |
| Discussions | https://github.com/plotly/plotly.R/discussions |
| Actions | https://github.com/plotly/plotly.R/actions |
| Projects | https://github.com/plotly/plotly.R/projects |
| Wiki | https://github.com/plotly/plotly.R/wiki |
| Security and quality | https://github.com/plotly/plotly.R/security |
| Insights | https://github.com/plotly/plotly.R/insights |
| https://github.com/plotly/plotly.R |
| cpsievert | https://github.com/cpsievert |
| master | https://github.com/plotly/plotly.R/tree/master |
| dev-ggplot2-fixes | https://github.com/plotly/plotly.R/tree/dev-ggplot2-fixes |
| Conversation | https://github.com/plotly/plotly.R/pull/2301 |
| Commits12 (12) | https://github.com/plotly/plotly.R/pull/2301/commits |
| Checks | https://github.com/plotly/plotly.R/pull/2301/checks |
| Files changed | https://github.com/plotly/plotly.R/pull/2301/files |
| Fixes/workaround for upcoming (> v3.4.3) ggplot2 release | https://github.com/plotly/plotly.R/pull/2301#top |
| cpsievert | https://github.com/cpsievert |
| master | https://github.com/plotly/plotly.R/tree/master |
| dev-ggplot2-fixes | https://github.com/plotly/plotly.R/tree/dev-ggplot2-fixes |
|
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
| Oct 6, 2023 | https://github.com/plotly/plotly.R/pull/2301#issue-1931023269 |
| Please reload this page | https://github.com/plotly/plotly.R/pull/2301 |
| Please reload this page | https://github.com/plotly/plotly.R/pull/2301 |
| cpsievert | https://github.com/cpsievert |
| October 6, 2023 17:54 | https://github.com/plotly/plotly.R/pull/2301#commits-pushed-e720a51 |
|
| https://github.com/cpsievert |
| Specify origin for numeric->date coercion in unit test | https://github.com/plotly/plotly.R/pull/2301/commits/e720a51317f1732979ba3cfff8ca2ce2c32dd23e |
| e720a51 | https://github.com/plotly/plotly.R/pull/2301/commits/e720a51317f1732979ba3cfff8ca2ce2c32dd23e |
|
| https://github.com/cpsievert |
| Quick and dirty fix proposal for | https://github.com/plotly/plotly.R/pull/2301/commits/922bea41b366e41e6f8ddc3e91906316da1c204b |
| tidyverse/ggplot2#5428 | https://github.com/tidyverse/ggplot2/pull/5428 |
| 922bea4 | https://github.com/plotly/plotly.R/pull/2301/commits/922bea41b366e41e6f8ddc3e91906316da1c204b |
|
| https://github.com/cpsievert |
| Quick and dirty fix proposal for | https://github.com/plotly/plotly.R/pull/2301/commits/13b8fecd5946344c96afb624aabbfa2d1af15549 |
| tidyverse/ggplot2#5343 | https://github.com/tidyverse/ggplot2/pull/5343 |
| 13b8fec | https://github.com/plotly/plotly.R/pull/2301/commits/13b8fecd5946344c96afb624aabbfa2d1af15549 |
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
|
Oct 6, 2023
| https://github.com/plotly/plotly.R/pull/2301#pullrequestreview-1662890903 |
|
View reviewed changes
| https://github.com/plotly/plotly.R/pull/2301/files/13b8fecd5946344c96afb624aabbfa2d1af15549 |
| R/ggplotly.R | https://github.com/plotly/plotly.R/pull/2301/files/13b8fecd5946344c96afb624aabbfa2d1af15549#diff-b72500ba8e46e017509b9b5fb36737d00ea48e732bd6a1ee2c505e1a7bd9e001 |
| Please reload this page | https://github.com/plotly/plotly.R/pull/2301 |
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
|
Oct 6, 2023
| https://github.com/plotly/plotly.R/pull/2301#pullrequestreview-1662891182 |
|
View reviewed changes
| https://github.com/plotly/plotly.R/pull/2301/files/13b8fecd5946344c96afb624aabbfa2d1af15549 |
| R/ggplotly.R | https://github.com/plotly/plotly.R/pull/2301/files/13b8fecd5946344c96afb624aabbfa2d1af15549#diff-b72500ba8e46e017509b9b5fb36737d00ea48e732bd6a1ee2c505e1a7bd9e001 |
| Please reload this page | https://github.com/plotly/plotly.R/pull/2301 |
| cpsievert | https://github.com/cpsievert |
| October 7, 2023 10:45 | https://github.com/plotly/plotly.R/pull/2301#commits-pushed-6cdcfc9 |
|
| https://github.com/cpsievert |
| Update snapshots | https://github.com/plotly/plotly.R/pull/2301/commits/6cdcfc96050986cbbe16a065a0f5abe8f354ec5d |
| 6cdcfc9 | https://github.com/plotly/plotly.R/pull/2301/commits/6cdcfc96050986cbbe16a065a0f5abe8f354ec5d |
|
| https://github.com/cpsievert |
| Use dev version of Gally during check | https://github.com/plotly/plotly.R/pull/2301/commits/03ef5e23fa241084916a63f97f4d62d09034dbb0 |
| 03ef5e2 | https://github.com/plotly/plotly.R/pull/2301/commits/03ef5e23fa241084916a63f97f4d62d09034dbb0 |
|
| https://github.com/cpsievert |
| Don't use pak to install dev GGally | https://github.com/plotly/plotly.R/pull/2301/commits/caa97c83c76889a1dd7252bea14c2106dfbbcb29 |
| caa97c8 | https://github.com/plotly/plotly.R/pull/2301/commits/caa97c83c76889a1dd7252bea14c2106dfbbcb29 |
|
| https://github.com/cpsievert |
| Use a proper shell context | https://github.com/plotly/plotly.R/pull/2301/commits/73d7e1bea63e5382417f66e25dabf632ffa14e86 |
| 73d7e1b | https://github.com/plotly/plotly.R/pull/2301/commits/73d7e1bea63e5382417f66e25dabf632ffa14e86 |
|
| https://github.com/cpsievert |
| Simplify scale type detection logic (since new approach works with ol… | https://github.com/plotly/plotly.R/pull/2301/commits/7f2d96f5a1302c2b3c49687cdeac3f89e1cd547f |
| 7f2d96f | https://github.com/plotly/plotly.R/pull/2301/commits/7f2d96f5a1302c2b3c49687cdeac3f89e1cd547f |
|
| https://github.com/cpsievert |
| Dev version GGally doesn't do anything to fix the issues dev ggplot2 … | https://github.com/plotly/plotly.R/pull/2301/commits/921b9b59b98cd7c37f9d08e18e123d59bb850df0 |
| 921b9b5 | https://github.com/plotly/plotly.R/pull/2301/commits/921b9b59b98cd7c37f9d08e18e123d59bb850df0 |
|
| https://github.com/cpsievert |
| Be more careful to support discrete scales that contain a vector of a… | https://github.com/plotly/plotly.R/pull/2301/commits/36fe752167ac300b7109b1e8022dfa2d369ac61c |
| 36fe752 | https://github.com/plotly/plotly.R/pull/2301/commits/36fe752167ac300b7109b1e8022dfa2d369ac61c |
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
| Oct 10, 2023 | https://github.com/plotly/plotly.R/pull/2301#issuecomment-1756288821 |
| Please reload this page | https://github.com/plotly/plotly.R/pull/2301 |
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
| October 10, 2023 21:26 | https://github.com/plotly/plotly.R/pull/2301#event-10610174047 |
| cpsievert | https://github.com/cpsievert |
| October 10, 2023 19:34 | https://github.com/plotly/plotly.R/pull/2301#commits-pushed-4707a8e |
|
| https://github.com/cpsievert |
| Check-in new snapshot | https://github.com/plotly/plotly.R/pull/2301/commits/4707a8e59d75f76c6b743663060706a3be5843ee |
| 4707a8e | https://github.com/plotly/plotly.R/pull/2301/commits/4707a8e59d75f76c6b743663060706a3be5843ee |
|
| https://github.com/cpsievert |
| Update news | https://github.com/plotly/plotly.R/pull/2301/commits/80147cdbeef46517720146082ac94494a1fb94ce |
| 80147cd | https://github.com/plotly/plotly.R/pull/2301/commits/80147cdbeef46517720146082ac94494a1fb94ce |
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
| 22d715d | https://github.com/plotly/plotly.R/commit/22d715d0b0080e900dc93e26853b35d6e16831af |
| Oct 11, 2023 | https://github.com/plotly/plotly.R/pull/2301#event-10611558784 |
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
| October 11, 2023 00:41 | https://github.com/plotly/plotly.R/pull/2301#event-10611559351 |
| https://github.com/zeehio |
| zeehio | https://github.com/zeehio |
|
Oct 21, 2023
| https://github.com/plotly/plotly.R/pull/2301#pullrequestreview-1691078712 |
|
View reviewed changes
| https://github.com/plotly/plotly.R/pull/2301/files/80147cdbeef46517720146082ac94494a1fb94ce |
| inst/examples/shiny/event_data/tests/shinytest/mytest-expected/001.json | https://github.com/plotly/plotly.R/pull/2301/files/80147cdbeef46517720146082ac94494a1fb94ce#diff-eabd7189bbad00c5f2a9d67b2081ec38667a3553ed7a40d0b58bc02632cb05c9 |
| zeehio | https://github.com/zeehio |
| Oct 21, 2023 | https://github.com/plotly/plotly.R/pull/2301#discussion_r1367606873 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @cpsievert | https://github.com/cpsievert |
| jeroen/jsonlite#420 | https://github.com/jeroen/jsonlite/issues/420 |
| Please reload this page | https://github.com/plotly/plotly.R/pull/2301 |
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
|
Nov 10, 2023
| https://github.com/plotly/plotly.R/pull/2301#ref-pullrequest-1987937181 |
|
Updates for recent changes to ggplot2 ggproto guide API
#2315
| https://github.com/plotly/plotly.R/pull/2315 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.R/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.R%2Fpull%2F2301 |
|
| https://github.com/zeehio |
|
zeehio
| https://github.com/zeehio |
|
| https://github.com/plotly/plotly.R/pull/2301/files/80147cdbeef46517720146082ac94494a1fb94ce |
| Please reload this page | https://github.com/plotly/plotly.R/pull/2301 |
| Please reload this page | https://github.com/plotly/plotly.R/pull/2301 |
|
| https://github.com/cpsievert |
|
| https://github.com/zeehio |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |