René's URL Explorer Experiment


Title: Handle recent changes to ggplot2's `plot_build()` logic by cpsievert · Pull Request #2262 · plotly/plotly.R · GitHub

Open Graph Title: Handle recent changes to ggplot2's `plot_build()` logic by cpsievert · Pull Request #2262 · plotly/plotly.R

X Title: Handle recent changes to ggplot2's `plot_build()` logic by cpsievert · Pull Request #2262 · plotly/plotly.R

Description: An interactive graphing library for R. Contribute to plotly/plotly.R development by creating an account on GitHub.

Open Graph Description: Closes #2259 This PR add support for recent (internal) changes to ggplot2 (mostly the ones made in tidyverse/ggplot2#4879 and tidyverse/ggplot2#5144). These changes removed some internal ggplot2 f...

X Description: Closes #2259 This PR add support for recent (internal) changes to ggplot2 (mostly the ones made in tidyverse/ggplot2#4879 and tidyverse/ggplot2#5144). These changes removed some internal ggplot2 f...

Opengraph URL: https://github.com/plotly/plotly.R/pull/2262

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e744d9c0-a090-30d7-d9dc-d99c99c1fc1d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA7DE:36A3E:EE4090:13EE985:6B010D03
html-safe-nonce47153c8ae9c5f61294ec5613fc0edbfb64489ab510c7c1956fb10130d1d45785
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0RFOjM2QTNFOkVFNDA5MDoxM0VFOTg1OjZCMDEwRDAzIiwidmlzaXRvcl9pZCI6IjYyNDYxNjg3MjMxNDIxMTU4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca6db72c3ffb9e814350bb82e6bf3768c6787e6a18a16045eae9f9b63bf43a0ca
hovercard-subject-tagpull_request:1334566107
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.R/2262/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/153e49ea62450b1b7f49d60810e9384e3a5bf8972caa8d6eab63e4da294eb7c8/plotly/plotly.R/pull/2262
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/153e49ea62450b1b7f49d60810e9384e3a5bf8972caa8d6eab63e4da294eb7c8/plotly/plotly.R/pull/2262
og:image:altCloses #2259 This PR add support for recent (internal) changes to ggplot2 (mostly the ones made in tidyverse/ggplot2#4879 and tidyverse/ggplot2#5144). These changes removed some internal ggplot2 f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecpsievert
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/plotly/plotly.R git https://github.com/plotly/plotly.R.git
octolytics-dimension-user_id5997976
octolytics-dimension-user_loginplotly
octolytics-dimension-repository_id14579179
octolytics-dimension-repository_nwoplotly/plotly.R
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id14579179
octolytics-dimension-repository_network_root_nwoplotly/plotly.R
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/plotly/plotly.R/pull/2262#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.R%2Fpull%2F2262
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.R%2Fpull%2F2262
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.R
Reloadhttps://github.com/plotly/plotly.R/pull/2262
Reloadhttps://github.com/plotly/plotly.R/pull/2262
Reloadhttps://github.com/plotly/plotly.R/pull/2262
plotlyhttps://github.com/plotly
plotly.Rhttps://github.com/plotly/plotly.R
Codehttps://github.com/plotly/plotly.R
Issues716 (716)https://github.com/plotly/plotly.R/issues
Pull requests47 (47)https://github.com/plotly/plotly.R/pulls
Discussionshttps://github.com/plotly/plotly.R/discussions
Actionshttps://github.com/plotly/plotly.R/actions
Projectshttps://github.com/plotly/plotly.R/projects
Wikihttps://github.com/plotly/plotly.R/wiki
Security and qualityhttps://github.com/plotly/plotly.R/security
Insightshttps://github.com/plotly/plotly.R/insights
https://github.com/plotly/plotly.R
cpsieverthttps://github.com/cpsievert
masterhttps://github.com/plotly/plotly.R/tree/master
ggplot2-v3.4.3https://github.com/plotly/plotly.R/tree/ggplot2-v3.4.3
Conversationhttps://github.com/plotly/plotly.R/pull/2262
Commits10 (10)https://github.com/plotly/plotly.R/pull/2262/commits
Checkshttps://github.com/plotly/plotly.R/pull/2262/checks
Files changedhttps://github.com/plotly/plotly.R/pull/2262/files
Handle recent changes to ggplot2's plot_build() logichttps://github.com/plotly/plotly.R/pull/2262#top
cpsieverthttps://github.com/cpsievert
masterhttps://github.com/plotly/plotly.R/tree/master
ggplot2-v3.4.3https://github.com/plotly/plotly.R/tree/ggplot2-v3.4.3
https://github.com/cpsievert
cpsieverthttps://github.com/cpsievert
May 2, 2023https://github.com/plotly/plotly.R/pull/2262#issue-1691648471
Please reload this pagehttps://github.com/plotly/plotly.R/pull/2262
#2259https://github.com/plotly/plotly.R/issues/2259
tidyverse/ggplot2#4879https://github.com/tidyverse/ggplot2/pull/4879
tidyverse/ggplot2#5144https://github.com/tidyverse/ggplot2/pull/5144
Please reload this pagehttps://github.com/plotly/plotly.R/pull/2262
https://github.com/cpsievert
Closehttps://github.com/plotly/plotly.R/pull/2262/commits/8a94f662cf089b65d50da9167a64b43acb9b90cc
#2259https://github.com/plotly/plotly.R/issues/2259
: handle recent changes to ggplot2's plot_build() logichttps://github.com/plotly/plotly.R/pull/2262/commits/8a94f662cf089b65d50da9167a64b43acb9b90cc
8a94f66https://github.com/plotly/plotly.R/pull/2262/commits/8a94f662cf089b65d50da9167a64b43acb9b90cc
https://github.com/cpsievert
cpsieverthttps://github.com/cpsievert
May 3, 2023 https://github.com/plotly/plotly.R/pull/2262#pullrequestreview-1412015001
View reviewed changes https://github.com/plotly/plotly.R/pull/2262/files/8a94f662cf089b65d50da9167a64b43acb9b90cc
R/ggplotly.Rhttps://github.com/plotly/plotly.R/pull/2262/files/8a94f662cf089b65d50da9167a64b43acb9b90cc#diff-b72500ba8e46e017509b9b5fb36737d00ea48e732bd6a1ee2c505e1a7bd9e001
Please reload this pagehttps://github.com/plotly/plotly.R/pull/2262
https://github.com/cpsievert
cpsieverthttps://github.com/cpsievert
May 3, 2023 https://github.com/plotly/plotly.R/pull/2262#pullrequestreview-1412016138
View reviewed changes https://github.com/plotly/plotly.R/pull/2262/files/8a94f662cf089b65d50da9167a64b43acb9b90cc
R/ggplotly.Rhttps://github.com/plotly/plotly.R/pull/2262/files/8a94f662cf089b65d50da9167a64b43acb9b90cc#diff-b72500ba8e46e017509b9b5fb36737d00ea48e732bd6a1ee2c505e1a7bd9e001
Please reload this pagehttps://github.com/plotly/plotly.R/pull/2262
cpsieverthttps://github.com/cpsievert
May 3, 2023 17:56https://github.com/plotly/plotly.R/pull/2262#commits-pushed-0b1fbe9
https://github.com/cpsievert
Apply suggestions from code reviewhttps://github.com/plotly/plotly.R/pull/2262/commits/0b1fbe9cecf7495e45f3fc73ed9a5fd7d91d0a41
0b1fbe9https://github.com/plotly/plotly.R/pull/2262/commits/0b1fbe9cecf7495e45f3fc73ed9a5fd7d91d0a41
https://github.com/cpsievert
Try using latest ubuntuhttps://github.com/plotly/plotly.R/pull/2262/commits/8f79eabaf97122f75cd084a251516ffa4c2bcc7d
8f79eabhttps://github.com/plotly/plotly.R/pull/2262/commits/8f79eabaf97122f75cd084a251516ffa4c2bcc7d
https://github.com/cpsievert
Also accomodate for guide changes made inhttps://github.com/plotly/plotly.R/pull/2262/commits/5b73531f0f41e123c6b5519069c02f7cfe03b2d0
tidyverse/ggplot2#4879https://github.com/tidyverse/ggplot2/pull/4879
5b73531https://github.com/plotly/plotly.R/pull/2262/commits/5b73531f0f41e123c6b5519069c02f7cfe03b2d0
https://github.com/cpsievert
Approve new visual baselinehttps://github.com/plotly/plotly.R/pull/2262/commits/7b34d73b797002b63880b608ba4b5db5d05d7561
7b34d73https://github.com/plotly/plotly.R/pull/2262/commits/7b34d73b797002b63880b608ba4b5db5d05d7561
https://github.com/cpsievert
Update test expectationshttps://github.com/plotly/plotly.R/pull/2262/commits/98becaea5b15e7bc73e1819bead82e3ff227e75e
98becaehttps://github.com/plotly/plotly.R/pull/2262/commits/98becaea5b15e7bc73e1819bead82e3ff227e75e
https://github.com/cpsievert
(Temporarily) test with ggplot2https://github.com/plotly/plotly.R/pull/2262/commits/8a3d09b3f48353be506ab9b0eec71e38947bc94d
8a3d09bhttps://github.com/plotly/plotly.R/pull/2262/commits/8a3d09b3f48353be506ab9b0eec71e38947bc94d
https://github.com/cpsievert
Fix more changes in colorscale parametershttps://github.com/plotly/plotly.R/pull/2262/commits/33ca9bda9bdb7a02233298cd8865656221bd8167
33ca9bdhttps://github.com/plotly/plotly.R/pull/2262/commits/33ca9bda9bdb7a02233298cd8865656221bd8167
https://github.com/cpsievert
Fix support for no guidehttps://github.com/plotly/plotly.R/pull/2262/commits/3666c2ecc9fcf9f44f0abab4edb201170ffcaee8
3666c2ehttps://github.com/plotly/plotly.R/pull/2262/commits/3666c2ecc9fcf9f44f0abab4edb201170ffcaee8
https://github.com/cpsievert
cpsieverthttps://github.com/cpsievert
May 5, 2023 https://github.com/plotly/plotly.R/pull/2262#pullrequestreview-1415144066
View reviewed changes https://github.com/plotly/plotly.R/pull/2262/files/3666c2ecc9fcf9f44f0abab4edb201170ffcaee8
R/layers2traces.Rhttps://github.com/plotly/plotly.R/pull/2262/files/3666c2ecc9fcf9f44f0abab4edb201170ffcaee8#diff-d84657ae70a4603c9cac16bdc349d40ea3412a66e6b15da7ce5df59ab815fdcc
Please reload this pagehttps://github.com/plotly/plotly.R/pull/2262
https://github.com/cpsievert
Accept new visual baselineshttps://github.com/plotly/plotly.R/pull/2262/commits/de2c37bdc01960b3c0029c469805b8a39b7c010d
de2c37bhttps://github.com/plotly/plotly.R/pull/2262/commits/de2c37bdc01960b3c0029c469805b8a39b7c010d
https://github.com/cpsievert
cpsieverthttps://github.com/cpsievert
4594408https://github.com/plotly/plotly.R/commit/45944086754cb8223f669e1094b953d2c2ca6710
May 5, 2023https://github.com/plotly/plotly.R/pull/2262#event-9180678362
https://github.com/cpsievert
cpsieverthttps://github.com/cpsievert
May 5, 2023 21:51https://github.com/plotly/plotly.R/pull/2262#event-9180678467
cpsieverthttps://github.com/cpsievert
May 5, 2023 https://github.com/plotly/plotly.R/pull/2262#ref-commit-2f08cf8
https://github.com/cpsievert
Follow up tohttps://github.com/plotly/plotly.R/commit/2f08cf8710239cf294e276654b269869adc8b9d2
#2262https://github.com/plotly/plotly.R/pull/2262
: add a clarifying comment; update newshttps://github.com/plotly/plotly.R/commit/2f08cf8710239cf294e276654b269869adc8b9d2
2f08cf8https://github.com/plotly/plotly.R/commit/2f08cf8710239cf294e276654b269869adc8b9d2
https://github.com/schloerke
schloerkehttps://github.com/schloerke
May 19, 2023 https://github.com/plotly/plotly.R/pull/2262#ref-pullrequest-1717280035
Relocate tidyverse/ggplot2 remote to Config/Needs/check #2268 https://github.com/plotly/plotly.R/pull/2268
https://github.com/cpsievert
cpsieverthttps://github.com/cpsievert
Nov 10, 2023 https://github.com/plotly/plotly.R/pull/2262#ref-pullrequest-1987937181
Updates for recent changes to ggplot2 ggproto guide API #2315 https://github.com/plotly/plotly.R/pull/2315
https://github.co/hiddenchars
https://github.com/plotly/plotly.R/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.R%2Fpull%2F2262
Please reload this pagehttps://github.com/plotly/plotly.R/pull/2262
Error in match.fun(FUN): 'ggfun("scales_transform_df")' is not a function, character or symbol https://github.com/plotly/plotly.R/issues/2259
Please reload this pagehttps://github.com/plotly/plotly.R/pull/2262
https://github.com/cpsievert
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.