| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:81123da4-54eb-1079-a29f-a7174178cc2a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9662:A71F9:404117:508DC5:6B0107F9 |
| html-safe-nonce | acd81f07299e39ed4a1789e0b50437e8ad95c1187034d95063275a29e644d288 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NjYyOkE3MUY5OjQwNDExNzo1MDhEQzU6NkIwMTA3RjkiLCJ2aXNpdG9yX2lkIjoiNTUxNzc3MzIzNzQ3NzUwOTExMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 364672ea07b6f06cfba09fd9f400eafaa126b48f64214973ecab399a7e5b6aa2 |
| hovercard-subject-tag | pull_request:313655898 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/plotly/plotly.R/1611/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2541cf38da5eed175c9d4cb433d85260776aff83da3f0fcc1cf923928ef8b0a5/plotly/plotly.R/pull/1611 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2541cf38da5eed175c9d4cb433d85260776aff83da3f0fcc1cf923928ef8b0a5/plotly/plotly.R/pull/1611 |
| og:image:alt | Fixes #1610. Note also that when pt.pointNumbers is populated, the key attribute is relayed properly
Testing notes
Install remotes::install_github("ropensci/plotly"), then run the app bel... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cpsievert |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/plotly/plotly.R git https://github.com/plotly/plotly.R.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 14579179 |
| octolytics-dimension-repository_nwo | plotly/plotly.R |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 14579179 |
| octolytics-dimension-repository_network_root_nwo | plotly/plotly.R |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/plotly/plotly.R/pull/1611#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.R%2Fpull%2F1611 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.R%2Fpull%2F1611 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=plotly%2Fplotly.R |
| Reload | https://github.com/plotly/plotly.R/pull/1611 |
| Reload | https://github.com/plotly/plotly.R/pull/1611 |
| Reload | https://github.com/plotly/plotly.R/pull/1611 |
| plotly | https://github.com/plotly |
| plotly.R | https://github.com/plotly/plotly.R |
| Code | https://github.com/plotly/plotly.R |
| Issues716 (716) | https://github.com/plotly/plotly.R/issues |
| Pull requests47 (47) | https://github.com/plotly/plotly.R/pulls |
| Discussions | https://github.com/plotly/plotly.R/discussions |
| Actions | https://github.com/plotly/plotly.R/actions |
| Projects | https://github.com/plotly/plotly.R/projects |
| Wiki | https://github.com/plotly/plotly.R/wiki |
| Security and quality | https://github.com/plotly/plotly.R/security |
| Insights | https://github.com/plotly/plotly.R/insights |
| https://github.com/plotly/plotly.R |
| cpsievert | https://github.com/cpsievert |
| master | https://github.com/plotly/plotly.R/tree/master |
| shiny-event-data-key | https://github.com/plotly/plotly.R/tree/shiny-event-data-key |
| Conversation | https://github.com/plotly/plotly.R/pull/1611 |
| Commits4 (4) | https://github.com/plotly/plotly.R/pull/1611/commits |
| Checks | https://github.com/plotly/plotly.R/pull/1611/checks |
| Files changed | https://github.com/plotly/plotly.R/pull/1611/files |
| Improvements to algorithm for attaching key attribute for shiny's event data, fixes #1610 | https://github.com/plotly/plotly.R/pull/1611#top |
| cpsievert | https://github.com/cpsievert |
| master | https://github.com/plotly/plotly.R/tree/master |
| shiny-event-data-key | https://github.com/plotly/plotly.R/tree/shiny-event-data-key |
|
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
| Sep 3, 2019 | https://github.com/plotly/plotly.R/pull/1611#issue-488684459 |
| Please reload this page | https://github.com/plotly/plotly.R/pull/1611 |
| #1610 | https://github.com/plotly/plotly.R/issues/1610 |
| Please reload this page | https://github.com/plotly/plotly.R/pull/1611 |
|
| https://github.com/cpsievert |
| Improvements to algorithm for attaching key attribute for shiny's eve… | https://github.com/plotly/plotly.R/pull/1611/commits/8bc36b949b162873fb15335475d49cfa1f7150ca |
| 8bc36b9 | https://github.com/plotly/plotly.R/pull/1611/commits/8bc36b949b162873fb15335475d49cfa1f7150ca |
| #1610 | https://github.com/plotly/plotly.R/issues/1610 |
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
| force-pushed | https://github.com/plotly/plotly.R/compare/2c219fe7428468d807737a8be5782062076bb378..8bc36b949b162873fb15335475d49cfa1f7150ca |
| 2c219fe | https://github.com/plotly/plotly.R/commit/2c219fe7428468d807737a8be5782062076bb378 |
| 8bc36b9 | https://github.com/plotly/plotly.R/commit/8bc36b949b162873fb15335475d49cfa1f7150ca |
|
Compare
| https://github.com/plotly/plotly.R/compare/2c219fe7428468d807737a8be5782062076bb378..8bc36b949b162873fb15335475d49cfa1f7150ca |
| September 3, 2019 15:47 | https://github.com/plotly/plotly.R/pull/1611#event-2604078821 |
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
| schloerke | https://github.com/schloerke |
| September 3, 2019 16:48 | https://github.com/plotly/plotly.R/pull/1611#event-2604268368 |
| https://github.com/schloerke |
| schloerke | https://github.com/schloerke |
|
Sep 3, 2019
| https://github.com/plotly/plotly.R/pull/1611#pullrequestreview-283192048 |
|
View reviewed changes
| https://github.com/plotly/plotly.R/pull/1611/files/8bc36b949b162873fb15335475d49cfa1f7150ca |
| inst/htmlwidgets/plotly.js | https://github.com/plotly/plotly.R/pull/1611/files/8bc36b949b162873fb15335475d49cfa1f7150ca#diff-03e4501880f3898c2900c4fdf7b773f1a0b902f31fc3c765d41b34372b4559ef |
| Please reload this page | https://github.com/plotly/plotly.R/pull/1611 |
|
| https://github.com/cpsievert |
| When pointNumber is a constant, relay it as such | https://github.com/plotly/plotly.R/pull/1611/commits/8056cc562fb0a3e46282f23ae512f3c2a3489930 |
| 8056cc5 | https://github.com/plotly/plotly.R/pull/1611/commits/8056cc562fb0a3e46282f23ae512f3c2a3489930 |
| https://github.com/schloerke |
| schloerke | https://github.com/schloerke |
|
Sep 3, 2019
| https://github.com/plotly/plotly.R/pull/1611#pullrequestreview-283226938 |
|
View reviewed changes
| https://github.com/plotly/plotly.R/pull/1611/files/8056cc562fb0a3e46282f23ae512f3c2a3489930 |
| schloerke | https://github.com/schloerke |
| https://github.com/plotly/plotly.R/pull/1611#pullrequestreview-283226938 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://github.com/ropensci/plotly/pull/1611/files#diff-0ad25a6dcc3b90b388d12e866865156fL269 | https://github.com/ropensci/plotly/pull/1611/files#diff-0ad25a6dcc3b90b388d12e866865156fL269 |
| Please reload this page | https://github.com/plotly/plotly.R/pull/1611 |
|
| https://github.com/cpsievert |
| handle the 3 cases separately | https://github.com/plotly/plotly.R/pull/1611/commits/81caeeb004f3e2a8b4db0e83651b703cf018dcd5 |
| 81caeeb | https://github.com/plotly/plotly.R/pull/1611/commits/81caeeb004f3e2a8b4db0e83651b703cf018dcd5 |
| https://github.com/schloerke |
| schloerke | https://github.com/schloerke |
|
Sep 3, 2019
| https://github.com/plotly/plotly.R/pull/1611#pullrequestreview-283248663 |
|
View reviewed changes
| https://github.com/plotly/plotly.R/pull/1611/files/81caeeb004f3e2a8b4db0e83651b703cf018dcd5 |
| inst/htmlwidgets/plotly.js | https://github.com/plotly/plotly.R/pull/1611/files/8056cc562fb0a3e46282f23ae512f3c2a3489930..81caeeb004f3e2a8b4db0e83651b703cf018dcd5#diff-03e4501880f3898c2900c4fdf7b773f1a0b902f31fc3c765d41b34372b4559ef |
| Please reload this page | https://github.com/plotly/plotly.R/pull/1611 |
| https://github.com/schloerke |
| schloerke | https://github.com/schloerke |
|
Sep 3, 2019
| https://github.com/plotly/plotly.R/pull/1611#pullrequestreview-283248946 |
|
View reviewed changes
| https://github.com/plotly/plotly.R/pull/1611/files/81caeeb004f3e2a8b4db0e83651b703cf018dcd5 |
|
| https://github.com/cpsievert |
| use idx instead of i | https://github.com/plotly/plotly.R/pull/1611/commits/30e39972eb13b436121952d44d8bedce214bf9b7 |
| 30e3997 | https://github.com/plotly/plotly.R/pull/1611/commits/30e39972eb13b436121952d44d8bedce214bf9b7 |
| https://github.com/cpsievert |
| cpsievert | https://github.com/cpsievert |
| 17466a3 | https://github.com/plotly/plotly.R/commit/17466a385c678a199aa09fa48b018b4829d285a8 |
| Sep 3, 2019 | https://github.com/plotly/plotly.R/pull/1611#event-2605052516 |
| https://github.co/hiddenchars |
| https://github.com/plotly/plotly.R/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fplotly%2Fplotly.R%2Fpull%2F1611 |
|
| https://github.com/schloerke |
|
schloerke
| https://github.com/schloerke |
|
| https://github.com/plotly/plotly.R/pull/1611/files/81caeeb004f3e2a8b4db0e83651b703cf018dcd5 |
| Please reload this page | https://github.com/plotly/plotly.R/pull/1611 |
|
highlight_key isn't working with shiny - TypeError: pt.pointNumber is undefined
| https://github.com/plotly/plotly.R/issues/1610 |
| Please reload this page | https://github.com/plotly/plotly.R/pull/1611 |
|
| https://github.com/cpsievert |
|
| https://github.com/schloerke |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |