Title: data-table: fixes warning about missing key prop by antoinerg · Pull Request #1778 · plotly/dash · GitHub
Open Graph Title: data-table: fixes warning about missing key prop by antoinerg · Pull Request #1778 · plotly/dash
X Title: data-table: fixes warning about missing key prop by antoinerg · Pull Request #1778 · plotly/dash
Description: Closes plotly/dash-table#860 and potentially #1433 As pointed out in plotly/dash-table#690 (comment), in order to see the warnings on the demo page, we need to use React's dev bundles (see 3eac50a). I also changed the version of the React bundle to match the one used in package-lock.json. I don't know if this should stay in the PR but @chabb made a good argument for it to stay in. The fix itself can be found in a25cca9. It adds the one missing key prop. After this commit, the missing key warning disappears in the demo page! cc @alexcjohnson Contributor Checklist I have broken down my PR scope into the following TODO tasks task 1 task 2 I have run the tests locally and they passed. (refer to testing section in contributing) I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR optionals I have added entry in the CHANGELOG.md If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows this GitHub #PR number updates the dash docs here is the show and tell thread in Plotly Dash community
Open Graph Description: Closes plotly/dash-table#860 and potentially #1433 As pointed out in plotly/dash-table#690 (comment), in order to see the warnings on the demo page, we need to use React's dev bundles (see 3eac...
X Description: Closes plotly/dash-table#860 and potentially #1433 As pointed out in plotly/dash-table#690 (comment), in order to see the warnings on the demo page, we need to use React's dev bundles (see ...
Opengraph URL: https://github.com/plotly/dash/pull/1778
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files/:range(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6871ee83-f60b-c8ae-08ce-de44a3accc83 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D26C:259C8E:201A420:2B82A4C:6A655C57 |
| html-safe-nonce | cce6ae8940df63a6f8e518dc62837c4baf6f527083a7038fec95f0c36a226c52 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjZDOjI1OUM4RToyMDFBNDIwOjJCODJBNEM6NkE2NTVDNTciLCJ2aXNpdG9yX2lkIjoiNzg2Mzg4OTk3ODkyMTkzMzkxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5f8f8107f895a0af37bee98b83843653566fb5604090acd845bd0360d3de85aa |
| hovercard-subject-tag | pull_request:742528095 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/plotly/dash/pull/1778/files/50f8c0481a77ab5b9353c81d980d1ddabc36bd26 |
| twitter:image | https://avatars.githubusercontent.com/u/301546?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/301546?s=400&v=4 |
| og:image:alt | Closes plotly/dash-table#860 and potentially #1433 As pointed out in plotly/dash-table#690 (comment), in order to see the warnings on the demo page, we need to use React's dev bundles (see 3eac... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/plotly/dash git https://github.com/plotly/dash.git |
| octolytics-dimension-user_id | 5997976 |
| octolytics-dimension-user_login | plotly |
| octolytics-dimension-repository_id | 33702544 |
| octolytics-dimension-repository_nwo | plotly/dash |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 33702544 |
| octolytics-dimension-repository_network_root_nwo | plotly/dash |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 309153364422b3c499922d1a2a6404910a58ed8e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width