{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect advice in android_support.h file from SDK.","articleBody":"In the gpg-cpp-sdk v 3.0.1 there is a file **android/include/gpg/android_support.h**\r\n\r\nThis file mentions:\r\n\r\n```\r\n* \u003ch1\u003eExample code for an Android 4.0+ game using a Java Activity\u003c/h1\u003e\r\n * In your Java Activity, please add the following. You may need to merge this\r\n * code with your existing lifecycle functions.\r\n * \\code\r\n * public class YourActivity extends Activity {\r\n *   protected void onActivityResult(int requestCode,\r\n *                                   int resultCode,\r\n *                                   Intent data) {\r\n *     super.onActivityResult(requestCode, resultCode, data);\r\n *     nativeOnActivityResult(this, requestCode, resultCode, data);\r\n *   }\r\n *\r\n *   // Implemented in C++.\r\n *   private static native void nativeOnActivityResult(\r\n *       Activity activity,\r\n *       int requestCode,\r\n *       int resultCode,\r\n *       Intent data);\r\n * }\r\n * \\endcode\r\n * Then, in your native library, add the following forwarding functions.\r\n * \\code\r\n * void Java_com_example_yourapp_YourActivity_nativeOnActivityResult(\r\n *     JNIEnv* env,\r\n *     jobject thiz,\r\n *     jobject activity,\r\n *     jint request_code,\r\n *     jint result_code,\r\n *     jobject data) {\r\n *   gpg::AndroidSupport::OnActivityResult(\r\n *       env, activity, request_code, result_code, data);\r\n * }\r\n * \\endcode\r\n```\r\n\r\nThese code snippets are incorrect.\r\n\r\nThe Java part of the code defines a static function, without a 'thiz' pointer.\r\n\r\nThe C part of the code defines a non static function, with a 'thiz' pointer.\r\n\r\nThese do not rhyme.\r\n\r\nCausing android studio to warn:\r\n\r\n![image](https://user-images.githubusercontent.com/455280/53825775-f51d6a00-3f2b-11e9-9057-1468e1f9e903.png)\r\n\r\nPlease address, @hak ","author":{"url":"https://github.com/stolk","@type":"Person","name":"stolk"},"datePublished":"2019-03-05T17:51:15.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/57/cpp-android-basic-samples/issues/57"}