René's URL Explorer Experiment


Title: Do not narrow a comparison operand whose counterpart can be NAN by zonuexe · Pull Request #7058 · phpstan/phpstan-src · GitHub

Open Graph Title: Do not narrow a comparison operand whose counterpart can be NAN by zonuexe · Pull Request #7058 · phpstan/phpstan-src

X Title: Do not narrow a comparison operand whose counterpart can be NAN by zonuexe · Pull Request #7058 · phpstan/phpstan-src

Description: PHPStan's source code. This is where development happens. Check https://github.com/phpstan/phpstan for the distribution repository. - Do not narrow a comparison operand whose counterpart can be NAN by zonuexe · Pull Request #7058 · phpstan/phpstan-src

Open Graph Description: BinaryOpHandler narrows both operands of <, <=, > and >= in the false branch. It keeps NAN on the side it narrows, but it still narrows each side as if the other one were ordered. This ...

X Description: BinaryOpHandler narrows both operands of &lt;, &lt;=, &gt; and &gt;= in the false branch. It keeps NAN on the side it narrows, but it still narrows each side as if the other one wer...

Opengraph URL: https://github.com/phpstan/phpstan-src/pull/7058

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:290375e3-d88c-bc42-6d54-4581656d4468
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8DCC:DC070:4A9DAB:68A14E:6B00727D
html-safe-nonceef1caccef3076dc1b38477072d3e5961ef7aaee04091d1cb8a77029bd401bb03
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RENDOkRDMDcwOjRBOURBQjo2OEExNEU6NkIwMDcyN0QiLCJ2aXNpdG9yX2lkIjoiMzYzOTY3OTE1MDk4NzQ0MDc2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5a83ea5e3bb51670f149c2103c67feee6a7306be8c42636568662af8bc4fdb14
hovercard-subject-tagpull_request:5301629309
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/7058/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5f27ee4f08f5553a2de71cc46f8373966653eca4d505e60b85cadf2e273b4c9a/phpstan/phpstan-src/pull/7058
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5f27ee4f08f5553a2de71cc46f8373966653eca4d505e60b85cadf2e273b4c9a/phpstan/phpstan-src/pull/7058
og:image:altBinaryOpHandler narrows both operands of <, <=, > and >= in the false branch. It keeps NAN on the side it narrows, but it still narrows each side as if the other one were ordered. This ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamezonuexe
hostnamegithub.com
expected-hostnamegithub.com
None75c2b65dd205f26961d0c29afed1a8d0bb7cca9f05780571dfd1ef93eb539d16
turbo-cache-controlno-cache
go-importgithub.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git
octolytics-dimension-user_id16435710
octolytics-dimension-user_loginphpstan
octolytics-dimension-repository_id219334214
octolytics-dimension-repository_nwophpstan/phpstan-src
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id219334214
octolytics-dimension-repository_network_root_nwophpstan/phpstan-src
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84e563eb4b55f8fa102f325f117533cee9e3df4a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/phpstan/phpstan-src/pull/7058#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F7058
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F7058
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src
Reloadhttps://github.com/phpstan/phpstan-src/pull/7058
Reloadhttps://github.com/phpstan/phpstan-src/pull/7058
Reloadhttps://github.com/phpstan/phpstan-src/pull/7058
phpstanhttps://github.com/phpstan
phpstan-srchttps://github.com/phpstan/phpstan-src
Codehttps://github.com/phpstan/phpstan-src
Pull requests185 (185)https://github.com/phpstan/phpstan-src/pulls
Actionshttps://github.com/phpstan/phpstan-src/actions
Security and qualityhttps://github.com/phpstan/phpstan-src/security
Insightshttps://github.com/phpstan/phpstan-src/insights
https://github.com/phpstan/phpstan-src
staabmhttps://github.com/staabm
phpstan:2.3.xhttps://github.com/phpstan/phpstan-src/tree/2.3.x
zonuexe:nan-comparison-narrowinghttps://github.com/zonuexe/phpstan-src/tree/nan-comparison-narrowing
Conversationhttps://github.com/phpstan/phpstan-src/pull/7058
Commits4 (4)https://github.com/phpstan/phpstan-src/pull/7058/commits
Checkshttps://github.com/phpstan/phpstan-src/pull/7058/checks
Files changedhttps://github.com/phpstan/phpstan-src/pull/7058/files
Do not narrow a comparison operand whose counterpart can be NANhttps://github.com/phpstan/phpstan-src/pull/7058#top
staabmhttps://github.com/staabm
phpstan:2.3.xhttps://github.com/phpstan/phpstan-src/tree/2.3.x
zonuexe:nan-comparison-narrowinghttps://github.com/zonuexe/phpstan-src/tree/nan-comparison-narrowing
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Nov 13, 2026https://github.com/phpstan/phpstan-src/pull/7058#issue-6378516644
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/7058
Add FloatRangeType for float #6937https://github.com/phpstan/phpstan-src/pull/6937
Type min() / max() of two arguments as the union of both comparison orders #7050https://github.com/phpstan/phpstan-src/pull/7050
phpstan/phpstan#15713https://github.com/phpstan/phpstan/issues/15713
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/7058
zonuexehttps://github.com/zonuexe
November 14, 2026 04:10https://github.com/phpstan/phpstan-src/pull/7058#commits-pushed-22569d8
https://github.com/zonuexe
Do not narrow a comparison operand whose counterpart can be NANhttps://github.com/phpstan/phpstan-src/pull/7058/commits/22569d8e3455443001faf3e980e1929239488621
22569d8https://github.com/phpstan/phpstan-src/pull/7058/commits/22569d8e3455443001faf3e980e1929239488621
https://github.com/zonuexe
Do not invert a count() comparison against an operand that can be NANhttps://github.com/phpstan/phpstan-src/pull/7058/commits/9aeb7480796e71735178b934253bfb0579511782
9aeb748https://github.com/phpstan/phpstan-src/pull/7058/commits/9aeb7480796e71735178b934253bfb0579511782
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Nov 13, 2026 https://github.com/phpstan/phpstan-src/pull/7058#ref-pullrequest-6362737860
Type min() / max() of two arguments as the union of both comparison orders #7050 https://github.com/phpstan/phpstan-src/pull/7050
https://github.com/zonuexe
Ask whether an operand can be NAN by removing NAN from its typehttps://github.com/phpstan/phpstan-src/pull/7058/commits/6896c23013f3cf617e3bc713f46f93d1ea330d7f
6896c23https://github.com/phpstan/phpstan-src/pull/7058/commits/6896c23013f3cf617e3bc713f46f93d1ea330d7f
https://github.com/SanderMuller
SanderMullerhttps://github.com/SanderMuller
Nov 13, 2026 https://github.com/phpstan/phpstan-src/pull/7058#pullrequestreview-5897912429
View reviewed changes https://github.com/phpstan/phpstan-src/pull/7058/files/6896c23013f3cf617e3bc713f46f93d1ea330d7f
SanderMullerhttps://github.com/SanderMuller
https://github.com/phpstan/phpstan-src/pull/7058#pullrequestreview-5897912429
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
94519e2https://github.com/phpstan/phpstan-src/commit/94519e24fb01caf54fa49b1735205e21bff703dc
6896c23https://github.com/phpstan/phpstan-src/commit/6896c23013f3cf617e3bc713f46f93d1ea330d7f
#7050https://github.com/phpstan/phpstan-src/pull/7050
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/7058
https://github.com/staabm
staabmhttps://github.com/staabm
Copilothttps://github.com/apps/copilot-pull-request-reviewer
November 13, 2026 21:03https://github.com/phpstan/phpstan-src/pull/7058#event-36073924491
started reviewinghttps://github.com/phpstan/phpstan-src/sessions/f4c3eb59-c749-4ead-9f74-11cae419efab
staabmhttps://github.com/staabm
November 13, 2026 21:04https://github.com/phpstan/phpstan-src/pull/7058#event-36073961855
View session https://github.com/phpstan/phpstan-src/sessions/f4c3eb59-c749-4ead-9f74-11cae419efab
https://github.com/apps/copilot-pull-request-reviewer
Copilothttps://github.com/apps/copilot-pull-request-reviewer
Nov 13, 2026 https://github.com/phpstan/phpstan-src/pull/7058#pullrequestreview-5898083799
View reviewed changes https://github.com/phpstan/phpstan-src/pull/7058/files/6896c23013f3cf617e3bc713f46f93d1ea330d7f
Copilothttps://github.com/apps/copilot-pull-request-reviewer
https://github.com/phpstan/phpstan-src/pull/7058#pullrequestreview-5898083799
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
NAN guard skips count narrowing in true comparison branchhttps://github.com/phpstan/phpstan-src/pull/7058#discussion_r4568686447
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/7058
src/Analyser/ExprHandler/BinaryOpHandler.phphttps://github.com/phpstan/phpstan-src/pull/7058/files/6896c23013f3cf617e3bc713f46f93d1ea330d7f#diff-e2217ed827cdafe40e6908ebdfce7ba7a212d4611a8af68cc7702f8aae95e500
https://github.com/zonuexe
Skip the inverse count() comparison whenever an operand can be NANhttps://github.com/phpstan/phpstan-src/pull/7058/commits/a916e03a3146dc9c0f88a1bd3d02ac8a3090ca4b
a916e03https://github.com/phpstan/phpstan-src/pull/7058/commits/a916e03a3146dc9c0f88a1bd3d02ac8a3090ca4b
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
Nov 13, 2026https://github.com/phpstan/phpstan-src/pull/7058#issuecomment-6865708802
a916e03https://github.com/phpstan/phpstan-src/commit/a916e03a3146dc9c0f88a1bd3d02ac8a3090ca4b
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/7058
https://github.com/SanderMuller
SanderMullerhttps://github.com/SanderMuller
Nov 13, 2026 https://github.com/phpstan/phpstan-src/pull/7058#pullrequestreview-5898885777
View reviewed changes https://github.com/phpstan/phpstan-src/pull/7058/files/a916e03a3146dc9c0f88a1bd3d02ac8a3090ca4b
SanderMullerhttps://github.com/SanderMuller
https://github.com/phpstan/phpstan-src/pull/7058#pullrequestreview-5898885777
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
a916e03https://github.com/phpstan/phpstan-src/commit/a916e03a3146dc9c0f88a1bd3d02ac8a3090ca4b
6896c23https://github.com/phpstan/phpstan-src/commit/6896c23013f3cf617e3bc713f46f93d1ea330d7f
6896c23https://github.com/phpstan/phpstan-src/commit/6896c23013f3cf617e3bc713f46f93d1ea330d7f
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/7058
https://github.com/staabm
staabmhttps://github.com/staabm
4ce4b19https://github.com/phpstan/phpstan-src/commit/4ce4b19c38a696617be2c274bb79da98bb8a4250
Nov 14, 2026https://github.com/phpstan/phpstan-src/pull/7058#event-36105625333
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/7058
https://github.com/staabm
staabmhttps://github.com/staabm
Nov 14, 2026https://github.com/phpstan/phpstan-src/pull/7058#issuecomment-6873148819
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/7058
https://github.com/zonuexe
zonuexehttps://github.com/zonuexe
November 14, 2026 06:34https://github.com/phpstan/phpstan-src/pull/7058#event-36105821230
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
Nov 14, 2026 https://github.com/phpstan/phpstan-src/pull/7058#ref-pullrequest-6387770022
Update drupal and glpi integration baselines for NAN comparisons phpstan/phpstan#15730 https://github.com/phpstan/phpstan/pull/15730
https://github.co/hiddenchars
https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F7058
Copilot code review https://github.com/apps/copilot-pull-request-reviewer
Copilot https://github.com/apps/copilot-pull-request-reviewer
Learn more about Copilot code review.https://gh.io/copilot-code-review-docs
https://github.com/phpstan/phpstan-src/pull/7058/files/6896c23013f3cf617e3bc713f46f93d1ea330d7f
https://github.com/SanderMuller
SanderMuller https://github.com/SanderMuller
https://github.com/phpstan/phpstan-src/pull/7058/files/a916e03a3146dc9c0f88a1bd3d02ac8a3090ca4b
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/7058
The false branch of < and <= narrows the other operand even when the compared value can be NAN https://github.com/phpstan/phpstan/issues/15713
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/7058
https://github.com/zonuexe
https://github.com/staabm
https://github.com/SanderMuller
https://github.com/apps/copilot-pull-request-reviewer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.