| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:290375e3-d88c-bc42-6d54-4581656d4468 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8DCC:DC070:4A9DAB:68A14E:6B00727D |
| html-safe-nonce | ef1caccef3076dc1b38477072d3e5961ef7aaee04091d1cb8a77029bd401bb03 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RENDOkRDMDcwOjRBOURBQjo2OEExNEU6NkIwMDcyN0QiLCJ2aXNpdG9yX2lkIjoiMzYzOTY3OTE1MDk4NzQ0MDc2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 5a83ea5e3bb51670f149c2103c67feee6a7306be8c42636568662af8bc4fdb14 |
| hovercard-subject-tag | pull_request:5301629309 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/7058/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5f27ee4f08f5553a2de71cc46f8373966653eca4d505e60b85cadf2e273b4c9a/phpstan/phpstan-src/pull/7058 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5f27ee4f08f5553a2de71cc46f8373966653eca4d505e60b85cadf2e273b4c9a/phpstan/phpstan-src/pull/7058 |
| og:image:alt | BinaryOpHandler narrows both operands of <, <=, > and >= in the false branch. It keeps NAN on the side it narrows, but it still narrows each side as if the other one were ordered. This ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zonuexe |
| hostname | github.com |
| expected-hostname | github.com |
| None | 75c2b65dd205f26961d0c29afed1a8d0bb7cca9f05780571dfd1ef93eb539d16 |
| turbo-cache-control | no-cache |
| go-import | github.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git |
| octolytics-dimension-user_id | 16435710 |
| octolytics-dimension-user_login | phpstan |
| octolytics-dimension-repository_id | 219334214 |
| octolytics-dimension-repository_nwo | phpstan/phpstan-src |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 219334214 |
| octolytics-dimension-repository_network_root_nwo | phpstan/phpstan-src |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84e563eb4b55f8fa102f325f117533cee9e3df4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/phpstan/phpstan-src/pull/7058#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F7058 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F7058 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src |
| Reload | https://github.com/phpstan/phpstan-src/pull/7058 |
| Reload | https://github.com/phpstan/phpstan-src/pull/7058 |
| Reload | https://github.com/phpstan/phpstan-src/pull/7058 |
| phpstan | https://github.com/phpstan |
| phpstan-src | https://github.com/phpstan/phpstan-src |
| Code | https://github.com/phpstan/phpstan-src |
| Pull requests185 (185) | https://github.com/phpstan/phpstan-src/pulls |
| Actions | https://github.com/phpstan/phpstan-src/actions |
| Security and quality | https://github.com/phpstan/phpstan-src/security |
| Insights | https://github.com/phpstan/phpstan-src/insights |
| https://github.com/phpstan/phpstan-src |
| staabm | https://github.com/staabm |
| phpstan:2.3.x | https://github.com/phpstan/phpstan-src/tree/2.3.x |
| zonuexe:nan-comparison-narrowing | https://github.com/zonuexe/phpstan-src/tree/nan-comparison-narrowing |
| Conversation | https://github.com/phpstan/phpstan-src/pull/7058 |
| Commits4 (4) | https://github.com/phpstan/phpstan-src/pull/7058/commits |
| Checks | https://github.com/phpstan/phpstan-src/pull/7058/checks |
| Files changed | https://github.com/phpstan/phpstan-src/pull/7058/files |
| Do not narrow a comparison operand whose counterpart can be NAN | https://github.com/phpstan/phpstan-src/pull/7058#top |
| staabm | https://github.com/staabm |
| phpstan:2.3.x | https://github.com/phpstan/phpstan-src/tree/2.3.x |
| zonuexe:nan-comparison-narrowing | https://github.com/zonuexe/phpstan-src/tree/nan-comparison-narrowing |
|
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7058#issue-6378516644 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7058 |
| Add FloatRangeType for float #6937 | https://github.com/phpstan/phpstan-src/pull/6937 |
| Type min() / max() of two arguments as the union of both comparison orders #7050 | https://github.com/phpstan/phpstan-src/pull/7050 |
| phpstan/phpstan#15713 | https://github.com/phpstan/phpstan/issues/15713 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7058 |
| zonuexe | https://github.com/zonuexe |
| November 14, 2026 04:10 | https://github.com/phpstan/phpstan-src/pull/7058#commits-pushed-22569d8 |
|
| https://github.com/zonuexe |
| Do not narrow a comparison operand whose counterpart can be NAN | https://github.com/phpstan/phpstan-src/pull/7058/commits/22569d8e3455443001faf3e980e1929239488621 |
| 22569d8 | https://github.com/phpstan/phpstan-src/pull/7058/commits/22569d8e3455443001faf3e980e1929239488621 |
|
| https://github.com/zonuexe |
| Do not invert a count() comparison against an operand that can be NAN | https://github.com/phpstan/phpstan-src/pull/7058/commits/9aeb7480796e71735178b934253bfb0579511782 |
| 9aeb748 | https://github.com/phpstan/phpstan-src/pull/7058/commits/9aeb7480796e71735178b934253bfb0579511782 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
|
Nov 13, 2026
| https://github.com/phpstan/phpstan-src/pull/7058#ref-pullrequest-6362737860 |
|
Type min() / max() of two arguments as the union of both comparison orders
#7050
| https://github.com/phpstan/phpstan-src/pull/7050 |
|
| https://github.com/zonuexe |
| Ask whether an operand can be NAN by removing NAN from its type | https://github.com/phpstan/phpstan-src/pull/7058/commits/6896c23013f3cf617e3bc713f46f93d1ea330d7f |
| 6896c23 | https://github.com/phpstan/phpstan-src/pull/7058/commits/6896c23013f3cf617e3bc713f46f93d1ea330d7f |
| https://github.com/SanderMuller |
| SanderMuller | https://github.com/SanderMuller |
|
Nov 13, 2026
| https://github.com/phpstan/phpstan-src/pull/7058#pullrequestreview-5897912429 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/7058/files/6896c23013f3cf617e3bc713f46f93d1ea330d7f |
| SanderMuller | https://github.com/SanderMuller |
| https://github.com/phpstan/phpstan-src/pull/7058#pullrequestreview-5897912429 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 94519e2 | https://github.com/phpstan/phpstan-src/commit/94519e24fb01caf54fa49b1735205e21bff703dc |
| 6896c23 | https://github.com/phpstan/phpstan-src/commit/6896c23013f3cf617e3bc713f46f93d1ea330d7f |
| #7050 | https://github.com/phpstan/phpstan-src/pull/7050 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7058 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| November 13, 2026 21:03 | https://github.com/phpstan/phpstan-src/pull/7058#event-36073924491 |
| started reviewing | https://github.com/phpstan/phpstan-src/sessions/f4c3eb59-c749-4ead-9f74-11cae419efab |
| staabm | https://github.com/staabm |
| November 13, 2026 21:04 | https://github.com/phpstan/phpstan-src/pull/7058#event-36073961855 |
|
View session
| https://github.com/phpstan/phpstan-src/sessions/f4c3eb59-c749-4ead-9f74-11cae419efab |
|
| https://github.com/apps/copilot-pull-request-reviewer |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
|
Nov 13, 2026
| https://github.com/phpstan/phpstan-src/pull/7058#pullrequestreview-5898083799 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/7058/files/6896c23013f3cf617e3bc713f46f93d1ea330d7f |
| Copilot | https://github.com/apps/copilot-pull-request-reviewer |
| https://github.com/phpstan/phpstan-src/pull/7058#pullrequestreview-5898083799 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| NAN guard skips count narrowing in true comparison branch | https://github.com/phpstan/phpstan-src/pull/7058#discussion_r4568686447 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7058 |
| src/Analyser/ExprHandler/BinaryOpHandler.php | https://github.com/phpstan/phpstan-src/pull/7058/files/6896c23013f3cf617e3bc713f46f93d1ea330d7f#diff-e2217ed827cdafe40e6908ebdfce7ba7a212d4611a8af68cc7702f8aae95e500 |
|
| https://github.com/zonuexe |
| Skip the inverse count() comparison whenever an operand can be NAN | https://github.com/phpstan/phpstan-src/pull/7058/commits/a916e03a3146dc9c0f88a1bd3d02ac8a3090ca4b |
| a916e03 | https://github.com/phpstan/phpstan-src/pull/7058/commits/a916e03a3146dc9c0f88a1bd3d02ac8a3090ca4b |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7058#issuecomment-6865708802 |
| a916e03 | https://github.com/phpstan/phpstan-src/commit/a916e03a3146dc9c0f88a1bd3d02ac8a3090ca4b |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7058 |
| https://github.com/SanderMuller |
| SanderMuller | https://github.com/SanderMuller |
|
Nov 13, 2026
| https://github.com/phpstan/phpstan-src/pull/7058#pullrequestreview-5898885777 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/7058/files/a916e03a3146dc9c0f88a1bd3d02ac8a3090ca4b |
| SanderMuller | https://github.com/SanderMuller |
| https://github.com/phpstan/phpstan-src/pull/7058#pullrequestreview-5898885777 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| a916e03 | https://github.com/phpstan/phpstan-src/commit/a916e03a3146dc9c0f88a1bd3d02ac8a3090ca4b |
| 6896c23 | https://github.com/phpstan/phpstan-src/commit/6896c23013f3cf617e3bc713f46f93d1ea330d7f |
| 6896c23 | https://github.com/phpstan/phpstan-src/commit/6896c23013f3cf617e3bc713f46f93d1ea330d7f |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7058 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| 4ce4b19 | https://github.com/phpstan/phpstan-src/commit/4ce4b19c38a696617be2c274bb79da98bb8a4250 |
| Nov 14, 2026 | https://github.com/phpstan/phpstan-src/pull/7058#event-36105625333 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7058 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| Nov 14, 2026 | https://github.com/phpstan/phpstan-src/pull/7058#issuecomment-6873148819 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7058 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| November 14, 2026 06:34 | https://github.com/phpstan/phpstan-src/pull/7058#event-36105821230 |
| https://github.com/ondrejmirtes |
| ondrejmirtes | https://github.com/ondrejmirtes |
|
Nov 14, 2026
| https://github.com/phpstan/phpstan-src/pull/7058#ref-pullrequest-6387770022 |
|
Update drupal and glpi integration baselines for NAN comparisons
phpstan/phpstan#15730
| https://github.com/phpstan/phpstan/pull/15730 |
| https://github.co/hiddenchars |
| https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F7058 |
|
Copilot code review
| https://github.com/apps/copilot-pull-request-reviewer |
|
Copilot
| https://github.com/apps/copilot-pull-request-reviewer |
| Learn more about Copilot code review. | https://gh.io/copilot-code-review-docs |
|
| https://github.com/phpstan/phpstan-src/pull/7058/files/6896c23013f3cf617e3bc713f46f93d1ea330d7f |
|
| https://github.com/SanderMuller |
|
SanderMuller
| https://github.com/SanderMuller |
|
| https://github.com/phpstan/phpstan-src/pull/7058/files/a916e03a3146dc9c0f88a1bd3d02ac8a3090ca4b |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7058 |
|
The false branch of < and <= narrows the other operand even when the compared value can be NAN
| https://github.com/phpstan/phpstan/issues/15713 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7058 |
|
| https://github.com/zonuexe |
|
| https://github.com/staabm |
|
| https://github.com/SanderMuller |
|
| https://github.com/apps/copilot-pull-request-reviewer |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |