| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cc1213b2-cd35-920c-ee35-95d3390d0ac6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AE72:3DCBB0:33AEE6:48A7C6:6B006E07 |
| html-safe-nonce | fd61300cf6f8ee920ededcad6c2dc5269a2f9582fd2d3a2b7204cb50056697aa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRTcyOjNEQ0JCMDozM0FFRTY6NDhBN0M2OjZCMDA2RTA3IiwidmlzaXRvcl9pZCI6Ijg3NzE3MjE2Nzg3NTg2MzcwNjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 6d988e45d35d0e1e499c06aade7ba9e5c7691f267a766114384d7b3ff5d116ce |
| hovercard-subject-tag | pull_request:5288337079 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/7050/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9d72c54fd53670390e51ae714ca8031ace5ec70e7cfa6405b2bf71f28ac707df/phpstan/phpstan-src/pull/7050 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9d72c54fd53670390e51ae714ca8031ace5ec70e7cfa6405b2bf71f28ac707df/phpstan/phpstan-src/pull/7050 |
| og:image:alt | MinMaxFunctionReturnTypeExtension types min($a, $b) as $a < $b ? $a : $b and max($a, $b) as $a < $b ? $b : $a. When the arguments compare as equal or one of them is NAN, which argument PHP re... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zonuexe |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6527e91c60c0b29d16606ff32ac5df8ecdc37a2a62205ea057a14d7762c870fa |
| turbo-cache-control | no-cache |
| go-import | github.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git |
| octolytics-dimension-user_id | 16435710 |
| octolytics-dimension-user_login | phpstan |
| octolytics-dimension-repository_id | 219334214 |
| octolytics-dimension-repository_nwo | phpstan/phpstan-src |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 219334214 |
| octolytics-dimension-repository_network_root_nwo | phpstan/phpstan-src |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 46f1cd2ae3cd8ae1a81019b5d619742e76f13bbd |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/phpstan/phpstan-src/pull/7050#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F7050 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F7050 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src |
| Reload | https://github.com/phpstan/phpstan-src/pull/7050 |
| Reload | https://github.com/phpstan/phpstan-src/pull/7050 |
| Reload | https://github.com/phpstan/phpstan-src/pull/7050 |
| phpstan | https://github.com/phpstan |
| phpstan-src | https://github.com/phpstan/phpstan-src |
| Code | https://github.com/phpstan/phpstan-src |
| Pull requests185 (185) | https://github.com/phpstan/phpstan-src/pulls |
| Actions | https://github.com/phpstan/phpstan-src/actions |
| Security and quality | https://github.com/phpstan/phpstan-src/security |
| Insights | https://github.com/phpstan/phpstan-src/insights |
| https://github.com/phpstan/phpstan-src |
| staabm | https://github.com/staabm |
| phpstan:2.3.x | https://github.com/phpstan/phpstan-src/tree/2.3.x |
| zonuexe:minmax-nan-both-orders | https://github.com/zonuexe/phpstan-src/tree/minmax-nan-both-orders |
| Conversation | https://github.com/phpstan/phpstan-src/pull/7050 |
| Commits6 (6) | https://github.com/phpstan/phpstan-src/pull/7050/commits |
| Checks | https://github.com/phpstan/phpstan-src/pull/7050/checks |
| Files changed | https://github.com/phpstan/phpstan-src/pull/7050/files |
| Type min() / max() of two arguments as the union of both comparison orders | https://github.com/phpstan/phpstan-src/pull/7050#top |
| staabm | https://github.com/staabm |
| phpstan:2.3.x | https://github.com/phpstan/phpstan-src/tree/2.3.x |
| zonuexe:minmax-nan-both-orders | https://github.com/zonuexe/phpstan-src/tree/minmax-nan-both-orders |
|
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issue-6362737860 |
| #6937 | https://github.com/phpstan/phpstan-src/pull/6937 |
| Add FloatRangeType for float #6937 | https://github.com/phpstan/phpstan-src/pull/6937 |
| Add FloatRangeType for float #6937 | https://github.com/phpstan/phpstan-src/pull/6937 |
| #6937 | https://github.com/phpstan/phpstan-src/pull/6937 |
| max/min return wrong value if signed (negative) zero php/php-src#20221 | https://github.com/php/php-src/issues/20221 |
| Add FloatRangeType for float #6937 | https://github.com/phpstan/phpstan-src/pull/6937 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
|
Nov 13, 2026
| https://github.com/phpstan/phpstan-src/pull/7050#pullrequestreview-5887243005 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/7050/files |
| src/Type/Php/MinMaxFunctionReturnTypeExtension.php | https://github.com/phpstan/phpstan-src/pull/7050/files#diff-b1a10b0e3c0ccbea063bae8da98c7f26d862672ddc4e2992db23ba79c5b07121 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6846286723 |
| @SanderMuller | https://github.com/SanderMuller |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6846318887 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6846782202 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6846849685 |
| https://3v4l.org/A3Rc1#veol | https://3v4l.org/A3Rc1#veol |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6847017063 |
| https://3v4l.org/tVFpJ | https://3v4l.org/tVFpJ |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6849451964 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/SanderMuller |
| SanderMuller | https://github.com/SanderMuller |
|
Nov 13, 2026
| https://github.com/phpstan/phpstan-src/pull/7050#ref-pullrequest-5543337082 |
|
Add range() throw type extension
#6539
| https://github.com/phpstan/phpstan-src/pull/6539 |
| https://github.com/SanderMuller |
| SanderMuller | https://github.com/SanderMuller |
|
Nov 13, 2026
| https://github.com/phpstan/phpstan-src/pull/7050#pullrequestreview-5891075389 |
|
View reviewed changes
| https://github.com/phpstan/phpstan-src/pull/7050/files |
| SanderMuller | https://github.com/SanderMuller |
| https://github.com/phpstan/phpstan-src/pull/7050#pullrequestreview-5891075389 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| de379c9 | https://github.com/phpstan/phpstan-src/commit/de379c9df65191f0b8c677e6d768ea555f14a8bc |
| #6539 | https://github.com/phpstan/phpstan-src/pull/6539 |
| #7038 | https://github.com/phpstan/phpstan-src/pull/7038 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6853226434 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/SanderMuller |
| SanderMuller | https://github.com/SanderMuller |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6853604813 |
| 7ce253f | https://github.com/phpstan/phpstan-src/commit/7ce253f4cd54535d7b883b3cf058012e1ce28c6c |
| de379c9 | https://github.com/phpstan/phpstan-src/commit/de379c9df65191f0b8c677e6d768ea555f14a8bc |
| 7ce253f | https://github.com/phpstan/phpstan-src/commit/7ce253f4cd54535d7b883b3cf058012e1ce28c6c |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6854383786 |
| phpstan/phpstan#15713 | https://github.com/phpstan/phpstan/issues/15713 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| zonuexe | https://github.com/zonuexe |
| November 13, 2026 16:06 | https://github.com/phpstan/phpstan-src/pull/7050#commits-pushed-8ef92fc |
|
| https://github.com/zonuexe |
|
| https://github.com/staabm |
| Type min() / max() of two arguments as the union of both comparison o… | https://github.com/phpstan/phpstan-src/pull/7050/commits/8ef92fc6b50aa7e5e39a6e024b51bdfaaf6a6733 |
| 8ef92fc | https://github.com/phpstan/phpstan-src/pull/7050/commits/8ef92fc6b50aa7e5e39a6e024b51bdfaaf6a6733 |
|
| https://github.com/zonuexe |
|
| https://github.com/staabm |
| Test min() / max() with NAN and int|float arguments in the comparison… | https://github.com/phpstan/phpstan-src/pull/7050/commits/eefc51e588150834fd5ba82a9bf051bb98a12dee |
| eefc51e | https://github.com/phpstan/phpstan-src/pull/7050/commits/eefc51e588150834fd5ba82a9bf051bb98a12dee |
|
| https://github.com/zonuexe |
|
| https://github.com/staabm |
| Declare int|float in the min() / max() fixtures with PHPDoc so they l… | https://github.com/phpstan/phpstan-src/pull/7050/commits/30c6874a26cbca33fb835e6bcb4eac3edcdbabcb |
| 30c6874 | https://github.com/phpstan/phpstan-src/pull/7050/commits/30c6874a26cbca33fb835e6bcb4eac3edcdbabcb |
|
| https://github.com/zonuexe |
|
| https://github.com/staabm |
| Do not narrow constant arguments of min() / max() by the comparison i… | https://github.com/phpstan/phpstan-src/pull/7050/commits/021679f85c15aee9fcab69384db341d0c9d8b344 |
| 021679f | https://github.com/phpstan/phpstan-src/pull/7050/commits/021679f85c15aee9fcab69384db341d0c9d8b344 |
|
| https://github.com/zonuexe |
|
| https://github.com/staabm |
| Keep literal arguments of min() / max() out of AlwaysRememberedExpr | https://github.com/phpstan/phpstan-src/pull/7050/commits/14e39d654c5e9e52b90934a58140c9a549848e87 |
| 14e39d6 | https://github.com/phpstan/phpstan-src/pull/7050/commits/14e39d654c5e9e52b90934a58140c9a549848e87 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| force-pushed | https://github.com/phpstan/phpstan-src/compare/39972661dddcb89a68b16a63c4fc38464b4930a3..14e39d654c5e9e52b90934a58140c9a549848e87 |
| 3997266 | https://github.com/phpstan/phpstan-src/commit/39972661dddcb89a68b16a63c4fc38464b4930a3 |
| 14e39d6 | https://github.com/phpstan/phpstan-src/commit/14e39d654c5e9e52b90934a58140c9a549848e87 |
|
Compare
| https://github.com/phpstan/phpstan-src/compare/39972661dddcb89a68b16a63c4fc38464b4930a3..14e39d654c5e9e52b90934a58140c9a549848e87 |
| November 13, 2026 15:06 | https://github.com/phpstan/phpstan-src/pull/7050#event-36042015279 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6856895286 |
| @SanderMuller | https://github.com/SanderMuller |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/SanderMuller |
| SanderMuller | https://github.com/SanderMuller |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6857043443 |
| 7ce253f | https://github.com/phpstan/phpstan-src/commit/7ce253f4cd54535d7b883b3cf058012e1ce28c6c |
| 7ce253f | https://github.com/phpstan/phpstan-src/commit/7ce253f4cd54535d7b883b3cf058012e1ce28c6c |
| 7ce253f | https://github.com/phpstan/phpstan-src/commit/7ce253f4cd54535d7b883b3cf058012e1ce28c6c |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
|
| https://github.com/zonuexe |
| Decide the comparison operands of min() / max() by the type, not the … | https://github.com/phpstan/phpstan-src/pull/7050/commits/48e94fcef4149e7e84aa373de920b10398b9caf9 |
| 48e94fc | https://github.com/phpstan/phpstan-src/pull/7050/commits/48e94fcef4149e7e84aa373de920b10398b9caf9 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| 94519e2 | https://github.com/phpstan/phpstan-src/commit/94519e24fb01caf54fa49b1735205e21bff703dc |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#event-36063083699 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/staabm |
| staabm | https://github.com/staabm |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6862083393 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| November 13, 2026 18:54 | https://github.com/phpstan/phpstan-src/pull/7050#event-36063175205 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
|
Nov 13, 2026
| https://github.com/phpstan/phpstan-src/pull/7050#ref-pullrequest-6378516644 |
|
Do not narrow a comparison operand whose counterpart can be NAN
#7058
| https://github.com/phpstan/phpstan-src/pull/7058 |
| https://github.com/zonuexe |
| zonuexe | https://github.com/zonuexe |
| Nov 13, 2026 | https://github.com/phpstan/phpstan-src/pull/7050#issuecomment-6863173792 |
| 94519e2 | https://github.com/phpstan/phpstan-src/commit/94519e24fb01caf54fa49b1735205e21bff703dc |
| #7058 | https://github.com/phpstan/phpstan-src/pull/7058 |
| phpstan/phpstan#15713 | https://github.com/phpstan/phpstan/issues/15713 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| https://github.co/hiddenchars |
| https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F7050 |
|
| https://github.com/staabm |
|
staabm
| https://github.com/staabm |
|
| https://github.com/phpstan/phpstan-src/pull/7050/files/ead0b84409ae4523264b31e309f9e69e55bb48e6 |
|
| https://github.com/SanderMuller |
|
SanderMuller
| https://github.com/SanderMuller |
|
| https://github.com/phpstan/phpstan-src/pull/7050/files/de379c9df65191f0b8c677e6d768ea555f14a8bc |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
| Please reload this page | https://github.com/phpstan/phpstan-src/pull/7050 |
|
| https://github.com/zonuexe |
|
| https://github.com/staabm |
|
| https://github.com/SanderMuller |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |