René's URL Explorer Experiment


Title: Reuse the errors of rules on CollectedDataNode from the result cache by SanderMuller · Pull Request #6840 · phpstan/phpstan-src · GitHub

Open Graph Title: Reuse the errors of rules on CollectedDataNode from the result cache by SanderMuller · Pull Request #6840 · phpstan/phpstan-src

X Title: Reuse the errors of rules on CollectedDataNode from the result cache by SanderMuller · Pull Request #6840 · phpstan/phpstan-src

Description: PHPStan's source code. This is where development happens. Check https://github.com/phpstan/phpstan for the distribution repository. - Reuse the errors of rules on CollectedDataNode from the result cache by SanderMuller · Pull Request #6840 · phpstan/phpstan-src

Open Graph Description: This follows the design from phpstan/phpstan#15447 (comment). The rules on CollectedDataNode now run again only when their input changed. CollectedDataNode records which collectors a rule reads wit...

X Description: This follows the design from phpstan/phpstan#15447 (comment). The rules on CollectedDataNode now run again only when their input changed. CollectedDataNode records which collectors a rule reads wit...

Opengraph URL: https://github.com/phpstan/phpstan-src/pull/6840

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d0cb0926-6848-71e9-b24b-66af06992c8e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id94AE:D5AA4:99756A:CEC6AD:6B00E086
html-safe-nonce9a9e425f0018d7e26c3389928a0f2d6282e674008ab5429b0bc78b2d91621a09
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEFFOkQ1QUE0Ojk5NzU2QTpDRUM2QUQ6NkIwMEUwODYiLCJ2aXNpdG9yX2lkIjoiOTAxMzE3OTY1NDg5ODUwNzkxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac97c48611e0456939e9d475754f2bb63d046dd781b3e35caad9769d1b78d1299a
hovercard-subject-tagpull_request:5008209327
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/phpstan/phpstan-src/6840/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2a0d7046e5dea24cdf4c81bc94bacf7a8a75413b3a4f8a5f06de1c686b3554e2/phpstan/phpstan-src/pull/6840
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2a0d7046e5dea24cdf4c81bc94bacf7a8a75413b3a4f8a5f06de1c686b3554e2/phpstan/phpstan-src/pull/6840
og:image:altThis follows the design from phpstan/phpstan#15447 (comment). The rules on CollectedDataNode now run again only when their input changed. CollectedDataNode records which collectors a rule reads wit...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameSanderMuller
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-cache
go-importgithub.com/phpstan/phpstan-src git https://github.com/phpstan/phpstan-src.git
octolytics-dimension-user_id16435710
octolytics-dimension-user_loginphpstan
octolytics-dimension-repository_id219334214
octolytics-dimension-repository_nwophpstan/phpstan-src
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id219334214
octolytics-dimension-repository_network_root_nwophpstan/phpstan-src
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/phpstan/phpstan-src/pull/6840#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F6840
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F6840
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=phpstan%2Fphpstan-src
Reloadhttps://github.com/phpstan/phpstan-src/pull/6840
Reloadhttps://github.com/phpstan/phpstan-src/pull/6840
Reloadhttps://github.com/phpstan/phpstan-src/pull/6840
phpstanhttps://github.com/phpstan
phpstan-srchttps://github.com/phpstan/phpstan-src
Codehttps://github.com/phpstan/phpstan-src
Pull requests186 (186)https://github.com/phpstan/phpstan-src/pulls
Actionshttps://github.com/phpstan/phpstan-src/actions
Security and qualityhttps://github.com/phpstan/phpstan-src/security
Insightshttps://github.com/phpstan/phpstan-src/insights
https://github.com/phpstan/phpstan-src
ondrejmirteshttps://github.com/ondrejmirtes
phpstan:2.3.xhttps://github.com/phpstan/phpstan-src/tree/2.3.x
SanderMuller:cache-collected-data-rule-errorshttps://github.com/SanderMuller/phpstan-src/tree/cache-collected-data-rule-errors
Conversationhttps://github.com/phpstan/phpstan-src/pull/6840
Commits3 (3)https://github.com/phpstan/phpstan-src/pull/6840/commits
Checkshttps://github.com/phpstan/phpstan-src/pull/6840/checks
Files changedhttps://github.com/phpstan/phpstan-src/pull/6840/files
Reuse the errors of rules on CollectedDataNode from the result cachehttps://github.com/phpstan/phpstan-src/pull/6840#top
ondrejmirteshttps://github.com/ondrejmirtes
phpstan:2.3.xhttps://github.com/phpstan/phpstan-src/tree/2.3.x
SanderMuller:cache-collected-data-rule-errorshttps://github.com/SanderMuller/phpstan-src/tree/cache-collected-data-rule-errors
https://github.com/SanderMuller
SanderMullerhttps://github.com/SanderMuller
Oct 25, 2026https://github.com/phpstan/phpstan-src/pull/6840#issue-6028721669
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
phpstan/phpstan#15447 (comment)https://github.com/phpstan/phpstan/issues/15447#issuecomment-6389042558
#6373https://github.com/phpstan/phpstan-src/pull/6373
phpstan/phpstan#15447https://github.com/phpstan/phpstan/issues/15447
Claude Codehttps://claude.com/claude-code
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
https://github.com/SanderMuller
SanderMullerhttps://github.com/SanderMuller
force-pushedhttps://github.com/phpstan/phpstan-src/compare/b36b4f2423a377c4c6508f0f52d6dc49e5bbf29d..b6b5518213837d8595797885d3de6f3c8d853aa0
b36b4f2https://github.com/phpstan/phpstan-src/commit/b36b4f2423a377c4c6508f0f52d6dc49e5bbf29d
b6b5518https://github.com/phpstan/phpstan-src/commit/b6b5518213837d8595797885d3de6f3c8d853aa0
Compare https://github.com/phpstan/phpstan-src/compare/b36b4f2423a377c4c6508f0f52d6dc49e5bbf29d..b6b5518213837d8595797885d3de6f3c8d853aa0
October 25, 2026 20:23https://github.com/phpstan/phpstan-src/pull/6840#event-34201910649
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
Oct 26, 2026https://github.com/phpstan/phpstan-src/pull/6840#issuecomment-6411832417
https://phpstan.org/developing-extensions/result-cache-meta-extensions#tracking-dependencies-on-fileshttps://phpstan.org/developing-extensions/result-cache-meta-extensions#tracking-dependencies-on-files
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
https://github.com/SanderMuller
SanderMullerhttps://github.com/SanderMuller
force-pushedhttps://github.com/phpstan/phpstan-src/compare/b6b5518213837d8595797885d3de6f3c8d853aa0..c96f229f4ef1c76113fba705e48fe778f0ab8e3e
b6b5518https://github.com/phpstan/phpstan-src/commit/b6b5518213837d8595797885d3de6f3c8d853aa0
c96f229https://github.com/phpstan/phpstan-src/commit/c96f229f4ef1c76113fba705e48fe778f0ab8e3e
Compare https://github.com/phpstan/phpstan-src/compare/b6b5518213837d8595797885d3de6f3c8d853aa0..c96f229f4ef1c76113fba705e48fe778f0ab8e3e
October 26, 2026 14:43https://github.com/phpstan/phpstan-src/pull/6840#event-34270431271
https://github.com/SanderMuller
SanderMullerhttps://github.com/SanderMuller
Oct 26, 2026https://github.com/phpstan/phpstan-src/pull/6840#issuecomment-6418877398
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
Oct 26, 2026https://github.com/phpstan/phpstan-src/pull/6840#issuecomment-6420855568
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
https://github.com/SanderMuller
SanderMullerhttps://github.com/SanderMuller
Oct 27, 2026https://github.com/phpstan/phpstan-src/pull/6840#issuecomment-6437297014
c7b1469https://github.com/phpstan/phpstan-src/commit/c7b14694c5c2da681266f2c735050b951085d893
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
SanderMullerhttps://github.com/SanderMuller
October 28, 2026 19:30https://github.com/phpstan/phpstan-src/pull/6840#commits-pushed-0d073f6
https://github.com/SanderMuller
https://github.com/claude
https://github.com/ondrejmirtes
Save the result cache after the rules on CollectedDataNode ranhttps://github.com/phpstan/phpstan-src/pull/6840/commits/0d073f6ca971dfbc2c5191a4f0e2832ca77064d4
0d073f6https://github.com/phpstan/phpstan-src/pull/6840/commits/0d073f6ca971dfbc2c5191a4f0e2832ca77064d4
https://github.com/SanderMuller
https://github.com/claude
https://github.com/ondrejmirtes
Reuse the errors of rules on CollectedDataNode from the result cachehttps://github.com/phpstan/phpstan-src/pull/6840/commits/6fd7610109144d07b60eb8d521ec10d6849d55cf
6fd7610https://github.com/phpstan/phpstan-src/pull/6840/commits/6fd7610109144d07b60eb8d521ec10d6849d55cf
https://github.com/SanderMuller
https://github.com/claude
https://github.com/ondrejmirtes
Rerun a rule on CollectedDataNode when what a class declares changedhttps://github.com/phpstan/phpstan-src/pull/6840/commits/9da18369789f8e62bd83c0728dedd9b60ae3bab3
9da1836https://github.com/phpstan/phpstan-src/pull/6840/commits/9da18369789f8e62bd83c0728dedd9b60ae3bab3
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
force-pushedhttps://github.com/phpstan/phpstan-src/compare/c7b14694c5c2da681266f2c735050b951085d893..9da18369789f8e62bd83c0728dedd9b60ae3bab3
c7b1469https://github.com/phpstan/phpstan-src/commit/c7b14694c5c2da681266f2c735050b951085d893
9da1836https://github.com/phpstan/phpstan-src/commit/9da18369789f8e62bd83c0728dedd9b60ae3bab3
Compare https://github.com/phpstan/phpstan-src/compare/c7b14694c5c2da681266f2c735050b951085d893..9da18369789f8e62bd83c0728dedd9b60ae3bab3
October 28, 2026 19:36https://github.com/phpstan/phpstan-src/pull/6840#event-34513021059
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
dda126fhttps://github.com/phpstan/phpstan-src/commit/dda126fdc77baf83b3d78c5e4c8d4e1f569e40cd
Oct 28, 2026https://github.com/phpstan/phpstan-src/pull/6840#event-34513154483
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
Oct 28, 2026https://github.com/phpstan/phpstan-src/pull/6840#issuecomment-6478763731
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
UnusedViewsRule and NoMissingTranslationsRule do not see file changes when PHPStan reuses their errors larastan/larastan#2628 https://github.com/larastan/larastan/issues/2628
UnusedViewsRule and NoMissingTranslationsRule do not see file changes when PHPStan reuses their errors calebdw/phpstan-laravel#51 https://github.com/calebdw/phpstan-laravel/issues/51
ComposerRule errors are reused on every warm run with PHPStan 2.3.4 bleeding edge pb30/phpstan-composer-analysis#67 https://github.com/pb30/phpstan-composer-analysis/issues/67
LatteTemplatesRule does not see template changes when PHPStan reuses its errors efabrica-team/phpstan-latte#481 https://github.com/efabrica-team/phpstan-latte/issues/481
TodoByTicketRule does not see ticket status changes when PHPStan reuses its errors staabm/phpstan-todo-by#199 https://github.com/staabm/phpstan-todo-by/issues/199
https://github.com/SanderMuller
SanderMullerhttps://github.com/SanderMuller
Oct 28, 2026https://github.com/phpstan/phpstan-src/pull/6840#issuecomment-6483076387
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
Oct 28, 2026https://github.com/phpstan/phpstan-src/pull/6840#issuecomment-6483162637
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
https://github.com/SanderMuller
SanderMullerhttps://github.com/SanderMuller
Oct 28, 2026https://github.com/phpstan/phpstan-src/pull/6840#issuecomment-6483189660
https://github.com/pb30/phpstan-composer-analysis/blob/4edd66c6b71c0bb3c08662943da319a1d67413a2/src/ComposerRule.php#L33-L40https://github.com/pb30/phpstan-composer-analysis/blob/4edd66c6b71c0bb3c08662943da319a1d67413a2/src/ComposerRule.php#L33-L40
pb30/phpstan-composer-analysis#67https://github.com/pb30/phpstan-composer-analysis/issues/67
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
Oct 28, 2026https://github.com/phpstan/phpstan-src/pull/6840#issuecomment-6483292857
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
https://github.com/SanderMuller
SanderMullerhttps://github.com/SanderMuller
Oct 28, 2026 https://github.com/phpstan/phpstan-src/pull/6840#ref-pullrequest-6089456569
Run rules on CollectedDataNode that do not call get(), and every rule with -vvv #6881 https://github.com/phpstan/phpstan-src/pull/6881
https://github.com/ondrejmirtes
ondrejmirteshttps://github.com/ondrejmirtes
Nov 5, 2026 https://github.com/phpstan/phpstan-src/pull/6840#ref-pullrequest-5346807214
Read the cached collected data only when the rules on CollectedDataNode run #6373 https://github.com/phpstan/phpstan-src/pull/6373
https://github.co/hiddenchars
https://github.com/phpstan/phpstan-src/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fphpstan%2Fphpstan-src%2Fpull%2F6840
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
Please reload this pagehttps://github.com/phpstan/phpstan-src/pull/6840
https://github.com/SanderMuller
https://github.com/ondrejmirtes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.